From nobody Tue Feb 10 06:27:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) client-ip=209.85.128.53; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f53.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1618947302; cv=none; d=zohomail.com; s=zohoarc; b=TcROa9ZDv5ouLkvskiez0RkW7tamTky7GqMONA5QT3y8V9J+5jyLkbGJ85XEk3Mal1Ydhecr7v6CPEelUebIQHDhg376TjIK1KxRIpvdnzu/YhA9dBwHSxP6w7dEUo/TTGMO9tY+nkku5twt/AlX9XQaiOHn4iVjQg9aNKqhPK8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618947302; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qLCiOBvYe9uou2qKsybkRDArrM3VCschSDNYIP+mEg4=; b=GhwgkMcwVLsMplBgKAHXt3/gujoMQucJXnTq6rGsuQU3+OEdhwVWJBK4CZc1c0T7azNRXOpynNdMVbYTcR0MFa/oBQttnfOKc3L0/DIsqjfWvYjDvG+jNqxuENr++bHur9gx/Vsy6zNc93yfZTbmYVnHBHRVpyKQeftE/8/v6QY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mx.zohomail.com with SMTPS id 1618947302357236.67642902468515; Tue, 20 Apr 2021 12:35:02 -0700 (PDT) Received: by mail-wm1-f53.google.com with SMTP id k128so20874763wmk.4 for ; Tue, 20 Apr 2021 12:35:01 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (39.red-81-40-121.staticip.rima-tde.net. [81.40.121.39]) by smtp.gmail.com with ESMTPSA id q7sm15939006wrr.62.2021.04.20.12.34.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Apr 2021 12:34:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qLCiOBvYe9uou2qKsybkRDArrM3VCschSDNYIP+mEg4=; b=UXpm50Kat3ML+nILUcSgIGazeHQ7BgpZrdbwOlr4Wan5vb4HfrhEY47zN+KMMSfbSH wZwk+lzDiElOgFUTvDqMFrh/U7KB3I7lHYNNguAAQjwut3K3EtY+e81cpkeyD3Gg9mBp z6+gK2z/fTr1JKtItPn7UllvuIdL1jEm0IBb3LtDjXk1ySfMlUd2NhxU2X0b06ER1Hdb OwqmQmcPn9Sz963TL8tmuvc9OSJpS5GINqNzKZVuAHCoYY+s/jpkVUzYQmQmXfWayzsc bhtP4ThagbwkeQEZOkFWNcyBEIbNdF24jBF0C1vATOzbuFeN4goDI3kmnG+lx8z3it0t bGyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=qLCiOBvYe9uou2qKsybkRDArrM3VCschSDNYIP+mEg4=; b=k+g0wjFS9z6EqJcvKko6YUmU8oTRJXCbQs56FMrQzz8xqlA3YQDG4I+jDcz3/Fik6d WwOJoQBbC/u1EPhTMR3jEdV0i/4VPj0n2khJRl6sx+G89A0NbIndPcivqwAKopKbT50g K9/Nn54ypzgp0TIKzsGuqlXDvnipXp55Qbza/cYDRanqGCGcdgoZIBVBjg0K5JrXb4ze 7fFERaBiplNmhaxJWtIY6jrv+8WpqMmPJhNNbZI9dAbiJ07pWB03efNPp5DTD2M3N/jj 2x32Go8uuoabH/QaF0c3WoGt2EBI5cPrD61lDazEannF9L7+2OaHfcrOSV1Omj5erO+1 AARw== X-Gm-Message-State: AOAM533u95fCUL8HF6TofUsnLXRFiKJ1D/gNCPax567v1+ZlNPtm0VF4 5nhni8z239QD66q2RnNtSKs= X-Google-Smtp-Source: ABdhPJxJldn4Rhtn7ZdT+/3BSZXXI22427rLDpLi0bQzl6lhAGKbjZ9pnylyhRUHraNncqL6cI28Vg== X-Received: by 2002:a1c:f618:: with SMTP id w24mr5972311wmc.93.1618947300467; Tue, 20 Apr 2021 12:35:00 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson , Jiaxun Yang , Aleksandar Rikalo Subject: [PATCH 1/5] target/mips: Remove duplicated check_cp0_enabled() calls in gen_cp0() Date: Tue, 20 Apr 2021 21:34:49 +0200 Message-Id: <20210420193453.1913810-2-f4bug@amsat.org> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210420193453.1913810-1-f4bug@amsat.org> References: <20210420193453.1913810-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) We already check for CP0 enabled at the beginning of gen_cp0(), no need to check it again after. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/translate.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 5dad75cdf37..9acca6ef045 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -9477,7 +9477,6 @@ static void gen_cp0(CPUMIPSState *env, DisasContext *= ctx, uint32_t opc, opn =3D "mthc0"; break; case OPC_MFTR: - check_cp0_enabled(ctx); if (rd =3D=3D 0) { /* Treat as NOP. */ return; @@ -9487,7 +9486,6 @@ static void gen_cp0(CPUMIPSState *env, DisasContext *= ctx, uint32_t opc, opn =3D "mftr"; break; case OPC_MTTR: - check_cp0_enabled(ctx); gen_mttr(env, ctx, rd, rt, (ctx->opcode >> 5) & 1, ctx->opcode & 0x7, (ctx->opcode >> 4) & 1); opn =3D "mttr"; --=20 2.26.3