From nobody Tue Feb 10 08:03:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.47 as permitted sender) client-ip=209.85.221.47; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f47.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.47 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1618859926; cv=none; d=zohomail.com; s=zohoarc; b=BtjhfbfKx2FsUzAxcwohMwzR5zmx3d6DReavnpPu4f9Y5ya4+Tm51QJv6PdDlWqaOuHtCBvnJLfoeAEvF27TPGr39fza1Ye1wSBQWfw0jVYvqHAPWjDfYabCLTREU8xXFbVJTvkWWU5j2jQAaZrjZ0lEbRKXULx912giYNbHXvk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618859926; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=JdLEvydvbX477BhH/ZmKV47FrIUBwZZqHvybwivTF10=; b=cFCVpuNKssneuBdvoa7GuDsUU2BmgAMl2PQZh+z9pnXuYhjP+P/96sAlCDMWq1jFUZW3XE7nPqsUozQXv+1yHsBuTfYsXsjjlVKUnW/8zwl8ztXAR4qrcRhY/mLt1QSktl9owvR/AuMdvYkQe5NsTDo18rq/EZsL3uKjx+aNeTs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.47 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by mx.zohomail.com with SMTPS id 1618859926278524.2137377286023; Mon, 19 Apr 2021 12:18:46 -0700 (PDT) Received: by mail-wr1-f47.google.com with SMTP id c15so26235739wro.13 for ; Mon, 19 Apr 2021 12:18:45 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (39.red-81-40-121.staticip.rima-tde.net. [81.40.121.39]) by smtp.gmail.com with ESMTPSA id l14sm522342wmq.4.2021.04.19.12.18.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Apr 2021 12:18:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JdLEvydvbX477BhH/ZmKV47FrIUBwZZqHvybwivTF10=; b=deltvGSS5dyc4th/Or9JYeoc8/sBGeL14V7j1CHjJmRPBMYszO9We6SAGbR/1Q7gd1 f6OitR3u0xZonZuaAZr+f2qYIMyJqj3CH9YVqHPNhv67K/KQjQvoDclc7su8WohW/39l hWcgFUvKA/YHDUOBOkIPtvc9TgJxOYgN4hozmP3KewS8ZpeKnd/dRHN3EEvi91LykHIJ +7yhZYMMAwe60PseXkCS62kTwgAtYYA0CQ0f+VDfK4zrbPNK5oQet6K5DdDFA1G0R1+a 1S3iMm7EHdnqHp3zAcEgJgNfc60ncbRTE3pYdzNGXhmrbhe6pzJ1twAK/17RAQW2oJSo LC9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=JdLEvydvbX477BhH/ZmKV47FrIUBwZZqHvybwivTF10=; b=fjVMOM9qLmRF88uMl6M7juraKMnz2YWTgiaCBiQdi+Cq4kQcaY2D0xOkGsgz5wlIQZ BMvGQXPxwn8iRgq5C3K2VJFt6AThdWH4tf1ShQxZpNWKE9Tb4MdbcVYwXgUx9msQrsaR KZmXQnFupaqfT9FywSVZJH2K7MtVlcR16LQcG/3Jyy6W8TSi0cGRPm7Cj0TqhsysWKJu Thoiqmi5tlCqMRFwk6j/7dWC82O6V/1UajE6vPb+cJD3L5SYuWAzn40Ha57Tr2lkVxsq 96HDCApZynW6Y5r4amnoCkFWbHDMyENFZVy54lCMwxX0LndzBkt02WhW+wm7ipfTwXea CPNQ== X-Gm-Message-State: AOAM530dixOuDsWka83t4drcRnr7aaimEZ3QnfPkHdt0+jWB0I+E6idF ritOXndRMIQNPSkRB6Pixoo= X-Google-Smtp-Source: ABdhPJxsQPEgEeJQ62/ux3atd5vqJj3q0umH9oqJYDF5uwzLlq0fo1W+0H1alfWC1Q4oMf+/TgFe4w== X-Received: by 2002:a5d:4405:: with SMTP id z5mr16594720wrq.313.1618859924495; Mon, 19 Apr 2021 12:18:44 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Rikalo , Aurelien Jarno , Huacai Chen Subject: [PATCH v3 04/30] target/mips: Make CPU/FPU regnames[] arrays global Date: Mon, 19 Apr 2021 21:17:57 +0200 Message-Id: <20210419191823.1555482-5-f4bug@amsat.org> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210419191823.1555482-1-f4bug@amsat.org> References: <20210419191823.1555482-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) The CPU/FPU regnames[] arrays is used in mips_tcg_init() and mips_cpu_dump_state(), which while being in translate.c is not specific to TCG. To be able to move mips_cpu_dump_state() to cpu.c, which is compiled for all accelerator, we need to make the regnames[] arrays global to target/mips/ by declaring them in "internal.h". Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/internal.h | 3 +++ target/mips/cpu.c | 7 +++++++ target/mips/fpu.c | 7 +++++++ target/mips/translate.c | 14 -------------- 4 files changed, 17 insertions(+), 14 deletions(-) diff --git a/target/mips/internal.h b/target/mips/internal.h index 99264b8bf6a..a8644f754a6 100644 --- a/target/mips/internal.h +++ b/target/mips/internal.h @@ -71,6 +71,9 @@ struct mips_def_t { int32_t SAARP; }; =20 +extern const char * const regnames[32]; +extern const char * const fregnames[32]; + extern const struct mips_def_t mips_defs[]; extern const int mips_defs_number; =20 diff --git a/target/mips/cpu.c b/target/mips/cpu.c index dce1e166bde..f354d18aec4 100644 --- a/target/mips/cpu.c +++ b/target/mips/cpu.c @@ -35,6 +35,13 @@ #include "qapi/qapi-commands-machine-target.h" #include "fpu_helper.h" =20 +const char * const regnames[32] =3D { + "r0", "at", "v0", "v1", "a0", "a1", "a2", "a3", + "t0", "t1", "t2", "t3", "t4", "t5", "t6", "t7", + "s0", "s1", "s2", "s3", "s4", "s5", "s6", "s7", + "t8", "t9", "k0", "k1", "gp", "sp", "s8", "ra", +}; + #if !defined(CONFIG_USER_ONLY) =20 /* Called for updates to CP0_Status. */ diff --git a/target/mips/fpu.c b/target/mips/fpu.c index 39a2f7fd22e..1447dba3fa3 100644 --- a/target/mips/fpu.c +++ b/target/mips/fpu.c @@ -16,3 +16,10 @@ const FloatRoundMode ieee_rm[4] =3D { float_round_up, float_round_down }; + +const char * const fregnames[32] =3D { + "f0", "f1", "f2", "f3", "f4", "f5", "f6", "f7", + "f8", "f9", "f10", "f11", "f12", "f13", "f14", "f15", + "f16", "f17", "f18", "f19", "f20", "f21", "f22", "f23", + "f24", "f25", "f26", "f27", "f28", "f29", "f30", "f31", +}; diff --git a/target/mips/translate.c b/target/mips/translate.c index 71fa5ec1973..f99d4d4016d 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -1267,13 +1267,6 @@ TCGv_i64 fpu_f64[32]; #define DISAS_STOP DISAS_TARGET_0 #define DISAS_EXIT DISAS_TARGET_1 =20 -static const char * const regnames[] =3D { - "r0", "at", "v0", "v1", "a0", "a1", "a2", "a3", - "t0", "t1", "t2", "t3", "t4", "t5", "t6", "t7", - "s0", "s1", "s2", "s3", "s4", "s5", "s6", "s7", - "t8", "t9", "k0", "k1", "gp", "sp", "s8", "ra", -}; - static const char * const regnames_HI[] =3D { "HI0", "HI1", "HI2", "HI3", }; @@ -1282,13 +1275,6 @@ static const char * const regnames_LO[] =3D { "LO0", "LO1", "LO2", "LO3", }; =20 -static const char * const fregnames[] =3D { - "f0", "f1", "f2", "f3", "f4", "f5", "f6", "f7", - "f8", "f9", "f10", "f11", "f12", "f13", "f14", "f15", - "f16", "f17", "f18", "f19", "f20", "f21", "f22", "f23", - "f24", "f25", "f26", "f27", "f28", "f29", "f30", "f31", -}; - /* General purpose registers moves. */ void gen_load_gpr(TCGv t, int reg) { --=20 2.26.3