From nobody Sat May 11 07:44:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) client-ip=209.85.221.50; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f50.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1618668546; cv=none; d=zohomail.com; s=zohoarc; b=Udw9CejsAWi/1ggaDP3eQGgdHpsvgk5i4RPqnuug+KkpXilJ37QLDMWRPjsDfd/XtTBHcXMhvP4irgcnsPlurxe/IYi/PXjzfYbVbDgLj0DZ2qjxqUIkVSYZu8RbU4Anot9ZmsyBBKhcXSUYubX13NdIovy/Mn1x961TOdySnNQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618668546; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=LuLkmyssT6Xg6qDeKETGDqI87aMBd3atyc1rUywcRKk=; b=BStB3tVvXPyEgO8WAKGpAnUl5teVimaY63lBgi7MPzFw21gI+wG5bworrG02QMRt4bcZJB/CqNp6Yij04uVTwnyhwW1jiIKz3izcil/AxjlsKz0DT5aWe9H6QWjM5LEdr6Cfo9t4vkU9gQqnjeGTUEgrljY51DKjVHxS1zez1SQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mx.zohomail.com with SMTPS id 1618668546559794.7552840283402; Sat, 17 Apr 2021 07:09:06 -0700 (PDT) Received: by mail-wr1-f50.google.com with SMTP id x7so29337946wrw.10 for ; Sat, 17 Apr 2021 07:09:05 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (39.red-81-40-121.staticip.rima-tde.net. [81.40.121.39]) by smtp.gmail.com with ESMTPSA id a8sm16451802wrh.91.2021.04.17.07.09.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Apr 2021 07:09:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LuLkmyssT6Xg6qDeKETGDqI87aMBd3atyc1rUywcRKk=; b=h/IRTLGICuWYWeSh2yzAj8z162VjsI0WhE8Fb+j0A9zaEMsnzpKlIK62Vy3SVz+bp2 d5cH9b9HgHt/BqcZsZEdJIC3o+bYrOHS4vhvUvs8e9cZUxNAirq9idjs1NOOrDIp8CPG V0pMIfoF/5Bfc8E46jrfzf8FvYoIRU0yRosMrxe2LEF94kf8XUz54kEFjI8rUlqBbTRw KYM8tuQ3QLDFXwOVXspwbK6iG9w+lbq5FkP1gdOEvERLQxYrFK+6ft4MobOtleP4TxGC bi67LmmHzuosdODXMTOyX+iKP86MvZ7tsATyOC9SQJ6DQgkZBG4hAuLxvAxvs9kKcQ20 myww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=LuLkmyssT6Xg6qDeKETGDqI87aMBd3atyc1rUywcRKk=; b=KnH0PJ+6Qw/eSB08OQnU8c6d4pTvXFabVH7fY7iHxMz+oJ2uAYpeHqGGFis9rV67Hl JgbMauLxdKbv34GzHbUv5M/xBeS7pFw3XC4IIp3kYD+3vzAqWXLSErslualFaYYbxrjC AxCcVcT0c2KhtL3wkwADZp7xRVoGoVvc4Kj2yJJvJmYeJIxqhVFB280wkQ0TgeFwGR5A Rpzpb7s9qX+jpETEuPSd2j1Szj8UdS+v6slGLnaRn8XJZ0lpURUDw7IR0zn7h0mvL6pY +wfK0/r9u7HEC+JPzOcaP/LSRZPxKiLrfT55ZScKLISSE8ivI1gKIG7N8/5FxasG3n6S C+eQ== X-Gm-Message-State: AOAM532NZFK8+Z8w9oFpBsA7swtoXqJxZe11SPsHYuZ7SPsws+ppYvx0 xFlrfi4FsdyA3JMSvF5pT92Hd+c4/cg= X-Google-Smtp-Source: ABdhPJw1qHPPufnBuf2I0W4LFRRH+tRTJSPxQtQOBXMoq0Uz6+iOQ4KomoVhIfvz7Llprmt5AdGx6w== X-Received: by 2002:a05:6000:1ac7:: with SMTP id i7mr4588156wry.9.1618668544829; Sat, 17 Apr 2021 07:09:04 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Richard Henderson , Prasad J Pandit , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2] memory: Initialize MemoryRegionOps for RAM memory regions Date: Sat, 17 Apr 2021 16:09:02 +0200 Message-Id: <20210417140902.677295-1-f4bug@amsat.org> X-Mailer: git-send-email 2.26.3 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) There is an issue when using memory_region_dispatch_read() or memory_region_dispatch_write() on RAM memory regions. RAM memory regions are initialized as: memory_region_init_ram() -> memory_region_init_ram_nomigrate() -> memory_region_init_ram_shared_nomigrate() -> memory_region_init() -> object_initialize(TYPE_MEMORY_REGION) -> memory_region_initfn() -> mr->ops =3D &unassigned_mem_ops; Later when accessing the alias, the memory_region_dispatch_read() flow is: memory_region_dispatch_read() -> memory_region_dispatch_read1() -> if (mr->ops->read) { /* not taken */ } else ... -> access_with_adjusted_size -> memory_region_read_with_attrs_accessor -> memory_region_dispatch_read -> unassigned_mem_read <- MEMTX_DECODE_ERROR The caller gets a MEMTX_DECODE_ERROR while the access is OK. (Similar flow with memory_region_dispatch_write). Fix by initializing the MemoryRegionOps to ram_device_mem_ops, this way the memory accesses are properly dispatched using memory_region_ram_device_read() / memory_region_ram_device_write(). Fixes: 4a2e242bbb ("memory: Don't use memcpy for ram_device regions") Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- Since v1: Corrected description (PJP) --- softmmu/memory.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/softmmu/memory.c b/softmmu/memory.c index 23bdbfac079..99886886a22 100644 --- a/softmmu/memory.c +++ b/softmmu/memory.c @@ -1556,6 +1556,8 @@ void memory_region_init_ram_shared_nomigrate(MemoryRe= gion *mr, Error *err =3D NULL; memory_region_init(mr, owner, name, size); mr->ram =3D true; + mr->ops =3D &ram_device_mem_ops; + mr->opaque =3D mr; mr->terminates =3D true; mr->destructor =3D memory_region_destructor_ram; mr->ram_block =3D qemu_ram_alloc(size, share, mr, &err); @@ -1579,6 +1581,8 @@ void memory_region_init_resizeable_ram(MemoryRegion *= mr, Error *err =3D NULL; memory_region_init(mr, owner, name, size); mr->ram =3D true; + mr->ops =3D &ram_device_mem_ops; + mr->opaque =3D mr; mr->terminates =3D true; mr->destructor =3D memory_region_destructor_ram; mr->ram_block =3D qemu_ram_alloc_resizeable(size, max_size, resized, @@ -1604,6 +1608,8 @@ void memory_region_init_ram_from_file(MemoryRegion *m= r, Error *err =3D NULL; memory_region_init(mr, owner, name, size); mr->ram =3D true; + mr->ops =3D &ram_device_mem_ops; + mr->opaque =3D mr; mr->readonly =3D readonly; mr->terminates =3D true; mr->destructor =3D memory_region_destructor_ram; @@ -1629,6 +1635,8 @@ void memory_region_init_ram_from_fd(MemoryRegion *mr, Error *err =3D NULL; memory_region_init(mr, owner, name, size); mr->ram =3D true; + mr->ops =3D &ram_device_mem_ops; + mr->opaque =3D mr; mr->terminates =3D true; mr->destructor =3D memory_region_destructor_ram; mr->ram_block =3D qemu_ram_alloc_from_fd(size, mr, @@ -1650,6 +1658,8 @@ void memory_region_init_ram_ptr(MemoryRegion *mr, { memory_region_init(mr, owner, name, size); mr->ram =3D true; + mr->ops =3D &ram_device_mem_ops; + mr->opaque =3D mr; mr->terminates =3D true; mr->destructor =3D memory_region_destructor_ram; =20 --=20 2.26.3