From nobody Wed Nov 19 21:01:33 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.51 as permitted sender) client-ip=209.85.128.51; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f51.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1618664037; cv=none; d=zohomail.com; s=zohoarc; b=cEGLZeqX8+KlakPl2aco/FwUrXYiD2BqJAl7Qgy0E/jHOO0jK1HLrIEc76CFfdk7uTcIx0zfrhJdlxyAI7jcKe7NYK2fOwzQe8OIoxnpKg20gC3ecuN+fLFPwrty8ytGRJMye1Fq18EuiESa7Qkkbpovv4E+gQ2HTyI8CA7GP1c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618664037; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=3yXOZoTUfxyQNFAWCAmS1kJdpG0/bIf8MfQR+y546HQ=; b=QVITdxHpl6mt61aQXI1PYi7xP8LCA7emvzs0ZVA2crRwfGZRNrW6Pz215ob9C79r2m4KPsRbGYiyp9k4VJq2mT+icJn5Zfjo/izmxOkjNZFgeZK/meWAE5f//cGFE+JLef8V/wxK/btu9VmQ8HUERsacV6wenGr1XlIad+CX2mM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by mx.zohomail.com with SMTPS id 1618664037726316.5157543197224; Sat, 17 Apr 2021 05:53:57 -0700 (PDT) Received: by mail-wm1-f51.google.com with SMTP id y204so14266443wmg.2 for ; Sat, 17 Apr 2021 05:53:57 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (39.red-81-40-121.staticip.rima-tde.net. [81.40.121.39]) by smtp.gmail.com with ESMTPSA id m14sm14498440wrh.28.2021.04.17.05.53.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Apr 2021 05:53:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3yXOZoTUfxyQNFAWCAmS1kJdpG0/bIf8MfQR+y546HQ=; b=XldwWDSgz9SHReyjm/3fxxbgqVEk8TPCofmhdHAXwc2Ps+cJi8jYrlc8743YX3VNZd 0Mj24UcS5XKDPf7SyGQc+/TTTlcZUD63Q0SP8pgWrQj33AksedXHSFMVzUnTPTP2qWls Glhf6U5ZyRTMIuiYbiL3byYiB4I707XZ4cdIb29+X77Y0c7F3ThJiM5EaCKwOy+CK9CK 7vAz5oHf2cYBuBU/7n+ue8jKb7AfB3dQKjCvXnrkY18APMUd4AR92U3pVe4wHcZdhmXk Cp7zEsX/GmbM/LJ+LpzvItUmLGoU9j7A0eOvlXprHedvYNE+jRcXOFaLwMyEpdRW8OS+ 3VxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=3yXOZoTUfxyQNFAWCAmS1kJdpG0/bIf8MfQR+y546HQ=; b=mCknJbsGI4MGsMvz9GM6WSq6W82DEu/n0Hx7Iepuiw2sy2z2sCq40RIG64lk+AeecD JSf5Raoo7fUC+pXX/ueMr3m9tUa9D++sqP15Jl/Na26IStjJSiwYdlhfquxjzlzF5F+l 7jHRrsRDVPQZHYC9Ex7unZXKGkvHzHc1Rbb1rtgcQjqJgRoUd/YVD8Krrw935kpn0kBN oWTxO6WUL2CVFexuPGKRt0VZtm0k0YGbum0oTbmfo/yqtZnJcE2szkZDbFyyCfLrI86m 7nOYr8yYHCddfJX9h76UwCzcXKLJkY8W4jy2ZJzDvsxg4ZYmlu8FTIPZck26x3byYLoU ml0A== X-Gm-Message-State: AOAM5327gBPHUdRRyfSNc3u8TaCcyhZlirI9UyFiQPVZ7kaGADTvJ68h KaujCSmt21n0hypgKcSzgTo= X-Google-Smtp-Source: ABdhPJxYyG5IWjhEJA4zRtpGe7bcxtqhQwMwWj2elJgtQimAnUQX6T548VNJDatCRykJXKqluowiLQ== X-Received: by 2002:a1c:bb46:: with SMTP id l67mr12513534wmf.103.1618664035907; Sat, 17 Apr 2021 05:53:55 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH] memory: Forbid memory_region_set_address() on AS root Date: Sat, 17 Apr 2021 14:53:53 +0200 Message-Id: <20210417125353.632589-1-f4bug@amsat.org> X-Mailer: git-send-email 2.26.3 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) To be sure an AddressSpace is zero-based, forbid changing base address of MemoryRegion used as AddressSpace container. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- Based-on: <20210417103028.601124-1-f4bug@amsat.org> --- softmmu/memory.c | 1 + 1 file changed, 1 insertion(+) diff --git a/softmmu/memory.c b/softmmu/memory.c index 409bcaec7f5..73c0e6f84f5 100644 --- a/softmmu/memory.c +++ b/softmmu/memory.c @@ -2522,6 +2522,7 @@ static void memory_region_readd_subregion(MemoryRegio= n *mr) =20 void memory_region_set_address(MemoryRegion *mr, hwaddr addr) { + assert(!mr->is_root_mr); if (addr !=3D mr->addr) { mr->addr =3D addr; memory_region_readd_subregion(mr); --=20 2.26.3