From nobody Tue Feb 10 11:56:15 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.42 as permitted sender) client-ip=209.85.128.42; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f42.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1618655489; cv=none; d=zohomail.com; s=zohoarc; b=dbfdnjjs0Q/M2uLJon3muqCksnYd0IxMerEffTroDQUaZFLz696mdnAx6dbRZ4Qt/aYaoSpGOJb1FKB59cprLTmoJWc8hM+h/MkoQxhlxraqpWAlgx+05C+moMrvDoalUsp+obvjm3H7E4Dw91DvIlf0Nlw8dfQPGa8+h5emCD4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618655489; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gigBM1s+F8HC4WmipCGGWWK+Zc3mdWdnCe6+x4OghgQ=; b=cY79AhXfymcIu05qDFJSJzYV6O3dx86VG3Gujn3ByVTMHo7mD1sfveE3kMVgaGkq877q82ZgPJrp8GFYXaB5lQXv00c7y+eyLFoOPZFOTCD/yammZSWrcv2uSbgfQHwxVMxTJX9ZIkFlYFudgvdCxZwr6FKSBb1Z9wsnANX5VKE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by mx.zohomail.com with SMTPS id 161865548937170.42182724146926; Sat, 17 Apr 2021 03:31:29 -0700 (PDT) Received: by mail-wm1-f42.google.com with SMTP id u20so10997094wmj.0 for ; Sat, 17 Apr 2021 03:31:28 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (39.red-81-40-121.staticip.rima-tde.net. [81.40.121.39]) by smtp.gmail.com with ESMTPSA id 61sm15406177wrm.52.2021.04.17.03.31.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Apr 2021 03:31:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gigBM1s+F8HC4WmipCGGWWK+Zc3mdWdnCe6+x4OghgQ=; b=MwueMmS8oD6spzk9WFw3065ohzOuSqbF7Js6YfDzNUHUDb+LpLdKYoGJH79SASQ5zm X4KjvPEBF0ixmvPdDFZQv/Bz9d3Gb9JNnPaEiZBALqvJoWY5y2YeW9u7D8Vx5pnVHzve XIGNsp4vnZcilKnGAToxNREVYEDpsUrH+kVGRx5VoW4KTsJVTdwAde63QKb6F0oVoGzh k3NzazNFFcsxfBU+cL4+BsYs4PnD+5+GHZag65/X6M2hZBelqfAJ3vLE2uKfQLenE59h EOSnyTRTXzQD0RPzu3PyMevn9g7hMuAi9emukm0k1Rok5Qyc9QgAtE+S7kVPXPn+qiKx JQLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=gigBM1s+F8HC4WmipCGGWWK+Zc3mdWdnCe6+x4OghgQ=; b=kfgtl0fFslgv/r+QLc6Y50MgbRdHrZbt4QUoqyrIQEq9+PbXU4ReME5KXWpJqmSphx KxR98fnE/6SRzjFlBY3Z+e8tzU6e+fj7um6TKV5PtPGDqqjCJe2T7BYffgQLpG4PKGh+ KZVV12sJIPKH9HDpIG7VlCra3K6wkugF4TlnUJ5/BvzodmZBBnTZuHwd6gD0NU0KfwLV 3EFkJE0NVxdLNiOn0U8ifccRU6QCy8AanVDv5vYHwWDB8RMWPCFIvslONelxP7/4+2H4 XkI9povNhI8e/NB5fnXSUPTB+wW0M9kb8/K6e23mNe4siPGr7dQqsCGItZjMYCXIuDUc 1clQ== X-Gm-Message-State: AOAM532cKmT9uyTGYjJzZVVFqGxOcAbYVfjpvskaGOW+198QTVJitL0I Azo1ABuWQaMsBbUfDdEiQcI= X-Google-Smtp-Source: ABdhPJw/dZBzwMZUey7yEHd29htp+tWvJn/VFSVNoujvvp9sF4mqO2yIEefGyv5XXLvaUfEAhKTqcQ== X-Received: by 2002:a7b:c098:: with SMTP id r24mr12066647wmh.77.1618655487679; Sat, 17 Apr 2021 03:31:27 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Peter Maydell , Peter Xu , David Gibson , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Greg Kurz Subject: [PATCH v2 11/11] hw/pci-host/raven: Remove temporary assertion 'root MR is zero-based' Date: Sat, 17 Apr 2021 12:30:28 +0200 Message-Id: <20210417103028.601124-12-f4bug@amsat.org> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210417103028.601124-1-f4bug@amsat.org> References: <20210417103028.601124-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Previous commit added a check in memory_region_add_subregion_common() to ensure AS root MR can't be added as subregion (changing the MR base address doing so). We can now remove the temporary assert in the raven model. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/pci-host/raven.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/hw/pci-host/raven.c b/hw/pci-host/raven.c index d8c1aaa11f5..3f8508bd467 100644 --- a/hw/pci-host/raven.c +++ b/hw/pci-host/raven.c @@ -141,16 +141,6 @@ static const MemoryRegionOps raven_intack_ops =3D { static inline hwaddr raven_io_address(PREPPCIState *s, hwaddr addr) { - /* - * We shouldn't access AddressSpace internals. However this assert - * is temporarily used to prove a subtle inconsistency from commit - * 1ae1dc5ba24 ("raven: Set a correct PCI I/O memory region") which - * expected the PCI I/O root region base address to be 0x80000000. - * - * We now use an alias memory region as root, which is zero-based. - */ - assert(s->pci_io_as.root->addr =3D=3D 0); - if (s->contiguous_map =3D=3D 0) { /* 64 KB contiguous space for IOs */ addr &=3D 0xFFFF; --=20 2.26.3