From nobody Wed Nov 19 20:54:58 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1618568766; cv=none; d=zohomail.com; s=zohoarc; b=D4EC25d1IBH5jI3Guuw6b4mlhJQJBD2cLvUeUtzBXVU66VCUzbVCRqeqAen0FQ47XZLnwEuZ0cKzTqozCDhzI4fqxgXBYT/MjUi1YroqbBRG9ZEYCP+iM0b/PctGaSCXqQSDw8IlG1pig/zVOMkdXqgZkX4jb2sboTCd5ZuEBJ0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618568766; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=Bz7dvEtXv7kRZHszJJrWUdDNdKLJ6tHkj89SwVHHMfE=; b=LJyzHpNi1Hq696/LxiMtb2nxJCIRHyaSfpE8r5EGUlUfKeVUFGxdd/4GvFEdy9LrjSxJqcz/lwiF0QcKDI0NWDrgGcgsIje9lMaFDELQa21/4dIFIM/Y7J/vyk8PeHV2SThkC0gRgaJjLzjKsshfKmRENku50ye1G1pYNp9a+0U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1618568766406430.1953562999431; Fri, 16 Apr 2021 03:26:06 -0700 (PDT) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-225-4cxQO_zYPwShMr1AEOO2kQ-1; Fri, 16 Apr 2021 06:26:03 -0400 Received: by mail-wm1-f71.google.com with SMTP id j3-20020a1c55030000b029012e7c06101aso1956945wmb.5 for ; Fri, 16 Apr 2021 03:26:03 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (39.red-81-40-121.staticip.rima-tde.net. [81.40.121.39]) by smtp.gmail.com with ESMTPSA id f1sm5179855wru.60.2021.04.16.03.26.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Apr 2021 03:26:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618568765; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Bz7dvEtXv7kRZHszJJrWUdDNdKLJ6tHkj89SwVHHMfE=; b=i+wo92bw0GmRc5hHq1ugjCtN/YjOtV0ct7216DrypTNPhGPvpocbTLRzVvam2OL7Yr6AWS RvJ5p0HxsIKZDH4vBFsrXYu+LXiTjQidTMX1djFVUG2FvfGUnX73gG2mRvM4ePb+cYCYMs O/2FX0d6i/LBSAIW0xGqj6VkJ2UFiIU= X-MC-Unique: 4cxQO_zYPwShMr1AEOO2kQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Bz7dvEtXv7kRZHszJJrWUdDNdKLJ6tHkj89SwVHHMfE=; b=coyZx2YQXZ2aYnTL46/r4CnP8EME/OKOc9ucZ25PtVXa//Agk8PSf2EGfbuRroM553 gxStOhI2yqmQu4rGoU9o/K6FU9wo1P7ysNKY/3H1nnAHYxu38/xSRHZLuk25D0h/15U1 bW8XWouPSlVgF+TwPxz/zYJEDlTYJ13sJA40V0iHTP5ApHaYgXwMSlkoIekLzW5VHQps oolT9kqwzy71eUZd6Ss5nMnsF464HqAWlCuBLQ1zqwQ07CieGrQO4rNHOzsmGyjzrqI5 agNJ9XJelkDNzdYpRkkiMeMBRxl2vuZQWvAInEiAh5NlBg97AKxC3UqvsoQUIxfLNNQp m+OA== X-Gm-Message-State: AOAM532031QX7lMMA48sAQHSySC5ZCIhaIt3GEQtiC7o0GKsy+tOMEo1 KMkGqr/q61yvgiVrX3FKkP1jq7sAD98QqLBJeJbCd+vO/Fa4j/bgbjnNOytXSYoMoyk8Pz3IVJl kkQtNAuGbJDwbug== X-Received: by 2002:a5d:4fc7:: with SMTP id h7mr8338086wrw.23.1618568762250; Fri, 16 Apr 2021 03:26:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzM2wVtDrN4Z5vp9WwZvr1sUlibkfbtBK2Z9nvI9lzKeLxcSAT0VbpsixCtaelPoPs31T9YIw== X-Received: by 2002:a5d:4fc7:: with SMTP id h7mr8338068wrw.23.1618568762068; Fri, 16 Apr 2021 03:26:02 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Eric Blake , Peter Maydell , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-6.0?] configure: Improve error message with specified meson path is not found Date: Fri, 16 Apr 2021 12:25:59 +0200 Message-Id: <20210416102559.213649-1-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) When building on a system where meson isn't available, but installed manually as user pip package, we get: $ ../configure --meson=3D~/.local/bin/meson qemu/configure: line 6387: --version: command not found You are attempting to run "setup" which requires administrative privileges, but more information is needed in order to do so. Authenticating as "root" Password: Improve the error message to something less scary: $ ../configure --meson=3D~/.local/bin/meson ERROR: Meson not found. Use --meson=3D/path/to/meson (absolute path) Actually in this case the fix is to use $HOME, not unexpanded ~: $ ../configure --meson=3D$HOME/.local/bin/meson The Meson build system Version: 0.56.99 ... Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Darren Kenny --- configure | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 4f374b48890..088a82e3d86 100755 --- a/configure +++ b/configure @@ -1987,7 +1987,12 @@ case "$meson" in git | internal) meson=3D"$python ${source_path}/meson/meson.py" ;; - *) meson=3D$(command -v "$meson") ;; + *) + meson=3D$(command -v "$meson") + if test -z "$meson"; then + error_exit "Meson not found. Use --meson=3D/path/to/meson (ab= solute path)" + fi + ;; esac =20 # Probe for ninja --=20 2.26.3