From nobody Sat Feb 7 06:21:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1618495448; cv=none; d=zohomail.com; s=zohoarc; b=kUx0N5papoZxwLU4dwZ8xrTXnlnuCwDQYnAmBGCiczMTls7bMkcOW7vssX+4d9NmpjvgzMmbtzeeOeFSDPAjHTO/rebO7muHAjfXTPhAmjRG33SeL1/HWrD+4jc1fsNjZdl9Rel3yUvd8dfH/9qo0besFe06mHoBNH4DETWjQBo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618495448; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=TFzRBkY+DSgenbNBn3jkrOtWXzY0sNDIyTzKb8fUwiE=; b=H2yexbYLJ3QpAissNfRrHZiNzm7GunRp0HvTAc4jcY0dTgpZj89mlPR7gLw3LdRlJA5AgPfl68OMRNtknveme4TK47AoCFlIlCB1yy7Pkjo0lag6hD4K1zQetW79I2jqNrkKZ47K5C8Pyebe6gA5nvUf75nWDsxwcJT2yR/fPGY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1618495448400945.5703524254914; Thu, 15 Apr 2021 07:04:08 -0700 (PDT) Received: from localhost ([::1]:55718 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lX2bH-0001qh-KR for importer@patchew.org; Thu, 15 Apr 2021 10:04:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53426) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lX2Wa-0005Uu-7N for qemu-devel@nongnu.org; Thu, 15 Apr 2021 09:59:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:36463) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lX2WX-00026R-KT for qemu-devel@nongnu.org; Thu, 15 Apr 2021 09:59:15 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-240-gwk9P3JaNOGJchgLUBlV3w-1; Thu, 15 Apr 2021 09:59:11 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 304AB107ACE4; Thu, 15 Apr 2021 13:59:10 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-115-159.ams2.redhat.com [10.36.115.159]) by smtp.corp.redhat.com (Postfix) with ESMTP id 83DFB6BF6B; Thu, 15 Apr 2021 13:59:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618495152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TFzRBkY+DSgenbNBn3jkrOtWXzY0sNDIyTzKb8fUwiE=; b=Kg7ZYmUIOtCYAMxN/0Ks7yhs8edpSXfIlwDbzWXlH8tO193C0W5+fG+5fHmUdg2FL3Sg6e ZqUQ5hiRv5IBz0B/JabHPDf7A5Kx7hAY4pA4BWhuG+xBHF8o0AJeFk7qkr5bBop1FBzF4Z ZmOwWHoaoLUUKn2qvgpN0afr66Yg81k= X-MC-Unique: gwk9P3JaNOGJchgLUBlV3w-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 3/5] block: preserve errno from fdatasync failures Date: Thu, 15 Apr 2021 14:58:49 +0100 Message-Id: <20210415135851.862406-4-berrange@redhat.com> In-Reply-To: <20210415135851.862406-1-berrange@redhat.com> References: <20210415135851.862406-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , qemu-block@nongnu.org, Juan Quintela , Richard Henderson , "Dr. David Alan Gilbert" , Max Reitz , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) When fdatasync() fails on a file backend we set a flag that short-circuits any future attempts to call fdatasync(). The first failure returns the true errno, but the later short- circuited calls return a generic EIO. The latter is unhelpful because fdatasync() can return a variety of errnos, including EACCESS. Signed-off-by: Daniel P. Berrang=C3=A9 --- block/file-posix.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/block/file-posix.c b/block/file-posix.c index 20e14f8e96..99cf452f84 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -160,7 +160,7 @@ typedef struct BDRVRawState { bool discard_zeroes:1; bool use_linux_aio:1; bool use_linux_io_uring:1; - bool page_cache_inconsistent:1; + int page_cache_inconsistent; /* errno from fdatasync failure */ bool has_fallocate; bool needs_alignment; bool drop_cache; @@ -1357,7 +1357,7 @@ static int handle_aiocb_flush(void *opaque) int ret; =20 if (s->page_cache_inconsistent) { - return -EIO; + return -s->page_cache_inconsistent; } =20 ret =3D qemu_fdatasync(aiocb->aio_fildes); @@ -1376,7 +1376,7 @@ static int handle_aiocb_flush(void *opaque) * Obviously, this doesn't affect O_DIRECT, which bypasses the page * cache. */ if ((s->open_flags & O_DIRECT) =3D=3D 0) { - s->page_cache_inconsistent =3D true; + s->page_cache_inconsistent =3D errno; } return -errno; } --=20 2.30.2