From nobody Tue Feb 10 05:43:48 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1618482216; cv=none; d=zohomail.com; s=zohoarc; b=ndb+fzSzDAJeFYL9qWQ8sa3SR2GvE8fw4vZg7A2YoNo4Yp9KnJcNM1SM2UgktLWM8l7mrf8eoyw1l15rQnpFIheDX9QwIR3XmAYhp7Fj3u9hIN8VjufVxTBAOURNqaeIrWqCID0UIEjuzFwewOoanfZi4gbiXqenvHDIkRLwFUE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618482216; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=w5PdIklFyUrXVkInzR6jRcGLXceYvSrty/XCh3gByxY=; b=jwDhTHz0FWsoz36X66GIjzc3DlZ0k7REvpOHPtGuQfyCzO5KJ5Andgq1/A2LiJabxcBB9mU3+QcGKDOgV8e7YzJ/DS4VUcrWHzOuVrFUh3KDHbOppEEShbSJ+aj5Q8ASrOoopCyEC4mCBWANUe4S2id9Q8WUOZfLzrfGb//jXjs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1618482216229873.9527202928921; Thu, 15 Apr 2021 03:23:36 -0700 (PDT) Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-583-1GC9lJ-PNlGGDpPCNvYhRA-1; Thu, 15 Apr 2021 06:23:31 -0400 Received: by mail-wr1-f70.google.com with SMTP id j4-20020adfe5040000b0290102bb319b87so2531061wrm.23 for ; Thu, 15 Apr 2021 03:23:31 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (39.red-81-40-121.staticip.rima-tde.net. [81.40.121.39]) by smtp.gmail.com with ESMTPSA id j30sm2386379wrj.62.2021.04.15.03.23.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Apr 2021 03:23:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618482215; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w5PdIklFyUrXVkInzR6jRcGLXceYvSrty/XCh3gByxY=; b=MVAz29u5qMOgdJ940SZNrOnT/L6Jbpt2x9OIVbORUgGnDmw84A+kOpLNdDjKvc266fPQM0 S1tvyg2tqbT7oUMHXpg+sfOMe9ntiNl9qxX4ic3GR8Ybpd2+4qW1/UdPrDCkRD+WlILKLm g+VgS+fWMdopIEC8RQDeDL3oDH0wxOc= X-MC-Unique: 1GC9lJ-PNlGGDpPCNvYhRA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=w5PdIklFyUrXVkInzR6jRcGLXceYvSrty/XCh3gByxY=; b=jw9UQc5PQf6KlDlT+1rYvl16evmDFW3v981IE/bszJvBUWC3k+F1X6iGsCrPeo9DLB 84eE5wsOHEDsomDPU/EG+ZJHAS4Tj+VVXZb7YnwDB9y3wWOhhf5Di2XvUyl+/IRsnGhH rFAkftXO6y5UogdvlzWwz1OVeNjzzRkYVwQNe6HiYPcEgFk4wSIaNF/2WKA1zRrSnn4l BVo1nkvpdkPhyqN3rNQigK4eSWTdGAf/1XhzFew6wz+U8MDXeOI1Wjbhj/PqFIFI+P+2 0CPpz5Jl/GBIjwPSigSsdi66sZZyEmx1s9fxvosfspImISgQ+N35ITYSiRc5PlJp9qQP RCMw== X-Gm-Message-State: AOAM531S1oO2lBXiGk2kFKWTPsNK1w59GpW4lGgYdOmRTJPzBm9bZ0dN AmXpswwaBJwA4sdmiDe+fzZjla1I94Q4+/BwD6HFZ7lW8VgbIOpILhUAm/E5/EHCexsAGV86g0F 5xWIVy7P5EvNFQQ== X-Received: by 2002:a05:6000:18af:: with SMTP id b15mr2708861wri.71.1618482210586; Thu, 15 Apr 2021 03:23:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzbPVHQ2wBHqituWSoyDnWCYWj0aptiH/Z5l+7RO+ETXkW6mEb05uZkMkReNfofB5x3l77Ecw== X-Received: by 2002:a05:6000:18af:: with SMTP id b15mr2708846wri.71.1618482210421; Thu, 15 Apr 2021 03:23:30 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: John Snow , qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Max Reitz , Aleksandar Rikalo , Kevin Wolf , Marcel Apfelbaum , Richard Henderson , Miroslav Rezanina , "Michael S. Tsirkin" , Mark Cave-Ayland , Aurelien Jarno , Artyom Tarasenko , Paolo Bonzini , Eduardo Habkost , qemu-block@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 1/4] hw/block/fdc: Replace disabled fprintf() by trace event Date: Thu, 15 Apr 2021 12:23:18 +0200 Message-Id: <20210415102321.3987935-2-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210415102321.3987935-1-philmd@redhat.com> References: <20210415102321.3987935-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: John Snow --- hw/block/fdc.c | 7 +------ hw/block/trace-events | 1 + 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/block/fdc.c b/hw/block/fdc.c index a825c2acbae..1d3a0473678 100644 --- a/hw/block/fdc.c +++ b/hw/block/fdc.c @@ -1242,12 +1242,7 @@ static void fdctrl_external_reset_isa(DeviceState *d) =20 static void fdctrl_handle_tc(void *opaque, int irq, int level) { - //FDCtrl *s =3D opaque; - - if (level) { - // XXX - FLOPPY_DPRINTF("TC pulsed\n"); - } + trace_fdctrl_tc_pulse(level); } =20 /* Change IRQ state */ diff --git a/hw/block/trace-events b/hw/block/trace-events index fa12e3a67a7..306989c193c 100644 --- a/hw/block/trace-events +++ b/hw/block/trace-events @@ -3,6 +3,7 @@ # fdc.c fdc_ioport_read(uint8_t reg, uint8_t value) "read reg 0x%02x val 0x%02x" fdc_ioport_write(uint8_t reg, uint8_t value) "write reg 0x%02x val 0x%02x" +fdctrl_tc_pulse(int level) "TC pulse: %u" =20 # pflash_cfi01.c # pflash_cfi02.c --=20 2.26.3