From nobody Wed Nov 19 19:24:38 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.47 as permitted sender) client-ip=209.85.221.47; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f47.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.47 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1618308705; cv=none; d=zohomail.com; s=zohoarc; b=OUHNKSxV7NUa92dTjkBwQpdN2iIyqRJMLC6zQ3kSQGevdXHo5YgZzbcuFTQ/82a9KNtnxiZbbMDDqIDH+r74732mU61dIVPXRMFsGTI+xW/VF/Okrv3CFNYIL5VqEanLnkRbqk2oDtZrnnUJIawBTT7ybOXZenK6XrgzjA928d8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618308705; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=BSVA5lz0rvdv4X13phsk6dqNsxhbZZ3liG9zO1ECjZA=; b=eMEbHFTW1gqRL1L9x+LLy1hBproCIfSHHU4VKBElFsCCDoXhgal82XnWSFBLv1rUSUSwUIkpR8Np+SQBtgLLh67ZSVpfJ7jJPOFQa+gKuAGwSPytxtK1rgmOR9Nem8LAIDCILn2QbLqW2QK8EIwVOYeWKGAEppn011AWtFTWu0s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.47 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by mx.zohomail.com with SMTPS id 1618308705104458.51102566019324; Tue, 13 Apr 2021 03:11:45 -0700 (PDT) Received: by mail-wr1-f47.google.com with SMTP id j5so14870415wrn.4 for ; Tue, 13 Apr 2021 03:11:44 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (39.red-81-40-121.staticip.rima-tde.net. [81.40.121.39]) by smtp.gmail.com with ESMTPSA id d2sm19337136wrs.10.2021.04.13.03.11.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 03:11:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BSVA5lz0rvdv4X13phsk6dqNsxhbZZ3liG9zO1ECjZA=; b=L7QRcJB3oehdqfYtvSCnZrhLJdHm7Ivu/ad4m49/NHXh5b8rU5JwAZrcm7gTUix999 7Ps7BXo4ah6TtHA7De4CE+A3Rzi50NRNVuh1hko6IBGr/dlfaVjTDLQH1QKWFOHRaVpF XMqsOAmQFnsQ9AvV7YhpHhSOlKrvULBJd4UKX77IIsCU9nUl4reuJgTAPoFQDvFJgJMx bpw6WpUj6kERCWOeJjSYzN9hrykbZPkxTiQ8IxanruxkZ6/sqkukF5/wmszXDV+H0EgO wm8uV5rQ1HsmGFywpCLm+EkJXUP4cDZudrnjstgAgL+ivNEzlzM+fap4uenDiB3654cF FMXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=BSVA5lz0rvdv4X13phsk6dqNsxhbZZ3liG9zO1ECjZA=; b=J89yoG0Fv9GAkEBmNCfVgLc01DRQWYkFEA94hOZM68cRHt0bZsRvGPCJD59L5ZNBlF zTXcUQF+mryx8SqjHN+cq+m9ONIY5+rmnvS9G3+dwu3CzitQA+RiXRUGl65YzJe5TEQO HSXlA0wIt9DR5k1cLiwr55IoFUYRrJ2G3bkkGRoKUQVVl/FSjtrT1BGw5V0EZ+wDEJrb /Fi85RuvlPWGrqaW09wXDKthIGCAG+KW2/AaSOkl+/ppLe/4GmUD7JX3OTB3Dq+RofKt a+FnCBdHgVSVifJq78T+5B1EzTN46dHIMjWP/VwBi3rKVjiBhQtUaauPY2nOt0YbpNfq mD+g== X-Gm-Message-State: AOAM532gzIMAntBEvlfHbFDDcjd4chqYChd0othiBxhGGdSTJwHIynnX xjsrWdIRrt6L32OK1DwzwY/THs02vhM= X-Google-Smtp-Source: ABdhPJxJSorTZf/PpQajR7gHmtaz2VDGNM7GQj+IE2PRzGWk6qyjZp7zRF3ip9IsLiJ1NFPBfbQPvw== X-Received: by 2002:adf:dd49:: with SMTP id u9mr19155899wrm.337.1618308703377; Tue, 13 Apr 2021 03:11:43 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Aleksandar Rikalo , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , BALATON Zoltan Subject: [PULL 1/3] hw/isa/Kconfig: Add missing dependency VIA VT82C686 -> APM Date: Tue, 13 Apr 2021 12:11:29 +0200 Message-Id: <20210413101131.3480173-2-f4bug@amsat.org> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210413101131.3480173-1-f4bug@amsat.org> References: <20210413101131.3480173-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) TYPE_VIA_PM calls apm_init() in via_pm_realize(), so requires APM to be selected. Reported-by: BALATON Zoltan Fixes: dd0ff8191ab ("isa: express SuperIO dependencies with Kconfig") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20210302080531.913802-1-f4bug@amsat.org> --- hw/isa/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig index 2691eae2f0c..55e0003ce40 100644 --- a/hw/isa/Kconfig +++ b/hw/isa/Kconfig @@ -48,6 +48,7 @@ config VT82C686 select SERIAL_ISA select FDC select USB_UHCI + select APM =20 config SMC37C669 bool --=20 2.26.3 From nobody Wed Nov 19 19:24:38 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.50 as permitted sender) client-ip=209.85.128.50; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f50.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1618308709; cv=none; d=zohomail.com; s=zohoarc; b=J6zFyuro+XNaLU9xahGe485HRJYFCEREvTdHi0JiSrQcxEwXEhO7ioQ8MpUFb5Bsh9VnrzdksiPATvGXQWoxBrSM3KjVytn9gf3EEjvrz8Xb3tOfd5xnRGj2wyvJiVNhkC0/k9/NhYFW9NsZgNtf+kmk2W+xLGkrkd5avuiiR9A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618308709; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=cHETbRXCR+t9b893UAfzQ7dYkQDMKdnYYi5AYTvl98I=; b=PwSHMA2B8QAy0XyENB3+ZqYzdfcUIF8XQ7jmyliYIrdYuJKtT4HOM+8D5lSl+5tACs7y32lCAOwxmTg65qGqXiiwQEm3FmE96kt0r5uF22iZqz2fmZy4jvAsneHAXAxEwt+w7M8TjJ8yiGyQu3yrPZwc961PQNPhUd8oKx1FiUI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by mx.zohomail.com with SMTPS id 1618308709975633.9410015633437; Tue, 13 Apr 2021 03:11:49 -0700 (PDT) Received: by mail-wm1-f50.google.com with SMTP id g66-20020a1c39450000b0290125d187ba22so8007827wma.2 for ; Tue, 13 Apr 2021 03:11:49 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (39.red-81-40-121.staticip.rima-tde.net. [81.40.121.39]) by smtp.gmail.com with ESMTPSA id p17sm1851536wmq.47.2021.04.13.03.11.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 03:11:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cHETbRXCR+t9b893UAfzQ7dYkQDMKdnYYi5AYTvl98I=; b=cqUY481mlxn96npT+uSN34Rvjbgv89GqcMHxNiDNvio4UMWjC42jOnuqwCtXSrRi6f KjqO6FWrko5iSyQX5FrGO37Wtk0WIyFnJCqbyID14X3GqVCRI/eXCI0Zul+czpATUcEb OwIW+IcRi4mCvZcG2dCLro6LkqPOk3KvbXtH+e0DRqevcSgbvlI31Ec4T6orGWukfZMz 0+e+4RFHdWdjjHh2w/M0DizQiRc9pmNxl/EX0YPevqJbklO5Fn44jWTvqPzARNziGMFU oo0xWR7rK0nm7QxOTnQ/tzx+lOuq2S9uWDa7qPmzlV57l9fJqWfS8yljMyMFP8pyVr6h 0ODg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=cHETbRXCR+t9b893UAfzQ7dYkQDMKdnYYi5AYTvl98I=; b=KRMpxlBr7cDOgFUeqZfMRSAk7vlE1P2hEAGsowQZcYF9unP91A8AoHG9p5GSFP/zGr fBIvesrikMqgBGV3R6tvGPszQTVvwdNNE4NCi1POnEAaN1LttY/8F1l/cX43gGUlzhlf tZC/HF0zAg67Nvw7mSMerNqGSrk1lFjZrfLMOPyypP9ums5xPyA0yutPgJaFQ7CDQDWq EyHxOpzlMvU3R92Ui6f8Gnn2G7Py3b9opO1jzgMXcHyttuUDcuRwxCEb3hUw1c+nUwqB 5q9O/v3/U8aJ7szotOR2SJETFAv/jWIEdcI5qRT6ynMQRPpm2sN0GM+WJSm/Z4Rhkd1f sMTA== X-Gm-Message-State: AOAM532EkWC23ZKgmzIaopxl9l1zhtXtc+jtMFpphciGHfJimWiX+ZFr 6u8S0suzuF2IaeDk6HmVhY8= X-Google-Smtp-Source: ABdhPJx1dJ5R3otNWtTTxXzDjsWhxu/smbj03EhH18V2hyArUlUcXSibY3Riq3ZH2tb//9eC6BAH4g== X-Received: by 2002:a1c:750d:: with SMTP id o13mr3333132wmc.76.1618308708156; Tue, 13 Apr 2021 03:11:48 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Aleksandar Rikalo , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , "Dr . David Alan Gilbert" Subject: [PULL 2/3] hw/isa/piix4: Migrate Reset Control Register Date: Tue, 13 Apr 2021 12:11:30 +0200 Message-Id: <20210413101131.3480173-3-f4bug@amsat.org> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210413101131.3480173-1-f4bug@amsat.org> References: <20210413101131.3480173-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) When adding the Reset register in commit 5790b757cfb we forgot to migrate it. While it is possible a VM using the PIIX4 is migrated just after requesting a system shutdown, it is very unlikely. However when restoring a migrated VM, we might have the RCR bit #4 set on the stack and when the VM resume it directly shutdowns. Add a post_load() migration handler and set the default RCR value to 0 for earlier versions, assuming the VM was not going to shutdown before migration. Fixes: 5790b757cfb ("piix4: Add the Reset Control Register") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Dr. David Alan Gilbert Message-Id: <20210324200334.729899-1-f4bug@amsat.org> --- hw/isa/piix4.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c index a50d97834c7..b3b6a4378a3 100644 --- a/hw/isa/piix4.c +++ b/hw/isa/piix4.c @@ -93,12 +93,25 @@ static void piix4_isa_reset(DeviceState *dev) pci_conf[0xae] =3D 0x00; } =20 +static int piix4_ide_post_load(void *opaque, int version_id) +{ + PIIX4State *s =3D opaque; + + if (version_id =3D=3D 2) { + s->rcr =3D 0; + } + + return 0; +} + static const VMStateDescription vmstate_piix4 =3D { .name =3D "PIIX4", - .version_id =3D 2, + .version_id =3D 3, .minimum_version_id =3D 2, + .post_load =3D piix4_ide_post_load, .fields =3D (VMStateField[]) { VMSTATE_PCI_DEVICE(dev, PIIX4State), + VMSTATE_UINT8_V(rcr, PIIX4State, 3), VMSTATE_END_OF_LIST() } }; --=20 2.26.3 From nobody Wed Nov 19 19:24:38 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) client-ip=209.85.221.41; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f41.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1618308714; cv=none; d=zohomail.com; s=zohoarc; b=fnzPPAs0fJZ7C/zF5UpXtWM9R/ztxKUBm8VjwtZs/2yE7FENHIy26HwVisIzLTmNv8gbtM8bDjGl2H1mce8kp9pFDIzasBGX4YLTWW1w/LcAWZqKJ+SpfQgzreq415axXscJMHTgwkPubJ6g2FVvNIahtplJO+BynIsS0YnzOXM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618308714; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OjQxr/jFzbomVhE1MW9X6lY8//4Qu15uyh6N5jl5uwI=; b=bhZxrz9Id8PgSPP6HC0rBkuth8DyDQRvxO32YxsNDQZ6NvXqHKQiAIRrV43QOBwm7Ii76hu0PrEtctsN8yavz9CVF/EasvJ6iPeBOo3Sj7FJUqcpawSr4F5GCDRCco4mxxGTO7bWkQYfyHJpKRdFDBbrhyz7qCq+UcVl8NQozuI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by mx.zohomail.com with SMTPS id 1618308714743197.26213280294985; Tue, 13 Apr 2021 03:11:54 -0700 (PDT) Received: by mail-wr1-f41.google.com with SMTP id 12so15860654wrz.7 for ; Tue, 13 Apr 2021 03:11:54 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (39.red-81-40-121.staticip.rima-tde.net. [81.40.121.39]) by smtp.gmail.com with ESMTPSA id x14sm19275847wrw.13.2021.04.13.03.11.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 03:11:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OjQxr/jFzbomVhE1MW9X6lY8//4Qu15uyh6N5jl5uwI=; b=fWg2n4QMGc/XXR8TtpILiRQdgOgZQHoUDz1QoS3jf2Pmj0u4btAIbBI+ap6Y9rp1xg EBOtngIp+fDjsvYtcmzOuRB7Td8ktrB0iyfYJdgURpD/HPi+gNSHnN1ieYx3NBvzyX52 n7y9UXdGt3V9sQ0/idZ4QXM3S4N7Bv+AgZ6uGZvSJumzD1v438+NxRQ2gWKBF1RTAz4C 8z9AfaLWUztnbCbND+zQHHaPfocVqXCvVhH1GOPxnuCcGtszDdIP8lRSWGHHIuj9z+aK KbsGeiXVC+QOTKT60IdfCHbApVX4SdB75CnwDGeR/dQaHeggHJ6lK/G5v8xZ6V9fHOaO 9mhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=OjQxr/jFzbomVhE1MW9X6lY8//4Qu15uyh6N5jl5uwI=; b=XXtNifGJ/LS0m3x1namsXnXUJQrdoZUf7hj1qLfxBDZMcDrrUt9ChwKjl/zBL/+h3c DMy/koXH17dEOg86ov6wLmKR/CCS4ldmcCqmSMwaKSUlSofK2c9I3LM+jyEiKuZSan3j a/mBw0RkplzXFQ7/7kNJoQLMp86hI0N4S+5CLTdjfvi9rjXeP+qXFWPtVCafkiPQP8zy A/6OOLuQAwB0snpUkqV5Kbagg9HuhQVZunHVeVTLsjte4w00gl/MWdn8PzfLHNWx+Zs9 9M0JOxC/FBbm5knLJ8Zxc2aqebSQ+MuTlB+NN/PDQnOW5S2qEmThjp/+F1n+D2JBMLcO S9iA== X-Gm-Message-State: AOAM530RhpcwSazElZrS2Ys3Py2MAcagsh6EcBxJnkofi/WQyRufZHRt qOvI2FTxB037pRyU/XEWh9M= X-Google-Smtp-Source: ABdhPJxnYNeDJkqc6fq5vGm7SdWiXySvTbDgd1wOSmYrl7TH/hb8Vikfsy3IBJuygD+MoMjD8wUk5w== X-Received: by 2002:a5d:658c:: with SMTP id q12mr35645779wru.30.1618308713052; Tue, 13 Apr 2021 03:11:53 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Aleksandar Rikalo , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Richard Henderson Subject: [PULL 3/3] target/mips: Fix TCG temporary leak in gen_cache_operation() Date: Tue, 13 Apr 2021 12:11:31 +0200 Message-Id: <20210413101131.3480173-4-f4bug@amsat.org> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210413101131.3480173-1-f4bug@amsat.org> References: <20210413101131.3480173-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Fix a TCG temporary leak when translating CACHE opcode. Fixes: 0d74a222c27 ("make ITC Configuration Tags accessible to the CPU") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20210406202857.1440744-1-f4bug@amsat.org> --- target/mips/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/mips/translate.c b/target/mips/translate.c index c518bf3963b..71fa5ec1973 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -12804,6 +12804,8 @@ static void gen_cache_operation(DisasContext *ctx, = uint32_t op, int base, TCGv t1 =3D tcg_temp_new(); gen_base_offset_addr(ctx, t1, base, offset); gen_helper_cache(cpu_env, t1, t0); + tcg_temp_free(t1); + tcg_temp_free_i32(t0); } =20 #if defined(TARGET_MIPS64) --=20 2.26.3