From nobody Fri May 3 23:39:45 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1617995269; cv=none; d=zohomail.com; s=zohoarc; b=Dzyw/x27pI7k6ifQONOgS3j29+oKqYb8q46yhiwqWipGYUP+gvRXIh10ZRTB9ME2eIUbJbI8XUyHMUe/s8yDXCFpZI0bS61+iaCs4qqWBb9xnYkmWS4wUzJt62lfgdmHFn91e1Mx1VfSn806mDLPntzG7hHFTzFEmIlwUox2mX0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617995269; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=XdjQd4Tz3drrplba7gJoIHHd/rnCraHm9/AfZOwDWhE=; b=jvdUC5lB/kQzdWIEL8qIeDD2YkXfTn36D1uv4fGCMsvzKj1jALdpjvDEQr6rr3qnXGlTplIbza4z3yoRCCm/eri/4V64oe2F4GTccVn8UoA6cEd3ZJk3DuTjaChOjQ5GsjObHmHfJXjRvGqw0pRxf2ky6VL5ud48a/hCTvQXeCg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1617995269601165.01914617028524; Fri, 9 Apr 2021 12:07:49 -0700 (PDT) Received: from localhost ([::1]:54850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUwTs-0007Ym-EK for importer@patchew.org; Fri, 09 Apr 2021 15:07:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60992) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUwOi-0004pS-8u for qemu-devel@nongnu.org; Fri, 09 Apr 2021 15:02:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:35307) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUwOd-0000Jx-PG for qemu-devel@nongnu.org; Fri, 09 Apr 2021 15:02:28 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-385-eOOJMa02Peq1twVi2nB9Xg-1; Fri, 09 Apr 2021 15:02:20 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8366D6D251 for ; Fri, 9 Apr 2021 19:02:19 +0000 (UTC) Received: from localhost (ovpn-112-55.ams2.redhat.com [10.36.112.55]) by smtp.corp.redhat.com (Postfix) with ESMTP id DD28B101E5AF; Fri, 9 Apr 2021 19:02:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617994942; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XdjQd4Tz3drrplba7gJoIHHd/rnCraHm9/AfZOwDWhE=; b=UoB8qUci1DPivzBujswV5wTagrygeOB0C7Hu4bA76AMjjEX+HNu/7GGwbr16dHson4xRi4 oqreAdouvog4+ViY0kFjSrNk9d1yZdemjis0knyzMuDKpPGgjTGwUUBMwrULehcFguWgnK uktHsB5JHWTDPiu+WiRg0lPKgu801t0= X-MC-Unique: eOOJMa02Peq1twVi2nB9Xg-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PATCH 1/2] libqos/qgraph: fix "UNAVAILBLE" typo Date: Fri, 9 Apr 2021 20:01:08 +0100 Message-Id: <20210409190109.476167-2-stefanha@redhat.com> In-Reply-To: <20210409190109.476167-1-stefanha@redhat.com> References: <20210409190109.476167-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MIME_BASE64_TEXT=1.741, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Paolo Bonzini , Thomas Huth , Emanuele Giuseppe Esposito , Stefan Hajnoczi Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Cc: Emanuele Giuseppe Esposito Cc: Paolo Bonzini Signed-off-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- tests/qtest/libqos/qgraph.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/libqos/qgraph.c b/tests/qtest/libqos/qgraph.c index b3b1a31f81..d1dc491930 100644 --- a/tests/qtest/libqos/qgraph.c +++ b/tests/qtest/libqos/qgraph.c @@ -844,7 +844,7 @@ void qos_dump_graph(void) } qos_printf_literal("type=3D%d cmd_line=3D'%s' [%s]\n", node->type, node->command_line, - node->available ? "available" : "UNAVAILBLE" + node->available ? "available" : "UNAVAILABLE" ); } g_list_free(keys); --=20 2.30.2 From nobody Fri May 3 23:39:45 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1617995386; cv=none; d=zohomail.com; s=zohoarc; b=XUFTAyJGO8QHKCOF4P0hTB005HVtXRrArYtP0pALJTWu48mjMVPLNGQtyILsR6paSM/o8DUhM96Jxk5YfAIsIM7ZTiAzWY4zCQ5HP8GMj/h3Lfjqq4NfOX4yUjt2dkhEvXCBhy6uhDV6PbyxiZuqgcijNDrYPDryv/C/IT3C2dQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617995386; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=WkPg0tL7I2ef+pb9boU4fPrBGU2236nCORY3RGZkAhU=; b=fnB1a6pCLSTfbXnIIJtR5tqi5kr69d68juRkWiBqZiDet+/aOzUmDuj76H5Et6werpXMdySrH3hwLOeR7bBwDMiy8q+iip1AhaKJVba7jnH0SEM2rxJ4JCbxDDc/X+KbkexX7WWffSKFL9IhJzS6p47H+FXAm2iUt0sjYq65gPg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1617995386733884.861005724984; Fri, 9 Apr 2021 12:09:46 -0700 (PDT) Received: from localhost ([::1]:57912 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUwVl-0000QB-Ng for importer@patchew.org; Fri, 09 Apr 2021 15:09:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60990) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUwOi-0004pQ-7h for qemu-devel@nongnu.org; Fri, 09 Apr 2021 15:02:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:40180) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUwOe-0000Kz-MK for qemu-devel@nongnu.org; Fri, 09 Apr 2021 15:02:26 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-211-YbXuEb1-MMShqG7hCxpOTg-1; Fri, 09 Apr 2021 15:02:22 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0E8491858EC9 for ; Fri, 9 Apr 2021 19:02:21 +0000 (UTC) Received: from localhost (ovpn-112-55.ams2.redhat.com [10.36.112.55]) by smtp.corp.redhat.com (Postfix) with ESMTP id A38421037E98; Fri, 9 Apr 2021 19:02:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617994943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WkPg0tL7I2ef+pb9boU4fPrBGU2236nCORY3RGZkAhU=; b=LRc3EAkIqoaj7nH9TsUdFyEo4jFPHZhkd2UzKF2IFc78SYH0UDEVfsBmYRfESxTSzDdSgE sZKkxMXeD9OJyeiWvrSRIJh3lcfcWGk1zpo8EgGPM1gHilcI7MBePDuZvi74Au9UcrkB72 B7mw4ZhS7U4ihTCEknUBCGPyQSzwywE= X-MC-Unique: YbXuEb1-MMShqG7hCxpOTg-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PATCH 2/2] docs/devel/qgraph: add troubleshooting information Date: Fri, 9 Apr 2021 20:01:09 +0100 Message-Id: <20210409190109.476167-3-stefanha@redhat.com> In-Reply-To: <20210409190109.476167-1-stefanha@redhat.com> References: <20210409190109.476167-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MIME_BASE64_TEXT=1.741, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, WEIRD_QUOTING=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Paolo Bonzini , Thomas Huth , Emanuele Giuseppe Esposito , Stefan Hajnoczi Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" It can be tricky to troubleshoot qos-test when a test won't execute. Add an explanation of how to trace qgraph node connectivity and find which node has the problem. Cc: Emanuele Giuseppe Esposito Cc: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- docs/devel/qgraph.rst | 58 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 58 insertions(+) diff --git a/docs/devel/qgraph.rst b/docs/devel/qgraph.rst index a9aff167ad..4635efb2c2 100644 --- a/docs/devel/qgraph.rst +++ b/docs/devel/qgraph.rst @@ -92,6 +92,64 @@ The basic framework steps are the following: Depending on the QEMU binary used, only some drivers/machines will be available and only test that are reached by them will be executed. =20 +Troubleshooting unavailable tests +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ +If there is no path from an available machine to a test then that test will +unavailable and cannot execute. This can happen if a test or driver did no= t set +up its qgraph node correctly. It can also happen if the necessary machine = type +or device is missing from the QEMU binary because it was compiled out or +otherwise. + +It is possible to troubleshoot unavailable tests by running:: + + $ QTEST_QEMU_BINARY=3Dbuild/qemu-system-x86_64 build/tests/qtest/qos-tes= t --verbose + # ALL QGRAPH EDGES: { + # src=3D'virtio-net' + # |-> dest=3D'virtio-net-tests/vhost-user/multiqueue' type=3D2 (nod= e=3D0x559142109e30) + # |-> dest=3D'virtio-net-tests/vhost-user/migrate' type=3D2 (node= =3D0x559142109d00) + # src=3D'virtio-net-pci' + # |-> dest=3D'virtio-net' type=3D1 (node=3D0x55914210d740) + # src=3D'pci-bus' + # |-> dest=3D'virtio-net-pci' type=3D2 (node=3D0x55914210d880) + # src=3D'pci-bus-pc' + # |-> dest=3D'pci-bus' type=3D1 (node=3D0x559142103f40) + # src=3D'i440FX-pcihost' + # |-> dest=3D'pci-bus-pc' type=3D0 (node=3D0x55914210ac70) + # src=3D'x86_64/pc' + # |-> dest=3D'i440FX-pcihost' type=3D0 (node=3D0x5591421117f0) + # src=3D'' + # |-> dest=3D'x86_64/pc' type=3D0 (node=3D0x559142111600) + # |-> dest=3D'arm/raspi2' type=3D0 (node=3D0x559142110740) + ... + # } + # ALL QGRAPH NODES: { + # name=3D'virtio-net-tests/announce-self' type=3D3 cmd_line=3D'(null)'= [available] + # name=3D'arm/raspi2' type=3D0 cmd_line=3D'-M raspi2 ' [UNAVAILABLE] + ... + # } + +The ``virtio-net-tests/announce-self`` test is listed as "available" in the +"ALL QGRAPH NODES" output. This means the test will execute. We can follow= the +qgraph path in the "ALL QGRAPH EDGES" output as follows: '' -> 'x86_64/pc'= -> +'i440FX-pcihost' -> 'pci-bus-pc' -> 'pci-bus' -> 'virtio-net-pci' -> +'virtio-net'. The root of the qgraph is '' and the depth first search begi= ns +there. + +The ``arm/raspi`` machine node is listed as "UNAVAILABLE". Although it is +reachable from the root via '' -> 'arm/raspi2' the node is unavailable bec= ause +the QEMU binary did not list it when queried by the framework. This is exp= ected +because we used the ``qemu-system-x86_64`` binary which does not support A= RM +machine types. + +If a test is unexpectedly listed as "UNAVAILABLE", first check that the "A= LL +QGRAPH EDGES" output reports edge connectivity from the root ('') to the t= est. +If there is no connectivity then the qgraph nodes were not set up correctl= y and +the driver or test code is incorrect. If there is connectivity, check the +availability of each node in the path in the "ALL QGRAPH NODES" output. The +first unavailable node in the path is the reason why the test is unavailab= le. +Typically this is because the QEMU binary lacks support for the necessary +machine type or device. + Creating a new driver and its interface """"""""""""""""""""""""""""""""""""""""" =20 --=20 2.30.2