From nobody Thu May 2 17:37:24 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1617975134; cv=none; d=zohomail.com; s=zohoarc; b=eT2TIE8nWngJZCxgy7zjjtjGEOPLo+iYoBD7b4T5lsvuiQTEzTefSUAKXvVwan9/KfKSXE4UvHre/rxzm+Auw3hBscuqS76dkMhvkLul8+y+h6LtOyEH37T9jDWnefk6vwTeuIskTzd/24Oe09rsS98ypU6/3v6DvEhVwn3WnuU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617975134; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=wsnsP07uN5j3BvYwTMv1RswmbCtmj25/r931U5r3zLI=; b=AgD71r1o77NB5BuABC2YHvd2gwSNxuGBtsmIMsyO2pbCSVGoaFfXc4ulDhLQ2Bc+aCBSMaxALLHFZTJ1YBzWtdH86NzphAtVVZBKPQHANqV1N/IJq5PGRYm+oId5MBV24RZi81xs1KE5zC17DP91kM2qoLMcDct1MIi+zz3pJSk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1617975134501386.08712841266413; Fri, 9 Apr 2021 06:32:14 -0700 (PDT) Received: from localhost ([::1]:51588 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUrF7-0004w8-1H for importer@patchew.org; Fri, 09 Apr 2021 09:32:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35180) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUrD0-00032T-0N for qemu-devel@nongnu.org; Fri, 09 Apr 2021 09:30:03 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:49512) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUrCx-0006Ik-4g for qemu-devel@nongnu.org; Fri, 09 Apr 2021 09:30:01 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-388-8VHsGn52NHG9jyyxOE8cSA-1; Fri, 09 Apr 2021 09:29:54 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 891271A8A60; Fri, 9 Apr 2021 13:29:53 +0000 (UTC) Received: from localhost (ovpn-114-67.ams2.redhat.com [10.36.114.67]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 015025D9E3; Fri, 9 Apr 2021 13:29:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617974996; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wsnsP07uN5j3BvYwTMv1RswmbCtmj25/r931U5r3zLI=; b=GarAcZne+JjK0NYVkEpdSV6wTp3bo+1q7vT7VyVSEjzA8d8VMzx0vQv1ipU8NQG1Enwkfc 9sQYJz3dTJ6A0XMBG0J7RpX3aBnDOH9cUJfP467dm19TS46ifFB1yLxnZAlwq8UcY4jiWz yHVYGXZUxExBUeZyAUlkcqxDNZwRBxE= X-MC-Unique: 8VHsGn52NHG9jyyxOE8cSA-1 From: Max Reitz To: qemu-block@nongnu.org Subject: [PATCH v2 1/3] job: Add job_wait_unpaused() for block-job-complete Date: Fri, 9 Apr 2021 15:29:45 +0200 Message-Id: <20210409132948.195511-2-mreitz@redhat.com> In-Reply-To: <20210409132948.195511-1-mreitz@redhat.com> References: <20210409132948.195511-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=mreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , John Snow , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" block-job-complete can only be applied when the job is READY, not when it is on STANDBY (ready, but paused). Draining a job technically pauses it (which makes a READY job enter STANDBY), and ending the drained section does not synchronously resume it, but only schedules the job, which will then be resumed. So attempting to complete a job immediately after a drained section may sometimes fail. That is bad at least because users cannot really work nicely around this: A job may be paused and resumed at any time, so waiting for the job to be in the READY state and then issuing a block-job-complete poses a TOCTTOU problem. The only way around it would be to issue block-job-complete until it no longer fails due to the job being in the STANDBY state, but that would not be nice. We can solve the problem by allowing block-job-complete to be invoked on jobs that are on STANDBY, if that status is the result of a drained section (not because the user has paused the job), and that section has ended. That is, if the job is on STANDBY, but scheduled to be resumed. Perhaps we could actually just directly allow this, seeing that mirror is the only user of ready/complete, and that mirror_complete() could probably work under the given circumstances, but there may be many side effects to consider. It is simpler to add a function job_wait_unpaused() that waits for the job to be resumed (under said circumstances), and to make qmp_block_job_complete() use it to delay job_complete() until then. Note that for the future, we probably want to make block-job-complete a coroutine QMP handler, so instead of polling job_wait_unpaused() would yield and have job_pause_point() wake it up. That would get around the problem of nested polling, which is currently the reason for returning an error when job->pause_point > 0. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=3D1945635 Signed-off-by: Max Reitz --- include/qemu/job.h | 15 +++++++++++++ blockdev.c | 3 +++ job.c | 53 ++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 71 insertions(+) diff --git a/include/qemu/job.h b/include/qemu/job.h index efc6fa7544..cf3082b6d7 100644 --- a/include/qemu/job.h +++ b/include/qemu/job.h @@ -563,4 +563,19 @@ void job_dismiss(Job **job, Error **errp); */ int job_finish_sync(Job *job, void (*finish)(Job *, Error **errp), Error *= *errp); =20 +/** + * If the job has been paused because of a drained section, and that + * section has ended, wait until the job is resumed. + * + * Return 0 if the job is not paused, or if it has been successfully + * resumed. + * Return an error if the job has been paused in such a way that + * waiting will not resume it, i.e. if it has been paused by the user, + * or if it is still drained. + * + * Callers must be in the home AioContext and hold the AioContext lock + * of job->aio_context. + */ +int job_wait_unpaused(Job *job, Error **errp); + #endif diff --git a/blockdev.c b/blockdev.c index a57590aae4..c0cc2fa364 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3414,6 +3414,9 @@ void qmp_block_job_complete(const char *device, Error= **errp) return; } =20 + if (job_wait_unpaused(&job->job, errp) < 0) { + return; + } trace_qmp_block_job_complete(job); job_complete(&job->job, errp); aio_context_release(aio_context); diff --git a/job.c b/job.c index 289edee143..fbccd4b32a 100644 --- a/job.c +++ b/job.c @@ -505,6 +505,7 @@ void coroutine_fn job_pause_point(Job *job) job_do_yield(job, -1); job->paused =3D false; job_state_transition(job, status); + aio_wait_kick(); } =20 if (job->driver->resume) { @@ -1023,3 +1024,55 @@ int job_finish_sync(Job *job, void (*finish)(Job *, = Error **errp), Error **errp) job_unref(job); return ret; } + +int job_wait_unpaused(Job *job, Error **errp) +{ + /* + * Only run this function from the main context, because this is + * what we need, and this way we do not have to think about what + * happens if the user concurrently pauses the job from the main + * monitor. + */ + assert(qemu_get_current_aio_context() =3D=3D qemu_get_aio_context()); + + /* + * Quick path (e.g. so we do not get an error if pause_count > 0 + * but the job is not even paused) + */ + if (!job->paused) { + return 0; + } + + /* If the user has paused the job, waiting will not help */ + if (job->user_paused) { + error_setg(errp, "Job '%s' has been paused and needs to be explici= tly " + "resumed", job->id); + return -EBUSY; + } + + /* + * Similarly, if the job is still drained, waiting may not help + * either: If the drain came from an IO thread, waiting would + * probably help. However, if the drain came from the main thread + * (which may be possible if the QMP handler calling this function + * has been invoked by BDRV_POLL_WHILE() from a drain_begin), then + * waiting will only deadlock. + * Better be safe and return an error. Drains from IO threads + * probably do not occur anyway. + */ + if (job->pause_count > 0) { + error_setg(errp, "Job '%s' is blocked and cannot be unpaused", job= ->id); + return -EBUSY; + } + + /* + * This function is specifically for waiting for a job to be + * resumed after a drained section. Ending the drained section + * includes a job_enter(), which schedules the job loop to be run, + * and once it does, job->paused will be cleared. Therefore, we + * do not need to invoke job_enter() here. + */ + AIO_WAIT_WHILE(job->aio_context, job->paused); + + return 0; +} --=20 2.29.2 From nobody Thu May 2 17:37:24 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1617975142; cv=none; d=zohomail.com; s=zohoarc; b=lUXqF0tvYle8/HxVi1z55N62nqXhziRRPMu+5DuFOfUaQhaMQpu5/YG7GLWAlCw6l+fd06PZjqSqvtw8dIPrI2rmC0DQ5EqOY7wuHQTRJJYlILaLitTN0eu2WlESJsJ0xwEPCV1D//ZjtavNbWWQd/nZ9/LOmQPoUlYoOCbiMCA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617975142; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ozyvUMwTUWB5EMkecsm7lCgbLvNzDma8A7uIYIHcNGo=; b=VbNqQARrMZxRZJAAqdo0fq7tlx5ib66PLUDFhKY3AcW1GHgcyqGZy4jXHpIjn6o7V7arFGXIP2lnBP1SZcZx1KbXW1nFxxKNCMZxMN9pVWOvJvNx/I9tQEC/nloqmN2xjNsBLHawMVT29OcUIGEp4jG77xBIWz/hB9DssDDDHtM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16179751422471003.9944526145189; Fri, 9 Apr 2021 06:32:22 -0700 (PDT) Received: from localhost ([::1]:52290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUrFE-0005DS-Vz for importer@patchew.org; Fri, 09 Apr 2021 09:32:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35214) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUrD4-00033o-C9 for qemu-devel@nongnu.org; Fri, 09 Apr 2021 09:30:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:42798) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUrCx-0006JO-Ie for qemu-devel@nongnu.org; Fri, 09 Apr 2021 09:30:06 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-556-gavCH29WOE67-6mpD8EMfg-1; Fri, 09 Apr 2021 09:29:57 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 10C218030A1; Fri, 9 Apr 2021 13:29:56 +0000 (UTC) Received: from localhost (ovpn-114-67.ams2.redhat.com [10.36.114.67]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9AB6910016FE; Fri, 9 Apr 2021 13:29:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617974998; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ozyvUMwTUWB5EMkecsm7lCgbLvNzDma8A7uIYIHcNGo=; b=Wo56f6qlAhaV7P3IBRNWPftPS6HD/I3Obt/0UAfLGb298nsnCpF10dmcRrt5QDe08OhGJ/ yyp0UozYS0K5tT4eE/0fFUehmC3XzYAh7IkLUrmnZfC1bAJOBYe/nS2MAbaoKF/eWz3nSr orXMnqgcWLDP6rvefd6FVkYTmtCq1zg= X-MC-Unique: gavCH29WOE67-6mpD8EMfg-1 From: Max Reitz To: qemu-block@nongnu.org Subject: [PATCH v2 2/3] test-blockjob: Test job_wait_unpaused() Date: Fri, 9 Apr 2021 15:29:46 +0200 Message-Id: <20210409132948.195511-3-mreitz@redhat.com> In-Reply-To: <20210409132948.195511-1-mreitz@redhat.com> References: <20210409132948.195511-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=mreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , John Snow , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Create a job that remains on STANDBY after a drained section, and see that invoking job_wait_unpaused() will get it unstuck. Signed-off-by: Max Reitz --- tests/unit/test-blockjob.c | 140 +++++++++++++++++++++++++++++++++++++ 1 file changed, 140 insertions(+) diff --git a/tests/unit/test-blockjob.c b/tests/unit/test-blockjob.c index 7519847912..b7736e298d 100644 --- a/tests/unit/test-blockjob.c +++ b/tests/unit/test-blockjob.c @@ -16,6 +16,7 @@ #include "block/blockjob_int.h" #include "sysemu/block-backend.h" #include "qapi/qmp/qdict.h" +#include "iothread.h" =20 static const BlockJobDriver test_block_job_driver =3D { .job_driver =3D { @@ -375,6 +376,144 @@ static void test_cancel_concluded(void) cancel_common(s); } =20 +/* (See test_yielding_driver for the job description) */ +typedef struct YieldingJob { + BlockJob common; + bool should_complete; +} YieldingJob; + +static void yielding_job_complete(Job *job, Error **errp) +{ + YieldingJob *s =3D container_of(job, YieldingJob, common.job); + s->should_complete =3D true; + job_enter(job); +} + +static int coroutine_fn yielding_job_run(Job *job, Error **errp) +{ + YieldingJob *s =3D container_of(job, YieldingJob, common.job); + + job_transition_to_ready(job); + + while (!s->should_complete) { + job_yield(job); + } + + return 0; +} + +/* + * This job transitions immediately to the READY state, and then + * yields until it is to complete. + */ +static const BlockJobDriver test_yielding_driver =3D { + .job_driver =3D { + .instance_size =3D sizeof(YieldingJob), + .free =3D block_job_free, + .user_resume =3D block_job_user_resume, + .run =3D yielding_job_run, + .complete =3D yielding_job_complete, + }, +}; + +/* + * Test that job_wait_unpaused() can get jobs from a paused state to + * a running state so that job_complete() can be applied (assuming the + * pause occurred due to a drain that has already been lifted). + * (This is what QMP's block-job-complete does so it can be executed + * even immediately after some other operation instated and lifted a + * drain.) + * + * To do this, run YieldingJob in an IO thread, get it into the READY + * state, then have a drained section. Before ending the section, + * acquire the context so the job will not be entered and will thus + * remain on STANDBY. + * + * Invoking job_complete() then will fail. + * + * However, job_wait_unpaused() should see the job is to be resumed, + * wait for it to be resumed, and then we can invoke job_complete() + * without error. + * + * Note that on the QMP interface, it is impossible to lock an IO + * thread before a drained section ends. In practice, the + * bdrv_drain_all_end() and the aio_context_acquire() will be + * reversed. However, that makes for worse reproducibility here: + * Sometimes, the job would no longer be in STANDBY then but already + * be started. We cannot prevent that, because the IO thread runs + * concurrently. We can only prevent it by taking the lock before + * ending the drained section, so we do that. + * + * (You can reverse the order of operations and most of the time the + * test will pass, but sometimes the assert(status =3D=3D STANDBY) will + * fail.) + */ +static void test_complete_in_standby(void) +{ + BlockBackend *blk; + IOThread *iothread; + AioContext *ctx; + Job *job; + BlockJob *bjob; + Error *local_err =3D NULL; + + /* Create a test drive, move it to an IO thread */ + blk =3D create_blk(NULL); + iothread =3D iothread_new(); + + ctx =3D iothread_get_aio_context(iothread); + blk_set_aio_context(blk, ctx, &error_abort); + + /* Create our test job */ + bjob =3D mk_job(blk, "job", &test_yielding_driver, true, + JOB_MANUAL_FINALIZE | JOB_MANUAL_DISMISS); + job =3D &bjob->job; + assert(job->status =3D=3D JOB_STATUS_CREATED); + + /* Wait for the job to become READY */ + job_start(job); + aio_context_acquire(ctx); + AIO_WAIT_WHILE(ctx, job->status !=3D JOB_STATUS_READY); + aio_context_release(ctx); + + /* Begin the drained section, pausing the job */ + bdrv_drain_all_begin(); + assert(job->status =3D=3D JOB_STATUS_STANDBY); + /* Lock the IO thread to prevent the job from being run */ + aio_context_acquire(ctx); + /* This will schedule the job to resume it */ + bdrv_drain_all_end(); + + /* But the job cannot run, so it will remain on standby */ + assert(job->status =3D=3D JOB_STATUS_STANDBY); + + /* A job on standby cannot be completed */ + job_complete(job, &local_err); + assert(local_err !=3D NULL); + error_free(local_err); + local_err =3D NULL; + + /* + * But waiting for it and then completing it should work. + * (This is what qmp_block_job_complete() does.) + */ + job_wait_unpaused(job, &error_abort); + job_complete(job, &error_abort); + + /* The test is done now, clean up. */ + job_finish_sync(job, NULL, &error_abort); + assert(job->status =3D=3D JOB_STATUS_PENDING); + + job_finalize(job, &error_abort); + assert(job->status =3D=3D JOB_STATUS_CONCLUDED); + + job_dismiss(&job, &error_abort); + + destroy_blk(blk); + aio_context_release(ctx); + iothread_join(iothread); +} + int main(int argc, char **argv) { qemu_init_main_loop(&error_abort); @@ -389,5 +528,6 @@ int main(int argc, char **argv) g_test_add_func("/blockjob/cancel/standby", test_cancel_standby); g_test_add_func("/blockjob/cancel/pending", test_cancel_pending); g_test_add_func("/blockjob/cancel/concluded", test_cancel_concluded); + g_test_add_func("/blockjob/complete_in_standby", test_complete_in_stan= dby); return g_test_run(); } --=20 2.29.2 From nobody Thu May 2 17:37:24 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1617975292; cv=none; d=zohomail.com; s=zohoarc; b=gMpUZM/dVqulH3AindkBuKXUNEXZORr9aNkhm7FqeU+lfFWtrJRL3TjovyoH4AivmE18oDXtC6BJHTwx66itMZ4QGAnAfGn3wbyErerUjljnTIgqfZ3noYsStr889UotfJtVoeTx8pKgl5JnUp+LIqtNVf2f03DAWr83YphK6yk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617975292; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=joSw4jwTLU8DYiFScDGknK1n4nE5TiMPrAyJTZ43A0M=; b=egV0v9RlfQxhJ4BqixVJiwiOGmlmv3XPDR9dP5UfM9t3hBJZdSNFUoxHFyWFpSN4Yjoqv4ZZcdf8iuhzS43tTORZqvldMOFzyvCwEreElZOCAPufnvIhvZk39DunF0fnLLb86A1rO6TDx9WuWgQz0M8nssj6D1ZjqDd8VVBgwEo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1617975292043689.4618802675168; Fri, 9 Apr 2021 06:34:52 -0700 (PDT) Received: from localhost ([::1]:59194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUrHe-00080k-GS for importer@patchew.org; Fri, 09 Apr 2021 09:34:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUrD4-00033a-2I for qemu-devel@nongnu.org; Fri, 09 Apr 2021 09:30:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:24581) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUrD1-0006Mr-Be for qemu-devel@nongnu.org; Fri, 09 Apr 2021 09:30:05 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-282-PlGxF8EROSCIjNYndxGvfw-1; Fri, 09 Apr 2021 09:29:59 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5E2AE100A8FF; Fri, 9 Apr 2021 13:29:58 +0000 (UTC) Received: from localhost (ovpn-114-67.ams2.redhat.com [10.36.114.67]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 024E560C05; Fri, 9 Apr 2021 13:29:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617975002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=joSw4jwTLU8DYiFScDGknK1n4nE5TiMPrAyJTZ43A0M=; b=PwcV5uYNBS+iHVguCOWIk1+M4IEnZzqAJYGpzxo4JSSlXN/RzXtmzwc26uTXNSMx5d4rxk 9SaW7y2fgs6Mzh7dLB2veiHpbycCZAcJ7t5UzcCMeBuobGtMGWGCWynAZkJqBTaATBOs8r 4F/BWExk91pDOqf07alri/NRpuLzzYo= X-MC-Unique: PlGxF8EROSCIjNYndxGvfw-1 From: Max Reitz To: qemu-block@nongnu.org Subject: [PATCH v2 3/3] iotests/041: block-job-complete on user-paused job Date: Fri, 9 Apr 2021 15:29:47 +0200 Message-Id: <20210409132948.195511-4-mreitz@redhat.com> In-Reply-To: <20210409132948.195511-1-mreitz@redhat.com> References: <20210409132948.195511-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=mreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , John Snow , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Expand test_pause() to check what happens when issuing block-job-complete on a job that is on STANDBY because it has been paused by the user. (This should be an error, and in particular not hang job_wait_unpaused().) Signed-off-by: Max Reitz --- tests/qemu-iotests/041 | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041 index 5cc02b24fc..d2c9669741 100755 --- a/tests/qemu-iotests/041 +++ b/tests/qemu-iotests/041 @@ -120,7 +120,18 @@ class TestSingleDrive(iotests.QMPTestCase): result =3D self.vm.qmp('block-job-resume', device=3D'drive0') self.assert_qmp(result, 'return', {}) =20 - self.complete_and_wait() + self.wait_ready() + + # Check that a job on STANDBY cannot be completed + self.pause_job('drive0') + result =3D self.vm.qmp('block-job-complete', device=3D'drive0') + self.assert_qmp(result, 'error/desc', + "Job 'drive0' has been paused by the user") + + result =3D self.vm.qmp('block-job-resume', device=3D'drive0') + self.assert_qmp(result, 'return', {}) + + self.complete_and_wait(wait_ready=3DFalse) self.vm.shutdown() self.assertTrue(iotests.compare_images(test_img, target_img), 'target image does not match source after mirrorin= g') --=20 2.29.2 From nobody Thu May 2 17:37:24 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1617975292; cv=none; d=zohomail.com; s=zohoarc; b=AFnhrlUJQ2WAuG3MYhjKni4ZMPJx4p/NKgDLg7SWspCYEALaSjbbYaR+dlEgcqybrB6wqpIpNMMhruSBWVrJjGNH3GJ3lUjOI0gnMW06sOf8zxs3liJXuT7qGguvt2JVng4iP85K9NGsoUnr4ZIT48epvcJpp+yMtlwdmxTGiBI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617975292; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=1srMCU2bYhO+BsWlK/xCgdMlVZmHB88CcU9bByF1iPo=; b=kplqTKFpWWfgg6Y+vimAoRWAGCwumdoo4J8caw8AtnLTQ6mNV0rXZSlQF8GkMu8dMUShWYOFQYCyg0lrfJDZ4moCQmwTJhodKDKIKdC8zKP57Dp+FxHg667tZU/R2iatNq5Q1YaTdv6bTpEB2GPCAa8EKRQUzkGVAjH6DKhtr+w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1617975292339556.4133815494541; Fri, 9 Apr 2021 06:34:52 -0700 (PDT) Received: from localhost ([::1]:59228 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUrHf-00081Y-4J for importer@patchew.org; Fri, 09 Apr 2021 09:34:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUrDM-00035D-Ng for qemu-devel@nongnu.org; Fri, 09 Apr 2021 09:30:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:52290) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUrD9-0006Rm-5e for qemu-devel@nongnu.org; Fri, 09 Apr 2021 09:30:21 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-504-TA8hswJ2NDmeRi8kRyi5HA-1; Fri, 09 Apr 2021 09:30:01 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CC0F2100A8FD; Fri, 9 Apr 2021 13:30:00 +0000 (UTC) Received: from localhost (ovpn-114-67.ams2.redhat.com [10.36.114.67]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5FC8010016FE; Fri, 9 Apr 2021 13:30:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617975010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1srMCU2bYhO+BsWlK/xCgdMlVZmHB88CcU9bByF1iPo=; b=I5Cxoh9MC5w4MDwxbRWMteSN9Ev+eBmBT8So9tReOSmHK/AHuM0r2gXy+1MtqJA8q4I0gY rXwHjgrsK1c5edMSpOG6W1i1vpwc9sHaHAfVYw6g/8wjWEHP0YiDmczBimrxmMGRjveEIG exi6iyUBJq77+JRk3kT1omKr1LxAyms= X-MC-Unique: TA8hswJ2NDmeRi8kRyi5HA-1 From: Max Reitz To: qemu-block@nongnu.org Subject: [PATCH v2 4/3] iotests: Test completion immediately after drain Date: Fri, 9 Apr 2021 15:29:48 +0200 Message-Id: <20210409132948.195511-5-mreitz@redhat.com> In-Reply-To: <20210409132948.195511-1-mreitz@redhat.com> References: <20210409132948.195511-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=mreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , John Snow , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Test what happens when you have multiple busy block jobs, drain all (via an empty transaction), and immediately issue a block-job-complete on one of the jobs. Sometimes it will still be in STANDBY, in which case block-job-complete used to fail. It should not. Signed-off-by: Max Reitz --- .../tests/mirror-complete-after-drain | 89 +++++++++++++++++++ .../tests/mirror-complete-after-drain.out | 14 +++ 2 files changed, 103 insertions(+) create mode 100755 tests/qemu-iotests/tests/mirror-complete-after-drain create mode 100644 tests/qemu-iotests/tests/mirror-complete-after-drain.out diff --git a/tests/qemu-iotests/tests/mirror-complete-after-drain b/tests/q= emu-iotests/tests/mirror-complete-after-drain new file mode 100755 index 0000000000..b096ffbcb4 --- /dev/null +++ b/tests/qemu-iotests/tests/mirror-complete-after-drain @@ -0,0 +1,89 @@ +#!/usr/bin/env python3 +# group: rw +# +# Tests for block-job-complete immediately after a drain +# +# Copyright (c) 2021 Red Hat, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . +# + +import iotests + +iotests.script_initialize(supported_fmts=3D['raw']) + +DISK_JOBS =3D 4 +NULL_JOBS =3D 1 + + +# We cannot auto-generate these in a loop because the files are +# deleted when their scope ends +src_imgs =3D iotests.file_path('src0', 'src1', 'src2', 'src3') +dst_imgs =3D iotests.file_path('dst0', 'dst1', 'dst2', 'dst3') + +assert len(src_imgs) =3D=3D DISK_JOBS +assert len(dst_imgs) =3D=3D DISK_JOBS + + +for i in range(DISK_JOBS): + ret =3D iotests.qemu_img('create', '-f', iotests.imgfmt, src_imgs[i], = '128M') + assert ret =3D=3D 0 + + ret =3D iotests.qemu_img('create', '-f', iotests.imgfmt, dst_imgs[i], = '128M') + assert ret =3D=3D 0 + +with iotests.VM() as vm: + vm.add_object('iothread,id=3Diothr0') + vm.add_device('virtio-scsi,iothread=3Diothr0') + + for i in range(DISK_JOBS): + vm.add_blockdev(f'file,node-name=3Dsource-disk-{i},' + f'filename=3D{src_imgs[i]}') + + vm.add_blockdev(f'file,node-name=3Dtarget-disk-{i},' + f'filename=3D{dst_imgs[i]}') + + vm.add_device(f'scsi-hd,id=3Ddevice-disk-{i},drive=3Dsource-disk-{= i}') + + for i in range(NULL_JOBS): + vm.add_blockdev(f'null-co,node-name=3Dsource-null-{i},read-zeroes= =3Don') + vm.add_blockdev(f'null-co,node-name=3Dtarget-null-{i},read-zeroes= =3Don') + vm.add_device(f'scsi-hd,id=3Ddevice-null-{i},drive=3Dsource-null-{= i}') + + vm.launch() + + for i in range(DISK_JOBS): + vm.qmp_log('blockdev-mirror', + job_id=3Df'mirror-disk-{i}', + device=3Df'source-disk-{i}', + target=3Df'target-disk-{i}', + sync=3D'full', + granularity=3D1048576, + buf_size=3D(16 * 1048576)) + + for i in range(NULL_JOBS): + vm.qmp_log('blockdev-mirror', + job_id=3Df'mirror-null-{i}', + device=3Df'source-null-{i}', + target=3Df'target-null-{i}', + sync=3D'full') + + for i in range(DISK_JOBS + NULL_JOBS): + vm.event_wait('BLOCK_JOB_READY') + + for i in range(DISK_JOBS): + vm.hmp(f'qemu-io -d device-disk-{i} "write 0 128M"') + + vm.qmp_log('transaction', actions=3D[]) + vm.qmp_log('block-job-complete', device=3D'mirror-null-0') diff --git a/tests/qemu-iotests/tests/mirror-complete-after-drain.out b/tes= ts/qemu-iotests/tests/mirror-complete-after-drain.out new file mode 100644 index 0000000000..4d9d0529fe --- /dev/null +++ b/tests/qemu-iotests/tests/mirror-complete-after-drain.out @@ -0,0 +1,14 @@ +{"execute": "blockdev-mirror", "arguments": {"buf-size": 16777216, "device= ": "source-disk-0", "granularity": 1048576, "job-id": "mirror-disk-0", "syn= c": "full", "target": "target-disk-0"}} +{"return": {}} +{"execute": "blockdev-mirror", "arguments": {"buf-size": 16777216, "device= ": "source-disk-1", "granularity": 1048576, "job-id": "mirror-disk-1", "syn= c": "full", "target": "target-disk-1"}} +{"return": {}} +{"execute": "blockdev-mirror", "arguments": {"buf-size": 16777216, "device= ": "source-disk-2", "granularity": 1048576, "job-id": "mirror-disk-2", "syn= c": "full", "target": "target-disk-2"}} +{"return": {}} +{"execute": "blockdev-mirror", "arguments": {"buf-size": 16777216, "device= ": "source-disk-3", "granularity": 1048576, "job-id": "mirror-disk-3", "syn= c": "full", "target": "target-disk-3"}} +{"return": {}} +{"execute": "blockdev-mirror", "arguments": {"device": "source-null-0", "j= ob-id": "mirror-null-0", "sync": "full", "target": "target-null-0"}} +{"return": {}} +{"execute": "transaction", "arguments": {"actions": []}} +{"return": {}} +{"execute": "block-job-complete", "arguments": {"device": "mirror-null-0"}} +{"return": {}} --=20 2.29.2