From nobody Tue Feb 10 05:44:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.218.48 as permitted sender) client-ip=209.85.218.48; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-f48.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1617949476; cv=none; d=zohomail.com; s=zohoarc; b=mdFfHD4syxQStJMc8NgvaU8QpIWEDq7JXcCI1mroD2aCQdJsu09XtCMt+cWR9caFd+fVWJUBaBYPvhkQkMNF3mkoE0gQ7qUn8CmL08NqyBiGZf50GezBaGIM93crLFqGdy2JW5bysD5N1oDl7TAJNUR3FBkdyW+Cmz1ERkhmb8A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617949476; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/OEqLEQHCmytseRt1FhXxp+Rob399wNsde0XeRnkGgQ=; b=emRM0bO6GnlRyFMb/9pKON5TjMTas8sq4h9FDvTc1iVzk0dRZChM/jnzCCaMpbEIyBC0xZHz4HYFnIW9HThH5MJTkRBY2p3WNRF0NfKE3Qc+90P6Es4Nf8YznkxHSh1CCKwB/u+VUoiNZv1kiJxjFzdWZ+YcDnIauvrmotdlVtQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by mx.zohomail.com with SMTPS id 1617949476600190.39508975255194; Thu, 8 Apr 2021 23:24:36 -0700 (PDT) Received: by mail-ej1-f48.google.com with SMTP id n2so6844230ejy.7 for ; Thu, 08 Apr 2021 23:24:36 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (17.red-88-21-201.staticip.rima-tde.net. [88.21.201.17]) by smtp.gmail.com with ESMTPSA id ay3sm845372edb.2.2021.04.08.23.24.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Apr 2021 23:24:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/OEqLEQHCmytseRt1FhXxp+Rob399wNsde0XeRnkGgQ=; b=ltZ+3820lLw6oC8xOjK05tEQA2ZV7Fjzd8OCarI9OfHsTY+NUKyaoYnOxRPhtsSRQm 8uGBBx3oMvSTowr3SN33+jgx5Wp+bCKEKx4LqgyNCmlQISba3rl04LV+cot9vw8rNO92 NobHeCeMMbo9VZFaZZl3Foopgh42a555jALD5/rqJ1fO7k8VwVdoQ3IRh/30Mcwor4l6 sRCR2ONs8ovaSJGtwNawSnhFxVgd9K4ZdP3FI1t/ZDtpy9z4m8mhy5kkFLr5YpwoaJeF Cbd9OTiZCfRkCWBGki4i8JE31x093/IQUIwLmvu/PnzjT6F4BSZwXsK+8KVHL+wHyCBQ EHCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=/OEqLEQHCmytseRt1FhXxp+Rob399wNsde0XeRnkGgQ=; b=hjtidYA309RpTTX+mijza6pBXR4AoXb5nEr7jI8rxrQcPr0QcETxKgcUJHgv7D2k8z LTNw0UK19rZ/HyYpcIgIJnZ5TISR2DOS02UHCGBnL40v/VoE5Sx9IQGzT0FReTFkWChD qgYa8asTn4Bkqfnl5FeluHwHWL3oOmTHl9c170EzN4gqLIndolu/PIXs9FL5bCt7BIe1 dgJ9HgFquzjq0c/cu5AAr5fu+KQvPJJWTV7UHI8yi5mL1/Z7vPDlHodroUO1Ef0Qlegv A9xmRRV/A0j4jqIIhB2OadVK7rsMRcYjX3+0CEoNB3KkmhGAgYhdbjZH8TfU18+BAkkZ Gwnw== X-Gm-Message-State: AOAM5332vaWSJp081O6iqsXsVULeoag47DzTWI/ZDXcffqQSyhgfncNY gQ52MQktlukBUd8kFHXcCeY= X-Google-Smtp-Source: ABdhPJyXnHdzktWS6AwWRoja1N2Z48ZZJD7qGZxm922GmRaCtBWzMTSguBD/9KCt+SZT4bgDl6OVMg== X-Received: by 2002:a17:906:170d:: with SMTP id c13mr14302431eje.491.1617949474885; Thu, 08 Apr 2021 23:24:34 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Paolo Bonzini , Luc Michel , Peter Maydell , Damien Hedde , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , Andrew Baumann Subject: [RFC PATCH-for-6.1 6/9] hw/misc/bcm2835_cprman: Use qdev_ground_clock() helper Date: Fri, 9 Apr 2021 08:23:58 +0200 Message-Id: <20210409062401.2350436-7-f4bug@amsat.org> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210409062401.2350436-1-f4bug@amsat.org> References: <20210409062401.2350436-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) The ground clock isn't really an internal component of the CPRMAN peripheral. Use the qdev_ground_clock() helper to access the board ground plane. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/misc/bcm2835_cprman.h | 1 - hw/misc/bcm2835_cprman.c | 7 ++----- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/include/hw/misc/bcm2835_cprman.h b/include/hw/misc/bcm2835_cpr= man.h index 3df4ceedd2e..2996ccb4632 100644 --- a/include/hw/misc/bcm2835_cprman.h +++ b/include/hw/misc/bcm2835_cprman.h @@ -204,7 +204,6 @@ struct BCM2835CprmanState { uint32_t xosc_freq; =20 Clock *xosc; - Clock *gnd; }; =20 #endif diff --git a/hw/misc/bcm2835_cprman.c b/hw/misc/bcm2835_cprman.c index 75e6c574d46..5039b7632b4 100644 --- a/hw/misc/bcm2835_cprman.c +++ b/hw/misc/bcm2835_cprman.c @@ -678,9 +678,6 @@ static void cprman_init(Object *obj) } =20 s->xosc =3D clock_new(obj, "xosc"); - s->gnd =3D clock_new(obj, "gnd"); - - clock_set(s->gnd, 0); =20 memory_region_init_io(&s->iomem, obj, &cprman_ops, s, "bcm2835-cprman", 0x2000); @@ -697,7 +694,7 @@ static void connect_mux_sources(BCM2835CprmanState *s, =20 /* For sources from 0 to 3. Source 4 to 9 are mux specific */ Clock * const CLK_SRC_MAPPING[] =3D { - [CPRMAN_CLOCK_SRC_GND] =3D s->gnd, + [CPRMAN_CLOCK_SRC_GND] =3D qdev_ground_clock(), [CPRMAN_CLOCK_SRC_XOSC] =3D s->xosc, [CPRMAN_CLOCK_SRC_TD0] =3D td0, [CPRMAN_CLOCK_SRC_TD1] =3D td1, @@ -708,7 +705,7 @@ static void connect_mux_sources(BCM2835CprmanState *s, Clock *src; =20 if (mapping =3D=3D CPRMAN_CLOCK_SRC_FORCE_GROUND) { - src =3D s->gnd; + src =3D qdev_ground_clock(); } else if (mapping =3D=3D CPRMAN_CLOCK_SRC_DSI0HSCK) { src =3D s->dsi0hsck_mux.out; } else if (i < CPRMAN_CLOCK_SRC_PLLA) { --=20 2.26.3