From nobody Sun Apr 28 19:29:46 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1617645006; cv=none; d=zohomail.com; s=zohoarc; b=MkFoePrUXrfeBfirtebTanS2XVoKZjegHTOpjTM8jkJRLICZiLEaKrdt7klUoyvSRTPXroktDksMkWg5tKV2dnZV+9GBD0gLAIJK0pN8k+Zb6QnOc9zMyGzwoKWNeryq+ASHqGkuG4AOM82D7wLlljSZ14wlQDyP1Smj7r5sCaw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617645006; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=20DvQ3WH5QWQR0UjiWykqS7FkDOIGVYlA50nzpdE8Y4=; b=NtEjin7Aj9RVz6RiHxNrtFWm82JhEAry5Ok4uh00BnYxJRnuxHv7K9f5gV8hmJNlICbcpvJvTd4NjtDCPtqoWa/MBBkioP/n+NpRsHemN4zuK3evPWldygrDR6k0Jlxf94mEZlCNbwuWcV/OGKrucnC/VWO6Ji/CwJEb0U3a1gk= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1617645006387449.0596640004285; Mon, 5 Apr 2021 10:50:06 -0700 (PDT) Received: from localhost ([::1]:36414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTTMS-0008T5-Um for importer@patchew.org; Mon, 05 Apr 2021 13:50:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58434) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTT8k-0004sf-4b; Mon, 05 Apr 2021 13:35:54 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:52949) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTT7b-00014d-PC; Mon, 05 Apr 2021 13:35:53 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 17A775C00D9; Mon, 5 Apr 2021 13:34:43 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 05 Apr 2021 13:34:43 -0400 Received: from apples.local (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by mail.messagingengine.com (Postfix) with ESMTPA id B51781080054; Mon, 5 Apr 2021 13:34:40 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm2; bh=20DvQ3WH5QWQR 0UjiWykqS7FkDOIGVYlA50nzpdE8Y4=; b=WB/z525JmpuHYVkuP+igZAjDMyJO0 8g5ijnlCUAuUYnqpjs/Lw2Devn92skGJIRevedAA1TaRf5lRTy8/joV/aL5l9vm+ B1d0SiKuRVDv7bEn5lMZtLucadDrwk/NKukGAJmu+L6ZNDEt7umAcqWL9biIwqHh O0bTzOWSGm2AGJNUP2JzIVA0uAG6/KLWDLomk1JDyhjq2PjBZFjh3Z/a71JwiAv4 /5XQYLPydtZRGwe5xle3VIHwbk6YALTGzZcj9SGQeA+Q+0cX7/+t4Zz2oEyQU43h I3rYKLkUf0aORj2J46W6sxr2jeCgX/5xlBAL0KrzaRU/k+Ujf+cdleAdw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=20DvQ3WH5QWQR0UjiWykqS7FkDOIGVYlA50nzpdE8Y4=; b=RwQaPIIj 5BYhbZ65NEPH3l92u477qtIXKbbLivJXcFpqty9j3hCM7llA6p/cXxYVpGl90wJQ hZej0rju75w8MkdrAXm9TC/tO8SBqDZJPcZf+CTd61fLU3JnIkFGT+Dxjci1BP0z 0x9hh4sTk/tVsNoezLoCwIcqXpFQVtcLdxoB0jDorDW9xeMUXL5QYSzaK4kcpspj uZGcFLoXkTZovNlicpns67IZnuE7TjuJcMDZnuxcvczDJ9Mrjko3HAIy62PLXqYK 9DJlBEcg9XG8XLjgOh74tWJhcibyKKl3wm2JmA4s/wzXYM7oNInBx4iVVmfQntVo s1uHdvv6mAi4yg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudejvddgudduiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepmfhlrghu shculfgvnhhsvghnuceoihhtshesihhrrhgvlhgvvhgrnhhtrdgukheqnecuggftrfgrth htvghrnhepueelteegieeuhffgkeefgfevjeeigfetkeeitdfgtdeifefhtdfhfeeuffev gfeknecukfhppeektddrudeijedrleekrdduledtnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepihhtshesihhrrhgvlhgvvhgrnhhtrdgukh X-ME-Proxy: From: Klaus Jensen To: Peter Maydell , qemu-devel@nongnu.org Subject: [PULL for-6.0 1/2] hw/block/nvme: remove description for zoned.append_size_limit Date: Mon, 5 Apr 2021 19:34:34 +0200 Message-Id: <20210405173435.36486-2-its@irrelevant.dk> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210405173435.36486-1-its@irrelevant.dk> References: <20210405173435.36486-1-its@irrelevant.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=66.111.4.28; envelope-from=its@irrelevant.dk; helo=out4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Niklas Cassel , qemu-block@nongnu.org, Klaus Jensen , Max Reitz , Keith Busch , Klaus Jensen Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Niklas Cassel The description was originally removed in commit 578d914b263c ("hw/block/nvme: align zoned.zasl with mdts") together with the removal of the zoned.append_size_limit parameter itself. However, it was (most likely accidentally), re-added in commit f7dcd31885cb ("hw/block/nvme: add non-mdts command size limit for verify"). Remove the description again, since the parameter it describes, zoned.append_size_limit, no longer exists. Signed-off-by: Niklas Cassel Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index c54ec3c9523c..08c204d46c43 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -91,14 +91,6 @@ * the minimum memory page size (CAP.MPSMIN). The default value is 0 (i.= e. * defaulting to the value of `mdts`). * - * - `zoned.append_size_limit` - * The maximum I/O size in bytes that is allowed in Zone Append command. - * The default is 128KiB. Since internally this this value is maintained= as - * ZASL =3D log2( / ), some values assig= ned - * to this property may be rounded down and result in a lower maximum ZA - * data size being in effect. By setting this property to 0, users can m= ake - * ZASL to be equal to MDTS. This property only affects zoned namespaces. - * * nvme namespace device parameters * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ * - `subsys` --=20 2.31.1 From nobody Sun Apr 28 19:29:46 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1617644451; cv=none; d=zohomail.com; s=zohoarc; b=FWLZGe9PjlNUJOESc1A/fxEOD4IrEIuZyzLOAIfYK3pAY8hlOkt6pZ9gNw5fIOqY0AR56a87dkKvbxBoBf7/1TuyIuM6VuHqPZABeGU3vIUjVKMlf5hGYtDQwT8kR1WxyhNFULfg0l+TZpd51KvMiRGkNRNVqcNa/eiCBNCe7hk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617644451; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qQSn4qZrcN7PgOW+0g4MaabmZlGAce9keeJ8TpfIV1k=; b=Xb52P4BsUN8TAETzv6t5HNtX6XVjKR2GQnkJVmL96B7HaVo/1XeLepKYCCWMXduRj+vJ17fUzUUtuf7BkC7pSp035wXgXInzLWwij7JfjL/pDCrJ/Oea8UoxI5oLvXYWy+CwZda2stp+cIaZoTU3RlCqcHeovVRX6uoerEaeDIc= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1617644450714976.2863912889829; Mon, 5 Apr 2021 10:40:50 -0700 (PDT) Received: from localhost ([::1]:59562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTTDQ-0005r3-Nw for importer@patchew.org; Mon, 05 Apr 2021 13:40:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58252) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTT7u-0004bp-Bg; Mon, 05 Apr 2021 13:35:02 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:60333) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTT7e-00014v-3T; Mon, 05 Apr 2021 13:35:01 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 472A65C00E8; Mon, 5 Apr 2021 13:34:45 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 05 Apr 2021 13:34:45 -0400 Received: from apples.local (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by mail.messagingengine.com (Postfix) with ESMTPA id EDB711080068; Mon, 5 Apr 2021 13:34:42 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm2; bh=qQSn4qZrcN7Pg OW+0g4MaabmZlGAce9keeJ8TpfIV1k=; b=PH20GZ/KlWAlF6KQ/0D87imPMcQMH 2S5MsrNpv9EAOxFbvCTRCrR/9b8tJbD+FcLXw9JheysGYEkyvr+1wplalBDa2OBp Gfwzm/wgC1c35+q57tnVjVK/9qAHomYm2k3q/dJHaothFK8/jnIYtCC3qHMi5GFM FvlTrnAbn3K8jCYS50UGjc0bRw9b7c+WomN2C78Gb2ktT3rZhU6af3M4yGlHjyOF o4nsU8BaYe/0EFX3KAkmhD3Beet2aGqVWYr7KUg3iFvKYV7zKUogknbGLYP2w/+D w1LX30yTFskIrQPT3fSJH9ZAUKKcaPredEVCTaEheed8Nvn3cXowdBXUw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=qQSn4qZrcN7PgOW+0g4MaabmZlGAce9keeJ8TpfIV1k=; b=KHRFMozX RS7S8KsSimLN7NwLx+VYrS54g7kgjGk6Ho9Dbmp9m0bqFFPcAohBRi8YYFJYs0YL V/hzV+w+4ieVsdehpfG67q7BDO14IpsKwwJT5IXjGHHkn0y+V8ur/rZh2BY9Icya lh6rR7e6Gc6/23axTPsy62SCpJ4ypsyRuVdmcKzpDp/ri+FyUCeVAA7w9RsFIPKs 9wNJudvi7rCP5dP12NEwP5bGE34O7hi4YFeD7zOKWp7r7r7X0VMT3XZ11z2nseT+ cyjVr0FxcgAfiprJpMXfX7NK7nQY32NF0C95KPqS8tp9VNZXBv1fOwxmr0qIfYZ/ rrdYNSGE7vVB7w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudejvddgudduiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepmfhlrghu shculfgvnhhsvghnuceoihhtshesihhrrhgvlhgvvhgrnhhtrdgukheqnecuggftrfgrth htvghrnhepueelteegieeuhffgkeefgfevjeeigfetkeeitdfgtdeifefhtdfhfeeuffev gfeknecukfhppeektddrudeijedrleekrdduledtnecuvehluhhsthgvrhfuihiivgepud enucfrrghrrghmpehmrghilhhfrhhomhepihhtshesihhrrhgvlhgvvhgrnhhtrdgukh X-ME-Proxy: From: Klaus Jensen To: Peter Maydell , qemu-devel@nongnu.org Subject: [PULL for-6.0 2/2] hw/block/nvme: expose 'bootindex' property Date: Mon, 5 Apr 2021 19:34:35 +0200 Message-Id: <20210405173435.36486-3-its@irrelevant.dk> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210405173435.36486-1-its@irrelevant.dk> References: <20210405173435.36486-1-its@irrelevant.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=66.111.4.28; envelope-from=its@irrelevant.dk; helo=out4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, Klaus Jensen , Max Reitz , Keith Busch , Joelle van Dyne , Klaus Jensen Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Joelle van Dyne The check for `n->namespace.blkconf.blk` always fails because this is in the initialization function. Signed-off-by: Joelle van Dyne Reviewed-by: Klaus Jensen Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 08c204d46c43..7244534a89e9 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -6328,11 +6328,9 @@ static void nvme_instance_init(Object *obj) { NvmeCtrl *n =3D NVME(obj); =20 - if (n->namespace.blkconf.blk) { - device_add_bootindex_property(obj, &n->namespace.blkconf.bootindex, - "bootindex", "/namespace@1,0", - DEVICE(obj)); - } + device_add_bootindex_property(obj, &n->namespace.blkconf.bootindex, + "bootindex", "/namespace@1,0", + DEVICE(obj)); =20 object_property_add(obj, "smart_critical_warning", "uint8", nvme_get_smart_warning, --=20 2.31.1