From nobody Sat Apr 27 14:37:29 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1617635314; cv=none; d=zohomail.com; s=zohoarc; b=mLp1S7plhR7tmemc+Uq2brSKj0oklEmkwrm3Y3fZ+mJCNILHgcv5qS+Vp2WEA/YRPGkKlQquXJ10P07IUaTs2zSsKUTS7SAWSDbWhcynVoD74TJ1Xk30lnoua+/tuvP3Khfj0MBy0BeKJmOVSWAwUaSbAxeEfQyTyvVhWFpEEoo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617635314; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9kPA2dY0kCBjioBoIDS+oak9/tGoYS6peLIn1K3t2p0=; b=FIuCWuJXiXJH3BjioGQetvs0NjUw8UkT7UxLPUGMujppqOzDgswqRRdCOMHxkm4cZhyVB9C3tlWUBsxC4hBpCWKvHV86m7R+sZvMHY0AX6EZV7vZkZh2rWKuLffh5p38OCgJaeR34KaUbg67f1HxOn2lttGerAJCJCL7z9fJNNQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1617635314244167.6397998309476; Mon, 5 Apr 2021 08:08:34 -0700 (PDT) Received: from localhost ([::1]:46656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTQq8-0008WE-0O for importer@patchew.org; Mon, 05 Apr 2021 11:08:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44468) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTQOy-00085z-BQ for qemu-devel@nongnu.org; Mon, 05 Apr 2021 10:40:29 -0400 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]:40474) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lTQOu-000652-Dq for qemu-devel@nongnu.org; Mon, 05 Apr 2021 10:40:28 -0400 Received: by mail-pl1-x62f.google.com with SMTP id h8so5757060plt.7 for ; Mon, 05 Apr 2021 07:40:23 -0700 (PDT) Received: from localhost.localdomain (50-200-230-211-static.hfc.comcastbusiness.net. [50.200.230.211]) by smtp.gmail.com with ESMTPSA id q5sm15752999pfk.219.2021.04.05.07.40.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Apr 2021 07:40:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9kPA2dY0kCBjioBoIDS+oak9/tGoYS6peLIn1K3t2p0=; b=ke5b9+6Itgq4i0fyQmaIgHoY9Ylq2dyXb06i+Yi4GJjx8ArZ0u45o8z80+Egm7nBNN uZL/yFEXbYOUowitRNHXMvl9q0nIRjm/iJPpCY4kBVloCsoAl/2IIm0f2D8ajBafoJva kSTDj7PJBJ774NwXhoTpONWZMpYR1V4Ados4E2PUkI2D/WgndLKV/8Mmpx86+HS50UeO K9K1GVxhaUPf6G2iwfcx/c6hwQOXjgf12algfRqmZmigosWGtNmUcfji8P7u9z8TekMy bqOwbfedZirpSIRyYe1+R0Ar/GoDIe2JJSOzusLmzcFKp11YfZ1wkRgb1jXRnq2G5ksn 7fNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9kPA2dY0kCBjioBoIDS+oak9/tGoYS6peLIn1K3t2p0=; b=gKmmLFovP/QEgL5fIVKFw4OiqtIguG/yIv1Z6JjUtXbqdtDK1aj9RSh6yFHHmeGkiv N5nyCi1/bv2pSt66hHfgTI2hcTCFX7A9Jk1wAbyXxoGYyclu5UmmcOmAbIzq6L1XEO9J WmAMkF9uuepBIMf1bDIjTw7URYA62uR5QULnYlQRsvGUHfgvcmdr5pTRnmxt5fa//BAa zEZtqLbI7H1FbDbDRo9SphYVmCDgcXAYU9tDQcCHNFJ/UdTuDDtjMTSPfB68GosuXHDB kDF5sHSMipecR1RMCz3t/sbG0n/MgO194SGrZnKYFrjWPPptm2Dgd9Vkbw0HRnSj2hEP TH9g== X-Gm-Message-State: AOAM533UZ01PPsjbgta399/+kNP0O0vkHNgVJ22Kr7Be/DYJynbyWUHu TXwAVlIRNZwgag8k6cMABz3ebRVEG0QrMA== X-Google-Smtp-Source: ABdhPJyJ+YFK5O/pmrE0XwJkKyiUc6ghnk9gktZHoSsk84Ehuktzzem0ugZL7lh99zrON2aTVBjX7Q== X-Received: by 2002:a17:90a:5106:: with SMTP id t6mr16528179pjh.177.1617633622317; Mon, 05 Apr 2021 07:40:22 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-6.0 1/2] tcg/mips: Fix SoftTLB comparison on mips backend Date: Mon, 5 Apr 2021 07:40:16 -0700 Message-Id: <20210405144017.20193-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210405144017.20193-1-richard.henderson@linaro.org> References: <20210405144017.20193-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62f; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Kele Huang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Kele Huang The addrl used to compare with SoftTLB entry should be sign-extended in common case, and it will cause constant failing in SoftTLB comparisons for the addrl whose address is over 0x80000000 on the emulation of 32-bit guest on 64-bit host. This is an important performance bug fix. Spec2000 gzip rate increase from ~45 to ~140 on Loongson 3A4000 (MIPS compatible platform). Signed-off-by: Kele Huang Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20210401100457.191458-1-kele.hwang@gmail.com> Signed-off-by: Richard Henderson --- tcg/mips/tcg-target.c.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/mips/tcg-target.c.inc b/tcg/mips/tcg-target.c.inc index 8738a3a581..8b16726242 100644 --- a/tcg/mips/tcg-target.c.inc +++ b/tcg/mips/tcg-target.c.inc @@ -1201,13 +1201,13 @@ static void tcg_out_tlb_load(TCGContext *s, TCGReg = base, TCGReg addrl, load the tlb addend for the fast path. */ tcg_out_ld(s, TCG_TYPE_PTR, TCG_TMP2, TCG_TMP3, add_off); } - tcg_out_opc_reg(s, OPC_AND, TCG_TMP1, TCG_TMP1, addrl); =20 /* Zero extend a 32-bit guest address for a 64-bit host. */ if (TCG_TARGET_REG_BITS > TARGET_LONG_BITS) { tcg_out_ext32u(s, base, addrl); addrl =3D base; } + tcg_out_opc_reg(s, OPC_AND, TCG_TMP1, TCG_TMP1, addrl); =20 label_ptr[0] =3D s->code_ptr; tcg_out_opc_br(s, OPC_BNE, TCG_TMP1, TCG_TMP0); --=20 2.25.1 From nobody Sat Apr 27 14:37:29 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1617635885; cv=none; d=zohomail.com; s=zohoarc; b=hT08SXDU9qU1c5vwvt0s5L+b5Ff15ox2w17TCW/FXd82qdiuXX7w+Yko65temo99M7hcLkLd6N5Q1hhiEbnLmn4k6suQlZctp2BVGdu2VsVJRJiimoaNKokMbIs3agbFXFl8gSvI8DGCrQ0Fiel3K+ww8Of5rhfEvk3LmU7znww= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617635885; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=dTsPV4XPxjrQUOgxsRHz250RxZ1fUey0SqTSTKo2NTE=; b=d8jRPhzdgXA0XhS+ttXX00ECiq96MF+S4pSUFFE7hy6OLhckYAmkhdNdJDQ2G0+ssRJooE/LIX8TukVT5gtuh4H91RZktTOshAhDGYTNCJFfRpE/kcGUlSbVAIGZsaMeCUbMeuKUqW2nN3XFcCF2NW3A+X6/sdm/j64Icm/q+Cs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16176358856671.9592354006573487; Mon, 5 Apr 2021 08:18:05 -0700 (PDT) Received: from localhost ([::1]:36474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTQzM-0007j8-7f for importer@patchew.org; Mon, 05 Apr 2021 11:18:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44484) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTQP6-00086t-Bo for qemu-devel@nongnu.org; Mon, 05 Apr 2021 10:40:37 -0400 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]:54265) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lTQOu-000656-Fb for qemu-devel@nongnu.org; Mon, 05 Apr 2021 10:40:36 -0400 Received: by mail-pj1-x1035.google.com with SMTP id t23so2950962pjy.3 for ; Mon, 05 Apr 2021 07:40:24 -0700 (PDT) Received: from localhost.localdomain (50-200-230-211-static.hfc.comcastbusiness.net. [50.200.230.211]) by smtp.gmail.com with ESMTPSA id q5sm15752999pfk.219.2021.04.05.07.40.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Apr 2021 07:40:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dTsPV4XPxjrQUOgxsRHz250RxZ1fUey0SqTSTKo2NTE=; b=t8ugGnsYnxGJ1JoTs8t+ERXmjPKji2vD3CqRcSDcJSJ5u0s05dJ2RK4AyNdMaghjm7 VMzniIbAs0Jx5qvv+YQ60uIX0gsPK6JwVNCVI160DcMnaS7yO5J1OrrrvQ7UC93oBBqr ZraEwD0DnmE3TdwgCRHnyPKt3i8ZaGnGBWLozcf9HmYjxFW2BrsjXrPo6WvNy2YOwJFf jBc/+wJmrhylOHmKBIWYQdzoNHivksDlK0mxcRsR3nH29VO9Ru1nG5cbTSTCGXDyS69R PXJf6FgRRDKxIZ/fujthD38CsDWTLmg0XfT1T+XMktrpCtmo4ZRloseQg5Wd3cxcwTQ4 ztew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dTsPV4XPxjrQUOgxsRHz250RxZ1fUey0SqTSTKo2NTE=; b=Qjlvp4J0w+WmOlwI9EcLtXMDttiY1eoWA0tpwyMks8Fe9jHnO/efxc6qhFK8Pnfacv CYLq7y2NTZ4hi0QvPi/knnT70yv2PRogdR6UmLBAiNYX+KSTiM6Ze8f4yNRsCB6/fhU+ zSOXtVppFnbrXO51tMRnF1wCEnlkMTLAmAo5pJciv1lT6TPHgQwa3f7JldX6pJ3SFRFw t82KMXXxNidcbWPH9HwXha0iYsQ/OeHFUXRaBTsQ+iiwXgV9/YoLRxhq57hjjUJYudiw Vzx+YO2GbBw1KuEhNDZxSd91UArpPoqbSwVKEzBWRljloyFky2PKqKDMfZd0rRITayx1 rlbQ== X-Gm-Message-State: AOAM533S0AuOrcmruVM5xDv6akdAtGNRvdsAF8y3aYuzK6TKTmTEGmD8 JL5XDBywk1PYqhxHWSuVZcXVNLyTaN8P3A== X-Google-Smtp-Source: ABdhPJw9rgZiBnwxgrvHN0Qm9EZOxLVS0CfZbp1mvcV7CSRDEkxnOaPPfAU4mpoSUb+uHNF/N6pSFw== X-Received: by 2002:a17:90a:868c:: with SMTP id p12mr26135809pjn.82.1617633623281; Mon, 05 Apr 2021 07:40:23 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL for-6.0 2/2] target/alpha: fix icount handling for timer instructions Date: Mon, 5 Apr 2021 07:40:17 -0700 Message-Id: <20210405144017.20193-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210405144017.20193-1-richard.henderson@linaro.org> References: <20210405144017.20193-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1035; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1035.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Pavel Dovgalyuk Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" From: Pavel Dovgalyuk This patch handles icount mode for timer read/write instructions, because it is required to call gen_io_start in such cases. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Richard Henderson Message-Id: <161700373035.1135822.16451510827008616793.stgit@pasha-ThinkPad= -X280> Signed-off-by: Richard Henderson --- target/alpha/translate.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/target/alpha/translate.c b/target/alpha/translate.c index a02b4e70b7..f454adea5e 100644 --- a/target/alpha/translate.c +++ b/target/alpha/translate.c @@ -1330,7 +1330,7 @@ static DisasJumpType gen_mfpr(DisasContext *ctx, TCGv= va, int regno) case 249: /* VMTIME */ helper =3D gen_helper_get_vmtime; do_helper: - if (icount_enabled()) { + if (tb_cflags(ctx->base.tb) & CF_USE_ICOUNT) { gen_io_start(); helper(va); return DISAS_PC_STALE; @@ -1366,6 +1366,7 @@ static DisasJumpType gen_mfpr(DisasContext *ctx, TCGv= va, int regno) static DisasJumpType gen_mtpr(DisasContext *ctx, TCGv vb, int regno) { int data; + DisasJumpType ret =3D DISAS_NEXT; =20 switch (regno) { case 255: @@ -1395,6 +1396,10 @@ static DisasJumpType gen_mtpr(DisasContext *ctx, TCG= v vb, int regno) =20 case 251: /* ALARM */ + if (tb_cflags(ctx->base.tb) & CF_USE_ICOUNT) { + gen_io_start(); + ret =3D DISAS_PC_STALE; + } gen_helper_set_alarm(cpu_env, vb); break; =20 @@ -1434,7 +1439,7 @@ static DisasJumpType gen_mtpr(DisasContext *ctx, TCGv= vb, int regno) break; } =20 - return DISAS_NEXT; + return ret; } #endif /* !USER_ONLY*/ =20 --=20 2.25.1