[PATCH v2 0/3] target/arm mte fixes

Richard Henderson posted 3 patches 1 year, 4 months ago
Test checkpatch failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210402161835.286665-1-richard.henderson@linaro.org
There is a newer version of this series
Maintainers: Peter Maydell <peter.maydell@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>
target/arm/helper-a64.h           |   3 +-
target/arm/internals.h            |  13 +--
target/arm/translate-a64.h        |   2 +-
tests/tcg/aarch64/mte.h           |   3 +-
accel/tcg/translate-all.c         |   9 +-
target/arm/mte_helper.c           | 171 ++++++++++++------------------
target/arm/sve_helper.c           |  96 ++++++-----------
target/arm/translate-a64.c        |  31 +++---
target/arm/translate-sve.c        |   9 +-
tests/tcg/aarch64/mte-5.c         |  44 ++++++++
tests/tcg/aarch64/mte-6.c         |  43 ++++++++
tests/tcg/aarch64/Makefile.target |   2 +-
12 files changed, 222 insertions(+), 204 deletions(-)
create mode 100644 tests/tcg/aarch64/mte-5.c
create mode 100644 tests/tcg/aarch64/mte-6.c
[PATCH v2 0/3] target/arm mte fixes
Posted by Richard Henderson 1 year, 4 months ago
In addition to re-instating the "is tag checking enabled" test
in gen_mte_checkN, add a fix for a second bug in mprotect.

I have verified that the 5.10 kernel, running in system mode,
allows setting PROT_MTE with mprotect.


r~


Supercedes: 20210402053728.265173-1-richard.henderson@linaro.org
("target/arm: Fix unaligned mte checks")


Richard Henderson (3):
  target/arm: Check PAGE_WRITE_ORG for MTE writeability
  target/arm: Fix unaligned mte checks
  accel/tcg: Preserve PAGE_ANON when changing page permissions

 target/arm/helper-a64.h           |   3 +-
 target/arm/internals.h            |  13 +--
 target/arm/translate-a64.h        |   2 +-
 tests/tcg/aarch64/mte.h           |   3 +-
 accel/tcg/translate-all.c         |   9 +-
 target/arm/mte_helper.c           | 171 ++++++++++++------------------
 target/arm/sve_helper.c           |  96 ++++++-----------
 target/arm/translate-a64.c        |  31 +++---
 target/arm/translate-sve.c        |   9 +-
 tests/tcg/aarch64/mte-5.c         |  44 ++++++++
 tests/tcg/aarch64/mte-6.c         |  43 ++++++++
 tests/tcg/aarch64/Makefile.target |   2 +-
 12 files changed, 222 insertions(+), 204 deletions(-)
 create mode 100644 tests/tcg/aarch64/mte-5.c
 create mode 100644 tests/tcg/aarch64/mte-6.c

-- 
2.25.1


Re: [PATCH v2 0/3] target/arm mte fixes
Posted by no-reply@patchew.org 1 year, 4 months ago
Patchew URL: https://patchew.org/QEMU/20210402161835.286665-1-richard.henderson@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210402161835.286665-1-richard.henderson@linaro.org
Subject: [PATCH v2 0/3] target/arm mte fixes

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210401181457.73039-1-vijai@behindbytes.com -> patchew/20210401181457.73039-1-vijai@behindbytes.com
 - [tag update]      patchew/20210402102128.213943-1-vaibhav@linux.ibm.com -> patchew/20210402102128.213943-1-vaibhav@linux.ibm.com
 * [new tag]         patchew/20210402161835.286665-1-richard.henderson@linaro.org -> patchew/20210402161835.286665-1-richard.henderson@linaro.org
 * [new tag]         patchew/20210402162052.264952-1-alxndr@bu.edu -> patchew/20210402162052.264952-1-alxndr@bu.edu
Switched to a new branch 'test'
e216c8a accel/tcg: Preserve PAGE_ANON when changing page permissions
6773b16 target/arm: Fix unaligned mte checks
431c19d target/arm: Check PAGE_WRITE_ORG for MTE writeability

=== OUTPUT BEGIN ===
1/3 Checking commit 431c19d5f137 (target/arm: Check PAGE_WRITE_ORG for MTE writeability)
WARNING: line over 80 characters
#28: FILE: target/arm/mte_helper.c:86:
+    if (!(flags & (ptr_access == MMU_DATA_STORE ? PAGE_WRITE_ORG : PAGE_READ))) {

total: 0 errors, 1 warnings, 8 lines checked

Patch 1/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/3 Checking commit 6773b163444d (target/arm: Fix unaligned mte checks)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
ERROR: spaces required around that '*' (ctx:WxV)
#407: FILE: target/arm/sve_helper.c:4438:
+               sve_ldst1_tlb_fn *tlb_fn)
                                 ^

ERROR: spaces required around that '*' (ctx:WxV)
#517: FILE: target/arm/sve_helper.c:5063:
+               sve_ldst1_tlb_fn *tlb_fn)
                                 ^

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#777: 
new file mode 100644

total: 2 errors, 1 warnings, 708 lines checked

Patch 2/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/3 Checking commit e216c8a64517 (accel/tcg: Preserve PAGE_ANON when changing page permissions)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#66: 
new file mode 100644

ERROR: "foo * bar" should be "foo *bar"
#123: FILE: tests/tcg/aarch64/mte.h:51:
+static void * alloc_mte_mem(size_t size) __attribute__((unused));

ERROR: "foo * bar" should be "foo *bar"
#124: FILE: tests/tcg/aarch64/mte.h:52:
+static void * alloc_mte_mem(size_t size)

total: 2 errors, 1 warnings, 84 lines checked

Patch 3/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210402161835.286665-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com