From nobody Thu May 2 19:12:10 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1617284080; cv=none; d=zohomail.com; s=zohoarc; b=XV/hhGHG6ppGcF7ZXsDyDsipK4FSNBdI3opEpQH0Iw5lA/Zw11psVQ/ewNYK15gHZr0v7yA5sIPTeqcUFb6pfZqJQEKHZdgR9XoAFIajoeuGWZcnT4ZrXxTUVNamhUiqnKte2ynnmYbhAc2WH/MyKMHA+05vzdfZEJKt6CBuvwI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617284080; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=gtClItl96uN/Dirz0cj4QFjaQ1RRVFmOXewsHedXFZw=; b=ZFa7ovSsvak06W66VNjJ/AncLy/LlP2bDZ2fYDVUHaduZGhroNs4NblbCBDMLkjwvj6u7kjXBHKeqqCzEw7iO834worxNI03x/Jn1r8Zz3yu4X4q37eZ/4Ia7fjI+DLtIWDOfGi7OjQIJPJxzqOjrPx8sjgyrxWSS2n+oUzC4z8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1617284080586962.9783678596002; Thu, 1 Apr 2021 06:34:40 -0700 (PDT) Received: from localhost ([::1]:60760 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRxT5-0006yb-9z for importer@patchew.org; Thu, 01 Apr 2021 09:34:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40928) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRxNS-0001js-SO for qemu-devel@nongnu.org; Thu, 01 Apr 2021 09:28:50 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:60853) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRxNP-0004LM-K3 for qemu-devel@nongnu.org; Thu, 01 Apr 2021 09:28:50 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-388-q6JJ-kUWN-Oz4qS-Oiqr3g-1; Thu, 01 Apr 2021 09:28:45 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 62CC7190D341; Thu, 1 Apr 2021 13:28:44 +0000 (UTC) Received: from localhost (ovpn-114-60.ams2.redhat.com [10.36.114.60]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D21C25D9CA; Thu, 1 Apr 2021 13:28:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617283726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gtClItl96uN/Dirz0cj4QFjaQ1RRVFmOXewsHedXFZw=; b=VZdliqdBCn0o9P1rMUiFaqR06cAE9gl94aq+LKkdRf0Cwjw+148fEU/Fe35orLrnkU+xSB H1s7hoRp3XbfxoI3WQOezoLWabpL9hQhj/OaTbmbSRlMhBDvievkRLRJ2lWvt9tvKTLjB4 zJ1PFFFB10XOikNGmYknxAumKWvNZCE= X-MC-Unique: q6JJ-kUWN-Oz4qS-Oiqr3g-1 From: Max Reitz To: qemu-block@nongnu.org Subject: [PATCH] iotests/qsd-jobs: Filter events in the first test Date: Thu, 1 Apr 2021 15:28:39 +0200 Message-Id: <20210401132839.139939-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=mreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, Stefan Hajnoczi , Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) The job may or may not be ready before the 'quit' is issued. Whether it is is irrelevant; for the purpose of the test, it only needs to still be there. Filter the job status change and READY events from the output so it becomes reliable. Reported-by: Peter Maydell Suggested-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy --- This is an alternative to "iotests/qsd-jobs: Use common.qemu for the QSD". I can't disagree with Vladimir that perhaps this test just should not care about the job status events, because all that matters is that the job is still running when 'quit' is issued (which we can see by the (not filtered) COMPLETED event coming afterwards), but it seems strange just not to care about what state the job is actually in when we quit the QSD. It=E2=80=99s definitely much simpler than the common.qemu variant. --- tests/qemu-iotests/tests/qsd-jobs | 5 ++++- tests/qemu-iotests/tests/qsd-jobs.out | 10 ---------- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/tests/qemu-iotests/tests/qsd-jobs b/tests/qemu-iotests/tests/q= sd-jobs index 972b6b3898..510bf0a9dc 100755 --- a/tests/qemu-iotests/tests/qsd-jobs +++ b/tests/qemu-iotests/tests/qsd-jobs @@ -52,9 +52,12 @@ echo "=3D=3D=3D Job still present at shutdown =3D=3D=3D" echo =20 # Just make sure that this doesn't crash +# (Filter job status and READY events, because their order may differ +# between runs, particularly around when 'quit' is issued) $QSD --chardev stdio,id=3Dstdio --monitor chardev=3Dstdio \ --blockdev node-name=3Dfile0,driver=3Dfile,filename=3D"$TEST_IMG" \ - --blockdev node-name=3Dfmt0,driver=3Dqcow2,file=3Dfile0 <