From nobody Tue May 7 11:35:55 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1617190910; cv=none; d=zohomail.com; s=zohoarc; b=ZVKMOzkOWisR0J2EnzAIOEvrbyX0+jZ3sxwO+Uh9Q94MAPF7wVArokfyTEKVU+D5Jf8CW67OT4Zhrx7OfAQeLp/0fAhsvRbkUE9k082wdMSv1zl8HuBwmz3LVwgPMdLs3FamvB5qsenf24V3MWXGgpKzIl/f+5s2K1jpG3JCZWA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617190910; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=JPSCgCVEpQjrJaHbtEdxAqB9J5Tb5Fqfyu6GL9BE70s=; b=k39bFyc7pvQj3rjLMe7admvaHI6dmMF4OfrXs1fvq69QBQcvZpbH0EjL/dusUlTArzCVYAyz0Nh9nerk0ANdZfQ1j5bw+LbTvSVyjMOVPLdnvpB/Ja6XSYE1R53fo8qaa5ERPYIVY3PUsXnvoMJq2KL1/K1Ahlx8Ur4ib63HEq8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1617190910876272.56500258179665; Wed, 31 Mar 2021 04:41:50 -0700 (PDT) Received: from localhost ([::1]:47374 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRZEL-00085i-Du for importer@patchew.org; Wed, 31 Mar 2021 07:41:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50788) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRZCo-0007UA-JF for qemu-devel@nongnu.org; Wed, 31 Mar 2021 07:40:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:45105) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRZCd-00073U-2y for qemu-devel@nongnu.org; Wed, 31 Mar 2021 07:40:12 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-602-XF2CCWSrOT6tezp8drrPrw-1; Wed, 31 Mar 2021 07:39:56 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D1D3910059C0; Wed, 31 Mar 2021 11:39:55 +0000 (UTC) Received: from vitty.brq.redhat.com (unknown [10.40.193.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id EAB495C1B4; Wed, 31 Mar 2021 11:39:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617190800; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JPSCgCVEpQjrJaHbtEdxAqB9J5Tb5Fqfyu6GL9BE70s=; b=dbrWNVfs7t40SlNoQmdKovsFTTdVIjC7pvnctIXF9b6Bux4skjmybbq6ZU/Nj0OPUq5eXI LuC45fVEhOPrQU0A6fn3AXjSIq2C42OG/DnOMr+X4uQWgzLV5gtBbMyZ9QVJVPHuICL9cy Id8tW/EPBGy3/0jUz+sEYNkdETmSY7w= X-MC-Unique: XF2CCWSrOT6tezp8drrPrw-1 From: Vitaly Kuznetsov To: qemu-devel@nongnu.org, Paolo Bonzini Subject: [PATCH v2] i386: Make 'hv-reenlightenment' require explicit 'tsc-frequency' setting Date: Wed, 31 Mar 2021 13:39:48 +0200 Message-Id: <20210331113948.333461-1-vkuznets@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vkuznets@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=vkuznets@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , David Edmondson , "Michael S. Tsirkin" , Richard Henderson , "Dr . David Alan Gilbert" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Commit 561dbb41b1d7 "i386: Make migration fail when Hyper-V reenlightenment was enabled but 'user_tsc_khz' is unset" forbade migrations with when guest has opted for reenlightenment notifications but 'tsc-frequency' wasn't set explicitly on the command line. This works but the migration fails late and this may come as an unpleasant surprise. To make things more explicit, require 'tsc-frequency=3D' on the command line when 'hv-reenlightenment' was enabled. Make the change affect 6.0+ machine types only to preserve previously-valid configurations. Signed-off-by: Vitaly Kuznetsov Acked-by: Dr. David Alan Gilbert --- Changes since v1: - Typos in commit message/comment fixed [David Edmondson] - Add Acked-by tag [Dr. David Alan Gilbert] --- docs/hyperv.txt | 1 + hw/i386/pc.c | 1 + target/i386/cpu.c | 23 +++++++++++++++++++++-- target/i386/cpu.h | 1 + 4 files changed, 24 insertions(+), 2 deletions(-) diff --git a/docs/hyperv.txt b/docs/hyperv.txt index e53c581f4586..5b02d341ab25 100644 --- a/docs/hyperv.txt +++ b/docs/hyperv.txt @@ -165,6 +165,7 @@ emulate TSC accesses after migration so 'tsc-frequency= =3D' CPU option also has to be specified to make migration succeed. The destination host has to either= have the same TSC frequency or support TSC scaling CPU feature. =20 +Requires: tsc-frequency Recommended: hv-frequencies =20 3.16. hv-evmcs diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 8a84b25a031e..47b79e949ad7 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -98,6 +98,7 @@ =20 GlobalProperty pc_compat_5_2[] =3D { { "ICH9-LPC", "x-smi-cpu-hotunplug", "off" }, + { TYPE_X86_CPU, "x-hv-reenlightenment-requires-tscfreq", "off"}, }; const size_t pc_compat_5_2_len =3D G_N_ELEMENTS(pc_compat_5_2); =20 diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 6b3e9467f177..dbcd2ffbbbe5 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -6647,10 +6647,23 @@ static void x86_cpu_filter_features(X86CPU *cpu, bo= ol verbose) } } =20 -static void x86_cpu_hyperv_realize(X86CPU *cpu) +static void x86_cpu_hyperv_realize(X86CPU *cpu, Error **errp) { + CPUX86State *env =3D &cpu->env; size_t len; =20 + /* + * Reenlightenment requires explicit 'tsc-frequency' setting for succe= ssful + * migration (see hyperv_reenlightenment_post_load()). As 'hv-passthro= ugh' + * mode is not migratable, we can loosen the restriction. + */ + if (hyperv_feat_enabled(cpu, HYPERV_FEAT_REENLIGHTENMENT) && + !cpu->hyperv_passthrough && !env->user_tsc_khz && + cpu->hyperv_reenlightenment_requires_tscfreq) { + error_setg(errp, "'hv-reenlightenment' requires 'tsc-frequency' to= be set"); + return; + } + /* Hyper-V vendor id */ if (!cpu->hyperv_vendor) { memcpy(cpu->hyperv_vendor_id, "Microsoft Hv", 12); @@ -6846,7 +6859,11 @@ static void x86_cpu_realizefn(DeviceState *dev, Erro= r **errp) } =20 /* Process Hyper-V enlightenments */ - x86_cpu_hyperv_realize(cpu); + x86_cpu_hyperv_realize(cpu, &local_err); + if (local_err !=3D NULL) { + error_propagate(errp, local_err); + return; + } =20 cpu_exec_realizefn(cs, &local_err); if (local_err !=3D NULL) { @@ -7374,6 +7391,8 @@ static Property x86_cpu_properties[] =3D { DEFINE_PROP_INT32("x-hv-max-vps", X86CPU, hv_max_vps, -1), DEFINE_PROP_BOOL("x-hv-synic-kvm-only", X86CPU, hyperv_synic_kvm_only, false), + DEFINE_PROP_BOOL("x-hv-reenlightenment-requires-tscfreq", X86CPU, + hyperv_reenlightenment_requires_tscfreq, true), DEFINE_PROP_BOOL("x-intel-pt-auto-level", X86CPU, intel_pt_auto_level, true), DEFINE_PROP_END_OF_LIST() diff --git a/target/i386/cpu.h b/target/i386/cpu.h index 570f916878f9..0196a300f018 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -1677,6 +1677,7 @@ struct X86CPU { uint32_t hyperv_spinlock_attempts; char *hyperv_vendor; bool hyperv_synic_kvm_only; + bool hyperv_reenlightenment_requires_tscfreq; uint64_t hyperv_features; bool hyperv_passthrough; OnOffAuto hyperv_no_nonarch_cs; --=20 2.30.2