From nobody Mon Feb 9 15:45:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=huawei.com ARC-Seal: i=1; a=rsa-sha256; t=1617185860; cv=none; d=zohomail.com; s=zohoarc; b=PdB9NyPF2KUMbT2+8x3gO1dXXsCVauTLFd075/zEkpkz6P7NP9zeMr7ic8EzxQv6VexXDjxAfG+3mgrsL2uPvYkF69oXXsj2/IZpuqQb1bOgrJbA1T+lWVQG8bYyzaDilPS+CHd4jh+QzPk+Jricya7SJdjXVZH1/9ehQ1CNJG0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1617185860; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=bOxz6/H8ZKGrq1dhuw4YPqmAjy7bSaP6shHOpluIELU=; b=GgQJxpGLBdm14NCBSQKc+2n+WyYRTXdbtEzKY3upLoCl3BGcYyxhBTexWdQqjRBRloLSN1CaI8t6vaCr4geiqBAQJpWHb+lc+AgwN1g3XyG2G3pg8VwOAd/F6KjuZhDcEiIHAbyTLYV6fWozOPb0J+jiRScL0jfmxxJEhqTRnYk= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1617185860624611.065662560594; Wed, 31 Mar 2021 03:17:40 -0700 (PDT) Received: from localhost ([::1]:53976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRXut-0006uX-BA for importer@patchew.org; Wed, 31 Mar 2021 06:17:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56352) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRXr7-0002a4-EW; Wed, 31 Mar 2021 06:13:45 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:4492) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRXr5-0005kV-8j; Wed, 31 Mar 2021 06:13:45 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4F9MXz4YfJzyNQb; Wed, 31 Mar 2021 18:11:31 +0800 (CST) Received: from DESKTOP-6NKE0BC.china.huawei.com (10.174.185.210) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.498.0; Wed, 31 Mar 2021 18:13:27 +0800 From: Kunkun Jiang To: Eric Auger , Peter Maydell , Alex Williamson , , Yi Sun , "open list:ARM SMMU" , "open list:All patches CC here" Subject: [RFC PATCH v2 3/4] vfio: Add vfio_prereg_listener_global_log_start/stop in nested stage Date: Wed, 31 Mar 2021 18:12:58 +0800 Message-ID: <20210331101259.2153-4-jiangkunkun@huawei.com> X-Mailer: git-send-email 2.26.2.windows.1 In-Reply-To: <20210331101259.2153-1-jiangkunkun@huawei.com> References: <20210331101259.2153-1-jiangkunkun@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.174.185.210] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=jiangkunkun@huawei.com; helo=szxga05-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Liu Yi L , shameerali.kolothum.thodi@huawei.com, Kirti Wankhede , Zenghui Yu , wanghaibin.wang@huawei.com, Keqian Zhu Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" In nested mode, we set up the stage 2 and stage 1 separately. In my opinion, vfio_memory_prereg_listener is used for stage 2 and vfio_memory_listener is used for stage 1. So it feels weird to call the global_log_start/stop interface in vfio_memory_listener to switch dirty tracking, although this won't cause any errors. Add global_log_start/stop interface in vfio_memory_prereg_listener can separate stage 2 from stage 1. Signed-off-by: Kunkun Jiang --- hw/vfio/common.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 86722814d4..efea252e46 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -1209,6 +1209,16 @@ static void vfio_listener_log_global_start(MemoryLis= tener *listener) { VFIOContainer *container =3D container_of(listener, VFIOContainer, lis= tener); =20 + if (container->iommu_type !=3D VFIO_TYPE1_NESTING_IOMMU) { + vfio_set_dirty_page_tracking(container, true); + } +} + +static void vfio_prereg_listener_log_global_start(MemoryListener *listener) +{ + VFIOContainer *container =3D + container_of(listener, VFIOContainer, prereg_listener); + vfio_set_dirty_page_tracking(container, true); } =20 @@ -1216,6 +1226,16 @@ static void vfio_listener_log_global_stop(MemoryList= ener *listener) { VFIOContainer *container =3D container_of(listener, VFIOContainer, lis= tener); =20 + if (container->iommu_type !=3D VFIO_TYPE1_NESTING_IOMMU) { + vfio_set_dirty_page_tracking(container, false); + } +} + +static void vfio_prereg_listener_log_global_stop(MemoryListener *listener) +{ + VFIOContainer *container =3D + container_of(listener, VFIOContainer, prereg_listener); + vfio_set_dirty_page_tracking(container, false); } =20 @@ -1408,6 +1428,8 @@ static const MemoryListener vfio_memory_listener =3D { static MemoryListener vfio_memory_prereg_listener =3D { .region_add =3D vfio_prereg_listener_region_add, .region_del =3D vfio_prereg_listener_region_del, + .log_global_start =3D vfio_prereg_listener_log_global_start, + .log_global_stop =3D vfio_prereg_listener_log_global_stop, .log_sync =3D vfio_prereg_listener_log_sync, }; =20 --=20 2.23.0