From nobody Tue Feb 10 03:38:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.49 as permitted sender) client-ip=209.85.128.49; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f49.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1616718494; cv=none; d=zohomail.com; s=zohoarc; b=mf3kpHJZjm5PCp+Rbbf4EOT+dpwZrO9AigxEijRm7lATlWn8X77+8I/GXd7fha+r3FA3H/LuvN856JlhFH81HIdMQem3opQM4Hzs4o7mmH/U1A36/07byUp/FycHQLV7+NsS/J5WYPBWLytVLW/hiKHGL8ztigF245lP6bKc/dM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616718494; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OKDA4eVJdfRxYq1EfuTuqohDkKwpb3am+iFd4G3Hvr4=; b=csBUeKPxIapNBqhX/Fi7xOHQdpwvobtaW7uJvAI5NDVPQ1RahM/2HdCzKBw1iw6Oik+0q8e5tf9ypzJ9sQrY4vJZRiBj9Wa/j8cPN5xW41ie4fC/7j3nMY7nn0vP9fG6/pOVU1bzy3c2vxJ5WhiS+DWxaGWaVUGdX63byAPaKm0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by mx.zohomail.com with SMTPS id 1616718494108459.98626616311185; Thu, 25 Mar 2021 17:28:14 -0700 (PDT) Received: by mail-wm1-f49.google.com with SMTP id g20so2103871wmk.3 for ; Thu, 25 Mar 2021 17:28:13 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (17.red-88-21-201.staticip.rima-tde.net. [88.21.201.17]) by smtp.gmail.com with ESMTPSA id s20sm8211386wmj.36.2021.03.25.17.28.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Mar 2021 17:28:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OKDA4eVJdfRxYq1EfuTuqohDkKwpb3am+iFd4G3Hvr4=; b=O8+KG+/omyfE3MH1os+UijgTr/H3PK50FfNKFkjBALk6lmN9OPaXSGbEHO8OzF7pKu unDA/pp34Ts9CED9QY34UuHA3GIVmBEdHxsLxbht2imL0nbsecRFsU9Ec3AjMun7ouPR LMAsCnSI0inmmqD3evV3B7wS4NHrwnZmoEDN2v+0xMnVNYFgbw+cSHY04OwBn5M+4RoH SFxa+/WDTyZg2KEnBBie2EYvW7FmxAr+BsO5cRy5TVF4r+iYlNB+8r/m8Qt7EuENKijG GmjymdiQR4f813q7I4djwx68DYv5/CeMKNsKHmvwewG5AC/h4JOdZYB57e7FmxDl5ekF j7Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=OKDA4eVJdfRxYq1EfuTuqohDkKwpb3am+iFd4G3Hvr4=; b=PNmMugcZRvPpVWKepn5hGCO0+qY9qekO/H5eZdDgoPLQXLhn7V7dU8WIctDgnIvJjC DKVmpiTTczCM8jVmuHlsh3zi3SgHmwtwPqHl9h+ryIJt+tchZ1/YXKInjtdmnoaNbv3H 3k81NRA1GEzyiG0jhXg1wwcAf4VjYRadko7lAmgjmuCwTTRzvYCDLKA5UL2/z4ukFwZl O2GjBvnJFA24NiOOyYStu/Aqu5W5781lUR4GFqFkUR/yy1JwXTQA/djrEinYlySdA7vB xfnWFabUdLuxWK/FQx2W4kBltqgRfiD8sgkdD7npV8euMnyaY/6KkW/0owouqid2j9iC wNFQ== X-Gm-Message-State: AOAM533iE8GEEA995heepms7d/b4MQyf719wuFtqB20Ql16+eX0kijzh G4WfSjqPnCCZ/qC8EEysZj8= X-Google-Smtp-Source: ABdhPJy1NXEfN2hkOHw1HkOWIl3+xRN70JpVZP9oEPisumT3Rs9PjqBFDq3uB88l1C8YmzpOK702fg== X-Received: by 2002:a1c:9a09:: with SMTP id c9mr10056005wme.172.1616718492267; Thu, 25 Mar 2021 17:28:12 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier , Mark Cave-Ayland , Peter Maydell , Richard Henderson , Alistair Francis , "Edgar E. Iglesias" , qemu-ppc@nongnu.org, qemu-arm@nongnu.org, David Gibson Subject: [RFC PATCH-for-6.1 08/10] hw/misc/aliased_region: Simplify aliased I/O regions Date: Fri, 26 Mar 2021 01:27:26 +0100 Message-Id: <20210326002728.1069834-9-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210326002728.1069834-1-f4bug@amsat.org> References: <20210326002728.1069834-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Currently a small I/O region aliased on a wide container creates many aliases. For example, a 8 bytes regions in a 4KiB container creates 512 aliases! As I/O goes via the slow path, we can optimize by using an I/O region which dispatch via an address space view of the aliased region. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/misc/aliased_region.h | 6 +++- hw/misc/aliased_region.c | 56 ++++++++++++++++++++++++++++++-- 2 files changed, 59 insertions(+), 3 deletions(-) diff --git a/include/hw/misc/aliased_region.h b/include/hw/misc/aliased_reg= ion.h index 0ce0d5d1cef..30b54cf06b7 100644 --- a/include/hw/misc/aliased_region.h +++ b/include/hw/misc/aliased_region.h @@ -1,7 +1,7 @@ /* * Aliased memory regions * - * Copyright (c) 2018 Philippe Mathieu-Daud=C3=A9 + * Copyright (c) 2018, 2020 Philippe Mathieu-Daud=C3=A9 * * SPDX-License-Identifier: GPL-2.0-or-later */ @@ -25,6 +25,10 @@ struct AliasedRegionState { uint64_t span_size; MemoryRegion *mr; =20 + struct { + AddressSpace as; + } io; + struct { size_t count; MemoryRegion *alias; diff --git a/hw/misc/aliased_region.c b/hw/misc/aliased_region.c index 8fcc63f2648..46b4412430a 100644 --- a/hw/misc/aliased_region.c +++ b/hw/misc/aliased_region.c @@ -1,7 +1,7 @@ /* * Aliased memory regions * - * Copyright (c) 2018 Philippe Mathieu-Daud=C3=A9 + * Copyright (c) 2018, 2020 Philippe Mathieu-Daud=C3=A9 * * SPDX-License-Identifier: GPL-2.0-or-later */ @@ -14,6 +14,50 @@ #include "hw/misc/aliased_region.h" #include "hw/qdev-properties.h" =20 +static MemTxResult aliased_io_read(void *opaque, hwaddr offset, + uint64_t *data, unsigned size, + MemTxAttrs attrs) +{ + AliasedRegionState *s =3D ALIASED_REGION(opaque); + + return address_space_read(&s->io.as, offset, attrs, data, size); +} + +static MemTxResult aliased_io_write(void *opaque, hwaddr offset, + uint64_t data, unsigned size, + MemTxAttrs attrs) +{ + AliasedRegionState *s =3D ALIASED_REGION(opaque); + + return address_space_write(&s->io.as, offset, attrs, &data, size); +} + +static bool aliased_io_accepts(void *opaque, hwaddr offset, unsigned size, + bool is_write, MemTxAttrs attrs) +{ + AliasedRegionState *s =3D ALIASED_REGION(opaque); + + return address_space_access_valid(&s->io.as, offset, size, is_write, a= ttrs); +} + +static const MemoryRegionOps aliased_io_ops =3D { + .read_with_attrs =3D aliased_io_read, + .write_with_attrs =3D aliased_io_write, + .impl.min_access_size =3D 1, + .impl.max_access_size =3D 8, + .valid.min_access_size =3D 1, + .valid.max_access_size =3D 8, + .valid.accepts =3D aliased_io_accepts, + .endianness =3D DEVICE_NATIVE_ENDIAN, +}; + +static void aliased_io_realize(AliasedRegionState *s, const char *mr_name) +{ + memory_region_init_io(&s->container, OBJECT(s), &aliased_io_ops, s, + mr_name, s->region_size); + address_space_init(&s->io.as, s->mr, memory_region_name(s->mr)); +} + static void aliased_mem_realize(AliasedRegionState *s, const char *mr_name) { uint64_t subregion_size; @@ -63,7 +107,15 @@ static void aliased_mr_realize(DeviceState *dev, Error = **errp) span =3D size_to_str(s->span_size); name =3D g_strdup_printf("masked %s [span of %s]", memory_region_name(s->mr), span); - aliased_mem_realize(s, name); + + if (memory_region_is_ram(s->mr) + || memory_region_is_ram_device(s->mr) + || memory_region_is_romd(s->mr)) { + aliased_mem_realize(s, name); + } else { + /* I/O or container */ + aliased_io_realize(s, name); + } sysbus_init_mmio(SYS_BUS_DEVICE(s), &s->container); } =20 --=20 2.26.2