From nobody Tue Feb 10 05:41:09 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.43 as permitted sender) client-ip=209.85.128.43; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f43.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1616718499; cv=none; d=zohomail.com; s=zohoarc; b=e+AgJL6BtIQdMmyelWO1G3pnJKM9cfsBCK7nkHlf/1ctSZEBXPAU4TEQsr+rzXCO2IBKLzJW2gN2tt/kLJzrk9VFLSIj4wPaNvtjtHaf71QIRRNGgoXszkElkYGgXtbk3nM9OHxvsTMx2U9vHK5UJGvwyChbkdvWC18SFAXXGwY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616718499; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ZjHOHQ6FW9OLxHcp9ojcwWz0Qq5Kwhc+7VGNOsAq47o=; b=RYDZOS5HnSvaM6ZiApXftpKWT0u6rpBNoPDIDnxgNkvbhxjZd2YvJfqbgDeAJihQc0OoR+x/Munh8M8iG+Uyq/uKJlXt0XUKhFtLBFay64smbSkZWwUgdKGj5Eq+eJmt+L1pteoIFqSuvrqDVEYOOTp6Y/4WJ3qiVNkCx9iD/NA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by mx.zohomail.com with SMTPS id 1616718499096798.8926606047008; Thu, 25 Mar 2021 17:28:19 -0700 (PDT) Received: by mail-wm1-f43.google.com with SMTP id g25so2139310wmh.0 for ; Thu, 25 Mar 2021 17:28:18 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (17.red-88-21-201.staticip.rima-tde.net. [88.21.201.17]) by smtp.gmail.com with ESMTPSA id f22sm8015889wmc.33.2021.03.25.17.28.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Mar 2021 17:28:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZjHOHQ6FW9OLxHcp9ojcwWz0Qq5Kwhc+7VGNOsAq47o=; b=aLBGIQyBNFRm+22cuNQuAwX4oIXI2Tfptl+DmTXOCqiT81LTlC8vCs5ZYzBSKqG7RI it57i0q/sCXWcAAP62Z2T/yrXCwRSimZ7BOTMVRdQSniflCGppEX0y9INwjMOybgqFS7 hAWbv8vUSAXHQaCaaSx8Tecd5pxOf+nb/JZCfcquFk7jMzCrn5aU+AElkqsaWnLhHzQC WPn8e3vTICuj8MHt4Mya7h0tPxSLXZMR5/fO7APO8xCoR4DNSzGSPTEdMEaEnJ0hZuMz WrM6D9LUlXQx37gBZRMmrkF2T6F89nt30gbLEW7KlDtH0cMmDNR7zs+/QCR7Z+Z4DFAw kp/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ZjHOHQ6FW9OLxHcp9ojcwWz0Qq5Kwhc+7VGNOsAq47o=; b=lab2aWKjvySAcnV02Zs/CYkYkx6Ew4iCGqAclomXhwFcAC1gaW2QeIm9zyBMgRFRN0 OFgOoJeAYQuhZOWIHoVfGBwNYaukEAEXCKurwraYOn1Hbw2+WRIsf9zrIflGFO+o5GQ4 4E69Rauy+s965qiXF4JCCfapJrNdUzLJxW9d54DJqQc+v83vfQwuUmUdcVlacU6UH5z/ fN8Hth6nHEUtjGRfBSTkGmt+r9ug187sefc7V7u6HmZpkyonyZYO7naSv//1G1KRM5OU t17hmn+bEhXO0Mfydvu9S6RD08N3BOFypof2jLrWjZtn7nZpELa3TUALCJUyY5rmfgDQ qnGw== X-Gm-Message-State: AOAM533Nki/TWXMHJX3dKO8MvMoIPQR5GPUtLMmCtwm7oLtmeXfN0end TZnJXUXNxguA1J8IL2RZRGs= X-Google-Smtp-Source: ABdhPJwoV5Hp8hbWmfYVBJtivaREd9dCiXrpe8vp/XnkXZA96gDS0sB6VTjt24fdnH2m3y6MBTjWjg== X-Received: by 2002:a7b:c047:: with SMTP id u7mr10379733wmc.98.1616718497222; Thu, 25 Mar 2021 17:28:17 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier , Mark Cave-Ayland , Peter Maydell , Richard Henderson , Alistair Francis , "Edgar E. Iglesias" , qemu-ppc@nongnu.org, qemu-arm@nongnu.org, David Gibson Subject: [PATCH-for-6.1 09/10] hw/m68k/q800: Add MacIO container Date: Fri, 26 Mar 2021 01:27:27 +0100 Message-Id: <20210326002728.1069834-10-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210326002728.1069834-1-f4bug@amsat.org> References: <20210326002728.1069834-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Instead of having devices mapped onto some main memory range, then having many aliases pointing to this memory range, add a container, map the devices onto it, and map aliases of the container onto the main memory. We gain a better visibility of the devices on the mac-io bus. - before: (qemu) info mtree address-space: memory 0000000000000000-ffffffffffffffff (prio 0, i/o): system 0000000000000000-0000000007ffffff (prio 0, ram): m68k_mac.ram 0000000040800000-00000000408fffff (prio 0, rom): m68k_mac.rom 0000000050000000-0000000050003fff (prio 0, i/o): mac-via 0000000050000000-0000000050001fff (prio 0, i/o): via1 0000000050002000-0000000050003fff (prio 0, i/o): via2 0000000050008000-0000000050008fff (prio 0, rom): dp8393x-prom 000000005000a000-000000005000a0ff (prio 0, i/o): dp8393x-regs 000000005000c020-000000005000c027 (prio 0, i/o): escc 0000000050010000-00000000500100ff (prio 0, i/o): esp-regs 0000000050010100-0000000050010103 (prio 0, i/o): esp-pdma 000000005001e000-000000005001ffff (prio 0, i/o): swim 0000000050040000-000000005007ffff (prio 0, i/o): alias mac_m68k.io[1]= @system 0000000050000000-000000005003ffff 0000000050080000-00000000500bffff (prio 0, i/o): alias mac_m68k.io[2]= @system 0000000050000000-000000005003ffff 00000000500c0000-00000000500fffff (prio 0, i/o): alias mac_m68k.io[3]= @system 0000000050000000-000000005003ffff ... 0000000053f40000-0000000053f7ffff (prio 0, i/o): alias mac_m68k.io[25= 3] @system 0000000050000000-000000005003ffff 0000000053f80000-0000000053fbffff (prio 0, i/o): alias mac_m68k.io[25= 4] @system 0000000050000000-000000005003ffff 0000000053fc0000-0000000053ffffff (prio 0, i/o): alias mac_m68k.io[25= 5] @system 0000000050000000-000000005003ffff 0000000060000000-00000000efffffff (prio 0, i/o): nubus-super-slots 00000000f0000000-00000000feffffff (prio 0, i/o): nubus-slots 00000000f9000000-00000000f9ffffff (prio 0, i/o): nubus-slot-9 00000000f9001000-00000000f9400fff (prio 0, ram): macfb-vram 00000000f9800000-00000000f9800fff (prio 0, i/o): macfb-ctrl 00000000f9ffffe8-00000000f9ffffeb (prio 0, i/o): nubus-slot-9-rom 00000000f9ffffec-00000000f9ffffff (prio 0, i/o): nubus-slot-9-for= mat-block - after: address-space: memory 0000000000000000-0000000007ffffff (prio 0, ram): m68k_mac.ram 0000000040800000-00000000408fffff (prio 0, rom): m68k_mac.rom 0000000050000000-000000005003ffff (prio 0, i/o): alias mac_m68k.io[0]= @mac-io 0000000000000000-000000000003ffff 0000000050040000-000000005007ffff (prio 0, i/o): alias mac_m68k.io[1]= @mac-io 0000000000000000-000000000003ffff 0000000050080000-00000000500bffff (prio 0, i/o): alias mac_m68k.io[2]= @mac-io 0000000000000000-000000000003ffff ... 0000000053f40000-0000000053f7ffff (prio 0, i/o): alias mac_m68k.io[25= 3] @mac-io 0000000000000000-000000000003ffff 0000000053f80000-0000000053fbffff (prio 0, i/o): alias mac_m68k.io[25= 4] @mac-io 0000000000000000-000000000003ffff 0000000053fc0000-0000000053ffffff (prio 0, i/o): alias mac_m68k.io[25= 5] @mac-io 0000000000000000-000000000003ffff 0000000060000000-00000000efffffff (prio 0, i/o): nubus-super-slots 00000000f0000000-00000000feffffff (prio 0, i/o): nubus-slots 00000000f9000000-00000000f9ffffff (prio 0, i/o): nubus-slot-9 00000000f9001000-00000000f9400fff (prio 0, ram): macfb-vram 00000000f9800000-00000000f9800fff (prio 0, i/o): macfb-ctrl 00000000f9ffffe8-00000000f9ffffeb (prio 0, i/o): nubus-slot-9-rom 00000000f9ffffec-00000000f9ffffff (prio 0, i/o): nubus-slot-9-for= mat-block memory-region: mac-io 0000000000000000-000000000003ffff (prio 0, i/o): mac-io 0000000000000000-0000000000003fff (prio 0, i/o): mac-via 0000000000000000-0000000000001fff (prio 0, i/o): via1 0000000000002000-0000000000003fff (prio 0, i/o): via2 0000000000008000-0000000000008fff (prio 0, rom): dp8393x-prom 000000000000a000-000000000000a0ff (prio 0, i/o): dp8393x-regs 000000000000c020-000000000000c027 (prio 0, i/o): escc 0000000000010000-00000000000100ff (prio 0, i/o): esp-regs 0000000000010100-0000000000010103 (prio 0, i/o): esp-pdma 000000000001e000-000000000001ffff (prio 0, i/o): swim Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/m68k/q800.c | 54 ++++++++++++++++++++++++++++++-------------------- 1 file changed, 33 insertions(+), 21 deletions(-) diff --git a/hw/m68k/q800.c b/hw/m68k/q800.c index 4d2e866eec7..8f14e677077 100644 --- a/hw/m68k/q800.c +++ b/hw/m68k/q800.c @@ -61,14 +61,14 @@ #define IO_SLICE 0x00040000 #define IO_SIZE 0x04000000 =20 -#define VIA_BASE (IO_BASE + 0x00000) -#define SONIC_PROM_BASE (IO_BASE + 0x08000) -#define SONIC_BASE (IO_BASE + 0x0a000) -#define SCC_BASE (IO_BASE + 0x0c020) -#define ESP_BASE (IO_BASE + 0x10000) -#define ESP_PDMA (IO_BASE + 0x10100) -#define ASC_BASE (IO_BASE + 0x14000) -#define SWIM_BASE (IO_BASE + 0x1E000) +#define VIA_OFFSET (0x00000) +#define SONIC_PROM_OFFSET (0x08000) +#define SONIC_IO_OFFSET (0x0a000) +#define SCC_OFFSET (0x0c020) +#define ESP_OFFSET (0x10000) +#define ESP_PDMA_OFFSET (0x10100) +#define ASC_OFFSET (0x14000) +#define SWIM_OFFSET (0x1e000) =20 #define NUBUS_SUPER_SLOT_BASE 0x60000000 #define NUBUS_SLOT_BASE 0xf0000000 @@ -213,8 +213,9 @@ static void q800_init(MachineState *machine) ram_addr_t initrd_base; int32_t initrd_size; MemoryRegion *rom; + MemoryRegion *macio; MemoryRegion *io; - const int io_slice_nb =3D (IO_SIZE / IO_SLICE) - 1; + const int io_slice_nb =3D (IO_SIZE / IO_SLICE); int i; ram_addr_t ram_size =3D machine->ram_size; const char *kernel_filename =3D machine->kernel_filename; @@ -249,18 +250,21 @@ static void q800_init(MachineState *machine) /* RAM */ memory_region_add_subregion(get_system_memory(), 0, machine->ram); =20 + /* MacIO bus */ + macio =3D g_new(MemoryRegion, 1); + memory_region_init(macio, NULL, "mac-io", 256 * KiB); /* FIXME or 128K= ? */ + /* * Memory from IO_BASE to IO_BASE + IO_SLICE is repeated * from IO_BASE + IO_SLICE to IO_BASE + IO_SIZE */ io =3D g_new(MemoryRegion, io_slice_nb); for (i =3D 0; i < io_slice_nb; i++) { - char *name =3D g_strdup_printf("mac_m68k.io[%d]", i + 1); + char *name =3D g_strdup_printf("mac_m68k.io[%d]", i); =20 - memory_region_init_alias(&io[i], NULL, name, get_system_memory(), - IO_BASE, IO_SLICE); + memory_region_init_alias(&io[i], NULL, name, macio, 0, IO_SLICE); memory_region_add_subregion(get_system_memory(), - IO_BASE + (i + 1) * IO_SLICE, &io[i]); + IO_BASE + i * IO_SLICE, &io[i]); g_free(name); } =20 @@ -278,7 +282,8 @@ static void q800_init(MachineState *machine) } sysbus =3D SYS_BUS_DEVICE(via_dev); sysbus_realize_and_unref(sysbus, &error_fatal); - sysbus_mmio_map(sysbus, 0, VIA_BASE); + memory_region_add_subregion(macio, VIA_OFFSET, + sysbus_mmio_get_region(sysbus, 0)); qdev_connect_gpio_out_named(DEVICE(sysbus), "irq", 0, qdev_get_gpio_in(glue, 0)); qdev_connect_gpio_out_named(DEVICE(sysbus), "irq", 1, @@ -321,9 +326,11 @@ static void q800_init(MachineState *machine) OBJECT(get_system_memory()), &error_abort); sysbus =3D SYS_BUS_DEVICE(dev); sysbus_realize_and_unref(sysbus, &error_fatal); - sysbus_mmio_map(sysbus, 0, SONIC_BASE); - sysbus_mmio_map(sysbus, 1, SONIC_PROM_BASE); sysbus_connect_irq(sysbus, 0, qdev_get_gpio_in(glue, 2)); + memory_region_add_subregion(macio, SONIC_IO_OFFSET, + sysbus_mmio_get_region(sysbus, 0)); + memory_region_add_subregion(macio, SONIC_PROM_OFFSET, + sysbus_mmio_get_region(sysbus, 1)); =20 /* SCC */ =20 @@ -346,7 +353,8 @@ static void q800_init(MachineState *machine) sysbus_connect_irq(sysbus, 0, qdev_get_gpio_in(escc_orgate, 0)); sysbus_connect_irq(sysbus, 1, qdev_get_gpio_in(escc_orgate, 1)); qdev_connect_gpio_out(DEVICE(escc_orgate), 0, qdev_get_gpio_in(glue, 3= )); - sysbus_mmio_map(sysbus, 0, SCC_BASE); + memory_region_add_subregion(macio, SCC_OFFSET, + sysbus_mmio_get_region(sysbus, 0)); =20 /* SCSI */ =20 @@ -367,8 +375,10 @@ static void q800_init(MachineState *machine) sysbus_connect_irq(sysbus, 1, qdev_get_gpio_in_named(via_dev, "via2-irq", VIA2_IRQ_SCSI_DATA_BIT)); - sysbus_mmio_map(sysbus, 0, ESP_BASE); - sysbus_mmio_map(sysbus, 1, ESP_PDMA); + memory_region_add_subregion(macio, ESP_OFFSET, + sysbus_mmio_get_region(sysbus, 0)); + memory_region_add_subregion(macio, ESP_PDMA_OFFSET, + sysbus_mmio_get_region(sysbus, 1)); =20 scsi_bus_legacy_handle_cmdline(&esp->bus); =20 @@ -376,7 +386,8 @@ static void q800_init(MachineState *machine) =20 dev =3D qdev_new(TYPE_SWIM); sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal); - sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, SWIM_BASE); + memory_region_add_subregion(macio, SWIM_OFFSET, + sysbus_mmio_get_region(SYS_BUS_DEVICE(dev)= , 0)); =20 /* NuBus */ =20 @@ -423,7 +434,8 @@ static void q800_init(MachineState *machine) (graphic_height << 16) | graphic_width); BOOTINFO1(cs->as, parameters_base, BI_MAC_VROW, (graphic_width * graphic_depth + 7) / 8); - BOOTINFO1(cs->as, parameters_base, BI_MAC_SCCBASE, SCC_BASE); + BOOTINFO1(cs->as, parameters_base, BI_MAC_SCCBASE, + IO_BASE + SCC_OFFSET); =20 rom =3D g_malloc(sizeof(*rom)); memory_region_init_ram_ptr(rom, NULL, "m68k_fake_mac.rom", --=20 2.26.2