[PULL for 6.0 00/22] various fixes (kernel-doc, semihosting, testing)

Alex Bennée posted 22 patches 3 years ago
Test checkpatch failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210324143021.8560-1-alex.bennee@linaro.org
Maintainers: Thomas Huth <thuth@redhat.com>, Cornelia Huck <cohuck@redhat.com>
docs/devel/style.rst                               |  46 ++++--
docs/devel/tcg-plugins.rst                         |   5 +
configure                                          |   6 +-
include/sysemu/arch_init.h                         |   9 ++
tests/tcg/aarch64/semicall.h                       |  18 +++
tests/tcg/arm/semicall.h                           |  15 +-
tests/tcg/riscv64/semicall.h                       |  22 +++
blockdev.c                                         |   6 +-
linux-user/riscv/cpu_loop.c                        |   5 +
semihosting/arm-compat-semi.c                      |  62 +++-----
softmmu/qdev-monitor.c                             |  65 ++++----
tests/tcg/arm/semihosting.c                        |  26 ----
.../arm-compat-semi}/semiconsole.c                 |   2 +
tests/tcg/multiarch/arm-compat-semi/semihosting.c  |  82 ++++++++++
tests/unit/test-cutils.c                           | 171 ++++++++++++++++++++-
tools/virtiofsd/fuse_lowlevel.c                    |   1 +
util/cutils.c                                      |  33 ++--
.cirrus.yml                                        |   7 +-
.gitlab-ci.d/crossbuilds.yml                       |  15 +-
.gitlab-ci.yml                                     |  43 ++----
MAINTAINERS                                        |   1 +
scripts/kernel-doc                                 |   3 +
tests/qemu-iotests/040                             |   2 +-
tests/qemu-iotests/051                             |  12 +-
tests/qemu-iotests/051.out                         |   2 +-
tests/qemu-iotests/051.pc.out                      |   2 +-
tests/qemu-iotests/068                             |   4 +-
tests/qemu-iotests/093                             |   3 +-
tests/qemu-iotests/127                             |   3 +-
tests/qemu-iotests/139                             |   9 +-
tests/qemu-iotests/182                             |  13 +-
tests/qemu-iotests/238                             |   4 +-
tests/qemu-iotests/240                             |  10 +-
tests/qemu-iotests/256                             |   6 +-
tests/qemu-iotests/257                             |   4 +-
tests/qemu-iotests/307                             |   4 +-
tests/qemu-iotests/common.rc                       |  13 ++
tests/qemu-iotests/iotests.py                      |  10 +-
tests/qemu-iotests/testenv.py                      |   1 +
tests/tcg/Makefile.target                          |   3 +
tests/tcg/aarch64/Makefile.target                  |  18 ---
tests/tcg/arm/Makefile.target                      |  22 ++-
tests/tcg/multiarch/Makefile.target                |  31 ++++
43 files changed, 548 insertions(+), 271 deletions(-)
create mode 100644 tests/tcg/aarch64/semicall.h
create mode 100644 tests/tcg/riscv64/semicall.h
delete mode 100644 tests/tcg/arm/semihosting.c
rename tests/tcg/{arm => multiarch/arm-compat-semi}/semiconsole.c (93%)
create mode 100644 tests/tcg/multiarch/arm-compat-semi/semihosting.c
[PULL for 6.0 00/22] various fixes (kernel-doc, semihosting, testing)
Posted by Alex Bennée 3 years ago
The following changes since commit 01874b15d36e3f9a3506c47941a92ccf8d8bed98:

  Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20210323' into staging (2021-03-24 11:22:08 +0000)

are available in the Git repository at:

  https://github.com/stsquad/qemu.git tags/pull-6.0-rc0-fixed-240321-1

for you to fetch changes up to a9eb2df27f117bbac9f370bf8cb79532005f19c2:

  gitlab: default to not building the documentation (2021-03-24 14:25:48 +0000)

----------------------------------------------------------------
Various fixes for 6.0:

  - include kernel-doc API reference for plugins
  - fix semihosting SYS_HEAPINFO
  - various tweaks to improve CI runtime
  - more stroz fixes
  - fix iotest CI regressions

----------------------------------------------------------------
Alex Bennée (11):
      scripts/kernel-doc: strip QEMU_ from function definitions
      docs/devel: include the plugin API information from the headers
      docs/devel: expand style section of memory management
      tools/virtiofsd: include --socket-group in help
      semihosting: move semihosting tests to multiarch
      semihosting/arm-compat-semi: unify GET/SET_ARG helpers
      semihosting/arm-compat-semi: don't use SET_ARG to report SYS_HEAPINFO
      linux-user/riscv: initialise the TaskState heap/stack info
      tests/tcg: add HeapInfo checking to semihosting test
      gitlab: extend timeouts for CFI builds
      gitlab: default to not building the documentation

Eric Blake (2):
      utils: Tighter tests for qemu_strtosz
      utils: Work around mingw strto*l bug with 0x

Laurent Vivier (6):
      qdev: define list of archs with virtio-pci or virtio-ccw
      m68k: add the virtio devices aliases
      blockdev: with -drive if=virtio, use generic virtio-blk
      iotests: Revert "iotests: use -ccw on s390x for 040, 139, and 182"
      iotests: test m68k with the virt machine
      iotests: iothreads need ioeventfd

Thomas Huth (3):
      gitlab-ci.yml: Merge the trace-backend testing into other jobs
      configure: Don't use the __atomic_*_16 functions for testing 128-bit support
      cirrus.yml: Update the FreeBSD task to version 12.2

 docs/devel/style.rst                               |  46 ++++--
 docs/devel/tcg-plugins.rst                         |   5 +
 configure                                          |   6 +-
 include/sysemu/arch_init.h                         |   9 ++
 tests/tcg/aarch64/semicall.h                       |  18 +++
 tests/tcg/arm/semicall.h                           |  15 +-
 tests/tcg/riscv64/semicall.h                       |  22 +++
 blockdev.c                                         |   6 +-
 linux-user/riscv/cpu_loop.c                        |   5 +
 semihosting/arm-compat-semi.c                      |  62 +++-----
 softmmu/qdev-monitor.c                             |  65 ++++----
 tests/tcg/arm/semihosting.c                        |  26 ----
 .../arm-compat-semi}/semiconsole.c                 |   2 +
 tests/tcg/multiarch/arm-compat-semi/semihosting.c  |  82 ++++++++++
 tests/unit/test-cutils.c                           | 171 ++++++++++++++++++++-
 tools/virtiofsd/fuse_lowlevel.c                    |   1 +
 util/cutils.c                                      |  33 ++--
 .cirrus.yml                                        |   7 +-
 .gitlab-ci.d/crossbuilds.yml                       |  15 +-
 .gitlab-ci.yml                                     |  43 ++----
 MAINTAINERS                                        |   1 +
 scripts/kernel-doc                                 |   3 +
 tests/qemu-iotests/040                             |   2 +-
 tests/qemu-iotests/051                             |  12 +-
 tests/qemu-iotests/051.out                         |   2 +-
 tests/qemu-iotests/051.pc.out                      |   2 +-
 tests/qemu-iotests/068                             |   4 +-
 tests/qemu-iotests/093                             |   3 +-
 tests/qemu-iotests/127                             |   3 +-
 tests/qemu-iotests/139                             |   9 +-
 tests/qemu-iotests/182                             |  13 +-
 tests/qemu-iotests/238                             |   4 +-
 tests/qemu-iotests/240                             |  10 +-
 tests/qemu-iotests/256                             |   6 +-
 tests/qemu-iotests/257                             |   4 +-
 tests/qemu-iotests/307                             |   4 +-
 tests/qemu-iotests/common.rc                       |  13 ++
 tests/qemu-iotests/iotests.py                      |  10 +-
 tests/qemu-iotests/testenv.py                      |   1 +
 tests/tcg/Makefile.target                          |   3 +
 tests/tcg/aarch64/Makefile.target                  |  18 ---
 tests/tcg/arm/Makefile.target                      |  22 ++-
 tests/tcg/multiarch/Makefile.target                |  31 ++++
 43 files changed, 548 insertions(+), 271 deletions(-)
 create mode 100644 tests/tcg/aarch64/semicall.h
 create mode 100644 tests/tcg/riscv64/semicall.h
 delete mode 100644 tests/tcg/arm/semihosting.c
 rename tests/tcg/{arm => multiarch/arm-compat-semi}/semiconsole.c (93%)
 create mode 100644 tests/tcg/multiarch/arm-compat-semi/semihosting.c

-- 
2.20.1


Re: [PULL for 6.0 00/22] various fixes (kernel-doc, semihosting, testing)
Posted by no-reply@patchew.org 3 years ago
Patchew URL: https://patchew.org/QEMU/20210324143021.8560-1-alex.bennee@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210324143021.8560-1-alex.bennee@linaro.org
Subject: [PULL for 6.0 00/22] various fixes (kernel-doc, semihosting, testing)

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210324143021.8560-1-alex.bennee@linaro.org -> patchew/20210324143021.8560-1-alex.bennee@linaro.org
Switched to a new branch 'test'
c0d4a2c gitlab: default to not building the documentation
64c6e36 iotests: iothreads need ioeventfd
12cee67 iotests: test m68k with the virt machine
6303dc6 iotests: Revert "iotests: use -ccw on s390x for 040, 139, and 182"
865c165 blockdev: with -drive if=virtio, use generic virtio-blk
d1a3668 m68k: add the virtio devices aliases
742c635 qdev: define list of archs with virtio-pci or virtio-ccw
c2b33bc gitlab: extend timeouts for CFI builds
c760417 utils: Work around mingw strto*l bug with 0x
1860f36 utils: Tighter tests for qemu_strtosz
d3598e7 cirrus.yml: Update the FreeBSD task to version 12.2
108a222 configure: Don't use the __atomic_*_16 functions for testing 128-bit support
5fbfc81 gitlab-ci.yml: Merge the trace-backend testing into other jobs
41d8c49 tests/tcg: add HeapInfo checking to semihosting test
b8f4662 linux-user/riscv: initialise the TaskState heap/stack info
316ec74 semihosting/arm-compat-semi: don't use SET_ARG to report SYS_HEAPINFO
d69fb4b semihosting/arm-compat-semi: unify GET/SET_ARG helpers
5428105 semihosting: move semihosting tests to multiarch
d1286bc tools/virtiofsd: include --socket-group in help
54d2761 docs/devel: expand style section of memory management
c5c3fbf docs/devel: include the plugin API information from the headers
f0bb0d5 scripts/kernel-doc: strip QEMU_ from function definitions

=== OUTPUT BEGIN ===
1/22 Checking commit f0bb0d54fcfa (scripts/kernel-doc: strip QEMU_ from function definitions)
2/22 Checking commit c5c3fbfdec88 (docs/devel: include the plugin API information from the headers)
3/22 Checking commit 54d2761f4aa4 (docs/devel: expand style section of memory management)
4/22 Checking commit d1286bc70171 (tools/virtiofsd: include --socket-group in help)
5/22 Checking commit 54281050f5c5 (semihosting: move semihosting tests to multiarch)
6/22 Checking commit d69fb4b75e34 (semihosting/arm-compat-semi: unify GET/SET_ARG helpers)
7/22 Checking commit 316ec74a997d (semihosting/arm-compat-semi: don't use SET_ARG to report SYS_HEAPINFO)
8/22 Checking commit b8f46621be65 (linux-user/riscv: initialise the TaskState heap/stack info)
9/22 Checking commit 41d8c49f2560 (tests/tcg: add HeapInfo checking to semihosting test)
10/22 Checking commit 5fbfc8104282 (gitlab-ci.yml: Merge the trace-backend testing into other jobs)
11/22 Checking commit 108a222ebaab (configure: Don't use the __atomic_*_16 functions for testing 128-bit support)
12/22 Checking commit d3598e78b4c0 (cirrus.yml: Update the FreeBSD task to version 12.2)
13/22 Checking commit 1860f36702eb (utils: Tighter tests for qemu_strtosz)
14/22 Checking commit c760417434c6 (utils: Work around mingw strto*l bug with 0x)
ERROR: consider using qemu_strtol in preference to strtol
#146: FILE: util/cutils.c:409:
+        if (strtol(nptr, &tmp, 10) == 0 && errno == 0 &&

total: 1 errors, 0 warnings, 169 lines checked

Patch 14/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

15/22 Checking commit c2b33bcdb254 (gitlab: extend timeouts for CFI builds)
16/22 Checking commit 742c635cb147 (qdev: define list of archs with virtio-pci or virtio-ccw)
17/22 Checking commit d1a366845ba4 (m68k: add the virtio devices aliases)
18/22 Checking commit 865c165d1853 (blockdev: with -drive if=virtio, use generic virtio-blk)
19/22 Checking commit 6303dc6e1cba (iotests: Revert "iotests: use -ccw on s390x for 040, 139, and 182")
20/22 Checking commit 12cee67703b2 (iotests: test m68k with the virt machine)
21/22 Checking commit 64c6e363b893 (iotests: iothreads need ioeventfd)
22/22 Checking commit c0d4a2c88b42 (gitlab: default to not building the documentation)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210324143021.8560-1-alex.bennee@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [PULL for 6.0 00/22] various fixes (kernel-doc, semihosting, testing)
Posted by Peter Maydell 3 years ago
On Wed, 24 Mar 2021 at 14:30, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> The following changes since commit 01874b15d36e3f9a3506c47941a92ccf8d8bed98:
>
>   Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20210323' into staging (2021-03-24 11:22:08 +0000)
>
> are available in the Git repository at:
>
>   https://github.com/stsquad/qemu.git tags/pull-6.0-rc0-fixed-240321-1
>
> for you to fetch changes up to a9eb2df27f117bbac9f370bf8cb79532005f19c2:
>
>   gitlab: default to not building the documentation (2021-03-24 14:25:48 +0000)
>
> ----------------------------------------------------------------
> Various fixes for 6.0:
>
>   - include kernel-doc API reference for plugins
>   - fix semihosting SYS_HEAPINFO
>   - various tweaks to improve CI runtime
>   - more stroz fixes
>   - fix iotest CI regressions
>
> ----------------------------------------------------------------


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/6.0
for any user-visible changes.

-- PMM