From nobody Fri May 3 19:53:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) client-ip=209.85.221.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1616524202; cv=none; d=zohomail.com; s=zohoarc; b=E/f+4hkxvW/CwjeYDasZeFi/5WLz5PRE37iy1MfRRH9NEM8mf1qlWCnWJrh3YJ3WCSnTcQZnkVFfROKjY6PRblugPpVxp0VGHLQWJZa7qGfPgSJjlJ4x3lcanhyhR1AItJcG0JrViagvRKWwtyNF9U98jixMUL4Qx86XztTWNGA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616524202; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=K0nfW/LiCoGkx3aq8IRZykw93coUaSyrmm75EamV5Po=; b=kcOeL8mRhtlXs6UxplbRKImuTwg/ZWvKgnA+zEssmPc2fkYgPZ2uR90bV38kWa+2Id4PmBZ3SymmyvcQQhVjZINjkf9TFLfrgbUNxenxTl8C0lSYMHiU6mhPVMvl/ecUW+ue6nzt1axFYaBLH4wqv6qj8ewSLBmnkOzNldkCBMc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mx.zohomail.com with SMTPS id 1616524202229637.0150751408157; Tue, 23 Mar 2021 11:30:02 -0700 (PDT) Received: by mail-wr1-f52.google.com with SMTP id v4so21814580wrp.13 for ; Tue, 23 Mar 2021 11:30:01 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (17.red-88-21-201.staticip.rima-tde.net. [88.21.201.17]) by smtp.gmail.com with ESMTPSA id e8sm3490396wme.14.2021.03.23.11.29.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 11:29:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=K0nfW/LiCoGkx3aq8IRZykw93coUaSyrmm75EamV5Po=; b=Gia0TC8iNv3r+mdeeV0bt4kppFG+n8xKMGnIfhvUiYH2l8IC5ukQdtbH2YxpUshiQ/ IUot2rDT3kxTFvpO5xI7LO9omY4rIFcldVtXoGY9v6MnQ6xeNdkIfng39/aTPDW5EeLn UT0Z7Ibsi52L1S2mfiAPQ2mng+kTlPp/V/CwwLJJQzuRby9lrtyTVcsoh8u4TQOJcMQx tAu0kQ8Zo/qpP/9loNg9RShRDJKB3XeOlvG9ZLGz4HypFW4ylA/LVLldkzTj0++Y3duV iLASIkcm2GfWYphqHWdCFDHKHVp/IaQ8iJp4x9TL4akBPLXPfpC+4BFvqWEtksXehD6h H0tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=K0nfW/LiCoGkx3aq8IRZykw93coUaSyrmm75EamV5Po=; b=BN0QAcaj0shmGCnLFBz0tUwbH43Zfu7iF7Jk5A8eZdHvVXBAbfa4ft7bmHKGc2ncO7 mRAZf59EcBiGM5E5x5olfNtQZuWt4i+ekpprq+PWZMUVGI6u/tSOfX9Cwz+Tki0I+cvU jm/B8+oxPAhJQW5EYbp6kWVzWzLYFP28H6OMZyfvw9OFgZI9a3Sid/2MvnY2i3r+sG30 lTFwF17K4kuXZg3VUFiPO9OT9t1t7xK/ytpfwdkWMbApiDWfGbSe5i2EhIig8EworoF6 fujQSr9hCmM5P3ZerDn8NpoOhDcfmJLsc6b6xzcXJx2Lybr5sMvSpqedKO7NhMGKTGKn DdTA== X-Gm-Message-State: AOAM531WLLVrBv42NvT+WjJIjYgHYoB+/fQSm3wRcLVRIhECJRw19M8O 9rQ/JRVI6W8ZMYova+YcAso= X-Google-Smtp-Source: ABdhPJznc10HSle60PymjuWQ5bJHUH2t+/ncwvs1VE5tYNmsqwPwMxWWa7v67JA6X7qfA0SvaxpzEQ== X-Received: by 2002:a5d:6602:: with SMTP id n2mr5526285wru.262.1616524200497; Tue, 23 Mar 2021 11:30:00 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Peter Maydell , "Edgar E. Iglesias" , Alistair Francis , KONRAD Frederic , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH] hw/display/xlnx_dp: Free FIFOs adding xlnx_dp_finalize() Date: Tue, 23 Mar 2021 19:29:58 +0100 Message-Id: <20210323182958.277654-1-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) When building with --enable-sanitizers we get: Direct leak of 16 byte(s) in 1 object(s) allocated from: #0 0x5618479ec7cf in malloc (qemu-system-aarch64+0x233b7cf) #1 0x7f675745f958 in g_malloc (/lib64/libglib-2.0.so.0+0x58958) #2 0x561847c2dcc9 in xlnx_dp_init hw/display/xlnx_dp.c:1259:5 #3 0x56184a5bdab8 in object_init_with_type qom/object.c:375:9 #4 0x56184a5a2bda in object_initialize_with_type qom/object.c:517:5 #5 0x56184a5a24d5 in object_initialize qom/object.c:536:5 #6 0x56184a5a2f6c in object_initialize_child_with_propsv qom/object.c= :566:5 #7 0x56184a5a2e60 in object_initialize_child_with_props qom/object.c:= 549:10 #8 0x56184a5a3a1e in object_initialize_child_internal qom/object.c:60= 3:5 #9 0x5618495aa431 in xlnx_zynqmp_init hw/arm/xlnx-zynqmp.c:273:5 The RX/TX FIFOs are created in xlnx_dp_init(), add xlnx_dp_finalize() to destroy them. Fixes: 58ac482a66d ("introduce xlnx-dp") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- hw/display/xlnx_dp.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/hw/display/xlnx_dp.c b/hw/display/xlnx_dp.c index c56e6ec5936..4fd6aeb18b5 100644 --- a/hw/display/xlnx_dp.c +++ b/hw/display/xlnx_dp.c @@ -1260,6 +1260,14 @@ static void xlnx_dp_init(Object *obj) fifo8_create(&s->tx_fifo, 16); } =20 +static void xlnx_dp_finalize(Object *obj) +{ + XlnxDPState *s =3D XLNX_DP(obj); + + fifo8_destroy(&s->tx_fifo); + fifo8_destroy(&s->rx_fifo); +} + static void xlnx_dp_realize(DeviceState *dev, Error **errp) { XlnxDPState *s =3D XLNX_DP(dev); @@ -1359,6 +1367,7 @@ static const TypeInfo xlnx_dp_info =3D { .parent =3D TYPE_SYS_BUS_DEVICE, .instance_size =3D sizeof(XlnxDPState), .instance_init =3D xlnx_dp_init, + .instance_finalize =3D xlnx_dp_finalize, .class_init =3D xlnx_dp_class_init, }; =20 --=20 2.26.2