[PATCH for 6.0 v2 00/22] fixes for rc1 pre-PR (kernel-doc, semihosting, testing)

Alex Bennée posted 22 patches 3 years ago
Test checkpatch failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210323165308.15244-1-alex.bennee@linaro.org
Maintainers: Cornelia Huck <cohuck@redhat.com>, Thomas Huth <thuth@redhat.com>
docs/devel/style.rst                          |  46 +++--
docs/devel/tcg-plugins.rst                    |   5 +
configure                                     |   6 +-
include/sysemu/arch_init.h                    |   9 +
tests/tcg/aarch64/semicall.h                  |  18 ++
tests/tcg/arm/semicall.h                      |  15 +-
tests/tcg/riscv64/semicall.h                  |  22 +++
blockdev.c                                    |   6 +-
linux-user/riscv/cpu_loop.c                   |   5 +
semihosting/arm-compat-semi.c                 |  62 +++----
softmmu/qdev-monitor.c                        |  65 ++++---
tests/tcg/arm/semihosting.c                   |  26 ---
.../arm-compat-semi}/semiconsole.c            |   2 +
.../multiarch/arm-compat-semi/semihosting.c   |  82 +++++++++
tests/unit/test-cutils.c                      | 171 +++++++++++++++++-
tools/virtiofsd/fuse_lowlevel.c               |   1 +
util/cutils.c                                 |  33 +++-
.cirrus.yml                                   |   7 +-
.gitlab-ci.d/crossbuilds.yml                  |  15 +-
.gitlab-ci.yml                                |  43 ++---
MAINTAINERS                                   |   1 +
scripts/kernel-doc                            |   3 +
tests/qemu-iotests/040                        |   2 +-
tests/qemu-iotests/051                        |  12 +-
tests/qemu-iotests/051.out                    |   2 +-
tests/qemu-iotests/051.pc.out                 |   2 +-
tests/qemu-iotests/068                        |   4 +-
tests/qemu-iotests/093                        |   3 +-
tests/qemu-iotests/127                        |   3 +-
tests/qemu-iotests/139                        |   9 +-
tests/qemu-iotests/182                        |  13 +-
tests/qemu-iotests/238                        |   4 +-
tests/qemu-iotests/240                        |  10 +-
tests/qemu-iotests/256                        |   6 +-
tests/qemu-iotests/257                        |   4 +-
tests/qemu-iotests/307                        |   4 +-
tests/qemu-iotests/common.rc                  |  13 ++
tests/qemu-iotests/iotests.py                 |  10 +-
tests/qemu-iotests/testenv.py                 |   1 +
tests/tcg/Makefile.target                     |   3 +
tests/tcg/aarch64/Makefile.target             |  18 --
tests/tcg/arm/Makefile.target                 |  22 +--
tests/tcg/multiarch/Makefile.target           |  31 ++++
43 files changed, 548 insertions(+), 271 deletions(-)
create mode 100644 tests/tcg/aarch64/semicall.h
create mode 100644 tests/tcg/riscv64/semicall.h
delete mode 100644 tests/tcg/arm/semihosting.c
rename tests/tcg/{arm => multiarch/arm-compat-semi}/semiconsole.c (93%)
create mode 100644 tests/tcg/multiarch/arm-compat-semi/semihosting.c
[PATCH for 6.0 v2 00/22] fixes for rc1 pre-PR (kernel-doc, semihosting, testing)
Posted by Alex Bennée 3 years ago
Hi,

I've added a testing patch to extend the CFI times, Laurent's series
to fix the iotest regressions currently keeping the CI from going
green and an optimisation to the --enable-docs build to try and start
bringing the total CI time down a bit. rc0 is being tagged today so
I'll probably roll a PR from this later in the week in time for rc1.

The following are still need review:

 - tests/tcg: add HeapInfo checking to semihosting test

Alex Bennée (11):
  scripts/kernel-doc: strip QEMU_ from function definitions
  docs/devel: include the plugin API information from the headers
  docs/devel: expand style section of memory management
  tools/virtiofsd: include --socket-group in help
  semihosting: move semihosting tests to multiarch
  semihosting/arm-compat-semi: unify GET/SET_ARG helpers
  semihosting/arm-compat-semi: don't use SET_ARG to report SYS_HEAPINFO
  linux-user/riscv: initialise the TaskState heap/stack info
  tests/tcg: add HeapInfo checking to semihosting test
  gitlab: extend timeouts for CFI builds
  gitlab: default to not building the documentation

Eric Blake (2):
  utils: Tighter tests for qemu_strtosz
  utils: Work around mingw strto*l bug with 0x

Laurent Vivier (6):
  qdev: define list of archs with virtio-pci or virtio-ccw
  m68k: add the virtio devices aliases
  blockdev: with -drive if=virtio, use generic virtio-blk
  iotests: Revert "iotests: use -ccw on s390x for 040, 139, and 182"
  iotests: test m68k with the virt machine
  iotests: iothreads need ioeventfd

Thomas Huth (3):
  gitlab-ci.yml: Merge the trace-backend testing into other jobs
  configure: Don't use the __atomic_*_16 functions for testing 128-bit
    support
  cirrus.yml: Update the FreeBSD task to version 12.2

 docs/devel/style.rst                          |  46 +++--
 docs/devel/tcg-plugins.rst                    |   5 +
 configure                                     |   6 +-
 include/sysemu/arch_init.h                    |   9 +
 tests/tcg/aarch64/semicall.h                  |  18 ++
 tests/tcg/arm/semicall.h                      |  15 +-
 tests/tcg/riscv64/semicall.h                  |  22 +++
 blockdev.c                                    |   6 +-
 linux-user/riscv/cpu_loop.c                   |   5 +
 semihosting/arm-compat-semi.c                 |  62 +++----
 softmmu/qdev-monitor.c                        |  65 ++++---
 tests/tcg/arm/semihosting.c                   |  26 ---
 .../arm-compat-semi}/semiconsole.c            |   2 +
 .../multiarch/arm-compat-semi/semihosting.c   |  82 +++++++++
 tests/unit/test-cutils.c                      | 171 +++++++++++++++++-
 tools/virtiofsd/fuse_lowlevel.c               |   1 +
 util/cutils.c                                 |  33 +++-
 .cirrus.yml                                   |   7 +-
 .gitlab-ci.d/crossbuilds.yml                  |  15 +-
 .gitlab-ci.yml                                |  43 ++---
 MAINTAINERS                                   |   1 +
 scripts/kernel-doc                            |   3 +
 tests/qemu-iotests/040                        |   2 +-
 tests/qemu-iotests/051                        |  12 +-
 tests/qemu-iotests/051.out                    |   2 +-
 tests/qemu-iotests/051.pc.out                 |   2 +-
 tests/qemu-iotests/068                        |   4 +-
 tests/qemu-iotests/093                        |   3 +-
 tests/qemu-iotests/127                        |   3 +-
 tests/qemu-iotests/139                        |   9 +-
 tests/qemu-iotests/182                        |  13 +-
 tests/qemu-iotests/238                        |   4 +-
 tests/qemu-iotests/240                        |  10 +-
 tests/qemu-iotests/256                        |   6 +-
 tests/qemu-iotests/257                        |   4 +-
 tests/qemu-iotests/307                        |   4 +-
 tests/qemu-iotests/common.rc                  |  13 ++
 tests/qemu-iotests/iotests.py                 |  10 +-
 tests/qemu-iotests/testenv.py                 |   1 +
 tests/tcg/Makefile.target                     |   3 +
 tests/tcg/aarch64/Makefile.target             |  18 --
 tests/tcg/arm/Makefile.target                 |  22 +--
 tests/tcg/multiarch/Makefile.target           |  31 ++++
 43 files changed, 548 insertions(+), 271 deletions(-)
 create mode 100644 tests/tcg/aarch64/semicall.h
 create mode 100644 tests/tcg/riscv64/semicall.h
 delete mode 100644 tests/tcg/arm/semihosting.c
 rename tests/tcg/{arm => multiarch/arm-compat-semi}/semiconsole.c (93%)
 create mode 100644 tests/tcg/multiarch/arm-compat-semi/semihosting.c

-- 
2.20.1


Re: [PATCH for 6.0 v2 00/22] fixes for rc1 pre-PR (kernel-doc, semihosting, testing)
Posted by no-reply@patchew.org 3 years ago
Patchew URL: https://patchew.org/QEMU/20210323165308.15244-1-alex.bennee@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210323165308.15244-1-alex.bennee@linaro.org
Subject: [PATCH for 6.0 v2 00/22] fixes for rc1 pre-PR (kernel-doc, semihosting, testing)

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210323094025.3569441-1-armbru@redhat.com -> patchew/20210323094025.3569441-1-armbru@redhat.com
 - [tag update]      patchew/20210323130614.146399-1-pbonzini@redhat.com -> patchew/20210323130614.146399-1-pbonzini@redhat.com
 * [new tag]         patchew/20210323165308.15244-1-alex.bennee@linaro.org -> patchew/20210323165308.15244-1-alex.bennee@linaro.org
Switched to a new branch 'test'
bcc7547 gitlab: default to not building the documentation
38b6266 iotests: iothreads need ioeventfd
7d603bd iotests: test m68k with the virt machine
175b36e iotests: Revert "iotests: use -ccw on s390x for 040, 139, and 182"
c1434e3 blockdev: with -drive if=virtio, use generic virtio-blk
d9a5d5d m68k: add the virtio devices aliases
c077a9b qdev: define list of archs with virtio-pci or virtio-ccw
fe1df61 gitlab: extend timeouts for CFI builds
90e13f7 utils: Work around mingw strto*l bug with 0x
185f381 utils: Tighter tests for qemu_strtosz
d5854c3 cirrus.yml: Update the FreeBSD task to version 12.2
22b3df6 configure: Don't use the __atomic_*_16 functions for testing 128-bit support
527d4ef gitlab-ci.yml: Merge the trace-backend testing into other jobs
25e535d tests/tcg: add HeapInfo checking to semihosting test
fec9305 linux-user/riscv: initialise the TaskState heap/stack info
bdc3001 semihosting/arm-compat-semi: don't use SET_ARG to report SYS_HEAPINFO
a1a5d52 semihosting/arm-compat-semi: unify GET/SET_ARG helpers
0270290 semihosting: move semihosting tests to multiarch
a5310d0 tools/virtiofsd: include --socket-group in help
cecadd6 docs/devel: expand style section of memory management
2494a85 docs/devel: include the plugin API information from the headers
0967712 scripts/kernel-doc: strip QEMU_ from function definitions

=== OUTPUT BEGIN ===
1/22 Checking commit 0967712253a3 (scripts/kernel-doc: strip QEMU_ from function definitions)
2/22 Checking commit 2494a8533c43 (docs/devel: include the plugin API information from the headers)
3/22 Checking commit cecadd684571 (docs/devel: expand style section of memory management)
4/22 Checking commit a5310d05fd4b (tools/virtiofsd: include --socket-group in help)
5/22 Checking commit 0270290bfb74 (semihosting: move semihosting tests to multiarch)
6/22 Checking commit a1a5d52d3a8e (semihosting/arm-compat-semi: unify GET/SET_ARG helpers)
7/22 Checking commit bdc30013e582 (semihosting/arm-compat-semi: don't use SET_ARG to report SYS_HEAPINFO)
8/22 Checking commit fec930576473 (linux-user/riscv: initialise the TaskState heap/stack info)
9/22 Checking commit 25e535d4c651 (tests/tcg: add HeapInfo checking to semihosting test)
10/22 Checking commit 527d4eff0f98 (gitlab-ci.yml: Merge the trace-backend testing into other jobs)
11/22 Checking commit 22b3df69b30c (configure: Don't use the __atomic_*_16 functions for testing 128-bit support)
12/22 Checking commit d5854c333694 (cirrus.yml: Update the FreeBSD task to version 12.2)
13/22 Checking commit 185f381817cd (utils: Tighter tests for qemu_strtosz)
14/22 Checking commit 90e13f730562 (utils: Work around mingw strto*l bug with 0x)
ERROR: consider using qemu_strtol in preference to strtol
#145: FILE: util/cutils.c:409:
+        if (strtol(nptr, &tmp, 10) == 0 && errno == 0 &&

total: 1 errors, 0 warnings, 169 lines checked

Patch 14/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

15/22 Checking commit fe1df614ddcc (gitlab: extend timeouts for CFI builds)
16/22 Checking commit c077a9b1d7be (qdev: define list of archs with virtio-pci or virtio-ccw)
17/22 Checking commit d9a5d5dfab12 (m68k: add the virtio devices aliases)
18/22 Checking commit c1434e384903 (blockdev: with -drive if=virtio, use generic virtio-blk)
19/22 Checking commit 175b36e18a3b (iotests: Revert "iotests: use -ccw on s390x for 040, 139, and 182")
20/22 Checking commit 7d603bdf27b0 (iotests: test m68k with the virt machine)
21/22 Checking commit 38b626694291 (iotests: iothreads need ioeventfd)
22/22 Checking commit bcc75474045f (gitlab: default to not building the documentation)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210323165308.15244-1-alex.bennee@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [PATCH for 6.0 v2 00/22] fixes for rc1 pre-PR (kernel-doc, semihosting, testing)
Posted by Peter Maydell 3 years ago
On Tue, 23 Mar 2021 at 17:59, Alex Bennée <alex.bennee@linaro.org> wrote:
> I've added a testing patch to extend the CFI times, Laurent's series
> to fix the iotest regressions currently keeping the CI from going
> green and an optimisation to the --enable-docs build to try and start
> bringing the total CI time down a bit. rc0 is being tagged today so
> I'll probably roll a PR from this later in the week in time for rc1.

That's tricky given you sent this patchseries at 6pm on the day
when rc1 was nominally going to be tagged :-)

I was kinda hoping to get the iotest regression fixed in rc1,
but I want to tag it today. Oh well, it's only the CI, not an
actual bug, so no big deal I guess.

thanks
-- PMM

Re: [PATCH for 6.0 v2 00/22] fixes for rc1 pre-PR (kernel-doc, semihosting, testing)
Posted by Alex Bennée 3 years ago
Peter Maydell <peter.maydell@linaro.org> writes:

> On Tue, 23 Mar 2021 at 17:59, Alex Bennée <alex.bennee@linaro.org> wrote:
>> I've added a testing patch to extend the CFI times, Laurent's series
>> to fix the iotest regressions currently keeping the CI from going
>> green and an optimisation to the --enable-docs build to try and start
>> bringing the total CI time down a bit. rc0 is being tagged today so
>> I'll probably roll a PR from this later in the week in time for rc1.
>
> That's tricky given you sent this patchseries at 6pm on the day
> when rc1 was nominally going to be tagged :-)

The wiki says:

  2021-03-30 	Tag rc1 

so I thought I had a few days. I wasn't aiming for rc0 just to give time
for final review comments to come in.

>
> I was kinda hoping to get the iotest regression fixed in rc1,
> but I want to tag it today. Oh well, it's only the CI, not an
> actual bug, so no big deal I guess.
>
> thanks
> -- PMM


-- 
Alex Bennée

Re: [PATCH for 6.0 v2 00/22] fixes for rc1 pre-PR (kernel-doc, semihosting, testing)
Posted by Peter Maydell 3 years ago
On Wed, 24 Mar 2021 at 14:23, Alex Bennée <alex.bennee@linaro.org> wrote:
>
>
> Peter Maydell <peter.maydell@linaro.org> writes:
>
> > On Tue, 23 Mar 2021 at 17:59, Alex Bennée <alex.bennee@linaro.org> wrote:
> >> I've added a testing patch to extend the CFI times, Laurent's series
> >> to fix the iotest regressions currently keeping the CI from going
> >> green and an optimisation to the --enable-docs build to try and start
> >> bringing the total CI time down a bit. rc0 is being tagged today so
> >> I'll probably roll a PR from this later in the week in time for rc1.
> >
> > That's tricky given you sent this patchseries at 6pm on the day
> > when rc1 was nominally going to be tagged :-)
>
> The wiki says:
>
>   2021-03-30    Tag rc1
>
> so I thought I had a few days.

Oops, yes, you're right, sorry. I always get confused by softfreeze
not being rc0...

-- PMM