From nobody Tue Feb 10 05:46:18 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) client-ip=209.85.128.53; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f53.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1616516104; cv=none; d=zohomail.com; s=zohoarc; b=Qz8RZhylCmMPLZHOh1B+mRsUzvPymjriG6dNNxCo7iYm0hk5QwQPxW2+0fYydYPzqAC5V04FGYr6hrETtsSNP/3noBN7vAifs+vFVw6s8rXGw845c4KthJxg8EpmYgUU+n+8T84g3eiNCCCAlAdALvgD4yadvsKMJ3Gl+c6zTSI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616516104; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=HbrBNw1rZqrHPhviLRhW2PghpzAbcjm/RCgXT7DkNTE=; b=MkGYKOhN7KP+1/si9T3qzk3dN5dXviIdguzN5sSj2KpHLQK/IttlpasAFgcnNpJtwK8lnUAUdAB0Uh+BCd70kh0JWh97kKk1BL33agUuyX9NeecIG6lXcsTlfzXEmG0J76VjLp6/Sz95f3Vi2WIZDSbWbp5+QvlXPM79TH+KtxM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mx.zohomail.com with SMTPS id 1616516104039176.65556317503206; Tue, 23 Mar 2021 09:15:04 -0700 (PDT) Received: by mail-wm1-f53.google.com with SMTP id a132-20020a1c668a0000b029010f141fe7c2so11123618wmc.0 for ; Tue, 23 Mar 2021 09:15:02 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (17.red-88-21-201.staticip.rima-tde.net. [88.21.201.17]) by smtp.gmail.com with ESMTPSA id v18sm25364270wru.85.2021.03.23.09.14.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 09:15:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HbrBNw1rZqrHPhviLRhW2PghpzAbcjm/RCgXT7DkNTE=; b=ksj7LqJzTbHlc44lYx65DgjFFrEo0PpNto6KWjJ8hJDLOo8wT6DD8kTDuJx6Sz7EDC kYHDZkngJ3w9e02yYndhWgb7dEf/UqoVGJyUz0rY3qthShyKukGfQHqTwl7u0LqSH2u5 2JEObyuBt1hx1uB5+LcU94FCSs9Q8a88IeNGFW2aX4y9ZwIaGqmhZiukbSo3W+Avh0Hn JZt64uo1ZFLX8GLQIq6L7qNhHFGM77OQY8/iTdIl8ev6Q6tLVuEKhv+opHAZ3f2g32O2 WsUc3pyqrCkwZNtwNl6A9IV5rVtp/FJntZdn7yXvME4rV1O5MvE3DbPWfAg8ntB6JXgz QGGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=HbrBNw1rZqrHPhviLRhW2PghpzAbcjm/RCgXT7DkNTE=; b=t5dlKf8NCqgAaVwGy/h6XiZnqGOQwGJ7HbEo/lZBxUow0CTZogn+OMuowQRqEMWa7i 5S9BZyBXnZMst6rdyHXH5BDJx4juhIQO8LkH7I89xXe3X20/s+68ulHyVpv5bq3Sh3iy KA2r5TO97CSjZT5vyqx380xfcroxJ71CCtzvCnfgz/TgALwxEwMwJyK4NAxOFOxEO3sw ZF5DHkMuiZH/UcCBDICBXq0NU1U5xDcdZhsngmUwtunLbVT+EOGtGcT7M3HZWQs/V1Sq /aLu4o1N5bTGUpPeCpjB9Bb/9U2LOxxDqF51E7JNR/4HUJ6jJ0p89TaGtpvDfxBgFpMd VYlQ== X-Gm-Message-State: AOAM531rrSu1tpaB6VPNPmXP170kiTi50RV180Gx4uas8QugIbblkuTo gQO0pkaHVhWbZb1OeGq+VJU= X-Google-Smtp-Source: ABdhPJxVKarlOvu3yxDnHW4vSCHa6FUdZoTWoBwzQUDWZXZhjSO+yJ1zSjhevHlkhlOBCmJemhvX3g== X-Received: by 2002:a1c:e912:: with SMTP id q18mr4120750wmc.59.1616516100617; Tue, 23 Mar 2021 09:15:00 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Andrew Baumann , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Peter Maydell Subject: [PATCH v2 3/3] hw/display/bcm2835_fb: Remove DeviceReset() call in DeviceRealize() Date: Tue, 23 Mar 2021 17:14:43 +0100 Message-Id: <20210323161443.245636-4-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210323161443.245636-1-f4bug@amsat.org> References: <20210323161443.245636-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) When QDev objects have their DeviceReset handler set, they shouldn't worry about calling it at realization stage (it is handled by hw/core/qdev.c::device_set_realized). Remove the pointless/confusing bcm2835_fb_reset() call. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/display/bcm2835_fb.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/display/bcm2835_fb.c b/hw/display/bcm2835_fb.c index a9c2e57d1c6..d7a44771c44 100644 --- a/hw/display/bcm2835_fb.c +++ b/hw/display/bcm2835_fb.c @@ -421,8 +421,6 @@ static void bcm2835_fb_realize(DeviceState *dev, Error = **errp) s->dma_mr =3D MEMORY_REGION(obj); address_space_init(&s->dma_as, s->dma_mr, TYPE_BCM2835_FB "-memory"); =20 - bcm2835_fb_reset(dev); - s->con =3D graphic_console_init(dev, 0, &vgafb_ops, s); qemu_console_resize(s->con, s->config.xres, s->config.yres); } --=20 2.26.2