From nobody Thu May 2 19:20:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.44 as permitted sender) client-ip=209.85.128.44; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f44.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1616516093; cv=none; d=zohomail.com; s=zohoarc; b=C601fQGm09XLQu3FXBfFNa0O+cyhGDNCRI8kEKniKld/lE9bTumyxQ4MZD/ST1d/Tq+J8DUKO+guKxnkWemgyvu46n770jCtnfUyvoB2s9ZlFBx7yuRsFgZVttaE+cL18zzbi0qXSzXl0EZs2psXIj8PIj3ieHhFO1mXc2qEmWE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616516093; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=EYb7MCD9rAm74EVNp0mTMTFqaEPr7f8+yagDdP+XAac=; b=N2V974v5LFWC93qt6Gr+wUVanQGXC8vxS7CAetrYclm9yn4ZQkNOU5oThjWDFrjjxc0WY8UVDB65GwnmwPHwW9z9bTxAgj2eTi3fsa/RPiQXuY8ZO+zby3Zfd6TNwEfj1S/V9hG6ZvxeeGQAQ/goofbk6ECqhIWsJl9398bhS24= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by mx.zohomail.com with SMTPS id 1616516093129499.3083441241796; Tue, 23 Mar 2021 09:14:53 -0700 (PDT) Received: by mail-wm1-f44.google.com with SMTP id n11-20020a05600c4f8bb029010e5cf86347so1394160wmq.1 for ; Tue, 23 Mar 2021 09:14:52 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (17.red-88-21-201.staticip.rima-tde.net. [88.21.201.17]) by smtp.gmail.com with ESMTPSA id c9sm3192765wml.42.2021.03.23.09.14.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 09:14:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EYb7MCD9rAm74EVNp0mTMTFqaEPr7f8+yagDdP+XAac=; b=ovVZUhAKnS78InoOcEsbdnP1XHBrT8vxa9YB+OEakLJ+nRRw0lHq/B2TGLCrswQKKI 14PzG66USogxaznvETy1GbVvOSCIxyNzzlycKBC3b3B+5shj+ufUX4+/Y1Bj93dDdgLt 6/x6tB/3R/GbvYltWkMS+vd4TRJAeaRvbqBokVrNnq5Yqx3nbHwkS6qadqXGe3/WHQrs UEMjr/1kUFP68MgT1co/uD54WFCi3naT+VJ/aFm3KVu63WASdQ7BCHmP3K5OsM3eI7Go jLa9912F94YT+rYwWq2OG8IY1CoDoagTxCpGZgu54L4NToNmNOo/3v4lX1J65BwQeOQn VvdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=EYb7MCD9rAm74EVNp0mTMTFqaEPr7f8+yagDdP+XAac=; b=Lmzbmed04WryeJu24bKhal1Z9KtQtso6BhfiQCBjxLTRHiQFlLDs0OBP1/sIugQsaH fO/GYkMbwob1jUG/sUA0gOv4lE64cSCIzZFo2wB0Dg3t4weRfsDbkjHbgcPMSD6GlmM0 IDBsbSWWOqSwLabVHH2QT7NJHdOOgw3beuxE3MK/twTbG66ZPw6lHuwsCFHNGDqZ6+f4 f9wQIteEYtRPlMGX2Ly8WITCIE8Ebf5gwgqZB/lQZRUMh8KyavGsnTK+okulgzWfLaPX y6ayE635zi5pCAdFWWSu/JYG3tpzBusN1u++K/2ygtEVU+xKuPdH3Dl/ifmpv5gbvmvW 7K8Q== X-Gm-Message-State: AOAM533XUme88YoSiJwqpDooMVCjejjyazlZO0EhpKqtLbmzJnGfkHeP cDlQxNfOM18D/2CdEvVwxN8= X-Google-Smtp-Source: ABdhPJyurHrGugczQbHJUAUFmJxVug13ywT9+2OpwDPfF4rdak5ODxZBLNDEX5W1hvTxBBBiLgdxIA== X-Received: by 2002:a1c:3954:: with SMTP id g81mr4100415wma.170.1616516091209; Tue, 23 Mar 2021 09:14:51 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Andrew Baumann , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Peter Maydell Subject: [PATCH v2 1/3] hw/display/bcm2835_fb: Resize console on reset Date: Tue, 23 Mar 2021 17:14:41 +0100 Message-Id: <20210323161443.245636-2-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210323161443.245636-1-f4bug@amsat.org> References: <20210323161443.245636-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) We want to remove the bcm2835_fb_reset() call in bcm2835_fb_realize() but doing triggers: hw/display/bcm2835_fb.c:131:13: runtime error: store to null pointer of t= ype 'uint32_t' (aka 'unsigned int') SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior hw/display/bcm283= 5_fb.c:131:13 in AddressSanitizer:DEADLYSIGNAL =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =3D=3D195864=3D=3DERROR: AddressSanitizer: SEGV on unknown address 0x0000= 00000000 (pc 0x555d1d51e6d6 bp 0x7ffd25a31160 sp 0x7ffd25a30fb0 T0) =3D=3D195864=3D=3DThe signal is caused by a WRITE memory access. =3D=3D195864=3D=3DHint: address points to the zero page. #0 0x555d1d51e6d6 in draw_line_src16 hw/display/bcm2835_fb.c:131:30 #1 0x555d1dd88d5f in framebuffer_update_display hw/display/framebuffer= .c:107:13 #2 0x555d1d51d081 in fb_update_display hw/display/bcm2835_fb.c:203:5 #3 0x555d1ccb93d6 in graphic_hw_update ui/console.c:279:9 #4 0x555d1dbc92cb in gd_refresh ui/gtk.c:492:5 #5 0x555d1ccef1fc in dpy_refresh ui/console.c:1734:13 #6 0x555d1ccee09c in gui_update ui/console.c:209:5 #7 0x555d201f3cf2 in timerlist_run_timers util/qemu-timer.c:586:9 #8 0x555d201f4061 in qemu_clock_run_timers util/qemu-timer.c:600:12 #9 0x555d201f5029 in qemu_clock_run_all_timers util/qemu-timer.c:682:25 #10 0x555d200c6f6c in main_loop_wait util/main-loop.c:541:5 #11 0x555d1f06ba93 in qemu_main_loop softmmu/runstate.c:725:9 #12 0x555d1cafe6ae in main softmmu/main.c:50:5 #13 0x7f6e6991b081 in __libc_start_main (/lib64/libc.so.6+0x27081) #14 0x555d1ca249ed in _start (/mnt/scratch/qemu/sanitizer_aa64/qemu-sys= tem-aarch64+0x22999ed) AddressSanitizer can not provide additional info. SUMMARY: AddressSanitizer: SEGV hw/display/bcm2835_fb.c:131:30 in draw_li= ne_src16 =3D=3D195864=3D=3DABORTING The graphic console timer kicks before the display device is realized. By calling qemu_console_resize() in bcm2835_fb_reset() we force the creation of the graphic console surface early enough. Reported-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/display/bcm2835_fb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/display/bcm2835_fb.c b/hw/display/bcm2835_fb.c index 2be77bdd3a0..3e63d58e0b2 100644 --- a/hw/display/bcm2835_fb.c +++ b/hw/display/bcm2835_fb.c @@ -399,6 +399,7 @@ static void bcm2835_fb_reset(DeviceState *dev) s->config =3D s->initial_config; =20 s->invalidate =3D true; + qemu_console_resize(s->con, s->initial_config.xres, s->initial_config.= yres); s->lock =3D false; } =20 --=20 2.26.2 From nobody Thu May 2 19:20:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.218.51 as permitted sender) client-ip=209.85.218.51; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-f51.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1616516614; cv=none; d=zohomail.com; s=zohoarc; b=k5qvNyMyeFe7p3Qwv0sOYinO1H2UXIDU14569Yfr+mMus6Wu/5X2W41sLkrNswv1xImkrL1ar3VrhkrsW0ScisIXbZBasySqlkjGzZZLNS/SMwCarT1scIGfgIg38fwRrFjW9ay/49OoJ5cwUABvFVmna1K6vgAt1NqnY1NWO8I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616516614; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=DSeqnX5N97W9rEK9WSPE4QKFRME0UciPhX0NyqSn+M8=; b=fcQt+P6zB9mqioxL3dtXOWy0wJIlRrenjOZEdyaUo4vwarTn91jZb3jfraiAiRqpbN9QMkmh+1ewx7N8wT1NFxnO6QSOd7eXYSse4JVP3pN2O3mJ8lvAi7jjhvdl6+d7KgMgZNvNkUE8FQHSyOKKeQGGB9aijrxNWSnDxVzOIek= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by mx.zohomail.com with SMTPS id 1616516614406177.82605284221995; Tue, 23 Mar 2021 09:23:34 -0700 (PDT) Received: by mail-ej1-f51.google.com with SMTP id l4so28075151ejc.10 for ; Tue, 23 Mar 2021 09:23:33 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (17.red-88-21-201.staticip.rima-tde.net. [88.21.201.17]) by smtp.gmail.com with ESMTPSA id q4sm2934464wma.20.2021.03.23.09.14.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 09:14:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DSeqnX5N97W9rEK9WSPE4QKFRME0UciPhX0NyqSn+M8=; b=R7dUzghB9unldNEhViaM1UR8ta25tikMbx6NJdZbQSUvKkIS7hkxVseKMPFTqBHGt2 OoTRjGw+iYnT+pJaUrjgMSp+fhVu3GNtFWimL98vV5r3ARRERo2QjAkVs386MEEqPHu8 nVQmaJPBKa9g614UD52Ye+/nZw5Rs+Kum8PucvJL/wBK0a+Qvvde6yBH2cojhO8vmMhd 7lKMfCy1HsZLeC5bw1NREPHYH3jsO7yTeYfJlmtos/oIfx+Cvb7RBQcNJ3AxRYq/iVq5 7Ys06xZlAqsdDafhVAtxTeXwB1yKq7mQhJzbcyJVlOHSCHCLIPb0rVWwUZYz1NulOl7E VFqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=DSeqnX5N97W9rEK9WSPE4QKFRME0UciPhX0NyqSn+M8=; b=adAY/C7R4ISv1xDFBFQeUrdBfXbAeO6nl/fK5Gm+IuqThfI/X++lAf1db88z6pLJTC RPAJkQI9TleqT8I+vs0zA7Rq9p1rYOX8s9HrMvEMuNxVixHw+THfj+9tdwRwR7I0uEwM lQgEjNCks8H7GiCXyd+wFPuEjp6flZ5pAilKsMAVvgFfHj6XneftT8FWlU6h5VW7Y4ik /5XPuB8kEHl+aRTmEhVzowEbu2W2TtUAgdirmSbjwn0Na6cclLYagkkmqyTc8K8RMOEF xa4HkdNZd3l78Nt8zmx/9/yUKCV8/MEYY8eT+3WVz+RoiuJckHnkpDtrmoISekPJB7oP 1EiA== X-Gm-Message-State: AOAM5336t0UbX73FigCAizCCBetqJrcKQmNHWDur0kc+QYoVNbL2CcZO +cC4SJSjWsGJK4a2nTker9UnvtGep5kDMw== X-Google-Smtp-Source: ABdhPJxzmk/6q6KI8inXOXYloQO7Bvb05rJTSRpn2RkP5IdU7tYqfepoq2/6KR3FY7quBaBAM5tBOg== X-Received: by 2002:adf:e38f:: with SMTP id e15mr4597775wrm.321.1616516095976; Tue, 23 Mar 2021 09:14:55 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Andrew Baumann , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Peter Maydell Subject: [PATCH v2 2/3] hw/display/bcm2835_fb: Use bcm2835_fb_reconfigure in bcm2835_fb_reset Date: Tue, 23 Mar 2021 17:14:42 +0100 Message-Id: <20210323161443.245636-3-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210323161443.245636-1-f4bug@amsat.org> References: <20210323161443.245636-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Directly use bcm2835_fb_reconfigure() instead of open coding it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/display/bcm2835_fb.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/hw/display/bcm2835_fb.c b/hw/display/bcm2835_fb.c index 3e63d58e0b2..a9c2e57d1c6 100644 --- a/hw/display/bcm2835_fb.c +++ b/hw/display/bcm2835_fb.c @@ -396,11 +396,7 @@ static void bcm2835_fb_reset(DeviceState *dev) =20 s->pending =3D false; =20 - s->config =3D s->initial_config; - - s->invalidate =3D true; - qemu_console_resize(s->con, s->initial_config.xres, s->initial_config.= yres); - s->lock =3D false; + bcm2835_fb_reconfigure(s, &s->initial_config); } =20 static void bcm2835_fb_realize(DeviceState *dev, Error **errp) --=20 2.26.2 From nobody Thu May 2 19:20:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) client-ip=209.85.128.53; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f53.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1616516104; cv=none; d=zohomail.com; s=zohoarc; b=Qz8RZhylCmMPLZHOh1B+mRsUzvPymjriG6dNNxCo7iYm0hk5QwQPxW2+0fYydYPzqAC5V04FGYr6hrETtsSNP/3noBN7vAifs+vFVw6s8rXGw845c4KthJxg8EpmYgUU+n+8T84g3eiNCCCAlAdALvgD4yadvsKMJ3Gl+c6zTSI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616516104; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=HbrBNw1rZqrHPhviLRhW2PghpzAbcjm/RCgXT7DkNTE=; b=MkGYKOhN7KP+1/si9T3qzk3dN5dXviIdguzN5sSj2KpHLQK/IttlpasAFgcnNpJtwK8lnUAUdAB0Uh+BCd70kh0JWh97kKk1BL33agUuyX9NeecIG6lXcsTlfzXEmG0J76VjLp6/Sz95f3Vi2WIZDSbWbp5+QvlXPM79TH+KtxM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mx.zohomail.com with SMTPS id 1616516104039176.65556317503206; Tue, 23 Mar 2021 09:15:04 -0700 (PDT) Received: by mail-wm1-f53.google.com with SMTP id a132-20020a1c668a0000b029010f141fe7c2so11123618wmc.0 for ; Tue, 23 Mar 2021 09:15:02 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (17.red-88-21-201.staticip.rima-tde.net. [88.21.201.17]) by smtp.gmail.com with ESMTPSA id v18sm25364270wru.85.2021.03.23.09.14.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 09:15:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HbrBNw1rZqrHPhviLRhW2PghpzAbcjm/RCgXT7DkNTE=; b=ksj7LqJzTbHlc44lYx65DgjFFrEo0PpNto6KWjJ8hJDLOo8wT6DD8kTDuJx6Sz7EDC kYHDZkngJ3w9e02yYndhWgb7dEf/UqoVGJyUz0rY3qthShyKukGfQHqTwl7u0LqSH2u5 2JEObyuBt1hx1uB5+LcU94FCSs9Q8a88IeNGFW2aX4y9ZwIaGqmhZiukbSo3W+Avh0Hn JZt64uo1ZFLX8GLQIq6L7qNhHFGM77OQY8/iTdIl8ev6Q6tLVuEKhv+opHAZ3f2g32O2 WsUc3pyqrCkwZNtwNl6A9IV5rVtp/FJntZdn7yXvME4rV1O5MvE3DbPWfAg8ntB6JXgz QGGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=HbrBNw1rZqrHPhviLRhW2PghpzAbcjm/RCgXT7DkNTE=; b=t5dlKf8NCqgAaVwGy/h6XiZnqGOQwGJ7HbEo/lZBxUow0CTZogn+OMuowQRqEMWa7i 5S9BZyBXnZMst6rdyHXH5BDJx4juhIQO8LkH7I89xXe3X20/s+68ulHyVpv5bq3Sh3iy KA2r5TO97CSjZT5vyqx380xfcroxJ71CCtzvCnfgz/TgALwxEwMwJyK4NAxOFOxEO3sw ZF5DHkMuiZH/UcCBDICBXq0NU1U5xDcdZhsngmUwtunLbVT+EOGtGcT7M3HZWQs/V1Sq /aLu4o1N5bTGUpPeCpjB9Bb/9U2LOxxDqF51E7JNR/4HUJ6jJ0p89TaGtpvDfxBgFpMd VYlQ== X-Gm-Message-State: AOAM531rrSu1tpaB6VPNPmXP170kiTi50RV180Gx4uas8QugIbblkuTo gQO0pkaHVhWbZb1OeGq+VJU= X-Google-Smtp-Source: ABdhPJxVKarlOvu3yxDnHW4vSCHa6FUdZoTWoBwzQUDWZXZhjSO+yJ1zSjhevHlkhlOBCmJemhvX3g== X-Received: by 2002:a1c:e912:: with SMTP id q18mr4120750wmc.59.1616516100617; Tue, 23 Mar 2021 09:15:00 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Andrew Baumann , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Peter Maydell Subject: [PATCH v2 3/3] hw/display/bcm2835_fb: Remove DeviceReset() call in DeviceRealize() Date: Tue, 23 Mar 2021 17:14:43 +0100 Message-Id: <20210323161443.245636-4-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210323161443.245636-1-f4bug@amsat.org> References: <20210323161443.245636-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) When QDev objects have their DeviceReset handler set, they shouldn't worry about calling it at realization stage (it is handled by hw/core/qdev.c::device_set_realized). Remove the pointless/confusing bcm2835_fb_reset() call. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/display/bcm2835_fb.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/display/bcm2835_fb.c b/hw/display/bcm2835_fb.c index a9c2e57d1c6..d7a44771c44 100644 --- a/hw/display/bcm2835_fb.c +++ b/hw/display/bcm2835_fb.c @@ -421,8 +421,6 @@ static void bcm2835_fb_realize(DeviceState *dev, Error = **errp) s->dma_mr =3D MEMORY_REGION(obj); address_space_init(&s->dma_as, s->dma_mr, TYPE_BCM2835_FB "-memory"); =20 - bcm2835_fb_reset(dev); - s->con =3D graphic_console_init(dev, 0, &vgafb_ops, s); qemu_console_resize(s->con, s->config.xres, s->config.yres); } --=20 2.26.2