From nobody Thu Apr 10 00:20:09 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1616510068; cv=none; d=zohomail.com; s=zohoarc; b=IKWE6bAC8RAgpN6589BmAUjWGDGjZVpTr9wt82wJZ3c/Og8hfUaOpvxjaeCffIHTJUAn98hPVWJhvik6gVODA96rl1G5YYo/PVssyrK6UXQVKhNcWRuyer+LZSdoQuBjREyPG0Z8fTjeKRUO5njAmmJ/GXefsSStV62Co5iyme4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616510068; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Bai26WipCTifnbK8KTHEvIfiuURCYGq1Q4Uwj4/TFi8=; b=AUD8vEEexa/ZsbuoZCCZSWGcSefgSCmczCYlPZulpg+oJDSSGuS6mt6UaUqMjh6NaHPvxaUNnO11fsXmXfuKmE2MtfnSvdJkOD/GTrnnrbrdBPQVKUjYNab9EmV/5IiehIX9f4Euxqe69SZopM9UZaDJh8k8X7gRRrQzB83bgmE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1616510068547210.6846585919593; Tue, 23 Mar 2021 07:34:28 -0700 (PDT) Received: from localhost ([::1]:53896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lOi70-0007CZ-Sx for importer@patchew.org; Tue, 23 Mar 2021 10:34:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46216) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOi05-0006ax-SX for qemu-devel@nongnu.org; Tue, 23 Mar 2021 10:27:18 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:40561) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lOhzn-0007Ao-AM for qemu-devel@nongnu.org; Tue, 23 Mar 2021 10:27:17 -0400 Received: by mail-wr1-x436.google.com with SMTP id v11so20966568wro.7 for ; Tue, 23 Mar 2021 07:26:58 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id a131sm2861292wmc.48.2021.03.23.07.26.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 07:26:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=Bai26WipCTifnbK8KTHEvIfiuURCYGq1Q4Uwj4/TFi8=; b=ndXK/vBObFhX367GoUu9PbcBjZDxFtJpflkQr5/2LIno5iEoO4/lPthE147GMplsGz ZoW+9ORta+RzwWz0ZQJV6mHMcPCGugpShlxew4BUzwUROnCcFYWzYMWr/jTpjSJClbST NrOvN4b+OF/dd6g2VaamZT3ayZzqpkIoVVy0yeEYpzr5Zg89gDO6wPj0TlIfs0hjI1yC glw2gkPdQxqnp0XbZGLiG/5xxMCgHyN9XmKXyIAb+687iVCAWNHxvJu2uqwgK/6udnnP PXBkNcHo86C+kCDe0h98zoTDeNNpX2/jr+Ot0ia1Bk4zP2i68Jf95w1Oyl5idKrQDMI9 ljzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Bai26WipCTifnbK8KTHEvIfiuURCYGq1Q4Uwj4/TFi8=; b=T4xgZ+Jinl3qJY4ur9gd09asI0lUcPwK/yLaBt9ntwUOXPkoc8My/5WrNl5LJQWbxQ Ewx4DNt/Yo1xJwqRcyAp4HEEovRZ5Qgjho10O80JsPZyfbgHmo1+orVkEJTWwg4xCL3O QG4UwQyfkf+jUzfSRw6B5l4ici+93yVVXEbyrmSKeEIkTn1Jbgk8XWEGR9VGnZ87wTna KJKapLI4Vc7ZIIs8hvhl0jG5hoFwsSDPSBi3TMy0kHWB95EHpZEfWEndn8cnvfyioMM2 5HCXlE7BfiIKCKLit4wZ6NOTm1bp2/p3w/ga3E6KzmAfzfdOqXOUUjACdcUtJt3MlcIY p2Sw== X-Gm-Message-State: AOAM532bbgdl8bsvyKe9p2Y1JmZk5MrcywNCON7E/QIGgbYKyD9h9YEN eLy9p1xLebDcsjpJrHYB2PCTFftnSa1oAkPF X-Google-Smtp-Source: ABdhPJwnUsBgBvfGkl9rEpvpIatEqybf8ys0Ok7KZJ4VqODGyTq4vWpYs/TS5/AiduUuWGY0bDrBog== X-Received: by 2002:adf:8562:: with SMTP id 89mr4317955wrh.101.1616509617190; Tue, 23 Mar 2021 07:26:57 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 2/7] memory: Make flatview_cb return bool, not int Date: Tue, 23 Mar 2021 14:26:48 +0000 Message-Id: <20210323142653.3538-3-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210323142653.3538-1-peter.maydell@linaro.org> References: <20210323142653.3538-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) The return value of the flatview_cb callback passed to the flatview_for_each_range() function is zero if the iteration through the ranges should continue, or non-zero to break out of it. Use a bool for this rather than int. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-id: 20210318174823.18066-2-peter.maydell@linaro.org --- include/exec/memory.h | 6 +++--- tests/qtest/fuzz/generic_fuzz.c | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index 260ddd8ade8..500bfc0abd2 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -776,9 +776,9 @@ static inline FlatView *address_space_to_flatview(Addre= ssSpace *as) return qatomic_rcu_read(&as->current_map); } =20 -typedef int (*flatview_cb)(Int128 start, - Int128 len, - const MemoryRegion*, void*); +typedef bool (*flatview_cb)(Int128 start, + Int128 len, + const MemoryRegion*, void*); =20 void flatview_for_each_range(FlatView *fv, flatview_cb cb , void *opaque); =20 diff --git a/tests/qtest/fuzz/generic_fuzz.c b/tests/qtest/fuzz/generic_fuz= z.c index b5fe27aae18..b6af4cbb18b 100644 --- a/tests/qtest/fuzz/generic_fuzz.c +++ b/tests/qtest/fuzz/generic_fuzz.c @@ -98,19 +98,19 @@ struct get_io_cb_info { address_range result; }; =20 -static int get_io_address_cb(Int128 start, Int128 size, - const MemoryRegion *mr, void *opaque) { +static bool get_io_address_cb(Int128 start, Int128 size, + const MemoryRegion *mr, void *opaque) { struct get_io_cb_info *info =3D opaque; if (g_hash_table_lookup(fuzzable_memoryregions, mr)) { if (info->index =3D=3D 0) { info->result.addr =3D (ram_addr_t)start; info->result.size =3D (ram_addr_t)size; info->found =3D 1; - return 1; + return true; } info->index--; } - return 0; + return false; } =20 /* --=20 2.20.1