[PATCH v3 0/9] simplebench improvements

Vladimir Sementsov-Ogievskiy posted 9 patches 3 years ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210323134734.72930-1-vsementsov@virtuozzo.com
Maintainers: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
MAINTAINERS                            |  1 +
scripts/simplebench/bench-backup.py    | 95 +++++++++++++++++++++-----
scripts/simplebench/bench_block_job.py | 42 +++++++++++-
scripts/simplebench/simplebench.py     | 28 +++++++-
4 files changed, 144 insertions(+), 22 deletions(-)
[PATCH v3 0/9] simplebench improvements
Posted by Vladimir Sementsov-Ogievskiy 3 years ago
Hi all!

Here are some improvements to simplebench lib, to support my
"qcow2: compressed write cache" series.

v3:
01: use simpler logic
02,04-06: add John's r-b
07: use BooleanOptionalAction and
    initial_run=args.initial_run
08: rewrite so that we have a new --drop-caches option

Vladimir Sementsov-Ogievskiy (9):
  simplebench: bench_one(): add slow_limit argument
  simplebench: bench_one(): support count=1
  simplebench/bench-backup: add --compressed option
  simplebench/bench-backup: add target-cache argument
  simplebench/bench_block_job: handle error in BLOCK_JOB_COMPLETED
  simplebench/bench-backup: support qcow2 source files
  simplebench/bench-backup: add --count and --no-initial-run
  simplebench/bench-backup: add --drop-caches argument
  MAINTAINERS: update Benchmark util: add git tree

 MAINTAINERS                            |  1 +
 scripts/simplebench/bench-backup.py    | 95 +++++++++++++++++++++-----
 scripts/simplebench/bench_block_job.py | 42 +++++++++++-
 scripts/simplebench/simplebench.py     | 28 +++++++-
 4 files changed, 144 insertions(+), 22 deletions(-)

-- 
2.29.2


Re: [PATCH v3 0/9] simplebench improvements
Posted by Vladimir Sementsov-Ogievskiy 2 years, 11 months ago
23.03.2021 16:47, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
> 
> Here are some improvements to simplebench lib, to support my
> "qcow2: compressed write cache" series.
> 
> v3:
> 01: use simpler logic
> 02,04-06: add John's r-b
> 07: use BooleanOptionalAction and
>      initial_run=args.initial_run
> 08: rewrite so that we have a new --drop-caches option
> 
> Vladimir Sementsov-Ogievskiy (9):
>    simplebench: bench_one(): add slow_limit argument
>    simplebench: bench_one(): support count=1
>    simplebench/bench-backup: add --compressed option
>    simplebench/bench-backup: add target-cache argument
>    simplebench/bench_block_job: handle error in BLOCK_JOB_COMPLETED
>    simplebench/bench-backup: support qcow2 source files
>    simplebench/bench-backup: add --count and --no-initial-run
>    simplebench/bench-backup: add --drop-caches argument
>    MAINTAINERS: update Benchmark util: add git tree
> 
>   MAINTAINERS                            |  1 +
>   scripts/simplebench/bench-backup.py    | 95 +++++++++++++++++++++-----
>   scripts/simplebench/bench_block_job.py | 42 +++++++++++-
>   scripts/simplebench/simplebench.py     | 28 +++++++-
>   4 files changed, 144 insertions(+), 22 deletions(-)
> 

Thanks for reviewing, applied to my simplebench branch at
https://src.openvz.org/scm/~vsementsov/qemu.git

I'm going to send pull request now, and see, will Peter take it or not :)

-- 
Best regards,
Vladimir

Re: [PATCH v3 0/9] simplebench improvements
Posted by Vladimir Sementsov-Ogievskiy 2 years, 11 months ago
kindly ping.

I probably can pull it as is when 6.0 finally released and new development phase opened..

Still, John, if you have some time for it, could you look through the changes and may be give missed r-bs?

changes v2->v3:
  
  https://patchew.org/QEMU/20210304101738.20248-1-vsementsov@virtuozzo.com/diff/20210323134734.72930-1-vsementsov@virtuozzo.com/

23.03.2021 16:47, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
> 
> Here are some improvements to simplebench lib, to support my
> "qcow2: compressed write cache" series.
> 
> v3:
> 01: use simpler logic
> 02,04-06: add John's r-b
> 07: use BooleanOptionalAction and
>      initial_run=args.initial_run
> 08: rewrite so that we have a new --drop-caches option
> 
> Vladimir Sementsov-Ogievskiy (9):
>    simplebench: bench_one(): add slow_limit argument
>    simplebench: bench_one(): support count=1
>    simplebench/bench-backup: add --compressed option
>    simplebench/bench-backup: add target-cache argument
>    simplebench/bench_block_job: handle error in BLOCK_JOB_COMPLETED
>    simplebench/bench-backup: support qcow2 source files
>    simplebench/bench-backup: add --count and --no-initial-run
>    simplebench/bench-backup: add --drop-caches argument
>    MAINTAINERS: update Benchmark util: add git tree
> 
>   MAINTAINERS                            |  1 +
>   scripts/simplebench/bench-backup.py    | 95 +++++++++++++++++++++-----
>   scripts/simplebench/bench_block_job.py | 42 +++++++++++-
>   scripts/simplebench/simplebench.py     | 28 +++++++-
>   4 files changed, 144 insertions(+), 22 deletions(-)
> 


-- 
Best regards,
Vladimir