[PULL 0/8] Misc bugfixes for QEMU soft freeze

Paolo Bonzini posted 8 patches 3 years ago
Test checkpatch failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210319143924.2173798-1-pbonzini@redhat.com
Maintainers: "Daniel P. Berrangé" <berrange@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, Richard Henderson <richard.henderson@linaro.org>
docs/hyperv.txt                              |  5 +++++
hw/intc/i8259.c                              | 12 ++++++------
qom/object_interfaces.c                      |  1 +
target/i386/cpu.c                            | 23 ++++++++---------------
target/i386/cpu.h                            |  1 -
target/i386/kvm/hyperv-proto.h               |  1 +
target/i386/machine.c                        | 24 ++++++++++++++++++++++--
target/i386/tcg/excp_helper.c                |  7 ++++---
target/i386/tcg/helper-tcg.h                 | 14 +++++---------
target/i386/tcg/misc_helper.c                |  4 ++++
target/i386/tcg/seg_helper.c                 |  4 ++--
target/i386/tcg/svm_helper.c                 | 15 +++++++--------
tests/qtest/{fuzz-test.c => lpc-ich9-test.c} | 12 +++++++-----
tests/qtest/meson.build                      |  2 +-
14 files changed, 73 insertions(+), 52 deletions(-)
rename tests/qtest/{fuzz-test.c => lpc-ich9-test.c} (71%)
[PULL 0/8] Misc bugfixes for QEMU soft freeze
Posted by Paolo Bonzini 3 years ago
The following changes since commit cf6b56d4f2107259f52413f979a1d474dad0c1e1:

  Merge remote-tracking branch 'remotes/philmd/tags/pflash-20210318' into staging (2021-03-18 23:04:41 +0000)

are available in the Git repository at:

  https://gitlab.com/bonzini/qemu.git tags/for-upstream

for you to fetch changes up to af05ffffd7fa28010d4df9f5744514b16e71055d:

  tests/qtest: cleanup the testcase for bug 1878642 (2021-03-19 10:37:46 -0400)

----------------------------------------------------------------
* fixes for i386 TCG paging
* fixes for Hyper-V enlightenments
* avoid uninitialized variable warning

----------------------------------------------------------------
Paolo Bonzini (5):
      qom: use qemu_printf to print help for user-creatable objects
      target/i386: allow modifying TCG phys-addr-bits
      target/i386: fail if toggling LA57 in 64-bit mode
      target/i386: svm: do not discard high 32 bits of EXITINFO1
      tests/qtest: cleanup the testcase for bug 1878642

Philippe Mathieu-Daudé (1):
      hw/intc/i8259: Refactor pic_read_irq() to avoid uninitialized variable

Vitaly Kuznetsov (2):
      i386: Fix 'hypercall_hypercall' typo
      i386: Make migration fail when Hyper-V reenlightenment was enabled but 'user_tsc_khz' is unset

 docs/hyperv.txt                              |  5 +++++
 hw/intc/i8259.c                              | 12 ++++++------
 qom/object_interfaces.c                      |  1 +
 target/i386/cpu.c                            | 23 ++++++++---------------
 target/i386/cpu.h                            |  1 -
 target/i386/kvm/hyperv-proto.h               |  1 +
 target/i386/machine.c                        | 24 ++++++++++++++++++++++--
 target/i386/tcg/excp_helper.c                |  7 ++++---
 target/i386/tcg/helper-tcg.h                 | 14 +++++---------
 target/i386/tcg/misc_helper.c                |  4 ++++
 target/i386/tcg/seg_helper.c                 |  4 ++--
 target/i386/tcg/svm_helper.c                 | 15 +++++++--------
 tests/qtest/{fuzz-test.c => lpc-ich9-test.c} | 12 +++++++-----
 tests/qtest/meson.build                      |  2 +-
 14 files changed, 73 insertions(+), 52 deletions(-)
 rename tests/qtest/{fuzz-test.c => lpc-ich9-test.c} (71%)
-- 
2.26.2


Re: [PULL 0/8] Misc bugfixes for QEMU soft freeze
Posted by no-reply@patchew.org 3 years ago
Patchew URL: https://patchew.org/QEMU/20210319143924.2173798-1-pbonzini@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210319143924.2173798-1-pbonzini@redhat.com
Subject: [PULL 0/8] Misc bugfixes for QEMU soft freeze

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20210319132008.1830950-1-armbru@redhat.com -> patchew/20210319132008.1830950-1-armbru@redhat.com
 - [tag update]      patchew/20210319132537.2046339-1-laurent@vivier.eu -> patchew/20210319132537.2046339-1-laurent@vivier.eu
 - [tag update]      patchew/20210319141459.1196741-1-georg.kotheimer@kernkonzept.com -> patchew/20210319141459.1196741-1-georg.kotheimer@kernkonzept.com
 - [tag update]      patchew/20210319142308.3980259-1-philmd@redhat.com -> patchew/20210319142308.3980259-1-philmd@redhat.com
 * [new tag]         patchew/20210319143924.2173798-1-pbonzini@redhat.com -> patchew/20210319143924.2173798-1-pbonzini@redhat.com
Switched to a new branch 'test'
3028e06 tests/qtest: cleanup the testcase for bug 1878642
bb694d0 hw/intc/i8259: Refactor pic_read_irq() to avoid uninitialized variable
d2848d7 i386: Make migration fail when Hyper-V reenlightenment was enabled but 'user_tsc_khz' is unset
b3272cd i386: Fix 'hypercall_hypercall' typo
1acb121 target/i386: svm: do not discard high 32 bits of EXITINFO1
98d4294 target/i386: fail if toggling LA57 in 64-bit mode
41fdb4c target/i386: allow modifying TCG phys-addr-bits
0399957 qom: use qemu_printf to print help for user-creatable objects

=== OUTPUT BEGIN ===
1/8 Checking commit 03999579d717 (qom: use qemu_printf to print help for user-creatable objects)
2/8 Checking commit 41fdb4c2ca91 (target/i386: allow modifying TCG phys-addr-bits)
3/8 Checking commit 98d4294615e0 (target/i386: fail if toggling LA57 in 64-bit mode)
ERROR: suspect code indent for conditional statements (8, 13)
#23: FILE: target/i386/tcg/misc_helper.c:170:
+        if (((t0 ^ env->cr[4]) & CR4_LA57_MASK) &&
[...]
+             raise_exception_ra(env, EXCP0D_GPF, GETPC());

total: 1 errors, 0 warnings, 10 lines checked

Patch 3/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/8 Checking commit 1acb12186d9c (target/i386: svm: do not discard high 32 bits of EXITINFO1)
5/8 Checking commit b3272cd52507 (i386: Fix 'hypercall_hypercall' typo)
6/8 Checking commit d2848d7ceb38 (i386: Make migration fail when Hyper-V reenlightenment was enabled but 'user_tsc_khz' is unset)
7/8 Checking commit bb694d03a9ee (hw/intc/i8259: Refactor pic_read_irq() to avoid uninitialized variable)
8/8 Checking commit 3028e06c7aef (tests/qtest: cleanup the testcase for bug 1878642)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
 tests/qtest/{fuzz-test.c => lpc-ich9-test.c} | 12 +++++++-----

total: 0 errors, 1 warnings, 42 lines checked

Patch 8/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210319143924.2173798-1-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [PULL 0/8] Misc bugfixes for QEMU soft freeze
Posted by Peter Maydell 3 years ago
On Fri, 19 Mar 2021 at 14:42, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> The following changes since commit cf6b56d4f2107259f52413f979a1d474dad0c1e1:
>
>   Merge remote-tracking branch 'remotes/philmd/tags/pflash-20210318' into staging (2021-03-18 23:04:41 +0000)
>
> are available in the Git repository at:
>
>   https://gitlab.com/bonzini/qemu.git tags/for-upstream
>
> for you to fetch changes up to af05ffffd7fa28010d4df9f5744514b16e71055d:
>
>   tests/qtest: cleanup the testcase for bug 1878642 (2021-03-19 10:37:46 -0400)
>
> ----------------------------------------------------------------
> * fixes for i386 TCG paging
> * fixes for Hyper-V enlightenments
> * avoid uninitialized variable warning
>


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/6.0
for any user-visible changes.

-- PMM

Re: [PULL 0/8] Misc bugfixes for QEMU soft freeze
Posted by Thomas Huth 3 years ago
On 19/03/2021 15.39, Paolo Bonzini wrote:
> The following changes since commit cf6b56d4f2107259f52413f979a1d474dad0c1e1:
> 
>    Merge remote-tracking branch 'remotes/philmd/tags/pflash-20210318' into staging (2021-03-18 23:04:41 +0000)
> 
> are available in the Git repository at:
> 
>    https://gitlab.com/bonzini/qemu.git tags/for-upstream
> 
> for you to fetch changes up to af05ffffd7fa28010d4df9f5744514b16e71055d:
> 
>    tests/qtest: cleanup the testcase for bug 1878642 (2021-03-19 10:37:46 -0400)
> 
> ----------------------------------------------------------------
> * fixes for i386 TCG paging
> * fixes for Hyper-V enlightenments
> * avoid uninitialized variable warning
> 
> ----------------------------------------------------------------
> Paolo Bonzini (5):
>        qom: use qemu_printf to print help for user-creatable objects

The qemu_printf patch that hit the master branch looks very funny. I think 
it should get reverted since that header file now gets included twice there?

  Thomas


Re: [PULL 0/8] Misc bugfixes for QEMU soft freeze
Posted by Paolo Bonzini 3 years ago
On 22/03/21 06:02, Thomas Huth wrote:
> On 19/03/2021 15.39, Paolo Bonzini wrote:
>> The following changes since commit 
>> cf6b56d4f2107259f52413f979a1d474dad0c1e1:
>>
>>    Merge remote-tracking branch 'remotes/philmd/tags/pflash-20210318' 
>> into staging (2021-03-18 23:04:41 +0000)
>>
>> are available in the Git repository at:
>>
>>    https://gitlab.com/bonzini/qemu.git tags/for-upstream
>>
>> for you to fetch changes up to af05ffffd7fa28010d4df9f5744514b16e71055d:
>>
>>    tests/qtest: cleanup the testcase for bug 1878642 (2021-03-19 
>> 10:37:46 -0400)
>>
>> ----------------------------------------------------------------
>> * fixes for i386 TCG paging
>> * fixes for Hyper-V enlightenments
>> * avoid uninitialized variable warning
>>
>> ----------------------------------------------------------------
>> Paolo Bonzini (5):
>>        qom: use qemu_printf to print help for user-creatable objects
> 
> The qemu_printf patch that hit the master branch looks very funny. I 
> think it should get reverted since that header file now gets included 
> twice there?

Indeed.  Most of the changes in the original patch were done already by 
Kevin's commit da0a932bbf ("hmp: QAPIfy object_add", 2021-03-19), so it 
can be reverted.

Paolo