From nobody Mon Feb 9 17:23:33 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1616148929; cv=none; d=zohomail.com; s=zohoarc; b=Vz7R2ZRySs9exYbbNpt4Uhe3Os5GqlmsCFt37TMHF6r1Bn/1siW1zxdyL5QIJK/HN+8SZ6bZELcM7zlb+lyzUuae41NVv2Q7RGtZtnXBDrVgf3o6Le6ZDr9vJgN4rq8HOEBl1nC998lSFl3dn2jNo8YKw7D+8O97upRKnvkpUCk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616148929; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gm0bKn2AknzXfWOrVnF1vpMqFpQSv+NvTkNokQkf9SU=; b=j27hHfUV/fLpynFhyeKRMlFro9fX34Sqf97RX3fCtjsPwSoRo4yDJT+a3iXGvBLbN0KKo9VTmikMCgVOygd7y41IvVhMaewzsjSa1MVAfWuRDoPXYmoEn+l17x5keFwdRj3W0iUYTk1uggMvpov78g3EOFEwBHKaLt+GjIp+6vA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1616148929248207.80665956623307; Fri, 19 Mar 2021 03:15:29 -0700 (PDT) Received: from localhost ([::1]:47704 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNCA7-0002XE-OI for importer@patchew.org; Fri, 19 Mar 2021 06:15:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47714) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNC83-0000ox-PF for qemu-devel@nongnu.org; Fri, 19 Mar 2021 06:13:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:20860) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNC82-0008SP-48 for qemu-devel@nongnu.org; Fri, 19 Mar 2021 06:13:15 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-169-jfFwo_aXOjmwTPLhBgSbbw-1; Fri, 19 Mar 2021 06:13:11 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4D411180FCAC; Fri, 19 Mar 2021 10:13:10 +0000 (UTC) Received: from t480s.redhat.com (ovpn-112-11.ams2.redhat.com [10.36.112.11]) by smtp.corp.redhat.com (Postfix) with ESMTP id E87F910013C1; Fri, 19 Mar 2021 10:13:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616148793; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gm0bKn2AknzXfWOrVnF1vpMqFpQSv+NvTkNokQkf9SU=; b=Lfg1hNaLeN2DVlYzBI2VlvXKGN+V8CEE45rGU8cZ+CKodMdejqfB+136enlCMHyx37qtkx BaJBRoC/u5NCHwU847h/w1b2IptxrHDCJAWOvVzdKEZZTvymVvNbAALFrA2sxMXYPooc8C LDh3j1BxhmWVkgjHRrCWOj8vOZotw+4= X-MC-Unique: jfFwo_aXOjmwTPLhBgSbbw-1 From: David Hildenbrand To: qemu-devel@nongnu.org Subject: [PATCH v4 03/14] softmmu/physmem: Fix qemu_ram_remap() to handle shared anonymous memory Date: Fri, 19 Mar 2021 11:12:19 +0100 Message-Id: <20210319101230.21531-4-david@redhat.com> In-Reply-To: <20210319101230.21531-1-david@redhat.com> References: <20210319101230.21531-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.249, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marcel Apfelbaum , Murilo Opsfelder Araujo , Igor Kotrasinski , Eduardo Habkost , "Michael S. Tsirkin" , David Hildenbrand , Richard Henderson , "Dr. David Alan Gilbert" , Peter Xu , Greg Kurz , Stefan Hajnoczi , Igor Mammedov , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Markus Armbruster Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" RAM_SHARED now also properly indicates shared anonymous memory. Let's check that flag for anonymous memory as well, to restore the proper mapping. Fixes: 06329ccecfa0 ("mem: add share parameter to memory-backend-ram") Signed-off-by: David Hildenbrand Reviewed-by: Peter Xu --- softmmu/physmem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/softmmu/physmem.c b/softmmu/physmem.c index afff96a6dc..cc59f05593 100644 --- a/softmmu/physmem.c +++ b/softmmu/physmem.c @@ -2222,13 +2222,13 @@ void qemu_ram_remap(ram_addr_t addr, ram_addr_t len= gth) abort(); } else { flags =3D MAP_FIXED; + flags |=3D block->flags & RAM_SHARED ? + MAP_SHARED : MAP_PRIVATE; if (block->fd >=3D 0) { - flags |=3D (block->flags & RAM_SHARED ? - MAP_SHARED : MAP_PRIVATE); area =3D mmap(vaddr, length, PROT_READ | PROT_WRITE, flags, block->fd, offset); } else { - flags |=3D MAP_PRIVATE | MAP_ANONYMOUS; + flags |=3D MAP_ANONYMOUS; area =3D mmap(vaddr, length, PROT_READ | PROT_WRITE, flags, -1, 0); } --=20 2.29.2