From nobody Wed Nov 19 13:53:34 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1616041172; cv=none; d=zohomail.com; s=zohoarc; b=MJUCGk/MblTjB0fsdwdjpK2xYyha+0y6F8K1qYS0I2wjagX1gedBYPJ5JQbyUvMlCUXLWy+5u7BCBS3StiJgD5kN5WsXLnB1M8LhrrNyoujg95g63W0zrcazmVfuvEBegVDzfwC8PKoacLgUMTfaK959B7fk0XmxnQAPc0mZyFw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616041172; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qjZfZkzonk1Y4WP53qI05iVmN8JtJxgOtn86BENF5bI=; b=SoeYodEcA1ZUSrYIKX1D4SLnLi6HnIsQxvObrg/Bs/xZMtpbdwWcBn0DkZsq0AS8zZZxhtRVGOFMAiSKEMX5KmSznKRbBNpp/nsTaOVIuuIO6+Qudw+iDaCxbgVkIK6gVv1bkdkmMZG0O2iJ38gcihFt2OqwzH8BSNaNkN+G/HQ= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 161604117255145.50674222723126; Wed, 17 Mar 2021 21:19:32 -0700 (PDT) Received: from localhost ([::1]:42938 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMk8B-0003Np-GO for importer@patchew.org; Thu, 18 Mar 2021 00:19:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38138) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMk6V-00026h-T4 for qemu-devel@nongnu.org; Thu, 18 Mar 2021 00:17:47 -0400 Received: from mga02.intel.com ([134.134.136.20]:25454) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMk6R-0004IZ-6w for qemu-devel@nongnu.org; Thu, 18 Mar 2021 00:17:47 -0400 Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2021 21:17:36 -0700 Received: from unknown (HELO localhost.localdomain) ([10.239.13.19]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2021 21:17:35 -0700 IronPort-SDR: Wcb3lCWlnrqpP659pj35/hNWWBwIStq1zWFT36bqs0fJTP4X8YZxd6WQpDCLMmFtFy3nkxqQm5 N5dxw5UTlLaA== X-IronPort-AV: E=McAfee;i="6000,8403,9926"; a="176727957" X-IronPort-AV: E=Sophos;i="5.81,257,1610438400"; d="scan'208";a="176727957" IronPort-SDR: la7LS0444kkEDVmEKBxOPJY1gqOPyJslEFPWOHsxy+Ja0Bj3ZXoOsdjaKwNcXasFMLh1JK0ilj QwcynIRDmNwA== X-IronPort-AV: E=Sophos;i="5.81,257,1610438400"; d="scan'208";a="412913963" From: Zhang Chen To: Jason Wang , qemu-dev Subject: [PULL 1/2] net/colo-compare.c: Fix memory leak for non-tcp packet Date: Thu, 18 Mar 2021 12:11:51 +0800 Message-Id: <20210318041152.59367-2-chen.zhang@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210318041152.59367-1-chen.zhang@intel.com> References: <20210318041152.59367-1-chen.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=134.134.136.20; envelope-from=chen.zhang@intel.com; helo=mga02.intel.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhang Chen , Lukas Straub , Zhang Chen Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Lukas Straub Additional to removing the packet from the secondary queue, we also need to free it. Signed-off-by: Lukas Straub Signed-off-by: Zhang Chen Reviewed-by: Zhang Chen --- net/colo-compare.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/colo-compare.c b/net/colo-compare.c index 84db4978ac..2e819ffedb 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -690,6 +690,7 @@ static void colo_compare_packet(CompareState *s, Connec= tion *conn, =20 if (result) { colo_release_primary_pkt(s, pkt); + packet_destroy(result->data, NULL); g_queue_remove(&conn->secondary_list, result->data); } else { /* --=20 2.25.1