From nobody Wed Nov 19 12:23:39 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1615953281; cv=none; d=zohomail.com; s=zohoarc; b=XI00mZH3dEbI2L4xae2R5BXe6+68KiDU83rj3iXABAzBEBPdxFuFsn5KieZrHLvbEuRvyc5IVOa1PO7OhlSBJEiPVTeKghPAGthOVZ1Hr/NSrzMDb5WW1FA9ID16XERzLwt+8WgmalSQUXSX8X24T+fJ1KHNj6PEVRIunqq2Vk0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615953281; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lHrAgiiRTvli6S+q8WbO/yd68EtMlaFBeXtli09gb5U=; b=FP66/MXfFLuQLWEU0jwwAdsvWEFeEi18YfUydc7X4ZhNQtOIk7dCDD9H8eWWTELtQE9TADT5zpjDA9lMaAZyJdP3/w5824ExK1GpKqd+f17qj0kUYbgeWYy4xetj+X9bx2r5wqT1Lex+zotvmH+gqhkedoGoThOJ6KoDkXsxh5I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1615953281794927.2642738976247; Tue, 16 Mar 2021 20:54:41 -0700 (PDT) Received: from localhost ([::1]:46122 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMNGa-0005sP-NP for importer@patchew.org; Tue, 16 Mar 2021 23:54:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40684) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMNEw-0003F6-UB for qemu-devel@nongnu.org; Tue, 16 Mar 2021 23:52:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:32630) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lMNEu-0002zq-OO for qemu-devel@nongnu.org; Tue, 16 Mar 2021 23:52:58 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-313-R2fox6hJPW6GXSyLHxeBWQ-1; Tue, 16 Mar 2021 23:52:53 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 86CF6100C61A; Wed, 17 Mar 2021 03:52:52 +0000 (UTC) Received: from localhost.net (ovpn-113-107.rdu2.redhat.com [10.10.113.107]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2AD495D9C0; Wed, 17 Mar 2021 03:52:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615953176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lHrAgiiRTvli6S+q8WbO/yd68EtMlaFBeXtli09gb5U=; b=O3/MWQEo3Yj7DlfQJPFoV1YoiUdN8K3s8AfCbl7PP5KmFVm0job+SBknC/3TH+pDNljf0a kxW+ozw9+aw+w4Z8hLu5ybPCxbimTkbBqrwKSmw7x95/9NmXGe22xkGlrTP7MbdqazSaOK z8PUVNVRKrD+A22Lrt9K/EEBxJNYMIU= X-MC-Unique: R2fox6hJPW6GXSyLHxeBWQ-1 From: Cleber Rosa To: Peter Maydell , qemu-devel@nongnu.org Subject: [PULL 1/5] tests/acceptance: Print expected message on wait_for_console_pattern Date: Tue, 16 Mar 2021 23:52:38 -0400 Message-Id: <20210317035242.24418-2-crosa@redhat.com> In-Reply-To: <20210317035242.24418-1-crosa@redhat.com> References: <20210317035242.24418-1-crosa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=crosa@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=crosa@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , John Snow , Wainer dos Santos Moschetta , Willian Rampazzo , Joel Stanley , Willian Rampazzo , Cleber Rosa , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Beraldo Leal Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Wainer dos Santos Moschetta For the sake of improve debuggability of tests which use the wait_for_console_pattern(), this changed the _console_interaction() so that the expected message is printed if the test fail. Signed-off-by: Wainer dos Santos Moschetta Message-Id: <20210309153507.1905682-1-wainersm@redhat.com> Reviewed-by: Joel Stanley Reviewed-by: Willian Rampazzo Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa Signed-off-by: Cleber Rosa --- tests/acceptance/avocado_qemu/__init__.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/a= vocado_qemu/__init__.py index df167b142cc..ed338caaba9 100644 --- a/tests/acceptance/avocado_qemu/__init__.py +++ b/tests/acceptance/avocado_qemu/__init__.py @@ -97,7 +97,8 @@ def _console_interaction(test, success_message, failure_m= essage, break if failure_message and failure_message in msg: console.close() - fail =3D 'Failure message found in console: %s' % failure_mess= age + fail =3D 'Failure message found in console: "%s". Expected: "%= s"' % \ + (failure_message, success_message) test.fail(fail) =20 def interrupt_interactive_console_until_pattern(test, success_message, --=20 2.30.2 From nobody Wed Nov 19 12:23:39 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1615953288; cv=none; d=zohomail.com; s=zohoarc; b=crYUXvgYKml/gcDR09QhbQvJNMaTc45yrlgzmd6ewaoWZ66wTyQa8NXgmjnpj08vnY4VhyhGz9r4mv4LnbJ/Ea/yPp4maXJ2HtKHrull23Z4drVtcWbb3kTKRzf5h0KDvgskMa714W0DY5ONGuIct9CABGvpKeVTbKDDSMgE66I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615953288; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=KkfvOmKQKuHQVQkHYuZzAVO0HmAfuKft1JVGth8R6g4=; b=Mc7zMUqT7DrBxtkQotUC8gjMoMUQxRD8P2dS0j4bN14BatmQe5lyvIb9Ot83OPU/COk+WrwrZA5rupDbKH2vkd4WYEEM48kE9pG13MXK4N1rT8cCV/A9l8LpHpd4a3aDbfABiqplrOn9GKP/VOjxzdBV9ZhDMmG1P048c0io/kY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1615953288445189.56399107542325; Tue, 16 Mar 2021 20:54:48 -0700 (PDT) Received: from localhost ([::1]:46778 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMNGh-00068w-Dw for importer@patchew.org; Tue, 16 Mar 2021 23:54:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40696) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMNF1-0003JO-9X for qemu-devel@nongnu.org; Tue, 16 Mar 2021 23:53:03 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:42187) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMNEy-00032K-Tl for qemu-devel@nongnu.org; Tue, 16 Mar 2021 23:53:03 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-22-NtaSTOy7PDW1jWxZZuyt7Q-1; Tue, 16 Mar 2021 23:52:57 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2D32818460E0; Wed, 17 Mar 2021 03:52:55 +0000 (UTC) Received: from localhost.net (ovpn-113-107.rdu2.redhat.com [10.10.113.107]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A6DBA5D9D3; Wed, 17 Mar 2021 03:52:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615953180; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KkfvOmKQKuHQVQkHYuZzAVO0HmAfuKft1JVGth8R6g4=; b=gGpDL7KnAs0kLRnb0+tfAC2ylJpF91Jzkx/VUcGdYcf7xLOTMOXoizc+mDSa040ypNYiWe U/XTv5OqqZSxRTp6rgvnSyrnXTHlPwHm6eIA4Bfc+BQvEkwsoRPm1I1MZ0wSwFvKrsd9f1 YYiP6uwu2K3WKruxp2vDhNsTjSwsh+A= X-MC-Unique: NtaSTOy7PDW1jWxZZuyt7Q-1 From: Cleber Rosa To: Peter Maydell , qemu-devel@nongnu.org Subject: [PULL 2/5] tests/migration: fix unix socket batch migration Date: Tue, 16 Mar 2021 23:52:39 -0400 Message-Id: <20210317035242.24418-3-crosa@redhat.com> In-Reply-To: <20210317035242.24418-1-crosa@redhat.com> References: <20210317035242.24418-1-crosa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=crosa@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=crosa@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , John Snow , Hyman , Wainer dos Santos Moschetta , Willian Rampazzo , Cleber Rosa , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Beraldo Leal Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Hyman when execute the following test command: "guestperf-batch.py --dst-host localhost --transport unix ..." test aborts and error message as the following be throwed: "launching VM Failed: [Errno 98] Address already in use". The reason is that batch script use the same monitor socket in all test cases and do not remove the socket file. The second migration test will launch vm use the same socket file as the first, so we get the error message. To fix it, just remove the socket file each time we have done the migration test. Signed-off-by: Hyman Message-Id: Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Cleber Rosa --- tests/migration/guestperf/engine.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tests/migration/guestperf/engine.py b/tests/migration/guestper= f/engine.py index 83bfc3b6bb8..5189cf96775 100644 --- a/tests/migration/guestperf/engine.py +++ b/tests/migration/guestperf/engine.py @@ -407,6 +407,13 @@ def run(self, hardware, scenario, result_dir=3Dos.getc= wd()): vcpu_timings =3D ret[2] if uri[0:5] =3D=3D "unix:": os.remove(uri[5:]) + + if os.path.exists(srcmonaddr): + os.remove(srcmonaddr) + + if self._dst_host =3D=3D "localhost" and os.path.exists(dstmon= addr): + os.remove(dstmonaddr) + if self._verbose: print("Finished migration") =20 --=20 2.30.2 From nobody Wed Nov 19 12:23:39 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1615953406; cv=none; d=zohomail.com; s=zohoarc; b=cxeHUv1RNIXIcLb7MA5STHEqZM4e3pW7lhCFA5RQWSeWv9AyDAKg92eFEGjTETNDGj079zfU79UCjBCcNKIMp7dxJbMaO6mljqv/qxU41FKfQEHYJEV7pXBEvRxqPWm9Aa7OD0LtZsQNMBXI+PNsl3lkGmdutS6UIsXk/d6oPI8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615953406; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NALnShKsYl2q3B7a8PzusRjg/2/PLwai26rLiZcw7Wk=; b=a4X8lH1j9nwHsfMnoVCEvPmfFYgfU5qzB9788CDs58fcYiGpyIbtBikegCVUgcxAqw+PAYGhsBHQkRv3+0zC40y/8YUaWeJsXpWvMXkeOYj2Xo69VPwZlRnLHpiH1jxObX+Vcbsbf9/yUmZM9jgdO8xwnQMfVARNvUnoRvSzfZo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1615953406322260.930722564563; Tue, 16 Mar 2021 20:56:46 -0700 (PDT) Received: from localhost ([::1]:53412 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMNIb-0000Sw-B9 for importer@patchew.org; Tue, 16 Mar 2021 23:56:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40726) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMNF6-0003UF-2d for qemu-devel@nongnu.org; Tue, 16 Mar 2021 23:53:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:59535) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lMNF4-00034o-9v for qemu-devel@nongnu.org; Tue, 16 Mar 2021 23:53:07 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-460-EDZjBrb5M_GnNyoTVlyT5g-1; Tue, 16 Mar 2021 23:52:57 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id ACC8618460E2; Wed, 17 Mar 2021 03:52:56 +0000 (UTC) Received: from localhost.net (ovpn-113-107.rdu2.redhat.com [10.10.113.107]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5039E5D9C0; Wed, 17 Mar 2021 03:52:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615953185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NALnShKsYl2q3B7a8PzusRjg/2/PLwai26rLiZcw7Wk=; b=IPNiAibqbuJaYNf1pCpImQChvAZEBtB3OQbl1YI0kUQtIRzlhDwEMhvSs0TQakCzBMuIPU M6L7NXULUvILz2/NrYpm+hNKnl1yjZphbhvU/KOWzsoUJU+QaP/yOm3PwMpifI8fOXKnfX LIzt7jweUS1cYwLvmW05VJgqwIwezns= X-MC-Unique: EDZjBrb5M_GnNyoTVlyT5g-1 From: Cleber Rosa To: Peter Maydell , qemu-devel@nongnu.org Subject: [PULL 3/5] avocado_qemu: add exec_command function Date: Tue, 16 Mar 2021 23:52:40 -0400 Message-Id: <20210317035242.24418-4-crosa@redhat.com> In-Reply-To: <20210317035242.24418-1-crosa@redhat.com> References: <20210317035242.24418-1-crosa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=crosa@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=crosa@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , John Snow , Wainer dos Santos Moschetta , Willian Rampazzo , Willian Rampazzo , Cleber Rosa , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Beraldo Leal Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Willian Rampazzo Sometimes a test needs to send a command to a console without waiting for a pattern as a result, or the command issued do not produce any kind of output, like, for example, a `mount` command. This introduces the `exec_command` function to the avocado_qemu, allowing the test to send a command to the console without the need to match a pattern produced as a result. Signed-off-by: Willian Rampazzo Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa Message-Id: <20210303205320.146047-2-willianr@redhat.com> Signed-off-by: Cleber Rosa --- tests/acceptance/avocado_qemu/__init__.py | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/a= vocado_qemu/__init__.py index ed338caaba9..ac8041821fa 100644 --- a/tests/acceptance/avocado_qemu/__init__.py +++ b/tests/acceptance/avocado_qemu/__init__.py @@ -93,7 +93,7 @@ def _console_interaction(test, success_message, failure_m= essage, if not msg: continue console_logger.debug(msg) - if success_message in msg: + if success_message is None or success_message in msg: break if failure_message and failure_message in msg: console.close() @@ -140,6 +140,18 @@ def wait_for_console_pattern(test, success_message, fa= ilure_message=3DNone, """ _console_interaction(test, success_message, failure_message, None, vm= =3Dvm) =20 +def exec_command(test, command): + """ + Send a command to a console (appending CRLF characters), while logging + the content. + + :param test: an Avocado test containing a VM. + :type test: :class:`avocado_qemu.Test` + :param command: the command to send + :type command: str + """ + _console_interaction(test, None, None, command + '\r') + def exec_command_and_wait_for_pattern(test, command, success_message, failure_message=3DN= one): """ --=20 2.30.2 From nobody Wed Nov 19 12:23:39 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1615953378; cv=none; d=zohomail.com; s=zohoarc; b=DpJtSl9cHjTk41EfTn3T7S+JUSfWrscDj3yMANOzz4XLu7lzX5MkatMnZjxonO2xVqZX3rlepf/5LPKJ4jxJddL/QY+q+XN1fejOh7ohtQO/jaXVDoTN0o3rA7RBdDa+HrFx1NQY3TydaTqJnMZWRrQOidosRHE6EEyViyfrFe8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615953378; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=j9Vl5xruJJBlbFXsoJIcF5JP8+Yl4Qas7pjnJ+nW5OU=; b=Jls+iA0yh6Ydx2VC2JmAxAuX6vP6FyfFj0JbgIkDbdGub/DrfFdbXO3dOpJWm4iF2QcC83E2yRtnJ5bXyNUxPyzQAfPb3NHK3wowzt+Mukz948LNkU0/vJ9WW03vWRFd8VIAGacJpVP6x7ojUXv61ynoo4Ud5jM2SXNhoCBEDZA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1615953378202440.50626909609014; Tue, 16 Mar 2021 20:56:18 -0700 (PDT) Received: from localhost ([::1]:50988 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMNI9-0007rJ-6A for importer@patchew.org; Tue, 16 Mar 2021 23:56:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40738) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMNF9-0003c6-Uu for qemu-devel@nongnu.org; Tue, 16 Mar 2021 23:53:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:27427) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMNF8-00036s-1r for qemu-devel@nongnu.org; Tue, 16 Mar 2021 23:53:11 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-37-Xh5rYL9SO9aPyqH8pBLsAw-1; Tue, 16 Mar 2021 23:53:06 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4178781744F; Wed, 17 Mar 2021 03:53:05 +0000 (UTC) Received: from localhost.net (ovpn-113-107.rdu2.redhat.com [10.10.113.107]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D03115D9C0; Wed, 17 Mar 2021 03:52:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615953189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j9Vl5xruJJBlbFXsoJIcF5JP8+Yl4Qas7pjnJ+nW5OU=; b=QhSLtE4wkrDofkmk6zKRA14Z6jQgbhYuOFefc7gnBwagLs0jjdT6veP78FqMiGS4vqlVSa owzYBc/viQ2a5FKaMrO1E459SD/43BBl5RAHVFrkql1NVSQNa6zfsP0Em/S7Q5Sd9AZgGA EhvQL8QP1sFVEQPF2cmSEPd2xkts0sw= X-MC-Unique: Xh5rYL9SO9aPyqH8pBLsAw-1 From: Cleber Rosa To: Peter Maydell , qemu-devel@nongnu.org Subject: [PULL 4/5] tests: Add functional test for out-of-process device emulation Date: Tue, 16 Mar 2021 23:52:41 -0400 Message-Id: <20210317035242.24418-5-crosa@redhat.com> In-Reply-To: <20210317035242.24418-1-crosa@redhat.com> References: <20210317035242.24418-1-crosa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=crosa@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=crosa@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Elena Ufimtseva , John G Johnson , Jagannathan Raman , Eduardo Habkost , John Snow , Stefan Hajnoczi , Wainer dos Santos Moschetta , Willian Rampazzo , Willian Rampazzo , Cleber Rosa , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Beraldo Leal Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Jagannathan Raman Runs the Avocado acceptance test to check if a remote lsi53c895a device gets identified by the guest. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Marc-Andr=C3=A9 Lureau [WR: Refactored code] Signed-off-by: Willian Rampazzo Tested-by: Wainer dos Santos Moschetta Reviewed-by: Stefan Hajnoczi Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa Message-Id: <20210303205320.146047-3-willianr@redhat.com> Signed-off-by: Cleber Rosa --- tests/acceptance/multiprocess.py | 95 ++++++++++++++++++++++++++++++++ 1 file changed, 95 insertions(+) create mode 100644 tests/acceptance/multiprocess.py diff --git a/tests/acceptance/multiprocess.py b/tests/acceptance/multiproce= ss.py new file mode 100644 index 00000000000..96627f022a8 --- /dev/null +++ b/tests/acceptance/multiprocess.py @@ -0,0 +1,95 @@ +# Test for multiprocess qemu +# +# This work is licensed under the terms of the GNU GPL, version 2 or +# later. See the COPYING file in the top-level directory. + + +import os +import socket + +from avocado_qemu import Test +from avocado_qemu import wait_for_console_pattern +from avocado_qemu import exec_command +from avocado_qemu import exec_command_and_wait_for_pattern + +class Multiprocess(Test): + """ + :avocado: tags=3Dmultiprocess + """ + KERNEL_COMMON_COMMAND_LINE =3D 'printk.time=3D0 ' + + def do_test(self, kernel_url, initrd_url, kernel_command_line, + machine_type): + """Main test method""" + self.require_accelerator('kvm') + + # Create socketpair to connect proxy and remote processes + proxy_sock, remote_sock =3D socket.socketpair(socket.AF_UNIX, + socket.SOCK_STREAM) + os.set_inheritable(proxy_sock.fileno(), True) + os.set_inheritable(remote_sock.fileno(), True) + + kernel_path =3D self.fetch_asset(kernel_url) + initrd_path =3D self.fetch_asset(initrd_url) + + # Create remote process + remote_vm =3D self.get_vm() + remote_vm.add_args('-machine', 'x-remote') + remote_vm.add_args('-nodefaults') + remote_vm.add_args('-device', 'lsi53c895a,id=3Dlsi1') + remote_vm.add_args('-object', 'x-remote-object,id=3Drobj1,' + 'devid=3Dlsi1,fd=3D'+str(remote_sock.fileno())) + remote_vm.launch() + + # Create proxy process + self.vm.set_console() + self.vm.add_args('-machine', machine_type) + self.vm.add_args('-accel', 'kvm') + self.vm.add_args('-cpu', 'host') + self.vm.add_args('-object', + 'memory-backend-memfd,id=3Dsysmem-file,size=3D2G') + self.vm.add_args('--numa', 'node,memdev=3Dsysmem-file') + self.vm.add_args('-m', '2048') + self.vm.add_args('-kernel', kernel_path, + '-initrd', initrd_path, + '-append', kernel_command_line) + self.vm.add_args('-device', + 'x-pci-proxy-dev,' + 'id=3Dlsi1,fd=3D'+str(proxy_sock.fileno())) + self.vm.launch() + wait_for_console_pattern(self, 'as init process', + 'Kernel panic - not syncing') + exec_command(self, 'mount -t sysfs sysfs /sys') + exec_command_and_wait_for_pattern(self, + 'cat /sys/bus/pci/devices/*/ueve= nt', + 'PCI_ID=3D1000:0012') + + def test_multiprocess_x86_64(self): + """ + :avocado: tags=3Darch:x86_64 + """ + kernel_url =3D ('https://archives.fedoraproject.org/pub/archive/fe= dora' + '/linux/releases/31/Everything/x86_64/os/images' + '/pxeboot/vmlinuz') + initrd_url =3D ('https://archives.fedoraproject.org/pub/archive/fe= dora' + '/linux/releases/31/Everything/x86_64/os/images' + '/pxeboot/initrd.img') + kernel_command_line =3D (self.KERNEL_COMMON_COMMAND_LINE + + 'console=3DttyS0 rdinit=3D/bin/bash') + machine_type =3D 'pc' + self.do_test(kernel_url, initrd_url, kernel_command_line, machine_= type) + + def test_multiprocess_aarch64(self): + """ + :avocado: tags=3Darch:aarch64 + """ + kernel_url =3D ('https://archives.fedoraproject.org/pub/archive/fe= dora' + '/linux/releases/31/Everything/aarch64/os/images' + '/pxeboot/vmlinuz') + initrd_url =3D ('https://archives.fedoraproject.org/pub/archive/fe= dora' + '/linux/releases/31/Everything/aarch64/os/images' + '/pxeboot/initrd.img') + kernel_command_line =3D (self.KERNEL_COMMON_COMMAND_LINE + + 'rdinit=3D/bin/bash console=3DttyAMA0') + machine_type =3D 'virt,gic-version=3D3' + self.do_test(kernel_url, initrd_url, kernel_command_line, machine_= type) --=20 2.30.2 From nobody Wed Nov 19 12:23:39 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1615953271; cv=none; d=zohomail.com; s=zohoarc; b=L7H0jV/xIJyJX93Att1LksG655HKVBTJHNdAn6obDkD73P7AtSWluICfk/RtBWi3JpbJYQw3a5MWyTuShkickCmZEOXvugufDg6euN3CYInNPIgaO2LRudXqvKsk+5kW/R5sX9Ab2mafmacKz11SyphRoCRCCWWZ064MpBZOK2U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615953271; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=8GKG3PiDrEQBJLCs+5Ktm4SczTf0D+iveHDe3qTuE3A=; b=nKzO9qWzRea01p1Ct0Ua99qFUJTr/p29oBpUrQ+evc8vPK5oyhye6N/vAGA1AzUV5ZjxpWWl5T80Dp0zJqJBUruIM8jQXkU1EhbMEq3ATC3akn1vvYi5c9R2aeMPteSuObbzHcSyBCnOTB5gM4okJlgs6NxzgNHQmGFkASwPokg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1615953271750354.27902742158744; Tue, 16 Mar 2021 20:54:31 -0700 (PDT) Received: from localhost ([::1]:45144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMNGQ-0005U1-Oc for importer@patchew.org; Tue, 16 Mar 2021 23:54:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40750) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMNFG-0003pS-N8 for qemu-devel@nongnu.org; Tue, 16 Mar 2021 23:53:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:57351) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMNFF-0003C6-3D for qemu-devel@nongnu.org; Tue, 16 Mar 2021 23:53:18 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-299-N-jETTgeO3aZjPj77ONdQA-1; Tue, 16 Mar 2021 23:53:13 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9B2DB107ACCD; Wed, 17 Mar 2021 03:53:12 +0000 (UTC) Received: from localhost.net (ovpn-113-107.rdu2.redhat.com [10.10.113.107]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 637475D9C0; Wed, 17 Mar 2021 03:53:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615953196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8GKG3PiDrEQBJLCs+5Ktm4SczTf0D+iveHDe3qTuE3A=; b=b88BBGutbFFnQcA35dvX+iSdKXJMW5lbb8k3o41PC6Q7KvTNn3UkMbEq/KJjs6Ua55ZvN9 76cY8BdHUgR3vf1PsP1vTapRcwUeZqwJEBRVic14sYmSiKyhKmaWEnrx+fKSE9fj32KCNy CUkaVWLWpnIRFfdwG958gQPTbh+T6UM= X-MC-Unique: N-jETTgeO3aZjPj77ONdQA-1 From: Cleber Rosa To: Peter Maydell , qemu-devel@nongnu.org Subject: [PULL 5/5] tests/acceptance: linux-related tests fix Date: Tue, 16 Mar 2021 23:52:42 -0400 Message-Id: <20210317035242.24418-6-crosa@redhat.com> In-Reply-To: <20210317035242.24418-1-crosa@redhat.com> References: <20210317035242.24418-1-crosa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=crosa@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=crosa@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pavel Dovgalyuk , Eduardo Habkost , John Snow , Wainer dos Santos Moschetta , Willian Rampazzo , Willian Rampazzo , Cleber Rosa , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Beraldo Leal Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Pavel Dovgalyuk This patch allows cloudinit images download when ssh key is not specified. Signed-off-by: Pavel Dovgalyuk Message-Id: <161373266228.1608713.7614311331725780044.stgit@pasha-ThinkPad-= X280> Reviewed-by: Willian Rampazzo Signed-off-by: Cleber Rosa --- tests/acceptance/avocado_qemu/__init__.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/a= vocado_qemu/__init__.py index ac8041821fa..83b1741ec85 100644 --- a/tests/acceptance/avocado_qemu/__init__.py +++ b/tests/acceptance/avocado_qemu/__init__.py @@ -317,8 +317,10 @@ def prepare_cloudinit(self, ssh_pubkey=3DNone): try: cloudinit_iso =3D os.path.join(self.workdir, 'cloudinit.iso') self.phone_home_port =3D network.find_free_port() - with open(ssh_pubkey) as pubkey: - pubkey_content =3D pubkey.read() + pubkey_content =3D None + if ssh_pubkey: + with open(ssh_pubkey) as pubkey: + pubkey_content =3D pubkey.read() cloudinit.iso(cloudinit_iso, self.name, username=3D'root', password=3D'password', --=20 2.30.2