From nobody Fri Dec 19 18:12:56 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1615905616; cv=none; d=zohomail.com; s=zohoarc; b=OnI+tS8MKM7gh22o/dDNO0DJ2i4oG1SMqcmZl4EQN2QSPqlhLEefx7ANCdtepZnEcMPFD+cuZZZkuCNcxWP4+/eV9RpodhrWObx228Api0qbFDj/OANBcpRRTYcr/sSD1E18necmAI7rsVYV/RkR6TT+cNP3k58BDfEqvNKLeL8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615905616; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=HenKwa4hoM0V49zGIkl82eGf1JLIKcUT10BtqC1W4jo=; b=N09VpqitOqr0Eo7QTiLHLA4IMEr5Cqu/1Nkh32l463+kyALlvI5MLqgyDKv/xMPZlCigT59k5WyMQIczCXqc2u5lDKW4WUAJR/6JMKDHNHlqzXl2X3y/Fj1TH2JRfGT2iazPu7MTrJg3aPe+W9il1VuXMrc0gn6oNyj7m5tIHNI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1615905616261551.9615024735937; Tue, 16 Mar 2021 07:40:16 -0700 (PDT) Received: from localhost ([::1]:59018 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMArl-0005JH-KM for importer@patchew.org; Tue, 16 Mar 2021 10:40:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMApy-0003dm-Gz for qemu-devel@nongnu.org; Tue, 16 Mar 2021 10:38:22 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:33294) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lMApw-0002Ab-O5 for qemu-devel@nongnu.org; Tue, 16 Mar 2021 10:38:22 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-424-zfOeyHqxMzyW8l_gOTzJBw-1; Tue, 16 Mar 2021 10:38:18 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8175C100C665 for ; Tue, 16 Mar 2021 14:38:17 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-141.ams2.redhat.com [10.36.112.141]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CA04C5B4B6; Tue, 16 Mar 2021 14:38:13 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 579CF180062A; Tue, 16 Mar 2021 15:38:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615905500; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HenKwa4hoM0V49zGIkl82eGf1JLIKcUT10BtqC1W4jo=; b=VK2SwZZdXL8aNZWZL/toMRkPAVysjEFvhYdLjeSORo9/21DObjbw3t29nbNHtJ/+4FYd6+ vmZi0t1xzOhd0ahFsheuquGMXZ5QFeVqQdCVwNvBiCnsAqW3qYHV7xvxZ1mi+drVA3KsNI z90PsF2dqckOYTCc27n0Oz1mqG1G8lI= X-MC-Unique: zfOeyHqxMzyW8l_gOTzJBw-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PATCH 3/9] edid: move xtra3 descriptor Date: Tue, 16 Mar 2021 15:38:06 +0100 Message-Id: <20210316143812.2363588-4-kraxel@redhat.com> In-Reply-To: <20210316143812.2363588-1-kraxel@redhat.com> References: <20210316143812.2363588-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Initialize the "Established timings III" block earlier. Also move up edid_fill_modes(). That'll make sure the offset for the additional descriptors in the dta block don't move any more, which in turn makes it easier to actually use them. Signed-off-by: Gerd Hoffmann --- hw/display/edid-generate.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/hw/display/edid-generate.c b/hw/display/edid-generate.c index ef7a70fc9654..259ef7315217 100644 --- a/hw/display/edid-generate.c +++ b/hw/display/edid-generate.c @@ -415,25 +415,28 @@ void qemu_edid_generate(uint8_t *edid, size_t size, width_mm, height_mm); desc =3D edid_desc_next(edid, dta, desc); =20 + xtra3 =3D desc; + edid_desc_xtra3_std(xtra3); + desc =3D edid_desc_next(edid, dta, desc); + edid_fill_modes(edid, xtra3, dta, info->maxx, info->maxy); + /* + * dta video data block is finished at thus point, + * so dta descriptor offsets don't move any more. + */ + edid_desc_ranges(desc); desc =3D edid_desc_next(edid, dta, desc); =20 - if (info->name) { + if (desc && info->name) { edid_desc_text(desc, 0xfc, info->name); desc =3D edid_desc_next(edid, dta, desc); } =20 - if (info->serial) { + if (desc && info->serial) { edid_desc_text(desc, 0xff, info->serial); desc =3D edid_desc_next(edid, dta, desc); } =20 - if (desc) { - xtra3 =3D desc; - edid_desc_xtra3_std(xtra3); - desc =3D edid_desc_next(edid, dta, desc); - } - while (desc) { edid_desc_dummy(desc); desc =3D edid_desc_next(edid, dta, desc); @@ -441,7 +444,6 @@ void qemu_edid_generate(uint8_t *edid, size_t size, =20 /* =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D finish up =3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ =20 - edid_fill_modes(edid, xtra3, dta, info->maxx, info->maxy); edid_checksum(edid); if (dta) { edid_checksum(dta); --=20 2.30.2