From nobody Sun May 19 06:23:06 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1615883068; cv=none; d=zohomail.com; s=zohoarc; b=AQvLhdj4DEND8yp4wj362UcKKmlpcUa6gyzDvfmfEmPoGm+wb1Dol4Srn3SrdcLuHgBhK5BzudgtqYpx5wWXDgu8a1AebftYqotnV14f/dHFFqxJHMhbqCImTiZohK/5aToh4gcrMYxsXM3zCqvSbgEfjbTatP82Golqs1+zDoE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615883068; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To; bh=cmN5NzO57LfWfprzjE4bCEYT68GRBf/RW6A3lofTxXY=; b=HoJZ1zwvXqSlWBIiSepNk6zo5W4f3A91H6SqCbeG8O/bs1iBdXTQyEAdQGcadHi2YMqFWQ0dRswz/lz5eso+VZ22yw2371MSi5mKIqKFce+Gf5L8s8iXpZ6rFXEc8QQTxhyHOR8kJKCpHhVr8AHXyg3rznH5hAToqCZ5lQaEmpg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1615883068835329.1943899729241; Tue, 16 Mar 2021 01:24:28 -0700 (PDT) Received: from localhost ([::1]:52598 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lM507-0003G5-QC for importer@patchew.org; Tue, 16 Mar 2021 04:24:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39958) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lM4rE-0005ev-GR; Tue, 16 Mar 2021 04:15:16 -0400 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:40911) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lM4rC-0000Wk-QH; Tue, 16 Mar 2021 04:15:16 -0400 Received: by mail-ed1-x52e.google.com with SMTP id b16so7637584eds.7; Tue, 16 Mar 2021 01:15:14 -0700 (PDT) Received: from pek-vx-bsp9.wrs.com (ec2-44-242-66-180.us-west-2.compute.amazonaws.com. [44.242.66.180]) by smtp.gmail.com with ESMTPSA id l10sm9778367edr.87.2021.03.16.01.15.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Mar 2021 01:15:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=cmN5NzO57LfWfprzjE4bCEYT68GRBf/RW6A3lofTxXY=; b=VYQoXJWVpFMgZvORBe3D8isRsM6n7lFPJc+Xbw1i/6MSOV1VwxM5vV5UdgwS/vfLu5 qdlK0KHgf0zYkyExyBSoNNjBtTGKO6WX/8NfZEXkAHilCLfWwT6+DdQgF7Ks6qZIJcL1 cSxfBAoc1PzA9u0GCBTNriTN7vOrvzzAyCmmWgl0ApfuICq2iwUORNEfobtQLkM4Szft /u8PLde5eCi+PElLdXVZa/MUe5QpwpNY0+x8TFIHVGS15pBtyasR09hSD9EGpeT4TKhY GuR5B3Tu3e72GWY8KxDP4SUKTU4QiG0+JA4g/WDwOJywzm0UfFAKj8msmU9Qz6YlJYMi c94Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=cmN5NzO57LfWfprzjE4bCEYT68GRBf/RW6A3lofTxXY=; b=UtPU+FJCLVOVTVyTiCiVImF7u9ENGH3DzljsimX4jH4fE3G9lbKjOjVzIlWcDNeUDv lb56jgAd+hGKHRUi/V1jMkSfoDtPP4YowKnlhkbtSCNsK347eBBzcn1zOnZb6NUdxXxX m5/G8y8Fc3T0B0RTdL5uohCzZUQdll8y13C2u1opIDQCMOftWjsacaNL3dDPEJeuL6lJ zu/IVtBKzfiy4sJqoMiKVs6i2gX6rIIQRsLNlY5UNgCbj033+MlfVFG909gNHhvCKak0 HP1vk5NPE3pXyMv2flhz4f4eckGl+j+lAHf+v6Mo8r/ocCJmlT6GfDnhh6F6WMjgeeu1 AQzQ== X-Gm-Message-State: AOAM532LBRmHmU4dVBmXeFLsf+eZI/6SSdDPj+Dv/vmCc1Lpf7+f2dC1 +j+UC7aI3WUcxJyMbFkrJog= X-Google-Smtp-Source: ABdhPJzqUUr+3R4gVQOfKYaxtJzA37VLFDdx4PIVbyuJOjoDyutef/x6MeqhK4MxIHbzHLoeHLlw3g== X-Received: by 2002:aa7:c447:: with SMTP id n7mr34158408edr.171.1615882512967; Tue, 16 Mar 2021 01:15:12 -0700 (PDT) From: Bin Meng To: David Gibson , Greg Kurz , Jason Wang Subject: [PATCH] hw/net: fsl_etsec: Tx padding length should exclude CRC Date: Tue, 16 Mar 2021 16:15:05 +0800 Message-Id: <20210316081505.72898-1-bmeng.cn@gmail.com> X-Mailer: git-send-email 2.17.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::52e; envelope-from=bmeng.cn@gmail.com; helo=mail-ed1-x52e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" As the comment of tx_padding_and_crc() says: "Never add CRC in QEMU", min_frame_len should excluce CRC, so it should be 60 instead of 64. Signed-off-by: Bin Meng --- hw/net/fsl_etsec/rings.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/fsl_etsec/rings.c b/hw/net/fsl_etsec/rings.c index d6be0d7d18..8f08446415 100644 --- a/hw/net/fsl_etsec/rings.c +++ b/hw/net/fsl_etsec/rings.c @@ -259,7 +259,7 @@ static void process_tx_bd(eTSEC *etsec, || etsec->regs[MACCFG2].value & MACCFG2_PADCRC) { =20 /* Padding and CRC (Padding implies CRC) */ - tx_padding_and_crc(etsec, 64); + tx_padding_and_crc(etsec, 60); =20 } else if (etsec->first_bd.flags & BD_TX_TC || etsec->regs[MACCFG2].value & MACCFG2_CRC_EN) { --=20 2.17.1