From nobody Fri May 17 13:50:40 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1615806005; cv=none; d=zohomail.com; s=zohoarc; b=Knhjg4w816JBg7FJ5MCEwpu0ZFMQVNZpV29DMZ0Jj2SRHTOXdcz/WBIALLmVRdTgHo69zFr9dvI0vMZ3pQ6MMdypqJq+tOVsBM99pYRYczLyalTonC1/vPs270NzMaQ5WJtw1R6tLn0EYY2qFEfGfo+oSsX2F9cVk/ZYw7pJtw4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615806005; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=QLRHiNpkcTmo6+f9Ptw2jEnPaJLV4SaZu1YpyKV8U/U=; b=m72PH8wBOhxkV6O/R/kIU2C4TyF3pIM4G8j9YOLuyWL/7G8QDI+57CXcKyH4nGEZG6vBd2JnfiiPatFyLcj25wYIiIRX9TzXDFpeNhhs+RBkHcIHYkF5z+euTAnByxad64QZGQ+v5NX1JLYavGFk/AYjOMOUfg/t5WJtSI0Sby0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1615806005083278.04369073491785; Mon, 15 Mar 2021 04:00:05 -0700 (PDT) Received: from localhost ([::1]:39036 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLkx9-0001Xi-RH for importer@patchew.org; Mon, 15 Mar 2021 07:00:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58582) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLkvu-0000Gn-66 for qemu-devel@nongnu.org; Mon, 15 Mar 2021 06:58:46 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:43047) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lLkvs-00035U-DM for qemu-devel@nongnu.org; Mon, 15 Mar 2021 06:58:45 -0400 Received: by mail-wr1-x435.google.com with SMTP id w11so8412868wrr.10 for ; Mon, 15 Mar 2021 03:58:43 -0700 (PDT) Received: from localhost.localdomain ([197.61.219.7]) by smtp.googlemail.com with ESMTPSA id r11sm18538747wrm.26.2021.03.15.03.58.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Mar 2021 03:58:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QLRHiNpkcTmo6+f9Ptw2jEnPaJLV4SaZu1YpyKV8U/U=; b=A2x7L9hm+jeuQRBd9UaW+ovqOOdPN/AEnTi/GQHA8hQ54jA+qN2GljjEHc7NFbF4gA DEToSoXZTRSmcD5iJW+tSH5oDxSvYjnavNa5XBQu92lAOQSJkwh8PjjmnbUGljT/Bdui BnwZ5lNOjDbf5DHt94YxKVuohQJ1kbkKwvhkdI7s9UHDNtKC6tsexQxQYeglM9sqy9mU MmKlI3/1Wj6018O1f3tQpX7QKY5+WZfvcQcQGu6REbsYmcSqlGb5PDTrxZHLH90w4k8s RFZUYeANacT8QQMguRhW3gbgwNzdC/2S4c3+FYWnIrhP2RMe6U38D+q1ODOpzxojTkVt Ko9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QLRHiNpkcTmo6+f9Ptw2jEnPaJLV4SaZu1YpyKV8U/U=; b=WXV+4gvkTDNkXlLMuZR/AVZ/f9Hr7KdHpokdxXGrMjoBJACU/zOhVnehv8HtnCB+LH mXj6BtnHAbzEXI11tZDuSlDUBvSfpqVKlkDAv8+xHn3dSaWGp4Jq06mnjXNPqJM3VkPQ CtSUO8skh4NG7GzbQrDRmjUxE9yGFjdrn8f5dUkc+i2glglGJz7sYqS1ITVO+DHt+MA1 swo6koSa+oY7eC60AnDR4M7xFbHaOBEoK1l8WRF4PEVjZN/9CyNJDQ/xMyuIw2YyY5BH 9n2m2GhasqoeJFubfMQshAv6vpItKXUWptmYhLJOa6Y89gtKacir3wTGYQ+KPDEZ9a9L JFmA== X-Gm-Message-State: AOAM532xRXYKyhC1KOGi4AeSs0EhbrQ0JbPdtsg/5NSPDV79DNOajQRy Rg60jwLzJfZxMLdqeuf468jWSYsweAo= X-Google-Smtp-Source: ABdhPJyStcIT/5BpezBJdd/CRT0NOjo6zGnWnQqLFC5upXNRQhsvQSZ/4bHrJJaCv6SZvtY6QpQqNg== X-Received: by 2002:a5d:684d:: with SMTP id o13mr27698474wrw.235.1615805922588; Mon, 15 Mar 2021 03:58:42 -0700 (PDT) From: Mahmoud Mandour To: qemu-devel@nongnu.org Subject: [PATCH 1/2] util/compatfd.c: Fixed style issues Date: Mon, 15 Mar 2021 12:58:13 +0200 Message-Id: <20210315105814.5188-2-ma.mandourr@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210315105814.5188-1-ma.mandourr@gmail.com> References: <20210315105814.5188-1-ma.mandourr@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=ma.mandourr@gmail.com; helo=mail-wr1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mahmoud Mandour Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) Content-Type: text/plain; charset="utf-8" Fixed two styling issues that caused checkpatch.pl errors. Signed-off-by: Mahmoud Mandour Reviewed-by: Thomas Huth --- util/compatfd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/util/compatfd.c b/util/compatfd.c index ee47dd8089..174f394533 100644 --- a/util/compatfd.c +++ b/util/compatfd.c @@ -20,8 +20,7 @@ #include #endif =20 -struct sigfd_compat_info -{ +struct sigfd_compat_info { sigset_t mask; int fd; }; @@ -53,8 +52,9 @@ static void *sigwait_compat(void *opaque) =20 len =3D write(info->fd, (char *)&buffer + offset, sizeof(buffer) - offset); - if (len =3D=3D -1 && errno =3D=3D EINTR) + if (len =3D=3D -1 && errno =3D=3D EINTR) { continue; + } =20 if (len <=3D 0) { return NULL; --=20 2.25.1 From nobody Fri May 17 13:50:40 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1615806005; cv=none; d=zohomail.com; s=zohoarc; b=gehLAQjDwRucfRK6SI2ioH8MSYOzVkgiM1bSWrpznYCvBpV84dfIWgJVeIfDJIT1Aax3tccGIF4WecogtV+07+bjFR0JQ4dogsAqS9I43hyXxOqPEOFXGQJxbfn7vGwSzyoeifXbshBYwSeZl+UOpdYbO5XkSnESLSRpYN8aXns= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615806005; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vOl85i3gsnl4nScUKWxpWtvzRuoZf1YV+64Qg7MEYQw=; b=WNYjMULkaa51AadxHAtSLJJpL4yZB4UiRnFenpanC0A9FLhn109P5FVrMfnKq35+KBTDgMUrJPOCe00ALTVY70fZz7iZgkpROIYwiQ2eZxszOLxA9Vq9rmmeN5s/OTPJX9WdF3IfLqFgScSZHDh2Z10OoJBV3tFQuZ9efy43pNg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1615806005396148.79667973218523; Mon, 15 Mar 2021 04:00:05 -0700 (PDT) Received: from localhost ([::1]:39054 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLkxA-0001Y0-7r for importer@patchew.org; Mon, 15 Mar 2021 07:00:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58604) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLkvv-0000Gz-D7 for qemu-devel@nongnu.org; Mon, 15 Mar 2021 06:58:47 -0400 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:36625) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lLkvt-00036M-2g for qemu-devel@nongnu.org; Mon, 15 Mar 2021 06:58:47 -0400 Received: by mail-wm1-x331.google.com with SMTP id r15-20020a05600c35cfb029010e639ca09eso19988419wmq.1 for ; Mon, 15 Mar 2021 03:58:44 -0700 (PDT) Received: from localhost.localdomain ([197.61.219.7]) by smtp.googlemail.com with ESMTPSA id r11sm18538747wrm.26.2021.03.15.03.58.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Mar 2021 03:58:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vOl85i3gsnl4nScUKWxpWtvzRuoZf1YV+64Qg7MEYQw=; b=Pc0OIAnyVK410jgjFMy2YFQt/I0kvE1tE8AVR2He1l/8Gzor2NUz/qe5R0zS8RiLQq +6s2udBLtCymgNpobqwSMR7CJ92yuz9Ew+IrBhaTUqSxT1tVgldvwHFePku6YiFRlcgE +9DOcP4vwvLBQwRoyasYZTf1jIOTIoMrhEcHRNd+KU6JOU82i3FK0f0tMsAJdYuNODSy ON02De7+JXlFd19Fe8WX/10yKZnVVjrJaYDW5v1StcSj3xwldtselS5NwzIomKSNXdYs UPIUwmgcy5Bb/vv8a4qDkiJPHMMV8z+0t1kQW6I+KZu4pgpAXqO1SA3MceQ7FnESRoGq GiUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vOl85i3gsnl4nScUKWxpWtvzRuoZf1YV+64Qg7MEYQw=; b=D+oAnikfiLaACJXzE0eMZYa2UiCJe4J9QIvxjgxcXQqypUZS1M4lVDpjEa4jpHwm1l LBzagaNyltDJS6ezVDsDzJlh97yTxm+0lrUD31rUop4GxU34Nf2kK4CByWwC9v1Ys/SP dpqYXELQEe1KaHzUgNKrciP0ilAHcGuFw2sUjijA+M9WnclBMhWILFLK3vqQ+3iZEMx0 I7zSb6IKKaw5TW/05bU+rgWybeTDQFZOLljIsi4BpNHAN8AK6Noleavtww8oFx8bKv7e U0G+hUAxNBloL9giC+y1su/1CErM0Gsb9ngobQQqYZ0X6syhhm2hkREWkUFR1JfwJ9iB KXKQ== X-Gm-Message-State: AOAM530PxUxTpxxPmQpzagwevLuflpeKKJkw0WvP8hdGlrk99dv9VBxr CFyzIw7cISrI5lakk0Juf9xECRmvG2c= X-Google-Smtp-Source: ABdhPJzCBRgyi3lu+XMQaZPLC/Yg1lhKTv5zUv8XxohKQxKym/mR7YQtcxS4vrz43XaU2FsYRJyFiA== X-Received: by 2002:a7b:cc0c:: with SMTP id f12mr25651455wmh.111.1615805923592; Mon, 15 Mar 2021 03:58:43 -0700 (PDT) From: Mahmoud Mandour To: qemu-devel@nongnu.org Subject: [PATCH 2/2] util/compatfd.c: Replaced a malloc call with g_malloc. Date: Mon, 15 Mar 2021 12:58:14 +0200 Message-Id: <20210315105814.5188-3-ma.mandourr@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210315105814.5188-1-ma.mandourr@gmail.com> References: <20210315105814.5188-1-ma.mandourr@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=ma.mandourr@gmail.com; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mahmoud Mandour Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) Content-Type: text/plain; charset="utf-8" Replaced a call to malloc() and its respective call to free() with g_malloc() and g_free(). g_malloc() is preferred more than g_try_* functions, which return NULL on error, when the size of the requested allocation is small. This is because allocating few bytes should not be a problem in a healthy system. Otherwise, the system is already in a critical state. Subsequently, removed NULL-checking after g_malloc(). Signed-off-by: Mahmoud Mandour Reviewed-by: Thomas Huth --- util/compatfd.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/util/compatfd.c b/util/compatfd.c index 174f394533..a8ec525c6c 100644 --- a/util/compatfd.c +++ b/util/compatfd.c @@ -72,14 +72,10 @@ static int qemu_signalfd_compat(const sigset_t *mask) QemuThread thread; int fds[2]; =20 - info =3D malloc(sizeof(*info)); - if (info =3D=3D NULL) { - errno =3D ENOMEM; - return -1; - } + info =3D g_malloc(sizeof(*info)); =20 if (pipe(fds) =3D=3D -1) { - free(info); + g_free(info); return -1; } =20 --=20 2.25.1