From nobody Fri May 17 17:01:47 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1615803331; cv=none; d=zohomail.com; s=zohoarc; b=O63h/j3osk8vOCbfyqdENy6KuM+lFJ2LSE9OGNbdujxSZmfHGrJcTOn1ETMs3Pmg3Fvz8HLpEPfBZg+LVh9aVBUpunnaCuyfemoA+sHobp8+Pld5Q1DXe8DUJedztyEFQkQ4Huy1bLCnearAIPEzYMVq2pwSY1eHyLOE2uD8t7o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615803331; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=attpSJGt8A80LJMSbNjtOADKaRS3S0o+HwNEAckWeUE=; b=UMxMVLtUqPE4hEsY0cVPdpw5xN3kJ4EX9MO3/HRE9UYDNn7SXIilxB+DDEusw0ucrx0XVdzrfAUkgAqYqJDkjV0EJsu/5DUh3p9fiRN3rgKsOGZusduGynGaEDC9sdflpnePnbx04t6Eu5L6ekLWdk2T8xb32rB0280RqhSK+aE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1615803331693522.1666471857649; Mon, 15 Mar 2021 03:15:31 -0700 (PDT) Received: from localhost ([::1]:47008 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLkG2-000462-MW for importer@patchew.org; Mon, 15 Mar 2021 06:15:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49106) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLkEd-0002z9-0M for qemu-devel@nongnu.org; Mon, 15 Mar 2021 06:14:03 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:26351) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lLkEa-0000sf-0o for qemu-devel@nongnu.org; Mon, 15 Mar 2021 06:14:01 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-368-mvLFuEZxOdK2jQTH4TvGNg-1; Mon, 15 Mar 2021 06:13:56 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2ADAE1858F16 for ; Mon, 15 Mar 2021 10:13:55 +0000 (UTC) Received: from workimage2020.rezanina.moe.rezanina.moe (unknown [10.40.193.51]) by smtp.corp.redhat.com (Postfix) with ESMTP id 203AA2719A; Mon, 15 Mar 2021 10:13:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615803237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=attpSJGt8A80LJMSbNjtOADKaRS3S0o+HwNEAckWeUE=; b=G2xr+hCm7T+uDg2gegfcfnrcS/7mQMFgVDV7qVDAHd6OdklRsmHxBdCYKi/Q+e7kvKyK32 3cntlfySt/LwqyLuJLy+ilS9phucv3woO4emg0pCv7r3E7lZ+UpWyTsNqzT+cKgyMM+v3C vfJe7yBpUlqv9Zi4xFbpNh02WdZfXBo= X-MC-Unique: mvLFuEZxOdK2jQTH4TvGNg-1 From: mrezanin@redhat.com To: qemu-devel@nongnu.org Subject: [PATCH v3] Add missing initialization for g_autofree variables Date: Mon, 15 Mar 2021 11:13:52 +0100 Message-Id: <20210315101352.152888-1-mrezanin@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mrezanin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=mrezanin@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Cornelia Huck Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Miroslav Rezanina When declaring g_autofree variable without inicialization, compiler will raise "may be used uninitialized in this function" warning due to automatic free handling. This is mentioned in docs/devel/style.rst (quote from section "Automatic memory deallocation"): * Variables declared with g_auto* MUST always be initialized, otherwise the cleanup function will use uninitialized stack memory Add inicialization for these declarations to prevent the warning and comply with coding style. Signed-off-by: Miroslav Rezanina Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth Tested-by: Matthew Rosato --- * v3: -- allocate in s390_pci_update_dma_avail instead of NULL init * v2: -- Removed fixes in hw/remote/memory.c and hw/remote/proxy.c fixed by patch sent by Zenghui Yu (multi-process: Initialize variables declared with g_auto*) --- hw/s390x/s390-pci-vfio.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/s390x/s390-pci-vfio.c b/hw/s390x/s390-pci-vfio.c index ead4f222d5..2a153fa8c9 100644 --- a/hw/s390x/s390-pci-vfio.c +++ b/hw/s390x/s390-pci-vfio.c @@ -29,14 +29,11 @@ */ bool s390_pci_update_dma_avail(int fd, unsigned int *avail) { - g_autofree struct vfio_iommu_type1_info *info; - uint32_t argsz; + uint32_t argsz =3D sizeof(struct vfio_iommu_type1_info); + g_autofree struct vfio_iommu_type1_info *info =3D g_malloc0(argsz); =20 assert(avail); =20 - argsz =3D sizeof(struct vfio_iommu_type1_info); - info =3D g_malloc0(argsz); - /* * If the specified argsz is not large enough to contain all capabilit= ies * it will be updated upon return from the ioctl. Retry until we have @@ -230,7 +227,7 @@ static void s390_pci_read_pfip(S390PCIBusDevice *pbdev, */ void s390_pci_get_clp_info(S390PCIBusDevice *pbdev) { - g_autofree struct vfio_device_info *info; + g_autofree struct vfio_device_info *info =3D NULL; VFIOPCIDevice *vfio_pci; uint32_t argsz; int fd; --=20 2.27.0