From nobody Tue Feb 10 11:14:52 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1615745284; cv=none; d=zohomail.com; s=zohoarc; b=Fbhj1RZaqh94Wy6XO5/onunKjQHzZ/JhVqVnaPX3fSSge2PReQabzmWkWGS14yFR2cyXAA89nmZpAAk+QcboX0jvEou+FAaxbsCZUWjkFl+nYOfd2BlgyLCXWfyq5xfjl8ydCAlIV+Nycay3X9DSpVdEA/+BQvDDrKZHjVscNI4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615745284; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+NXtQw9hpPp+VCgrduDja0oQSnznjQ9crwR/vZ//mYY=; b=bFemjR1lj3KcImcaDVx0v3bFKw5NpqSf79vADsW8zCEqbtqXONoIUPR7mIpWvfjJXKRWmZTSL9P0P/b9tVKJcl6OG/FE2Ds2Nfw1uMQ8ICoCdi69ql68LM5wNGzuHsxzMDfXuVWUz8pkhNmKqK4LWxZmjCY8lS05d1jPs94jFyQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1615745284022324.5319975084318; Sun, 14 Mar 2021 11:08:04 -0700 (PDT) Received: from localhost ([::1]:51316 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLV9m-000092-Pa for importer@patchew.org; Sun, 14 Mar 2021 14:08:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48434) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLV1U-0002BI-Ah for qemu-devel@nongnu.org; Sun, 14 Mar 2021 13:59:28 -0400 Received: from mail-qt1-x82d.google.com ([2607:f8b0:4864:20::82d]:42545) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lLV1G-00028E-N9 for qemu-devel@nongnu.org; Sun, 14 Mar 2021 13:59:28 -0400 Received: by mail-qt1-x82d.google.com with SMTP id l13so7657564qtu.9 for ; Sun, 14 Mar 2021 10:59:14 -0700 (PDT) Received: from localhost.localdomain (fixed-187-189-51-144.totalplay.net. [187.189.51.144]) by smtp.gmail.com with ESMTPSA id c127sm10216240qkd.87.2021.03.14.10.59.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Mar 2021 10:59:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+NXtQw9hpPp+VCgrduDja0oQSnznjQ9crwR/vZ//mYY=; b=iCM8bSzTKdYITmEQEJAGPbZXZEc8almMrR4wb+ut32XGVIb4W/jFVmtR8MhN+YmXCZ EjifYoNQOIFmKPbgmg8Y5lA2F8fAlU+SlPglkmRb8LkTvzM5T0qzZQHO+sEoPAjzsZk3 qqIl96yXTnyhHU0eIuIrb3IuIRo0MY1zKL8M8JwLlcObgHNI8Zxlb/J4wEVX347ROL3Z XDE8R5LsMg2GO2GERxvygRHDYCKphBxsH5lg59oUavPRHj0r0C6KhbzNCbWartYwblKu gGQrLVtE6yLE5vLrlg/QQKigPahdP10L2v83ezPsHz5rTNSbrG2P/E7zdN1Kg2naCZvC rn5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+NXtQw9hpPp+VCgrduDja0oQSnznjQ9crwR/vZ//mYY=; b=WAP+TxMMfGmmYPkERYk+rIEoY5ka00VSxJjJwA3xuMyeHcYOTBfJn1vKwlJmbYbxuZ RASxFhNRFbfs/ps2Of4RljH+47LEPNM/8c3yCXOF05HhPRb01Z/b3+XIhyrnn77v4TTS XgVGPkrKsmWZ+xF+wzfDIyCYdS9ugg481ge5LLSXisPpMlayktTS6oYWr+3msmlWG7Cj GnWL6AeA18pai59wed/VfrC2CAL+tqu/XOSbzKQj6t7ZLxorFmBkH/xw7WHhNTPaLFVx MwQ33r8l5fEhxf8PKcU4/ujto9ARUkL3zd/Op8ktPQM54dK2P1fvxGbIY0fTskhUoKX+ RN7Q== X-Gm-Message-State: AOAM5326EhPh36mtdEK0qGMdQbSRmsznkprZWAyXuvWVxMWjeR+qgwBV pWtVVvIPbnpBZq1SM1Jo+198w26pjrnr3dH5 X-Google-Smtp-Source: ABdhPJx1yyBV//bFI3Lf58VRlDfUHoIrQIcwbSf6Msh4Dl06SU/kbMOLthcEaSnMpJZMli3DcChRZA== X-Received: by 2002:a05:622a:1748:: with SMTP id l8mr4552820qtk.73.1615744753834; Sun, 14 Mar 2021 10:59:13 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v3 04/16] target/ppc: Do not call hreg_compute_mem_idx after ppc_store_msr Date: Sun, 14 Mar 2021 11:58:54 -0600 Message-Id: <20210314175906.1733746-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210314175906.1733746-1-richard.henderson@linaro.org> References: <20210314175906.1733746-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::82d; envelope-from=richard.henderson@linaro.org; helo=mail-qt1-x82d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ivan@vmfacility.fr, qemu-ppc@nongnu.org, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" In ppc_store_msr we call hreg_compute_hflags, which itself calls hreg_compute_mem_idx. Rely on ppc_store_msr to update everything required by the msr update. Signed-off-by: Richard Henderson --- target/ppc/machine.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/target/ppc/machine.c b/target/ppc/machine.c index 87d7bffb86..f6eeda9642 100644 --- a/target/ppc/machine.c +++ b/target/ppc/machine.c @@ -125,9 +125,6 @@ static int cpu_load_old(QEMUFile *f, void *opaque, int = version_id) env->msr ^=3D env->msr_mask & ~((1ULL << MSR_TGPR) | MSR_HVB); ppc_store_msr(env, msr); =20 - /* Recompute mmu indices */ - hreg_compute_mem_idx(env); - return 0; } =20 @@ -418,14 +415,12 @@ static int cpu_post_load(void *opaque, int version_id) =20 /* * Invalidate all supported msr bits except MSR_TGPR/MSR_HVB - * before restoring + * before restoring. Note that this recomputes hflags and mem_idx. */ msr =3D env->msr; env->msr ^=3D env->msr_mask & ~((1ULL << MSR_TGPR) | MSR_HVB); ppc_store_msr(env, msr); =20 - hreg_compute_mem_idx(env); - return 0; } =20 --=20 2.25.1