From nobody Mon Feb 9 00:01:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1615692416; cv=none; d=zohomail.com; s=zohoarc; b=bauB2xkbWHLqBpY5euR+f/pmPoabnxIAi9PquIRnT4bQSYRRL3L56jy0YjQRHnHz07OvcZAhrQMuCmOoxTFzmRbCBLQyTB5pquDGqPQ/HTMUp6A6zHq+HY/d5cspOZmZ+tM3xXMd7wMyi3vDQF+Kmw4KHD2Fnwuro3gLYJ1wmkA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615692416; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=jsATIuWJVLsP36O5rVx7aqqo47uS9kRVIQPzX/a9z+M=; b=HJOFj6trjWbniqA9hi3UMA/cTf/wWCHM5K7tBAU/Ehemv77rUFvLqDVW/04vcsdjFRAksW+rEhPDieg6Pds2anQI1tYyuleyuMPXcYnRcFL/G4hQeD1v5+6oIg5T287jIsChVBwoqhBRsb24yzMoj6XhbA7rn4714PcK9aoRNxE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 161569241685660.4006332275643; Sat, 13 Mar 2021 19:26:56 -0800 (PST) Received: from localhost ([::1]:43142 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLHP5-0000mz-St for importer@patchew.org; Sat, 13 Mar 2021 22:26:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48920) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLHMH-0006V2-6C for qemu-devel@nongnu.org; Sat, 13 Mar 2021 22:24:01 -0500 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:37658) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lLHMF-0004Qa-8F for qemu-devel@nongnu.org; Sat, 13 Mar 2021 22:24:00 -0500 Received: by mail-wm1-x331.google.com with SMTP id f22-20020a7bc8d60000b029010c024a1407so18142586wml.2 for ; Sat, 13 Mar 2021 19:23:58 -0800 (PST) Received: from localhost.localdomain ([197.61.164.30]) by smtp.googlemail.com with ESMTPSA id e1sm14922249wrd.44.2021.03.13.19.23.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Mar 2021 19:23:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jsATIuWJVLsP36O5rVx7aqqo47uS9kRVIQPzX/a9z+M=; b=h47gePfWpVLTlLPeqZkKtPpprzcttqNm4iqD709FU3AmUNx5hZF7Ma5GzOUvsuXdE0 x4mwtwFfcDugY+XLj22iWPLYPll3qqoyQw46nZzht2aqWaYbUoelLvO0hvlNB6u9LXh7 74GU9z+9h4A1Vf/fYlj0nb6hIFvaqSN45IBa8eJzXtitgwW2GkRMCW5lUiKPt7ffFeRH LcXqbDX3TQyRXAjIe3841bnbXBV2SUwfq0S44Ul+Rq6cl/QlDGNRkwXMN0MuCbIW77w/ 6thnQtdpZ2tR3XigZTxAOhpUloTSj69BmJIG03aJbVHkXSLk2nOEwzaCvBRUpRPfCIkq nmQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jsATIuWJVLsP36O5rVx7aqqo47uS9kRVIQPzX/a9z+M=; b=DXILvivAyzEG6VRgb0B49H0FDgX0sfMc4ZpqxaS9OfEUHbLUq8IJmhIzWF1CmGq7ih 1kYVaDYd2xCDmFQuMa7rmts2Ll4a0rTEX2w6LzkSHz/rAXcoeokwROtMlyQ/SV3ImCdo xGpuv2793aoJg174aNtJtknZ0ArY5JxctyYB5u0ck1qBeopjvFYQA2def21RsLw6uGmu uT8CqCLZewoIRMlOOFKWv2RoQv32I6zTiab1HwkAfsW6bVDfzMqHkBYxWoZVXr1WM13R cKDabf4nlUFLPX9y/k7onndKQGKKByKsC+knzJjpSdBa92rqwl3x0cJcomSiN1o0ZBOi FTWw== X-Gm-Message-State: AOAM532ymiv6+L7UOfo1o2mGqHntN5zofqPXuLQoULbF2wpeZZ2iDB+S 6SJ+l7AGAlCU47HU9+gx4fFJRjgAbJg= X-Google-Smtp-Source: ABdhPJzqIDzR+OfYBW1hXWgNXuwHYHW1Ydm/6WN4sD2new6S/6A72iUdabFtAqRUo+oDaMfAx5rTfQ== X-Received: by 2002:a1c:3954:: with SMTP id g81mr17364503wma.170.1615692236853; Sat, 13 Mar 2021 19:23:56 -0800 (PST) From: Mahmoud Mandour To: qemu-devel@nongnu.org Subject: [PATCH 2/8] hw/audio/fmopl.c: Fixing some style errors Date: Sun, 14 Mar 2021 05:23:18 +0200 Message-Id: <20210314032324.45142-3-ma.mandourr@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210314032324.45142-1-ma.mandourr@gmail.com> References: <20210314032324.45142-1-ma.mandourr@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=ma.mandourr@gmail.com; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mahmoud Mandour , Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) Content-Type: text/plain; charset="utf-8" Fixed style errors on the relevant lines in which I will introduce changes. Signed-off-by: Mahmoud Mandour --- hw/audio/fmopl.c | 58 ++++++++++++++++++++++++++---------------------- 1 file changed, 32 insertions(+), 26 deletions(-) diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c index 8a71a569fa..51b773695a 100644 --- a/hw/audio/fmopl.c +++ b/hw/audio/fmopl.c @@ -607,26 +607,32 @@ static int OPLOpenTable( void ) double pom; =20 /* allocate dynamic tables */ - if( (TL_TABLE =3D malloc(TL_MAX*2*sizeof(int32_t))) =3D=3D NULL) - return 0; - if( (SIN_TABLE =3D malloc(SIN_ENT*4 *sizeof(int32_t *))) =3D=3D NULL) - { - free(TL_TABLE); - return 0; - } - if( (AMS_TABLE =3D malloc(AMS_ENT*2 *sizeof(int32_t))) =3D=3D NULL) - { - free(TL_TABLE); - free(SIN_TABLE); - return 0; - } - if( (VIB_TABLE =3D malloc(VIB_ENT*2 *sizeof(int32_t))) =3D=3D NULL) - { - free(TL_TABLE); - free(SIN_TABLE); - free(AMS_TABLE); - return 0; - } + TL_TABLE =3D malloc(TL_MAX * 2 * sizeof(int32_t)); + if (TL_TABLE =3D=3D NULL) { + return 0; + } + + SIN_TABLE =3D malloc(SIN_ENT * 4 * sizeof(int32_t *)); + if (SIN_TABLE =3D=3D NULL) { + free(TL_TABLE); + return 0; + } + + AMS_TABLE =3D malloc(AMS_ENT * 2 * sizeof(int32_t)); + if (AMS_TABLE =3D=3D NULL) { + free(TL_TABLE); + free(SIN_TABLE); + return 0; + } + + VIB_TABLE =3D malloc(VIB_ENT * 2 * sizeof(int32_t)); + if (VIB_TABLE =3D=3D NULL) { + free(TL_TABLE); + free(SIN_TABLE); + free(AMS_TABLE); + return 0; + } + ENV_CURVE =3D g_new(int32_t, 2 * EG_ENT + 1); /* make total level table */ for (t =3D 0;t < EG_ENT-1 ;t++){ @@ -696,10 +702,10 @@ static int OPLOpenTable( void ) static void OPLCloseTable( void ) { g_free(ENV_CURVE); - free(TL_TABLE); - free(SIN_TABLE); - free(AMS_TABLE); - free(VIB_TABLE); + free(TL_TABLE); + free(SIN_TABLE); + free(AMS_TABLE); + free(VIB_TABLE); } =20 /* CSM Key Control */ @@ -1082,7 +1088,7 @@ FM_OPL *OPLCreate(int clock, int rate) state_size =3D sizeof(FM_OPL); state_size +=3D sizeof(OPL_CH)*max_ch; /* allocate memory block */ - ptr =3D malloc(state_size); + ptr =3D malloc(state_size); if(ptr=3D=3DNULL) return NULL; /* clear */ memset(ptr,0,state_size); @@ -1128,7 +1134,7 @@ void OPLDestroy(FM_OPL *OPL) } #endif OPL_UnLockTable(); - free(OPL); + free(OPL); } =20 /* ---------- Option handlers ---------- */ --=20 2.25.1