From nobody Sun May 19 06:23:11 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.44 as permitted sender) client-ip=209.85.128.44; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f44.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1615654895; cv=none; d=zohomail.com; s=zohoarc; b=Q1dflnvX9qT3b61qS8mwe46IGsxDt/lPNGgKEohQF0jufYQgaTAugSEKToNmON9fNxgV7wsZWOU0/PyVfZbjk9MWU5pp7E/oqODTyP16cQ7HLbMqIof/vZGYTpUMvlxfA7/lDPMex0jTSIuYWScyKDg5p1MPzyxogPOyLWR8jMY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615654895; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=1zohvJ6sxOOfnWcGj8WNa9DGoLyrIMi2NDlIWklnQZ0=; b=mv1irQ5zn2aAS9EFE4GbCKTiq2RGxU9whQxGvl8kQmFbzVegnu/ebAupgRYnDs6J2ggCmcvTgHf/ugST/Qs/DqV8aAGdDSuKXBrSwi6w76DfnxP/0VLgddqOpYBLLgj1L3T0IiGBzsPInfi8p+9vS0EXf+6VGd8Q0dFV7mK7BFk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by mx.zohomail.com with SMTPS id 1615654895557124.9363227402016; Sat, 13 Mar 2021 09:01:35 -0800 (PST) Received: by mail-wm1-f44.google.com with SMTP id t5-20020a1c77050000b029010e62cea9deso16930310wmi.0 for ; Sat, 13 Mar 2021 09:01:35 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (17.red-88-21-201.staticip.rima-tde.net. [88.21.201.17]) by smtp.gmail.com with ESMTPSA id x13sm12537825wrt.75.2021.03.13.09.01.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Mar 2021 09:01:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1zohvJ6sxOOfnWcGj8WNa9DGoLyrIMi2NDlIWklnQZ0=; b=OM6pQwt/kkccbZR3cVt4ymTr8LOkJ8w7VVGXpd73Hm4EJmFvQodROi/Q7d/R8JrxWr +ehjto8shw4J/qM6FSPAkFlg0rbBYX4YvpP9Kv3fwuRt7CKmBqUCTu3p29KG/xjScHQE 6npQ4Tn2Tbn8lKFOjMElKMSsFDOwB+pDjpmq3S9lSsO1XRQehwygrTiUAEFsZFDVu4MO hCGEwK+n3De6xEYE3RMXlxxBSipkEQup0/J1BihMn1n3pAtwUGcrUV/zfSXIe0bxN/YI Uhpqv9bok9fFDcb/6M9QdKt1ziqZ0ATVLhFOzcGSIhgExZf2cCLwhAzyKQct68LJLzcV mdTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=1zohvJ6sxOOfnWcGj8WNa9DGoLyrIMi2NDlIWklnQZ0=; b=dIWQBKDUYE2qK5fVLcWSg1rChcNlks8zKujjP61skVeKWWHklb6vsOY7olJAwhLQak +PetUEJc4IcDL0ZyCJPpeYAb/Ls1extxdEHrpHmxJ//YS6FM5C0fuesTMSC97C5CaXWQ PYXM13Oqk8fbIzH873cmSmxkIvXj4XMdT7OZb+gFPVOPDaNTFdCByK8HL64/oy9Z0kTe Q6mFbPf5uJ5YY3dvuo4Fjie75yxKFuICCWWu+lJgbPNMkezSP7Sl7Omv5A+1KXRPw+qg nzsxWnqLSb+TSUyETfPlHv644VBeX1yGLpdCZNs9FL1fryrM0qdGZN9jQ0l6UyhF0Si1 j6Sg== X-Gm-Message-State: AOAM530V46mShj4RYJdEUumJixCYw3uljf2cHSdgcbvos048mttLN7RJ s4A3BCqrvv9AHjKfAQR7pfxciUvU1BPtKg== X-Google-Smtp-Source: ABdhPJx6sVPibfoGBxIEe2KVQLhSQoQ5bmSGpN3Jj4zad1dNH2ixwWo4HL8kjZZaVNHvqSKMbbycfw== X-Received: by 2002:a1c:e041:: with SMTP id x62mr18173662wmg.95.1615654893887; Sat, 13 Mar 2021 09:01:33 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-arm@nongnu.org, qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Andrew Baumann Subject: [PATCH] hw/display/bcm2835_fb: Remove DeviceReset() call in DeviceRealize() Date: Sat, 13 Mar 2021 18:01:31 +0100 Message-Id: <20210313170131.2116837-1-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) When QDev objects have their DeviceReset handler set, they shouldn't worry about calling it at realization stage (it is handled by hw/core/qdev.c::device_set_realized). Remove the pointless/confusing bcm2835_fb_reset() call. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- hw/display/bcm2835_fb.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/display/bcm2835_fb.c b/hw/display/bcm2835_fb.c index 2be77bdd3a0..445e8636770 100644 --- a/hw/display/bcm2835_fb.c +++ b/hw/display/bcm2835_fb.c @@ -424,8 +424,6 @@ static void bcm2835_fb_realize(DeviceState *dev, Error = **errp) s->dma_mr =3D MEMORY_REGION(obj); address_space_init(&s->dma_as, s->dma_mr, TYPE_BCM2835_FB "-memory"); =20 - bcm2835_fb_reset(dev); - s->con =3D graphic_console_init(dev, 0, &vgafb_ops, s); qemu_console_resize(s->con, s->config.xres, s->config.yres); } --=20 2.26.2