From nobody Tue Feb 10 02:54:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) client-ip=209.85.221.51; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f51.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1615654521; cv=none; d=zohomail.com; s=zohoarc; b=LBWPb01ghzowgNikSnDCsQdxF8bBiYFKF0QAiQ8J4hzRcGsKKQu+pp41xEOkGuK7AD/OvNVmNHwhCIIsYamTuAd34kmM0Cf5vtAyQsyQXS6q2hRbRTz0+kMtiDSmBZrzK215PQZ75cgw1u2l6SUGE2jpT76wD/IHQoqh4VQ5iN8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615654521; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=p8kHAMKTSMM1CGT+akUwZjEeXDL24OQm1KW3vQNoEJk=; b=LbhkR7rjKV51M41CKb9ZjWbY1Q55+2jgS5BBG50I48mLrWEYmZiAAPJ5IIGCWjBILe0e0cXPI3KVa37X3TmvR5TXoCUAhMADQyfPYFZZGFqDoCkM4BNtRa31LZ7VpTtW10nuWRUjwtnWGlWxTigIeoLHuT4czi+zNjQBGyzeKNs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by mx.zohomail.com with SMTPS id 161565452107789.78671434603439; Sat, 13 Mar 2021 08:55:21 -0800 (PST) Received: by mail-wr1-f51.google.com with SMTP id y16so6477979wrw.3 for ; Sat, 13 Mar 2021 08:55:20 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (17.red-88-21-201.staticip.rima-tde.net. [88.21.201.17]) by smtp.gmail.com with ESMTPSA id n66sm6895423wmn.25.2021.03.13.08.55.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Mar 2021 08:55:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=p8kHAMKTSMM1CGT+akUwZjEeXDL24OQm1KW3vQNoEJk=; b=WQ2wVFvhCDwMFRKCNYHjor7KH/1RubNYJ4McUmMA9KwlRJQb6mCuFwsQDKV4AEmhPP XhsSlzpzP30ALgCNxD8SCO1NLK9TuIWm8oqxV2b0t0KfBhkE8Ae1+ieY1DfQMX+Q18t+ MOjHAyMtA54Ys68MxGHppQTJ2HK02uwTpWg4d13HowKOmOivR4/NTLhZZT697wHaKpNt wh2rGb7ADYzpMNZ5KUvgFM7f/F0F0EHTuZ8QPy3AOLMNf4h3UvEgwmqsr1lZrtiiIupj Ak3QGjxxreeL3+h6kUcoduLDTEa+z0nAjl7TUI6b2jgn10czkIEzjN5vqRUMGZUWswUo 6kJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=p8kHAMKTSMM1CGT+akUwZjEeXDL24OQm1KW3vQNoEJk=; b=dDCI9ZLOLFeD7SMJfgDCPTQ1+BcM1LauILo2vqH1Q9hoJiVKiCJgCB0u90I5IJiUmV eP489xUXO0MYr1yqdhkRAYELCCc8o3xX5rktPYL1h3BcRfuezMZLEiVTGK2t8uTAJck5 b/ZcNV3HfBoayL/oKpKKk+u3/zEnxDzLUOWirtplkhlDR1L9CiZpVOpkOpj8kusM1s2X /YUJapzEuBsUL6gYy8XiG1lryyxA0/J0MoeY2bsmzbHgB7nwbiN5r1umeIfcATQfMErE BBZjlD3eWkIK4bgJP7cD8inRZkpwY8DSefCea2Vc3ovjHZMfogUYenHBublOgcCR+zZW 5/Og== X-Gm-Message-State: AOAM531/UAseFfZndLM0gv3tNXgjQJdrOIEf2on3Vl2QfYjwuZfMbupx XI1sVsq9U8zqLEr8ZmxqF8LmLhvSfc4Eig== X-Google-Smtp-Source: ABdhPJxuTQ4QIY8gqCbYm73GI+f85wgxSjiWkfQ7e2YJ/wKkNovOrQK/lkXNQtmcDsnIbdUxLO4eEA== X-Received: by 2002:a5d:4ac4:: with SMTP id y4mr19391582wrs.86.1615654519250; Sat, 13 Mar 2021 08:55:19 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Michael Rolnik , Thomas Huth , Sarah Harris Subject: [PATCH 06/11] hw/gpio/avr_gpio: Simplify avr_gpio_write_port using extract32() Date: Sat, 13 Mar 2021 17:54:40 +0100 Message-Id: <20210313165445.2113938-7-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210313165445.2113938-1-f4bug@amsat.org> References: <20210313165445.2113938-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- hw/gpio/avr_gpio.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/hw/gpio/avr_gpio.c b/hw/gpio/avr_gpio.c index 3db55bfa77f..e4c7122e62c 100644 --- a/hw/gpio/avr_gpio.c +++ b/hw/gpio/avr_gpio.c @@ -39,20 +39,15 @@ static void avr_gpio_reset(DeviceState *dev) static void avr_gpio_write_port(AVRGPIOState *s, uint64_t value) { uint8_t pin; - uint8_t cur_port_val =3D s->reg.port; - uint8_t cur_ddr_val =3D s->reg.ddr; =20 for (pin =3D 0u; pin < AVR_GPIO_COUNT ; pin++) { - uint8_t cur_port_pin_val =3D cur_port_val & 0x01u; - uint8_t cur_ddr_pin_val =3D cur_ddr_val & 0x01u; - uint8_t new_port_pin_val =3D value & 0x01u; + uint8_t cur_port_pin_val =3D extract32(s->reg.port, pin, 1); + uint8_t cur_ddr_pin_val =3D extract32(s->reg.ddr, pin, 1); + uint8_t new_port_pin_val =3D extract32(value, pin, 1); =20 if (cur_ddr_pin_val && (cur_port_pin_val !=3D new_port_pin_val)) { qemu_set_irq(s->out[pin], new_port_pin_val); } - cur_port_val >>=3D 1u; - cur_ddr_val >>=3D 1u; - value >>=3D 1u; } s->reg.port =3D value & s->reg.ddr; } --=20 2.26.2