From nobody Tue Feb 10 10:54:46 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) client-ip=209.85.221.50; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f50.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1615573746; cv=none; d=zohomail.com; s=zohoarc; b=kwRAdf8wkxfYM331Ay4XgsnhwzUlPKGZTA+5Ss51xjcwvBxbD5YcyZQRgfhWHHatpfqXrtZnqlnKeqYN4s9OjlWRXjA5cUenykvJYMGjma8sPmu0BT9PcADEqbUCZ7duaANL5aXEU6ZDM/s33oRV0LsSwbFIlrjwRQ0T7m008yo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615573746; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9tJp0u8EkF/DAA9zO9gGqV8fJY+V8VUWnyEVu07oRsU=; b=jR2VBvxH1wkcMY7j1/9mFS2qqiQxeJkVuOAQbTpVZApKE71zSJ9ncFHvn9LKNq8ZKZfq/bJotSPN0QVYzgrohKcgupQAt6vkda630v5TYxagQj6dJT/3zfEKWpAaPd6sxbr/a5obisUj/WfRS4GTanfbqx1Nk9sDgBCQZqMYwIw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mx.zohomail.com with SMTPS id 1615573746691308.96414392446866; Fri, 12 Mar 2021 10:29:06 -0800 (PST) Received: by mail-wr1-f50.google.com with SMTP id l11so5333382wrp.7 for ; Fri, 12 Mar 2021 10:29:06 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (17.red-88-21-201.staticip.rima-tde.net. [88.21.201.17]) by smtp.gmail.com with ESMTPSA id j11sm8494397wrm.13.2021.03.12.10.29.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 10:29:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9tJp0u8EkF/DAA9zO9gGqV8fJY+V8VUWnyEVu07oRsU=; b=D4vLJqQyOFpCuz45zqLrkOqIezWkBmmZA6sCZs5wd+E9a+q76yyxoMXjTQLKk8DLTF T7cDt9CiZuIt0duYmAOcS7DA2UXzHms3jgYxPyQpapTwKPsfe3uX+GFv/YdI2EyxQ4qp iOSWDpVm7iVc9SpyvGB1putYGOoSx31MjZ/W+lGamX7B80noAS6waTeIkJrtreCvhA66 q1M1Yx6+4Uph4BXgZQ/77tGYFQ32M3ztmxBtvwYP49mACpmSZrQdw7gEnVzNSODDFKV8 PMlUCxxAWHi6Kc0Mct3lpzWDlXh7TFddBWu3l39t4jsQecqMXvDRtcoMaOQjnfhpMoFE kmRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=9tJp0u8EkF/DAA9zO9gGqV8fJY+V8VUWnyEVu07oRsU=; b=mRsVD4aWzQ7rBqmr3wZTv+bGu9kYNpD1Du/cOLl9FCtYwn1Dz1hcDQI1IHoOMgKQnT ZUWiSPjycAOrG0iEbxwAxzZeZrKd72ell6z3N0KoNsiIO+UPpzjHwWXYAXPz0ZhH9OuB SVOfrYNtfPBIfVj6dc9+yEq6FAvZyeJWqzVQhl1r1/H9mw202rsHUD/qfcADbfRw3679 sb4PhtRNuWcYUtL/Nd/4CkTxLi4Q5zlFdLNmKPtKBco/Pe/EggSTGYzBIkbOoQgAm2fK ylsHRWNm4KgqQdk9ix5yQQGBtMX8KCScpcihuNaVRAbEF/5D4QkgOTBMnu+O1ACfxu/s 7TUQ== X-Gm-Message-State: AOAM530AJAH7UVEvfndXkqEHuqtni5TjRpZ+DgCpmxTCScZLzRNDlb3k 9CeIFb1BGwlEgbHRqDGkQHc= X-Google-Smtp-Source: ABdhPJw0X6cG3IBekwtztTFo0R627GOg0kkqW4JcehgXqIdlD+gObeIqPhRoRmb1VvX6ZKy1yNn/hA== X-Received: by 2002:adf:e84f:: with SMTP id d15mr15382841wrn.394.1615573744919; Fri, 12 Mar 2021 10:29:04 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Greg Kurz , qemu-arm@nongnu.org, Peter Xu , Andrew Jeffery , Alistair Francis , Joel Stanley , Paolo Bonzini , qemu-ppc@nongnu.org, David Gibson , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 2/5] hw/arm/aspeed: Do not sysbus-map mmio flash region directly, use alias Date: Fri, 12 Mar 2021 19:28:48 +0100 Message-Id: <20210312182851.1922972-3-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210312182851.1922972-1-f4bug@amsat.org> References: <20210312182851.1922972-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) The flash mmio region is exposed as an AddressSpace. AddressSpaces must not be sysbus-mapped, therefore map the region using an alias. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/ssi/aspeed_smc.h | 1 + hw/ssi/aspeed_smc.c | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/include/hw/ssi/aspeed_smc.h b/include/hw/ssi/aspeed_smc.h index 16c03fe64f3..e3c96cecbd8 100644 --- a/include/hw/ssi/aspeed_smc.h +++ b/include/hw/ssi/aspeed_smc.h @@ -84,6 +84,7 @@ struct AspeedSMCState { =20 MemoryRegion mmio; MemoryRegion mmio_flash; + MemoryRegion mmio_flash_alias; =20 qemu_irq irq; int irqline; diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c index 16addee4dc8..aa26578bdac 100644 --- a/hw/ssi/aspeed_smc.c +++ b/hw/ssi/aspeed_smc.c @@ -1386,7 +1386,9 @@ static void aspeed_smc_realize(DeviceState *dev, Erro= r **errp) memory_region_init_io(&s->mmio_flash, OBJECT(s), &aspeed_smc_flash_default_ops, s, name, s->ctrl->flash_window_size); - sysbus_init_mmio(sbd, &s->mmio_flash); + memory_region_init_alias(&s->mmio_flash_alias, OBJECT(s), name, + &s->mmio_flash, 0, s->ctrl->flash_window_size= ); + sysbus_init_mmio(sbd, &s->mmio_flash_alias); =20 s->flashes =3D g_new0(AspeedSMCFlash, s->ctrl->max_peripherals); =20 --=20 2.26.2