From nobody Sat May 18 19:12:40 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1615559888; cv=none; d=zohomail.com; s=zohoarc; b=VUPrzo9InXxHvwgbqimz5gnJYuTNEA/K5PE/97us9bP3Ow/HxKvNR4fY4Z94qQSg48cT0CeEG94Tpb6OosEnNhzg7FDzYRe9+idTVpe2vqODQNsHrSGRy9zENC/qOKJ7wbz6IK8ysTJ33l3nokJdQVQJ3zOXRaDiEu0Md1xfqZg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615559888; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=cZrvXHS+DcxoNQInCruf3VWn2bZV+SPpCNc7NTPb2eM=; b=mwje3ZPnE9lkozFUvgF2rk0b5TAWuy38qux3UydPX3aycElLuCCkqPmBrJ0Xub//4hNr/R0BEDmmzGYv9ZkSAx5ZsdyHaBO/xp4XIJ6Pj4J+WOtfDf1JuwmbWkUzGDzg8rrcdqbY3KoEMOYqSkeJL43DFdUTisZCzy5v4Ww2KNU= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1615559888672561.3599229902518; Fri, 12 Mar 2021 06:38:08 -0800 (PST) Received: from localhost ([::1]:55162 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKivX-000372-KN for importer@patchew.org; Fri, 12 Mar 2021 09:38:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48148) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKiUh-0002ge-TW for qemu-devel@nongnu.org; Fri, 12 Mar 2021 09:10:23 -0500 Received: from us-smtp-delivery-44.mimecast.com ([205.139.111.44]:46968) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lKiUf-0003uV-H4 for qemu-devel@nongnu.org; Fri, 12 Mar 2021 09:10:23 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-150-MO7gm_TUOemda3JyKN8QPA-1; Fri, 12 Mar 2021 09:10:16 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CB2C4107ACCA; Fri, 12 Mar 2021 14:10:15 +0000 (UTC) Received: from bahia.redhat.com (ovpn-113-236.ams2.redhat.com [10.36.113.236]) by smtp.corp.redhat.com (Postfix) with ESMTP id 765DA5D6D7; Fri, 12 Mar 2021 14:10:14 +0000 (UTC) X-MC-Unique: MO7gm_TUOemda3JyKN8QPA-1 From: Greg Kurz To: qemu-devel@nongnu.org Subject: [PATCH 1/3] virtiofsd: Don't allow empty paths in lookup_name() Date: Fri, 12 Mar 2021 15:10:01 +0100 Message-Id: <20210312141003.819108-2-groug@kaod.org> In-Reply-To: <20210312141003.819108-1-groug@kaod.org> References: <20210312141003.819108-1-groug@kaod.org> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: kaod.org Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: softfail client-ip=205.139.111.44; envelope-from=groug@kaod.org; helo=us-smtp-delivery-44.mimecast.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: virtio-fs@redhat.com, Miklos Szeredi , "Dr. David Alan Gilbert" , Stefan Hajnoczi , Greg Kurz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" When passed an empty filename, lookup_name() returns the inode of the parent directory, unless the parent is the root in which case the st_dev doesn't match and lo_find() returns NULL. This is because lookup_name() passes AT_EMPTY_PATH down to fstatat() or statx(). This behavior doesn't quite make sense because users of lookup_name() then pass the name to unlinkat(), renameat() or renameat2(), all of which will always fail on empty names. Drop AT_EMPTY_PATH from the flags in lookup_name() so that it has the consistent behavior of "returning an existing child inode or NULL" for all directories. Signed-off-by: Greg Kurz Reviewed-by: Connor Kuehl Reviewed-by: Vivek Goyal --- tools/virtiofsd/passthrough_ll.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough= _ll.c index fc7e1b1e8e2b..27a6c636dcaf 100644 --- a/tools/virtiofsd/passthrough_ll.c +++ b/tools/virtiofsd/passthrough_ll.c @@ -1308,8 +1308,7 @@ static struct lo_inode *lookup_name(fuse_req_t req, f= use_ino_t parent, return NULL; } =20 - res =3D do_statx(lo, dir->fd, name, &attr, - AT_EMPTY_PATH | AT_SYMLINK_NOFOLLOW, &mnt_id); + res =3D do_statx(lo, dir->fd, name, &attr, AT_SYMLINK_NOFOLLOW, &mnt_i= d); lo_inode_put(lo, &dir); if (res =3D=3D -1) { return NULL; --=20 2.26.2 From nobody Sat May 18 19:12:40 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1615560125; cv=none; d=zohomail.com; s=zohoarc; b=BSX8wzcCqJvip48MqAd94kSnOleWW/r56R/Vyn4eHAzbCCS/HWhHnvyyLWqHoO4m5LlW2at3SO/XLhU2EvenXisHDG490RcctCjBXodHcZwnUTs9vqa82q5CqugCQFEuTS676uz+4rKQBQRwHy/f2/RbrOkkYyNl1F/fnt2nR4A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615560125; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=LxMT18i7e0qM7XNWDuNTYXmlrvAUVUAI1dUEZfhhI8s=; b=ULy/H8uOB0fl+iZvB3hwanyF8/P82AUSls8gGtijsXjTSpXhUMPp8c88QmAH3QQgdxnrbqy7h4r5DZVaUsp/n6XX1icuNvPM93mR+RFAT+ny7m2sYeVUXbMlhZST2opdsyPiDVX1c2viZ0hP2MEFhpQF8NAsK9gyYgK6KVqk97E= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1615560125370957.1024215693419; Fri, 12 Mar 2021 06:42:05 -0800 (PST) Received: from localhost ([::1]:32770 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKizM-0006k3-5k for importer@patchew.org; Fri, 12 Mar 2021 09:42:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48150) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKiUi-0002hy-Gs for qemu-devel@nongnu.org; Fri, 12 Mar 2021 09:10:24 -0500 Received: from us-smtp-delivery-44.mimecast.com ([207.211.30.44]:58326) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lKiUg-0003wq-TA for qemu-devel@nongnu.org; Fri, 12 Mar 2021 09:10:24 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-317-2MY1dohRM4-VGnZJoCtmeQ-1; Fri, 12 Mar 2021 09:10:18 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9CB07EC1A2; Fri, 12 Mar 2021 14:10:17 +0000 (UTC) Received: from bahia.redhat.com (ovpn-113-236.ams2.redhat.com [10.36.113.236]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3B4AF5D6D7; Fri, 12 Mar 2021 14:10:15 +0000 (UTC) X-MC-Unique: 2MY1dohRM4-VGnZJoCtmeQ-1 From: Greg Kurz To: qemu-devel@nongnu.org Subject: [PATCH 2/3] virtiofsd: Convert some functions to return bool Date: Fri, 12 Mar 2021 15:10:02 +0100 Message-Id: <20210312141003.819108-3-groug@kaod.org> In-Reply-To: <20210312141003.819108-1-groug@kaod.org> References: <20210312141003.819108-1-groug@kaod.org> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: kaod.org Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: softfail client-ip=207.211.30.44; envelope-from=groug@kaod.org; helo=us-smtp-delivery-44.mimecast.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: virtio-fs@redhat.com, Miklos Szeredi , "Dr. David Alan Gilbert" , Stefan Hajnoczi , Greg Kurz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Both currently only return 0 or 1. Signed-off-by: Greg Kurz Reviewed-by: Connor Kuehl Reviewed-by: Vivek Goyal --- tools/virtiofsd/passthrough_ll.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough= _ll.c index 27a6c636dcaf..f63016d35626 100644 --- a/tools/virtiofsd/passthrough_ll.c +++ b/tools/virtiofsd/passthrough_ll.c @@ -221,17 +221,17 @@ static struct lo_inode *lo_find(struct lo_data *lo, s= truct stat *st, static int xattr_map_client(const struct lo_data *lo, const char *client_n= ame, char **out_name); =20 -static int is_dot_or_dotdot(const char *name) +static bool is_dot_or_dotdot(const char *name) { return name[0] =3D=3D '.' && (name[1] =3D=3D '\0' || (name[1] =3D=3D '.' && name[2] =3D=3D '= \0')); } =20 /* Is `path` a single path component that is not "." or ".."? */ -static int is_safe_path_component(const char *path) +static bool is_safe_path_component(const char *path) { if (strchr(path, '/')) { - return 0; + return false; } =20 return !is_dot_or_dotdot(path); --=20 2.26.2 From nobody Sat May 18 19:12:40 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1615559183; cv=none; d=zohomail.com; s=zohoarc; b=bvAU/kWBHJ7W7Eb3T0oIVixy5Sl0XVnGzsvjz2Ps8gV2QQbLORL6OqAghDONISPcXW4Kz6wY99Vu+rp9eH9EZ4dK5irPXd3a/m6BOyOO+M+2u4i4JmJZxLtmqRmCmYVSU/FtBMkXDWtC1NdWNMgJL/w4aForSUE2hnoIwojZRZ4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615559183; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nMypH5fF/VN+dL1CwQENwhbytTjusoroeG4HblIriuc=; b=XgF/aDWXm37EZbQQLPBQTP1KiZd29vhNoIuosSNcdIeND5ipyGnKn6SKgtKLE0cynDMfrAz7WFsTPS28fruSMi7e/hzLUn8Mq4mkWJbvxSHI6BzXuUrTdydmY7u7sH/YH3UeOXEx2z5HTynuqusMlcCCcnX1G7XokG9d6vrWJLM= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1615559183589420.7319510310748; Fri, 12 Mar 2021 06:26:23 -0800 (PST) Received: from localhost ([::1]:59252 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKikA-0008AS-GV for importer@patchew.org; Fri, 12 Mar 2021 09:26:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48164) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKiUl-0002oc-EO for qemu-devel@nongnu.org; Fri, 12 Mar 2021 09:10:27 -0500 Received: from us-smtp-delivery-44.mimecast.com ([207.211.30.44]:29353) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lKiUj-00041j-OK for qemu-devel@nongnu.org; Fri, 12 Mar 2021 09:10:27 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-163-BVLymU5FOtSto8Cp4lqBZA-1; Fri, 12 Mar 2021 09:10:21 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4523DEC1A0; Fri, 12 Mar 2021 14:10:19 +0000 (UTC) Received: from bahia.redhat.com (ovpn-113-236.ams2.redhat.com [10.36.113.236]) by smtp.corp.redhat.com (Postfix) with ESMTP id E5D345D6D7; Fri, 12 Mar 2021 14:10:17 +0000 (UTC) X-MC-Unique: BVLymU5FOtSto8Cp4lqBZA-1 From: Greg Kurz To: qemu-devel@nongnu.org Subject: [PATCH 3/3] virtiofsd: Don't allow empty filenames Date: Fri, 12 Mar 2021 15:10:03 +0100 Message-Id: <20210312141003.819108-4-groug@kaod.org> In-Reply-To: <20210312141003.819108-1-groug@kaod.org> References: <20210312141003.819108-1-groug@kaod.org> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=groug@kaod.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: kaod.org Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: softfail client-ip=207.211.30.44; envelope-from=groug@kaod.org; helo=us-smtp-delivery-44.mimecast.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: virtio-fs@redhat.com, Miklos Szeredi , "Dr. David Alan Gilbert" , Stefan Hajnoczi , Greg Kurz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" POSIX.1-2017 clearly stipulates that empty filenames aren't allowed ([1] and [2]). Since virtiofsd is supposed to mirror the host file system hierarchy and the host can be assumed to be linux, we don't really expect clients to pass requests with an empty path in it. If they do so anyway, this would eventually cause an error when trying to create/lookup the actual inode on the underlying POSIX filesystem. But this could still confuse some code that wouldn't be ready to cope with this. Filter out empty names coming from the client at the top level, so that the rest doesn't have to care about it. This is done everywhere we already call is_safe_path_component(), but in a separate helper since the usual error for empty path names is ENOENT instead of EINVAL. [1] https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.htm= l#tag_03_170 [2] https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap04.htm= l#tag_04_13 Signed-off-by: Greg Kurz Reviewed-by: Connor Kuehl --- tools/virtiofsd/passthrough_ll.c | 35 ++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough= _ll.c index f63016d35626..bff9dc2cd26d 100644 --- a/tools/virtiofsd/passthrough_ll.c +++ b/tools/virtiofsd/passthrough_ll.c @@ -237,6 +237,11 @@ static bool is_safe_path_component(const char *path) return !is_dot_or_dotdot(path); } =20 +static bool is_empty(const char *name) +{ + return name[0] =3D=3D '\0'; +} + static struct lo_data *lo_data(fuse_req_t req) { return (struct lo_data *)fuse_req_userdata(req); @@ -1083,6 +1088,11 @@ static void lo_lookup(fuse_req_t req, fuse_ino_t par= ent, const char *name) fuse_log(FUSE_LOG_DEBUG, "lo_lookup(parent=3D%" PRIu64 ", name=3D%s)\n= ", parent, name); =20 + if (is_empty(name)) { + fuse_reply_err(req, ENOENT); + return; + } + /* * Don't use is_safe_path_component(), allow "." and ".." for NFS expo= rt * support. @@ -1174,6 +1184,11 @@ static void lo_mknod_symlink(fuse_req_t req, fuse_in= o_t parent, struct fuse_entry_param e; struct lo_cred old =3D {}; =20 + if (is_empty(name)) { + fuse_reply_err(req, ENOENT); + return; + } + if (!is_safe_path_component(name)) { fuse_reply_err(req, EINVAL); return; @@ -1246,6 +1261,11 @@ static void lo_link(fuse_req_t req, fuse_ino_t ino, = fuse_ino_t parent, char procname[64]; int saverr; =20 + if (is_empty(name)) { + fuse_reply_err(req, ENOENT); + return; + } + if (!is_safe_path_component(name)) { fuse_reply_err(req, EINVAL); return; @@ -1323,6 +1343,11 @@ static void lo_rmdir(fuse_req_t req, fuse_ino_t pare= nt, const char *name) struct lo_inode *inode; struct lo_data *lo =3D lo_data(req); =20 + if (is_empty(name)) { + fuse_reply_err(req, ENOENT); + return; + } + if (!is_safe_path_component(name)) { fuse_reply_err(req, EINVAL); return; @@ -1352,6 +1377,11 @@ static void lo_rename(fuse_req_t req, fuse_ino_t par= ent, const char *name, struct lo_inode *newinode =3D NULL; struct lo_data *lo =3D lo_data(req); =20 + if (is_empty(name) || is_empty(newname)) { + fuse_reply_err(req, ENOENT); + return; + } + if (!is_safe_path_component(name) || !is_safe_path_component(newname))= { fuse_reply_err(req, EINVAL); return; @@ -1405,6 +1435,11 @@ static void lo_unlink(fuse_req_t req, fuse_ino_t par= ent, const char *name) struct lo_inode *inode; struct lo_data *lo =3D lo_data(req); =20 + if (is_empty(name)) { + fuse_reply_err(req, ENOENT); + return; + } + if (!is_safe_path_component(name)) { fuse_reply_err(req, EINVAL); return; --=20 2.26.2