From nobody Sat May 18 19:24:31 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) client-ip=209.85.128.53; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f53.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1615508329; cv=none; d=zohomail.com; s=zohoarc; b=asH+ONu9iWZvT9zrEsU02fN22OUbhw7X+FOema8xMAqa6BKjfT2VwYqzTi/QSRzM8mBm4hhgKgpab3z/hDp3Q7yaTis0DHDU+Q5lbZrTSME4LpQYUNIAackmnjiWJLaoY6gJ78eJBmqcJ2Puf74d68dIL4f9n+R7zLRDRQm7Je8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615508329; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=ro2t9KYjjz9CCAnsd96braIE+NeDdsOkzjCPjxJPjjM=; b=ZzLW4z6yYZgsi6lTtBi1f08w1BzP4UV62xJTmt0+RdwEnrbZOoIjjAWsRZAO9Xug4ox2mNGoVGEehYcmMBlTJQpRkDM02RRT28lFpIs2Y777QwaZD6xIedlxjzuHycgN89IwpVwqiGoviCvd3mIlu4YUQ0FwYXxzH5hhEPXTAKo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mx.zohomail.com with SMTPS id 1615508329695116.01679183253987; Thu, 11 Mar 2021 16:18:49 -0800 (PST) Received: by mail-wm1-f53.google.com with SMTP id c76-20020a1c9a4f0000b029010c94499aedso14780735wme.0 for ; Thu, 11 Mar 2021 16:18:49 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (17.red-88-21-201.staticip.rima-tde.net. [88.21.201.17]) by smtp.gmail.com with ESMTPSA id f16sm5895407wrt.21.2021.03.11.16.18.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Mar 2021 16:18:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ro2t9KYjjz9CCAnsd96braIE+NeDdsOkzjCPjxJPjjM=; b=srNIc/OFvdRu/wLKAzJAnzNg4c4mzJew0YXCJ+10f+umaf5GeSVSvOpfsCFh5VpsZ8 fFDlPmSKKaYuJNYwJHdEWha32aSHzdcnOmAmX8p5U29/FEF9tee6WpgDh2GfWSsbgaMu ZJeH9L0mqFlle4brixjTcj0MYNNiQNWgWpRS7pEWKQSwSHRMRsIxj7LCFFcna1k9mB6p /UPqpENopY4weIfYzqOVnFltWu54Jhir66WbJTHcZHN3eIHIKWMPCBm8vtp7Nmjm97NH 8qWt7GcFDQ1n8kC9kBFyO2v6uq33PnB7pKbGLktzMjAjR3qBXmuFFv5Oyi7ss0bsMFgQ gArg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=ro2t9KYjjz9CCAnsd96braIE+NeDdsOkzjCPjxJPjjM=; b=UmhJaG+xk0qZKUGcusfe++WtcWZvsK7ghy8cZ11EBWH8Arw3G69JHBOimKbcLj5jil Fzs1Pnk9OrhvibewA/jtb05/X1bciQuufwhTe0bLi7CwsD+2TLnu8LQSp1kpGWkh2l+e ZU2u+saORaSMo43lZRfadzFq1W1y+MuC7n20W9QtSmgfGekRkNHeRjUXyIwtjoURqiHX 3KK6N90NTetRPK5FHywo3mahQ2jUQLNABt2kS+r3eLVgXe7cAiZfqHmg4nnsvdDIX4Te uoktgVF6AlmmbrEHwk1o6rnkq9NsheDtkXOPGdpFjOR3h3WEU6c921EQsvu81ovtETsQ i+Vg== X-Gm-Message-State: AOAM531uSRkXYS0+SnSF79vW5cxRhFG8v7RLbDJVLv0FKDmnH7enlIlp 7SK0Im0ytsj1kjaRSonKSZH8WRE6BGE= X-Google-Smtp-Source: ABdhPJzVEeIiqQADSYW2T2J0FHdWWSLwWyHPxX7Wyh4nQgBuWiteNR5xC8nHZpPibBRpHXboAfaKVw== X-Received: by 2002:a05:600c:284:: with SMTP id 4mr10643683wmk.24.1615508327937; Thu, 11 Mar 2021 16:18:47 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Peter Maydell , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH] hw/timer/sse-timer: Propagate eventual error in sse_timer_realize() Date: Fri, 12 Mar 2021 01:18:45 +0100 Message-Id: <20210312001845.1562670-1-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) If the SSECounter link is absent, we set an error message in sse_timer_realize() but forgot to propagate this error. Add the missing 'return'. Fixes: CID 1450755 (Null pointer dereferences) Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/timer/sse-timer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/timer/sse-timer.c b/hw/timer/sse-timer.c index 8dbe6ac651e..f959cb9d603 100644 --- a/hw/timer/sse-timer.c +++ b/hw/timer/sse-timer.c @@ -415,6 +415,7 @@ static void sse_timer_realize(DeviceState *dev, Error *= *errp) =20 if (!s->counter) { error_setg(errp, "counter property was not set"); + return; } =20 s->counter_notifier.notify =3D sse_timer_counter_callback; --=20 2.26.2