From nobody Mon Feb 9 17:36:17 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1615466408; cv=none; d=zohomail.com; s=zohoarc; b=B9FVjKC+PeuFhN1OZmf8QyIUGmuDXXQhrtnvbg1/Hz/m+iYgqPrytRUeTMHdjd7CEz5brKw0t4wHEPwJOri/ieb3ZZSq2IvarTOWRH+yORgSG8As92W4TmAP3d3Iw4OqmCXj7BujPnynhqQFMCPmnXxMkX2G5sYIwqqUV7ojqKo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615466408; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=hItlt2rz+ypHQJ0JcSDbJEMqcGZ5UqN4LOprhKfFsEU=; b=fDrNokiszg7/8Bb9KaTV/I2m++QnlNNEuJRozOuSZxI6XfpHZgydXFDXlqeDHlQOnVBwvDWor4qzbMluGMQxNIaB/7A+omGsDqQDpgC3NALxPpGgaiJX2mlYoKfZaKCacED7PHQfw1RAkm4Rbn19fiSMv3fUNLArFQJDLLWSrGY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1615466408206712.7544603996594; Thu, 11 Mar 2021 04:40:08 -0800 (PST) Received: from localhost ([::1]:48036 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKKbm-00004x-UM for importer@patchew.org; Thu, 11 Mar 2021 07:40:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52204) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKKWB-0003f1-JR for qemu-devel@nongnu.org; Thu, 11 Mar 2021 07:34:21 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:60306) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lKKW5-0006Uh-KA for qemu-devel@nongnu.org; Thu, 11 Mar 2021 07:34:18 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-365-VVbw03LlNX2z1QBEgi8ftg-1; Thu, 11 Mar 2021 07:34:09 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 829E919253C6; Thu, 11 Mar 2021 12:34:08 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-141.ams2.redhat.com [10.36.112.141]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 498425DAA5; Thu, 11 Mar 2021 12:34:08 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id E4A551800911; Thu, 11 Mar 2021 13:34:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615466051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hItlt2rz+ypHQJ0JcSDbJEMqcGZ5UqN4LOprhKfFsEU=; b=Hf9L3C7Xwyu/op96xMuKyLGLRg+5QmlVPZYpqNWVOFSY84NzgkLsKHeA/O8kMHiK63fbC8 EYTS0ffF9T6Yaiqm7Xwi63jK0aiMcyQKmaUMTgNiRutOAyiPC7Nzfw+LiUiYdt++B9LHif HA8WEvPBYoFZP9371oqu7F3cGDIjQ64= X-MC-Unique: VVbw03LlNX2z1QBEgi8ftg-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PULL 5/8] ui/cocoa: Do not rely on the first argument Date: Thu, 11 Mar 2021 13:33:58 +0100 Message-Id: <20210311123401.340122-6-kraxel@redhat.com> In-Reply-To: <20210311123401.340122-1-kraxel@redhat.com> References: <20210311123401.340122-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Gerd Hoffmann , Akihiko Odaki Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Akihiko Odaki The first argument of the executable was used to get its path, but it is not reliable because the executer can specify any arbitrary string. Use the interfaces provided by QEMU and the platform to get those paths. Signed-off-by: Akihiko Odaki Message-Id: <20210309122226.23117-2-akihiko.odaki@gmail.com> Signed-off-by: Gerd Hoffmann --- ui/cocoa.m | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index e589534fa460..4753bb2f8800 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -1398,20 +1398,21 @@ QemuCocoaView *cocoaView; [superView addSubview: picture_view]; =20 /* Make the name label */ - x =3D 0; - y =3D y - 25; - int name_width =3D about_width, name_height =3D 20; - NSRect name_rect =3D NSMakeRect(x, y, name_width, name_height); - NSTextField *name_label =3D [[NSTextField alloc] initWithFrame: name_r= ect]; - [name_label setEditable: NO]; - [name_label setBezeled: NO]; - [name_label setDrawsBackground: NO]; - [name_label setAlignment: NSTextAlignmentCenter]; - NSString *qemu_name =3D [[NSString alloc] initWithCString: gArgv[0] - encoding: NSASCIIStringEncodin= g]; - qemu_name =3D [qemu_name lastPathComponent]; - [name_label setStringValue: qemu_name]; - [superView addSubview: name_label]; + NSBundle *bundle =3D [NSBundle mainBundle]; + if (bundle) { + x =3D 0; + y =3D y - 25; + int name_width =3D about_width, name_height =3D 20; + NSRect name_rect =3D NSMakeRect(x, y, name_width, name_height); + NSTextField *name_label =3D [[NSTextField alloc] initWithFrame: na= me_rect]; + [name_label setEditable: NO]; + [name_label setBezeled: NO]; + [name_label setDrawsBackground: NO]; + [name_label setAlignment: NSTextAlignmentCenter]; + NSString *qemu_name =3D [[bundle executablePath] lastPathComponent= ]; + [name_label setStringValue: qemu_name]; + [superView addSubview: name_label]; + } =20 /* Set the version label's attributes */ x =3D 0; --=20 2.29.2