From nobody Sun May 19 14:40:12 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1615453264; cv=none; d=zohomail.com; s=zohoarc; b=OkN8wDxMLsXvV9tfjMRr/qIzYmbrH1xXnCLlrg1ZtTQCJnk825/h0TnkDlflxBHWpeYjWec+XXRSCVLTKfH+uQB9XMyemu/xyZaC3JG2CmwINz7t38tny8ofNqw6R8cO7w+Vn+MfvIqk4rkby5nKU+OVN5mIYXhGWxCs6WYU7aY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615453264; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=FxpCeXiidvNJwE7rPl521PmAEY8PSOl29Hl4evXKyn0=; b=a+in5dIAciTdwOgBL+EB0NW2OMmrX2b3bGzi3zLZv+tl4FmKZRivCQp8IjwY4X28c7/6YpoPu+xGxIsWH6F/eqzhUX1OcFHQ+L9GEquxX+4zTUWrEQ7fd69VzE0WYcsoP4P9bdc0SbyvWIJNg1FJCvN+6+vuHXZqQAEwbyEVIjM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1615453263559974.6243813709445; Thu, 11 Mar 2021 01:01:03 -0800 (PST) Received: from localhost ([::1]:40886 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKHBm-0005b0-4Y for importer@patchew.org; Thu, 11 Mar 2021 04:01:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKHAM-0004pK-66 for qemu-devel@nongnu.org; Thu, 11 Mar 2021 03:59:34 -0500 Received: from forwardcorp1o.mail.yandex.net ([2a02:6b8:0:1a2d::193]:35374) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKHAI-0004fK-Gu for qemu-devel@nongnu.org; Thu, 11 Mar 2021 03:59:32 -0500 Received: from iva8-d077482f1536.qloud-c.yandex.net (iva8-d077482f1536.qloud-c.yandex.net [IPv6:2a02:6b8:c0c:2f26:0:640:d077:482f]) by forwardcorp1o.mail.yandex.net (Yandex) with ESMTP id 1884E2E15EC; Thu, 11 Mar 2021 11:59:25 +0300 (MSK) Received: from iva8-5ba4ca89b0c6.qloud-c.yandex.net (iva8-5ba4ca89b0c6.qloud-c.yandex.net [2a02:6b8:c0c:a8ae:0:640:5ba4:ca89]) by iva8-d077482f1536.qloud-c.yandex.net (mxbackcorp/Yandex) with ESMTP id Y8I071V31I-xOx0NUGZ; Thu, 11 Mar 2021 11:59:25 +0300 Received: from dynamic-iva.dhcp.yndx.net (dynamic-iva.dhcp.yndx.net [2a02:6b8:b080:8818::1:8]) by iva8-5ba4ca89b0c6.qloud-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id C5N1gh1pOz-xOoiAqvH; Thu, 11 Mar 2021 11:59:24 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) Precedence: bulk DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1615453165; bh=FxpCeXiidvNJwE7rPl521PmAEY8PSOl29Hl4evXKyn0=; h=Message-Id:Date:Subject:To:From:Cc; b=qALzcKz0kbtwfMPT6CxRjYJZ6er7Sm2fMEoXUn0y0Ewa7jaX29hsFP+l3qZgaBV8M GwTOo+3IwDUywSpBoyH2JQztUaNiTgTQdDfKFRwWVLaD8DZV3wgT2LqoiNdXh0RNvk mx1IUp6TsiWRHwoZDySuVRmCAXrzJD0VRUcmj7bE= Authentication-Results: iva8-d077482f1536.qloud-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Denis Plotnikov To: qemu-devel@nongnu.org Subject: [PATCH v1] softmmu/vl: make default prealloc-threads work w/o -mem-prealloc Date: Thu, 11 Mar 2021 11:59:18 +0300 Message-Id: <20210311085918.284903-1-den-plotnikov@yandex-team.ru> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a02:6b8:0:1a2d::193; envelope-from=den-plotnikov@yandex-team.ru; helo=forwardcorp1o.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, yc-core@yandex-team.ru Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Preallocation in memory backends can be specified with either global QEMU option "-mem-prealloc", or with per-backend property "prealloc=3Dtrue". In the latter case, however, the default for the number of preallocation threads is not set to the number of vcpus, but remains at 1 instead. Fix it by setting the "prealloc-threads" sugar property of "memory-backend" to the number of vcpus unconditionally. Fixes: ffac16fab3 ("hostmem: introduce "prealloc-threads" property") Signed-off-by: Denis Plotnikov --- softmmu/vl.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index ff488ea3e7db..e392e226a2d3 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -2300,14 +2300,17 @@ static void qemu_validate_options(void) =20 static void qemu_process_sugar_options(void) { - if (mem_prealloc) { - char *val; + char *val; =20 - val =3D g_strdup_printf("%d", - (uint32_t) qemu_opt_get_number(qemu_find_opts_singleton("= smp-opts"), "cpus", 1)); - object_register_sugar_prop("memory-backend", "prealloc-threads", v= al, - false); - g_free(val); + val =3D g_strdup_printf("%d", + (uint32_t) qemu_opt_get_number( + qemu_find_opts_singleton("smp-opts"), "cpus",= 1)); + + object_register_sugar_prop("memory-backend", "prealloc-threads", val, + false); + g_free(val); + + if (mem_prealloc) { object_register_sugar_prop("memory-backend", "prealloc", "on", fal= se); } =20 --=20 2.25.1