From nobody Mon Feb 9 23:57:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1615401288; cv=none; d=zohomail.com; s=zohoarc; b=DnQ7i5WAyWgPY72+jt7fkY5zK9f7i7t1kRKUg3F/VP25j9dosSjUThnxP/Ead060TAq+ZqCD+FMSY1S2ZS54k14EwkU+BN0+fyheTqpSE7C2ERU6CatfyPke0q30qssy526np0OEtOgeJ3LIU3MgwJdbmfFRooRaISpyG3re9Wk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615401288; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=cVxutgLWbsHETCN5jy828gv0QTW9f6WZtMgIaL8WtCw=; b=BIg61G4ghxhLLNmj0sIBmxJl2E4wT/H2VruwipDvGvhNTjk8wacvgKQF3pfoXvooGlDJREl8mxGOE0szagGmz2lUlbsFBjuphjIQ2lU24/IokKSBlS88AGszE5lmCqwpqVokdzdJaAxl4ZSEAuQS2Q2pEiF2BDqbQfctMClPJaU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1615401288880991.2037124647951; Wed, 10 Mar 2021 10:34:48 -0800 (PST) Received: from localhost ([::1]:57634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lK3fT-0007No-M4 for importer@patchew.org; Wed, 10 Mar 2021 13:34:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59994) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lK3cf-0005eZ-Bd for qemu-devel@nongnu.org; Wed, 10 Mar 2021 13:31:53 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:23555) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lK3cd-0003AM-PK for qemu-devel@nongnu.org; Wed, 10 Mar 2021 13:31:53 -0500 Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-601-d7kI1jEzN9-TALkyBx1fZQ-1; Wed, 10 Mar 2021 13:31:48 -0500 Received: by mail-ed1-f70.google.com with SMTP id o15so8832019edv.7 for ; Wed, 10 Mar 2021 10:31:47 -0800 (PST) Received: from x1w.redhat.com (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id l1sm46800edt.59.2021.03.10.10.31.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 10:31:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615401111; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cVxutgLWbsHETCN5jy828gv0QTW9f6WZtMgIaL8WtCw=; b=R4pCSn8HUf8cBvQoCrCtwHeB7QVVeJz7mlrMzoFQ6lMw4vfUXfOMPjFJxtvt5lsT257vdE ua41yDJSS78Ma7DMiS/4LpdNXo2RJo2D3dog1xZPQEL3xjmbwa1KEboVl4jvejduwkjMca +djoCgUUHYKUcp+k2pf83fvfzUBnxz8= X-MC-Unique: d7kI1jEzN9-TALkyBx1fZQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cVxutgLWbsHETCN5jy828gv0QTW9f6WZtMgIaL8WtCw=; b=puwwVVjrMasOKjamUXv4GCl/yGxcF1j7lHM6R3PQzX05FiD0YoVlnH/KwOvVywfCSN 3T8R03ZVqCrYZHJLdruMvR19UGIdVZqO501DTPM5W1WeI/TMCSxEYoqy5ojdwFBMGWYQ lrNl5aTc66z1CAc0BFDTyTh46sXZBH8U8leg2zqjWUnFeVwY1XlI6hDMVNJKycK8neht iPBxsGcx91I0/wDC1G1Ac/WE//NqrG1zQacP9QJ2mysVc4gsBApfW6TEMgNAmv5hHDuO /Wtm/uI23woNZAiQ03Q5ZkoPa0nWRPAnCuI6kD+xHGi4L/VTk5G8Vzy/f+8uwN3jQFoU E+Ww== X-Gm-Message-State: AOAM530UG8fv5oqK3vStC2g560aHiuvN8SNktri3rxA2OCMIi53YZ8uc ZJQxynFlOhbokjH1q4cI1KB4Zt86AXG5yii6FutTWC+N4HoAas/r2OD08lgABkZw/6/Xn8Lhs3H oMj49SMZ6V8tnBJfaS4GrWB3bqTA64t2BvG+PkqIMkcGRDW9f8tlPivv45ftGQyyz X-Received: by 2002:a50:f38f:: with SMTP id g15mr4777484edm.262.1615401106511; Wed, 10 Mar 2021 10:31:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJwFTm8bvR5JbHuRlKvusWoKijCjYjWBuuzyu4Um+n/Ft5PMrFRPw690bsI3d6ebIsc3Q/oK7A== X-Received: by 2002:a50:f38f:: with SMTP id g15mr4777461edm.262.1615401106376; Wed, 10 Mar 2021 10:31:46 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v6 4/7] net/eth: Check size earlier in _eth_get_rss_ex_dst_addr() Date: Wed, 10 Mar 2021 19:31:20 +0100 Message-Id: <20210310183123.1212612-5-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210310183123.1212612-1-philmd@redhat.com> References: <20210310183123.1212612-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.243, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Dmitry Fleytman , Jason Wang , Paolo Bonzini , Miroslav Rezanina , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Stefano Garzarella Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Reviewed-by: Stefano Garzarella Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- net/eth.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/net/eth.c b/net/eth.c index ed047b5760b..492359afbbb 100644 --- a/net/eth.c +++ b/net/eth.c @@ -406,16 +406,14 @@ _eth_get_rss_ex_dst_addr(const struct iovec *pkt, int= pkt_frags, struct in6_address *dst_addr) { struct ip6_ext_hdr_routing *rthdr =3D (struct ip6_ext_hdr_routing *) e= xt_hdr; + size_t input_size =3D iov_size(pkt, pkt_frags); + size_t bytes_read; + + if (input_size < ext_hdr_offset + sizeof(*ext_hdr)) { + return false; + } =20 if ((rthdr->rtype =3D=3D 2) && (rthdr->segleft =3D=3D 1)) { - - size_t input_size =3D iov_size(pkt, pkt_frags); - size_t bytes_read; - - if (input_size < ext_hdr_offset + sizeof(*ext_hdr)) { - return false; - } - bytes_read =3D iov_to_buf(pkt, pkt_frags, ext_hdr_offset + sizeof(*rthdr), dst_addr, sizeof(*dst_addr)); --=20 2.26.2