From nobody Wed Nov 19 08:28:01 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1615395995; cv=none; d=zohomail.com; s=zohoarc; b=cmicLV5atLV3+RqDWxof/k1DCkgmjKBvCmRA5fTxbmKEQzUbjzKCSJ2QweFLyGOkRCYbe+8nCimoTo82V0558SMEN84530hL4Zwaa19WmRntn9++mbvle4AjL0GyMFX3hLgWuuhrQPXBZkjRYcEBrmYkyIkn0eyhWhr9bemtXk8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615395995; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=DiFt/bunDuWc+GWqxvzEWiyWpy7maT5GLWM3/1nEM9A=; b=gqAa41knLyOH+8DanUuHA1EuPFpAEeCX+/RiN4UwD6NZciAF6Mv4gC0be4T5mSbD2FFvaxAAbVOMQkNyL6wfO3zWDJEJvTk0371DO2lDPjAQHP6qMsIXZa8Q7kV+uNiNSvEhDuY3W8GfWrXulEi6ibVDNobN6qjTJJLKh3RjwPw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1615395995480705.357082046925; Wed, 10 Mar 2021 09:06:35 -0800 (PST) Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-111-PmlhZgo_Pd-MeDDSMBqpFQ-1; Wed, 10 Mar 2021 12:06:30 -0500 Received: by mail-ed1-f72.google.com with SMTP id v27so8695913edx.1 for ; Wed, 10 Mar 2021 09:06:30 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id v1sm42743ejd.3.2021.03.10.09.06.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 09:06:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615395994; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DiFt/bunDuWc+GWqxvzEWiyWpy7maT5GLWM3/1nEM9A=; b=GZz2Q1bVXF4K7fcA2ofmONH5mgoHM9NeH0R1TKe6ggQEnPgvjOpRCLkqQNJ0HLZQPPxBJf f9dUVJ06oiqK7f9MyIYDFyS9bN4MSKqLNuglBliEYgUqH31U6ozPDbh5dZJeRoVDxqyF6Z GxUVCvsR8yimx69fO7aaoN7oEX0qvlc= X-MC-Unique: PmlhZgo_Pd-MeDDSMBqpFQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DiFt/bunDuWc+GWqxvzEWiyWpy7maT5GLWM3/1nEM9A=; b=Dovsce/Srvm1W8Apzyuqr6pYyPPiqdOV8QGOoiiktCo7zERBptnxqi4zUX9m4hOZP6 diDA0NrtdN86FP4jgqyYzBiyD+b8SUS7wJcoup9zxTrji0XR9bAlW4wkopg3PsQ/axpq RQVg5q/RFPEYnszbHRj7qJwqX12OtzajUfaxC1PmxhQctSJOZxGiNbMBjz7vtNh6vnu0 kE8c/R7imp7opBeoHYK9lmviMJU+yZcDviXwNTjWbj/MKKo7cdC0aj0PBzHbmbjAnMno 9tKccrfHk1rNoE6FUpibGUHL4OjhPusZTsNJgkoFhD3lUq34DhmqHIgiT/d24V8VTBmg 2klA== X-Gm-Message-State: AOAM533i3YlugRcQ8zl6IKnMl66rjpH9XbUdBW4CYlGTQQJ41kxT8EzC GWquo2yMVyNZdhJvOxBL31Mu4Tdh/9FrwMces40/dC3hI8gNa3hO4cdboiQNyO9w0LfC6fqzoNd zxJqFRItGrmhErQ== X-Received: by 2002:a05:6402:12d5:: with SMTP id k21mr4523039edx.318.1615395989394; Wed, 10 Mar 2021 09:06:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJw5jsZvbUpg2B3B0dIO7abvtqnLN0IyGttpA5dAmgARREaemkdlpx0hegUUjxJRg385QyiQRg== X-Received: by 2002:a05:6402:12d5:: with SMTP id k21mr4523022edx.318.1615395989289; Wed, 10 Mar 2021 09:06:29 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Alistair Francis , Max Reitz , David Edmondson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-block@nongnu.org, Stephen Checkoway , Kevin Wolf Subject: [PATCH v2 11/12] hw/block/pflash_cfi01: Correct the type of PFlashCFI01.ro Date: Wed, 10 Mar 2021 18:05:27 +0100 Message-Id: <20210310170528.1184868-12-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210310170528.1184868-1-philmd@redhat.com> References: <20210310170528.1184868-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) From: David Edmondson PFlashCFI01.ro is a bool, declare it as such. Signed-off-by: David Edmondson Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20210216142721.1985543-3-david.edmondson@oracle.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Bin Meng --- hw/block/pflash_cfi01.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c index 32c9b289715..787466b249f 100644 --- a/hw/block/pflash_cfi01.c +++ b/hw/block/pflash_cfi01.c @@ -82,7 +82,7 @@ struct PFlashCFI01 { uint8_t max_device_width; /* max device width in bytes */ uint32_t features; uint8_t wcycle; /* if 0, the flash is read normally */ - int ro; + bool ro; uint8_t cmd; uint8_t status; uint16_t ident0; @@ -858,7 +858,7 @@ static void pflash_cfi01_realize(DeviceState *dev, Erro= r **errp) return; } } else { - pfl->ro =3D 0; + pfl->ro =3D false; } =20 if (pfl->blk) { --=20 2.26.2