From nobody Wed Nov 19 08:26:31 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1615395985; cv=none; d=zohomail.com; s=zohoarc; b=OKe8LF7FZPlhVbQBqmpUp9P/0eLgbMjmKmg7msXPsGrEnblEeq5E//H/14ydy8QnUUE7zWEHqHeWojK6O9kbLhklVgxsUjRMIbugfxYh0coq05cw59tSsGfMIAhCQB2EMIf6mR9y2fyIVCxMqn6Ps/vbrl5MyRcnkIbw+2wvCNw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615395985; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Xx92GyJcKDec9ihkE2KCgTkx1XXRENYEtB83EjOcbgc=; b=hNVzAT3P2BVcMBiz27WdMdkrdLKJtBK7J7wIIKK6ERUeyvQgToeEopsijHWsRNYCniRoHRiCSTncIU979xc8FjU207aaNFDHGoXnZAhxLNDZOMnZj/+Ae2gRG6tL3Dy+LAdTGaGSOZbCs5rrU8y+7XLWHls3bktQqVplBT1Ewk0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1615395985201170.70036612599085; Wed, 10 Mar 2021 09:06:25 -0800 (PST) Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-509-THS8bjooPWKSV_Cddhp4Dg-1; Wed, 10 Mar 2021 12:06:20 -0500 Received: by mail-ed1-f72.google.com with SMTP id i19so8731137edy.18 for ; Wed, 10 Mar 2021 09:06:20 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id q26sm36453eja.45.2021.03.10.09.06.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 09:06:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615395984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xx92GyJcKDec9ihkE2KCgTkx1XXRENYEtB83EjOcbgc=; b=e0290WGerB05/YrDlg0Y7sX/NxPE6NNwVrkFEljfHlh6lwavtOKyUsMOjZncOA1gc/1rja wDBWElp6O2HnL+hpyBs9hoCzDbz9X5h+Tf/PneJxBfY7x2uhcP7guXYQHolvkFYkbut2bt 9bLVnIaS5CbM1C1KNGwd/o2NW+wXZ+4= X-MC-Unique: THS8bjooPWKSV_Cddhp4Dg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Xx92GyJcKDec9ihkE2KCgTkx1XXRENYEtB83EjOcbgc=; b=p3UnuQE1X4QEcACNF4gQo+uYKnna7gABLLZJzlugytu1uB9FeCJJcHBxSRK+GwoexD SYPha2jER6XBUqRxNQs52OxAqx+3dFn4vSb2J9X/kLWnVe3UsT3xl9GVz6dQCtKH8ECd heLjqXHGekLZJaAubkBaHAMtxw1or5SkXCCOqfVB5gy3ufB9+frzSJXFC5zDJ7FNDW8k jWvX0Wpn490ub/45rqRODOvOJT2a/Ugul8YnbA955yKgkItW/54cc99az0TteudnCsXp ejD4eJ8nSRuW3SVEkxPr6aB282eWCc75NouFjDU5nDUY8BCoRkwGOTl0dacj0fa2uYIe 2vrw== X-Gm-Message-State: AOAM531Dk2NmGBu8OrNXA5Ep0oEJJM6TM+rwP1XloG/WrjPENbB1Ze5C gGAAPixshmSuL91Jec9aLX/pMHmE3y3IAY8gFA6UbKEdVsAwJ2fRunVZDHFTITG8hoZCx4VI4yR 3Ae7ZnsuicSN+JA== X-Received: by 2002:a50:ec07:: with SMTP id g7mr4438451edr.72.1615395979088; Wed, 10 Mar 2021 09:06:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJzltBhQM/nIoGAXOTteIpW4DjJt2eiK6oPdsWyVC5ftA50YZpxSfRXnhjHY6DNQf7DAZbIQZw== X-Received: by 2002:a50:ec07:: with SMTP id g7mr4438439edr.72.1615395978996; Wed, 10 Mar 2021 09:06:18 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Alistair Francis , Max Reitz , David Edmondson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-block@nongnu.org, Stephen Checkoway , Kevin Wolf , Bin Meng Subject: [PATCH v2 09/12] hw/block/pflash_cfi01: Clarify trace events Date: Wed, 10 Mar 2021 18:05:25 +0100 Message-Id: <20210310170528.1184868-10-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210310170528.1184868-1-philmd@redhat.com> References: <20210310170528.1184868-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Use the 'mode_read_array' event when we set the device in such mode, and use the 'reset' event in DeviceReset handler. Reviewed-by: Bin Meng Reviewed-by: David Edmondson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/block/pflash_cfi01.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c index 03472ea5b64..2618e00926d 100644 --- a/hw/block/pflash_cfi01.c +++ b/hw/block/pflash_cfi01.c @@ -663,7 +663,7 @@ static void pflash_write(PFlashCFI01 *pfl, hwaddr offse= t, "\n", __func__, offset, pfl->wcycle, pfl->cmd, value); =20 mode_read_array: - trace_pflash_reset(); + trace_pflash_mode_read_array(); memory_region_rom_device_set_romd(&pfl->mem, true); pfl->wcycle =3D 0; pfl->cmd =3D 0x00; /* This model reset value for READ_ARRAY (not CFI) = */ @@ -886,6 +886,7 @@ static void pflash_cfi01_system_reset(DeviceState *dev) { PFlashCFI01 *pfl =3D PFLASH_CFI01(dev); =20 + trace_pflash_reset(); /* * The command 0x00 is not assigned by the CFI open standard, * but QEMU historically uses it for the READ_ARRAY command (0xff). --=20 2.26.2