From nobody Wed Nov 19 08:23:58 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1615333877; cv=none; d=zohomail.com; s=zohoarc; b=fHOixfH5g7c8ZB2Q4bCwJh6wjqJpuFq4+SEn+6VLBfngAc7pa5FH87X6ZG3k9/HSqcKud43E1wrY7Kvr1CH/orUF5Jwe9t8BE9Tck5yEDt2BkkEsXt3gmKke0WzDtSiy1xx52zckcr54Iw4x8TI2/1ZLhrhAekGTmRhGWF7HA/o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615333877; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=1sffFlZ9/SNFgtZee/CEsk5iX0bBYiTE0XhzbPNOxhU=; b=Kq1ts3LgSYmXtPOrVbUxoQxnywVMoX1cLuJ1HA4nvu0aefcSA8EKLAsgntWtuiaeZHb5iPA7/zZojBLrqlWJUkY9m4/FC0O+9t0AXXnYkzhC7XHpXm0GPObuokjwE/xqGC/QfTI6T/JivXZElN57vFYx+3Z6JmGhd1iRmRD4JVI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 161533387752164.51440827772035; Tue, 9 Mar 2021 15:51:17 -0800 (PST) Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-235-HIFwOrTJPsGZag61PEKvYg-1; Tue, 09 Mar 2021 18:51:14 -0500 Received: by mail-ed1-f71.google.com with SMTP id a2so7544155edx.0 for ; Tue, 09 Mar 2021 15:51:14 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id h15sm7172603edb.74.2021.03.09.15.51.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Mar 2021 15:51:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615333876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1sffFlZ9/SNFgtZee/CEsk5iX0bBYiTE0XhzbPNOxhU=; b=Vhk5djBkG89APOeRZ1+UYmcbOrUEXKGhPJCykRpNwadADxRQWh6BUb7rnBW2h+UJD5wW4/ f6ApY4SasbgV8uogBLd8lLUyszcD5DD/SnWDOoEKt0vkpcz4ep7ypBRUGqVTpXdsVbENHR whgQIvH7Se9ou2AjxeGqya6GUVQNHwY= X-MC-Unique: HIFwOrTJPsGZag61PEKvYg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1sffFlZ9/SNFgtZee/CEsk5iX0bBYiTE0XhzbPNOxhU=; b=It4H6ddW8cWDdTE8NJvuq1mAaZRcjIe0AFUiZd/Mt25HHDybYv9VtxQWoMDuYuzKXy OQ4zUJgfKt03z+Nk9GGBrCrs1Z3NbrIvERW9/rW8qV17HCKPZLN0Iyr0E+ruTA/aPat6 M32dzZoMAY28Pc9vvV7cT1P3/PbbxxpajnV2CNbYrK2VA8Ngo4gNoReRJSgVXAbldwMF LwYejYYnwdu3Oqt2Anjf4LkQibSHVQAZ1NLBwEa3+/F5+xRs3JSxjPpIRLt7SGxl6tL3 Z0wHhodOSq9kci5C4HjbUj5LX1WAcG4rkY1qMK3Lnz5wzso3cNzSTgdT2Kvsa+tOJaaY wC+A== X-Gm-Message-State: AOAM531tFgGqoTZasKso1sa4QIds5X8RGZWrVJ+wrw7vgEmTINYg94jh ANYghUuNy/G1I8ZZzL/FHx1t+y1c9LykeUIKk81tSJn07K0AquMBAgRLHJj2H/YlHnohWiOvJB0 9p19fKvkNNlnm2w== X-Received: by 2002:a50:9d0b:: with SMTP id v11mr190502ede.308.1615333873705; Tue, 09 Mar 2021 15:51:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJwTEWns1FXeYiJTJdgIWM3J+uyhLArzMKGqWPuyHy+KUK3Q1lRRZYqdsO2EftnANh7RlSSrLg== X-Received: by 2002:a50:9d0b:: with SMTP id v11mr190485ede.308.1615333873519; Tue, 09 Mar 2021 15:51:13 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Alistair Francis , Max Reitz , Kevin Wolf , Stephen Checkoway , David Edmondson , qemu-block@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 8/9] hw/block/pflash_cfi01: Clarify trace events Date: Wed, 10 Mar 2021 00:50:27 +0100 Message-Id: <20210309235028.912078-9-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210309235028.912078-1-philmd@redhat.com> References: <20210309235028.912078-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Use the 'mode_read_array' event when we set the device in such mode, and use the 'reset' event in DeviceReset handler. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Bin Meng Reviewed-by: David Edmondson --- hw/block/pflash_cfi01.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c index 03472ea5b64..2618e00926d 100644 --- a/hw/block/pflash_cfi01.c +++ b/hw/block/pflash_cfi01.c @@ -663,7 +663,7 @@ static void pflash_write(PFlashCFI01 *pfl, hwaddr offse= t, "\n", __func__, offset, pfl->wcycle, pfl->cmd, value); =20 mode_read_array: - trace_pflash_reset(); + trace_pflash_mode_read_array(); memory_region_rom_device_set_romd(&pfl->mem, true); pfl->wcycle =3D 0; pfl->cmd =3D 0x00; /* This model reset value for READ_ARRAY (not CFI) = */ @@ -886,6 +886,7 @@ static void pflash_cfi01_system_reset(DeviceState *dev) { PFlashCFI01 *pfl =3D PFLASH_CFI01(dev); =20 + trace_pflash_reset(); /* * The command 0x00 is not assigned by the CFI open standard, * but QEMU historically uses it for the READ_ARRAY command (0xff). --=20 2.26.2