From nobody Sun Feb 8 11:15:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1615319977; cv=none; d=zohomail.com; s=zohoarc; b=m+rrp60uUXy7q+2gRkPVZ4E0Lxsi2QEqsYL6WxNekvU8mHpT8zvEcYedky8GLXLG5+Rb56haaJcK1bLNbx0F3a/UQWuDp0aVN47AC0HWTWsecVS7Ah4Dd00zSuPI1RDIdqeA56BCLpmxXDtXVnkvSRISxg5l2lplWhrVKDnRGOY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615319977; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=2CrmU62ozq80Fd+S/jOJxexIiH/pWOvihZ4sbtDF95M=; b=eGi1Y5K44Yr+Nhe315vykfmLEsEACnmmuhI42scF5VAKnRHRClKb0rijOlP8jbze8YRBMoQPMy5NcIt8R50AxXXhRLNM8XXMbzhs+nZsA+BwaBhdvAxFKeeIQw4csKcEik+QI/CpE2YfzaNJBLFKbtlngNfzGXb7htvaAFf7EZk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1615319977598899.1715020728747; Tue, 9 Mar 2021 11:59:37 -0800 (PST) Received: from localhost ([::1]:59834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJiVy-0003Dq-JT for importer@patchew.org; Tue, 09 Mar 2021 14:59:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38372) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJgGE-0006Lq-FL for qemu-devel@nongnu.org; Tue, 09 Mar 2021 12:35:13 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:52299) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lJgGA-0005rq-4T for qemu-devel@nongnu.org; Tue, 09 Mar 2021 12:35:09 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-20-6IyflFeFMUCUKnIDzLkpEQ-1; Tue, 09 Mar 2021 12:34:58 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 351AB800D62; Tue, 9 Mar 2021 17:34:57 +0000 (UTC) Received: from merkur.redhat.com (ovpn-114-169.ams2.redhat.com [10.36.114.169]) by smtp.corp.redhat.com (Postfix) with ESMTP id 063335C266; Tue, 9 Mar 2021 17:34:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615311304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2CrmU62ozq80Fd+S/jOJxexIiH/pWOvihZ4sbtDF95M=; b=ZlgcmSqn6JadK5i7wFwGNj4ACFQ9yljhSSUJXHTwsyMbkmTlqEbeD9O/BHiK86FwaLZf0G Di9yMnSeGrNF7MFfS++1QWXrD3lmHRdvZEe6gcqbjCJmGLQWKL78dCFEESYQrXASRfKiNc rSIJwaukK+8J23HqEfcxtbms1FmGI3g= X-MC-Unique: 6IyflFeFMUCUKnIDzLkpEQ-1 From: Kevin Wolf To: qemu-block@nongnu.org Subject: [PATCH] stream: Don't crash when node permission is denied Date: Tue, 9 Mar 2021 18:34:51 +0100 Message-Id: <20210309173451.45152-1-kwolf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.251, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, ngu@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The image streaming block job restricts shared permissions of the nodes it accesses. This can obviously fail when other users already got these permissions. &error_abort is therefore wrong and can crash. Handle these errors gracefully and just fail starting the block job. Reported-by: Nini Gu Signed-off-by: Kevin Wolf Reviewed-by: Alberto Garcia Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy --- Based-on: 20210309121814.31078-1-kwolf@redhat.com ('storage-daemon: Call job_cancel_sync_all() on shutdown') block/stream.c | 15 +++++++++++---- tests/qemu-iotests/tests/qsd-jobs | 20 ++++++++++++++++++++ tests/qemu-iotests/tests/qsd-jobs.out | 10 ++++++++++ 3 files changed, 41 insertions(+), 4 deletions(-) diff --git a/block/stream.c b/block/stream.c index 1fa742b0db..97bee482dc 100644 --- a/block/stream.c +++ b/block/stream.c @@ -206,7 +206,7 @@ void stream_start(const char *job_id, BlockDriverState = *bs, const char *filter_node_name, Error **errp) { - StreamBlockJob *s; + StreamBlockJob *s =3D NULL; BlockDriverState *iter; bool bs_read_only; int basic_flags =3D BLK_PERM_CONSISTENT_READ | BLK_PERM_WRITE_UNCHANGE= D; @@ -214,6 +214,7 @@ void stream_start(const char *job_id, BlockDriverState = *bs, BlockDriverState *cor_filter_bs =3D NULL; BlockDriverState *above_base; QDict *opts; + int ret; =20 assert(!(base && bottom)); assert(!(backing_file_str && bottom)); @@ -303,7 +304,7 @@ void stream_start(const char *job_id, BlockDriverState = *bs, * queried only at the job start and then cached. */ if (block_job_add_bdrv(&s->common, "active node", bs, 0, - basic_flags | BLK_PERM_WRITE, &error_abort)) { + basic_flags | BLK_PERM_WRITE, errp)) { goto fail; } =20 @@ -320,8 +321,11 @@ void stream_start(const char *job_id, BlockDriverState= *bs, for (iter =3D bdrv_filter_or_cow_bs(bs); iter !=3D base; iter =3D bdrv_filter_or_cow_bs(iter)) { - block_job_add_bdrv(&s->common, "intermediate node", iter, 0, - basic_flags, &error_abort); + ret =3D block_job_add_bdrv(&s->common, "intermediate node", iter, = 0, + basic_flags, errp); + if (ret < 0) { + goto fail; + } } =20 s->base_overlay =3D base_overlay; @@ -337,6 +341,9 @@ void stream_start(const char *job_id, BlockDriverState = *bs, return; =20 fail: + if (s) { + job_early_fail(&s->common.job); + } if (cor_filter_bs) { bdrv_cor_filter_drop(cor_filter_bs); } diff --git a/tests/qemu-iotests/tests/qsd-jobs b/tests/qemu-iotests/tests/q= sd-jobs index 1a1c534fac..972b6b3898 100755 --- a/tests/qemu-iotests/tests/qsd-jobs +++ b/tests/qemu-iotests/tests/qsd-jobs @@ -30,6 +30,7 @@ status=3D1 # failure is the default! _cleanup() { _cleanup_test_img + rm -f "$SOCK_DIR/nbd.sock" } trap "_cleanup; exit \$status" 0 1 2 3 15 =20 @@ -59,6 +60,25 @@ $QSD --chardev stdio,id=3Dstdio --monitor chardev=3Dstdi= o \ {"execute": "quit"} EOF =20 +echo +echo "=3D=3D=3D Streaming can't get permission on base node =3D=3D=3D" +echo + +# Just make sure that this doesn't crash +$QSD --chardev stdio,id=3Dstdio --monitor chardev=3Dstdio \ + --blockdev node-name=3Dfile_base,driver=3Dfile,filename=3D"$TEST_IMG.b= ase" \ + --blockdev node-name=3Dfmt_base,driver=3Dqcow2,file=3Dfile_base \ + --blockdev node-name=3Dfile_overlay,driver=3Dfile,filename=3D"$TEST_IM= G" \ + --blockdev node-name=3Dfmt_overlay,driver=3Dqcow2,file=3Dfile_overlay,= backing=3Dfmt_base \ + --nbd-server addr.type=3Dunix,addr.path=3D"$SOCK_DIR/nbd.sock" \ + --export type=3Dnbd,id=3Dexport1,node-name=3Dfmt_base,writable=3Don,na= me=3Dexport1 \ + <