[PATCH v3 0/4] semihosting/next (SYS_HEAPINFO)

Alex Bennée posted 4 patches 3 years ago
Only 3 patches received!
There is a newer version of this series
tests/tcg/aarch64/semicall.h                  | 18 ++++++
tests/tcg/arm/semicall.h                      | 15 +----
tests/tcg/riscv64/semicall.h                  | 22 +++++++
semihosting/arm-compat-semi.c                 | 62 +++++++------------
tests/tcg/arm/semihosting.c                   | 26 --------
.../arm-compat-semi}/semiconsole.c            |  2 +
.../multiarch/arm-compat-semi/semihosting.c   | 62 +++++++++++++++++++
tests/tcg/Makefile.target                     |  3 +
tests/tcg/aarch64/Makefile.target             | 18 ------
tests/tcg/arm/Makefile.target                 | 16 +----
tests/tcg/multiarch/Makefile.target           | 31 ++++++++++
11 files changed, 165 insertions(+), 110 deletions(-)
create mode 100644 tests/tcg/aarch64/semicall.h
create mode 100644 tests/tcg/riscv64/semicall.h
delete mode 100644 tests/tcg/arm/semihosting.c
rename tests/tcg/{arm => multiarch/arm-compat-semi}/semiconsole.c (93%)
create mode 100644 tests/tcg/multiarch/arm-compat-semi/semihosting.c
[PATCH v3 0/4] semihosting/next (SYS_HEAPINFO)
Posted by Alex Bennée 3 years ago
Hi,

Hopefully the final revision, instead of hacking about args to
reverted to the orignal code (with minor tweaks for args). Still based
on my in-flight PR:

  pull-testing-docs-xen-updates-080321-1

which already moves the semihosting code out of hw/. Please review:

 - tests/tcg: add HeapInfo checking to semihosting test
 - semihosting/arm-compat-semi: deref parameter register for SYS_HEAPINFO
 - semihosting/arm-compat-semi: unify GET/SET_ARG helpers
 - semihosting: move semihosting tests to multiarch


Alex Bennée (4):
  semihosting: move semihosting tests to multiarch
  semihosting/arm-compat-semi: unify GET/SET_ARG helpers
  semihosting/arm-compat-semi: don't use SET_ARG to report SYS_HEAPINFO
  tests/tcg: add HeapInfo checking to semihosting test

 tests/tcg/aarch64/semicall.h                  | 18 ++++++
 tests/tcg/arm/semicall.h                      | 15 +----
 tests/tcg/riscv64/semicall.h                  | 22 +++++++
 semihosting/arm-compat-semi.c                 | 62 +++++++------------
 tests/tcg/arm/semihosting.c                   | 26 --------
 .../arm-compat-semi}/semiconsole.c            |  2 +
 .../multiarch/arm-compat-semi/semihosting.c   | 62 +++++++++++++++++++
 tests/tcg/Makefile.target                     |  3 +
 tests/tcg/aarch64/Makefile.target             | 18 ------
 tests/tcg/arm/Makefile.target                 | 16 +----
 tests/tcg/multiarch/Makefile.target           | 31 ++++++++++
 11 files changed, 165 insertions(+), 110 deletions(-)
 create mode 100644 tests/tcg/aarch64/semicall.h
 create mode 100644 tests/tcg/riscv64/semicall.h
 delete mode 100644 tests/tcg/arm/semihosting.c
 rename tests/tcg/{arm => multiarch/arm-compat-semi}/semiconsole.c (93%)
 create mode 100644 tests/tcg/multiarch/arm-compat-semi/semihosting.c

-- 
2.20.1


Re: [PATCH v3 0/4] semihosting/next (SYS_HEAPINFO)
Posted by Peter Maydell 3 years ago
On Tue, 9 Mar 2021 at 19:23, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> Hi,
>
> Hopefully the final revision, instead of hacking about args to
> reverted to the orignal code (with minor tweaks for args). Still based
> on my in-flight PR:
>
>   pull-testing-docs-xen-updates-080321-1
>
> which already moves the semihosting code out of hw/. Please review:
>
>  - tests/tcg: add HeapInfo checking to semihosting test
>  - semihosting/arm-compat-semi: deref parameter register for SYS_HEAPINFO
>  - semihosting/arm-compat-semi: unify GET/SET_ARG helpers
>  - semihosting: move semihosting tests to multiarch
>
>
> Alex Bennée (4):
>   semihosting: move semihosting tests to multiarch
>   semihosting/arm-compat-semi: unify GET/SET_ARG helpers
>   semihosting/arm-compat-semi: don't use SET_ARG to report SYS_HEAPINFO
>   tests/tcg: add HeapInfo checking to semihosting test

Patch 3 never made it to the list or to patchew:

https://patchew.org/QEMU/20210309172127.20470-1-alex.bennee@linaro.org/

Could you try resending the series, maybe ?

thanks
-- PMM

Re: [PATCH v3 0/4] semihosting/next (SYS_HEAPINFO)
Posted by Alex Bennée 3 years ago
Peter Maydell <peter.maydell@linaro.org> writes:

> On Tue, 9 Mar 2021 at 19:23, Alex Bennée <alex.bennee@linaro.org> wrote:
>>
>> Hi,
>>
>> Hopefully the final revision, instead of hacking about args to
>> reverted to the orignal code (with minor tweaks for args). Still based
>> on my in-flight PR:
>>
>>   pull-testing-docs-xen-updates-080321-1
>>
>> which already moves the semihosting code out of hw/. Please review:
>>
>>  - tests/tcg: add HeapInfo checking to semihosting test
>>  - semihosting/arm-compat-semi: deref parameter register for SYS_HEAPINFO
>>  - semihosting/arm-compat-semi: unify GET/SET_ARG helpers
>>  - semihosting: move semihosting tests to multiarch
>>
>>
>> Alex Bennée (4):
>>   semihosting: move semihosting tests to multiarch
>>   semihosting/arm-compat-semi: unify GET/SET_ARG helpers
>>   semihosting/arm-compat-semi: don't use SET_ARG to report SYS_HEAPINFO
>>   tests/tcg: add HeapInfo checking to semihosting test
>
> Patch 3 never made it to the list or to patchew:

It's on the qemu-devel archive:

  https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg03051.html

AKA:

  To: qemu-devel@nongnu.org
  Cc: keithp@keithp.com,
          =?UTF-8?q?Alex=20Benn=C3=A9e?= <alex.bennee@linaro.org>,
          Bug 1915925 <1915925@bugs.launchpad.net>
  Subject: [PATCH  v3 3/4] semihosting/arm-compat-semi: don't use SET_ARG to report SYS_HEAPINFO
  Date: Tue,  9 Mar 2021 17:21:26 +0000
  Message-Id: <20210309172127.20470-4-alex.bennee@linaro.org>
  X-Mailer: git-send-email 2.20.1
  In-Reply-To: <20210309172127.20470-1-alex.bennee@linaro.org>
  References: <20210309172127.20470-1-alex.bennee@linaro.org>

>
> https://patchew.org/QEMU/20210309172127.20470-1-alex.bennee@linaro.org/
>
> Could you try resending the series, maybe ?

OK

>
> thanks
> -- PMM


-- 
Alex Bennée